Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Wu, Hao A
Hello Ashish, I think the IOMMU feature is added for the protection of FW integrity against HW devices, which is the motivation to use IOMMU PPI for memory allocation. The fix is easy for the DXE part since the IOMMU part has been integrated to the implementation of the PciIo protocol. As for

Re: [edk2-devel] OVMF is crashing for me in master

2019-10-10 Thread Andrew Fish via Groups.Io
Liming, Thanks for looking into this! Can someone also answer my question about the expected behavior of taking an exception in OVMF? Is the CpuDeadloop() expected? Thanks, Andrew Fish > On Oct 10, 2019, at 6:19 PM, Gao, Liming wrote: > > Andrew: > I verify the change

Re: [edk2-devel] [edk2-platforms][PATCH V1 17/17] SimicsOpenBoardPkg: Assign unique token namespace

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Wei, David Y Subject: [edk2-devel] [edk2-platforms][PATCH V1 17/17] SimicsOpenBoardPkg:

Re: [edk2-devel] [edk2-platforms][PATCH V1 15/17] SimicsOpenBoardPkg/BoardX58Ich10: Remove OpenBoardPkgConfig.dsc

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Wei, David Y Subject: [edk2-devel] [edk2-platforms][PATCH V1 15/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 16/17] SimicsOpenBoardPkg/BoardX58Ich10: DSC cleanup

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Wei, David Y Subject: [edk2-devel] [edk2-platforms][PATCH V1 16/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10: Relocate DSC includes

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Wei, David Y Subject: [edk2-devel] [edk2-platforms][PATCH V1 14/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 11/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Update FSP base PCDs

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 11/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 10/17] CoffeelakeSiliconPkg: Add DSC include file section tags

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms][PATCH V1 10/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 12/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: DSC cleanup

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 12/17]

Re: [edk2-devel] [edk2-platforms][PATCH V1 05/17] KabylakeOpenBoardPkg/GalagoPro3: Remove OpenBoardPkgConfig.dsc

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 05/17] KabylakeOpenBoardPkg/GalagoPro3: Remove

Re: [edk2-devel] [edk2-platforms][PATCH V1 03/17] KabylakeOpenBoardPkg/KabylakeRvp3: DSC cleanup

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH V1 03/17] KabylakeOpenBoardPkg/KabylakeRvp3: DSC cleanup

Re: [edk2-devel] [edk2-platforms][PATCH V1 07/17] KabylakeOpenBoardPkg: Assign unique token namespace

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 07/17] KabylakeOpenBoardPkg: Assign unique token

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove OpenBoardPkgConfig.dsc

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH V1 09/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove

Re: [edk2-devel] [edk2-platforms][PATCH V1 08/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Relocate PCD DSC include

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH V1 08/17] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Relocate PCD DSC include

Re: [edk2-devel] [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC include file section tags

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg:

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/17] KabylakeOpenBoardPkg/GalagoPro3: DSC cleanup

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 06/17] KabylakeOpenBoardPkg/GalagoPro3: DSC cleanup

Re: [edk2-devel] [edk2-platforms][PATCH V1 04/17] KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC include

2019-10-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Jeremy Soller Subject: [edk2-platforms][PATCH V1 04/17] KabylakeOpenBoardPkg/GalagoPro3: Relocate PCD DSC

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Ashish Singhal
Hello Hao, What is your motivation towards using IoMMUPei for memory allocation now instead of Pei Services? The fix would be simple if we just change the number of pages needed to accommodate for the alignment. The call to free the pages would not do anything. If we use IoMMUPei, we may need

[edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP ReceiveFilters change to IHV

2019-10-10 Thread xianhui liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2197 sync commit 3d98de052fcd47f187190802e6201ac6aaabfda7 on file EFI/Protocol/SimpleNetwork/BlackBoxTest /SimpleNetworkBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu ---

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-10 Thread Wu, Jiaxin
Hi Laszlo & David, I think I have *repeated* several times that we are targeting to fix the HostName validation issue, not the IP or email address. *But* even so, the series patches for UEFI TLS is also allowable to specify IP as host name for CN or dNSName of SAN in the certificate. That's

[edk2-devel] Upcoming Event: TianoCore Community Meeting - APAC/NAMO - Thu, 10/10/2019 7:30pm-8:00pm #cal-reminder

2019-10-10 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 10 October 2019, 7:30pm to 8:00pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=484144 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV

2019-10-10 Thread Eric Jin
Push at 6fd3e7e11930566df8c3ba8fe1c8160c9bc01607 -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, October 10, 2019 10:32 AM To: devel@edk2.groups.io; Liu, XianhuiX Cc: Heinrich Schuchardt ; Supreeth Venkatesh Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SNP Statistics change to IHV

2019-10-10 Thread Eric Jin
Push at 4a3165b8afa563eca1fc0ca93c1a849207a38c8b -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, October 10, 2019 10:33 AM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Heinrich Schuchardt ; Supreeth Venkatesh Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync StrUpr() test change to IHV

2019-10-10 Thread Eric Jin
Pushed at a28541892a03dc34a7af5a8acdf0b39ad3daf7cc -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, October 10, 2019 9:58 AM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Heinrich Schuchardt ; Supreeth Venkatesh ; Jin, Eric Subject: Re: [edk2-devel]

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
Laszlo: >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, October 11, 2019 12:43 AM >To: devel@edk2.groups.io; Gao, Liming ; Andrew Fish > >Cc: Justen, Jordan L >Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain - > >Hi Liming, >

Re: [edk2-devel] question about qemu+kvm+ovmf+winxp

2019-10-10 Thread Junhao Gao
Hi Laszlo Thank you very much for your great support. Hi David Refer to http://www.linux-kvm.org/downloads/lersek/ovmf-whitepaper-c770f8c.txt. Interested users and developers should look for OVMF's "-D CSM_ENABLE" build-time option, and check out the

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-10 Thread Liming Gao
Laszlo: >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Friday, October 11, 2019 1:35 AM >To: devel@edk2.groups.io; Gao, Liming ; Justen, >Jordan L >Subject: Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "- >fno-omit-frame-pointer" for CLANG9

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
Laszlo: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Friday, October 11, 2019 12:32 AM >To: devel@edk2.groups.io; Gao, Liming ; >af...@apple.com >Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove

Re: [edk2-devel] OVMF is crashing for me in master

2019-10-10 Thread Liming Gao
Andrew: I verify the change (2de1f611be06ded3a59726a4052a9039be7d459b MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0) in Emulator. It works, because PCD value is set to 10 in Emulator. Before this change, if TimeOut PCD is zero, BdsEntry doesn't call

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-10 Thread Siyuan, Fu
> -Original Message- > From: Laszlo Ersek > Sent: 2019年10月11日 0:06 > To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda, > Maciej > Cc: Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove > ExitBootServices event > > On 10/10/19 11:29, Fu, Siyuan wrote: > >>

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-10 Thread Andrew Fish via Groups.Io
> On Oct 10, 2019, at 4:17 PM, Lendacky, Thomas wrote: > > On 10/3/19 10:12 AM, Tom Lendacky wrote: >> >> >> On 10/3/19 5:32 AM, Laszlo Ersek wrote: >>> On 10/03/19 12:12, Laszlo Ersek wrote: >>> UINT32 ApEntryPoint; EFI_GUID SevEsFooterGuid; UINT16 Size; >>> >>>

Re: [edk2-devel] [edk2-platforms: PATCH v3 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

2019-10-10 Thread Leif Lindholm
On Fri, Oct 11, 2019 at 01:33:49AM +0200, Marcin Wojtas wrote: > Hi Leif, > > pt., 11 paź 2019 o 01:04 Leif Lindholm napisał(a): > > > > On Thu, Oct 10, 2019 at 07:42:18AM +0200, Marcin Wojtas wrote: > > > From: Patryk Duda > > > > > > This patch implements convenient way of changing strings

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 10/10/2019 5:00pm-5:30pm #cal-reminder

2019-10-10 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 10 October 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=484142 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [edk2-platforms: PATCH v3 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

2019-10-10 Thread Marcin Wojtas
Hi Leif, pt., 11 paź 2019 o 01:04 Leif Lindholm napisał(a): > > On Thu, Oct 10, 2019 at 07:42:18AM +0200, Marcin Wojtas wrote: > > From: Patryk Duda > > > > This patch implements convenient way of changing strings included > > in SMBIOS Table1, Table2, Table3. > > > > Strings can be altered by

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-10 Thread Lendacky, Thomas
On 10/3/19 10:12 AM, Tom Lendacky wrote: > > > On 10/3/19 5:32 AM, Laszlo Ersek wrote: >> On 10/03/19 12:12, Laszlo Ersek wrote: >> >>> UINT32 ApEntryPoint; >>> EFI_GUID SevEsFooterGuid; >>> UINT16 Size; >> >> It's probably better to reverse the order of "Size" and >>

Re: [edk2-devel] [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings

2019-10-10 Thread Marcin Wojtas
Hi Leif, pt., 11 paź 2019 o 01:07 Leif Lindholm napisał(a): > > On Thu, Oct 10, 2019 at 07:42:19AM +0200, Marcin Wojtas wrote: > > Now that the customization of Type1/2/3 SBMIOS > > tables strings is possible, adjust them for all > > supported boards. > > > > Signed-off-by: Marcin Wojtas > >

Re: [edk2-devel] [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:19AM +0200, Marcin Wojtas wrote: > Now that the customization of Type1/2/3 SBMIOS > tables strings is possible, adjust them for all > supported boards. > > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc| 4 >

Re: [edk2-devel] [edk2-platforms: PATCH v3 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:18AM +0200, Marcin Wojtas wrote: > From: Patryk Duda > > This patch implements convenient way of changing strings included > in SMBIOS Table1, Table2, Table3. > > Strings can be altered by defining following PCDs: > gMarvellTokenSpaceGuid.PcdProductManufacturer >

Re: [edk2-devel] [edk2-platforms: PATCH v3 7/9] Marvell/Cn9132Db: Introduce board support

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:17AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9132-DB setup A. Note > the ACPI is not yet available for this variant, due to > the current ICU (CP1xx interrupt controller) support >

Re: [edk2-devel] [edk2-platforms: PATCH v3 6/9] Marvell/Cn9131Db: Introduce board support

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:16AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9131-DB setup A. > > In order to build this variant, '-D CN9131' flag should be added. > > Signed-off-by: Marcin Wojtas Reviewed-by: Leif

Re: [edk2-devel] [edk2-platforms: PATCH v3 4/9] Marvell/Library: ArmadaSoCDescLib/MppLib: Extend Xenon information

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:14AM +0200, Marcin Wojtas wrote: > Hitherto SoC description and MppLib libraries code assumed > that there could be only two Xenon SdMmc controller > instances in the SoC. Remove those limitations, so that > to support CN913x SoCs, which may have up to 4 of such

Re: [edk2-devel] [edk2-platforms: PATCH v3 3/9] Marvell/Cn9130Db: Introduce board support

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:13AM +0200, Marcin Wojtas wrote: > This patch introduces all necessary components required > for building EDK2 firmware for CN9130-DB setup A. > Because the board is modular and can be extended to support > also CN9131 and CN9132 SoC variants, extract common part into

Re: [edk2-devel] [edk2-platforms: PATCH v3 1/9] Marvell/Armada7k8k: Fix 32-bit compilation

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:42:11AM +0200, Marcin Wojtas wrote: > It turned out, that the recently added features broke > ARM compilation. Fix all issues: > * Update signatures types in structures (UINTN -> UINT64) > * Use fixed type for address in ICU > * Limit memory for ARM build to 1GB and stop

[edk2-devel] OVMF is crashing for me in master

2019-10-10 Thread Andrew Fish via Groups.Io
This is my flavor of OVMF: build -p OvmfPkg/OvmfPkgX64.dsc -a X64 -t XCODE5 It looks like I took an exception? Is it expected that an unhandled exception just hang in a dead loop? I would have expected some serial output about the failure? Looks like a divide by zero exception. The

Re: [edk2-devel] question about qemu+kvm+ovmf+winxp

2019-10-10 Thread Laszlo Ersek
On 10/10/19 16:37, Junhao Gao wrote: > Hi edk2 members > >I have a question for your help. >I want to enable qemu+kvm+ovmf to boot up windows xp, >then ovmf support winxp starting-up? To my understanding, the first Windows "family" with any kind of

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-10 Thread Laszlo Ersek
On 10/10/19 17:45, David Woodhouse wrote: > On Thu, 2019-10-10 at 10:00 +0200, Laszlo Ersek wrote: >>> Subject: C=HU, ST=Pest, L=Budapest, O=Laszlo Ersek Home Office, >>> OU=IPv6 cert, CN=fd33:eb1b:9b36::2 > > Yeah, you're not actually testing the case I'm talking about. You want > a

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Ashish Singhal
Hello Hao, I agree that for completeness we should fix the issue in both DXE as well as PEI but on my target, we do not have any PEI phase for me to be able to verify any change that I will be making. If you still want, I can still make the change so that someone else can verify or we can have

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-10 Thread Laszlo Ersek
Hi Liming, On 10/10/19 16:08, Liming Gao wrote: > Laszlo: > Option (a) works. Jordan patch can fix this issue. > Option (b) doesn't work. Even if disable optimization, CLANG doesn't > generate the code with push rbp & pop rbp. > > So, Jordan patch becomes only option. We can discuss

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Pete Batard
On 2019.10.10 17:49, Leif Lindholm wrote: On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I wrote in 0/5 for the v2, because the cover letter this is usually the place I try to clarify elements that may throw

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/RPi3/RpiFirmwareDxe: Add more query functions

2019-10-10 Thread Pete Batard
On 2019.10.10 17:43, Leif Lindholm wrote: On Thu, Oct 10, 2019 at 01:41:06PM +0100, Pete Batard wrote: Hi Leif, On 2019.10.10 09:39, Leif Lindholm wrote: On Tue, Oct 08, 2019 at 01:38:37PM +0100, Pete Batard wrote: This patch introduces the capability to also query the Model Name/

Re: [edk2-devel] [edk2-non-osi: PATCH 0/3] Marvell CN913x device tree

2019-10-10 Thread Marcin Wojtas
czw., 10 paź 2019 o 18:59 Leif Lindholm napisał(a): > On Thu, Oct 10, 2019 at 07:41:15AM +0200, Marcin Wojtas wrote: > > Hi, > > > > As agreed, due to the licencing concerns (GPL/MIT), it is > > better to keep the device trees for newly added SoC family > > in edk2-non-osi. > > > > For

Re: [edk2-devel] [edk2-non-osi: PATCH 0/3] Marvell CN913x device tree

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 07:41:15AM +0200, Marcin Wojtas wrote: > Hi, > > As agreed, due to the licencing concerns (GPL/MIT), it is > better to keep the device trees for newly added SoC family > in edk2-non-osi. > > For convenience, the patches are available in the public > github branch: >

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: > It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I > wrote in 0/5 for the v2, because the cover letter this is usually the place > I try to clarify elements that may throw off a maintainer, and that don't >

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/RPi3/RpiFirmwareDxe: Add more query functions

2019-10-10 Thread Leif Lindholm
On Thu, Oct 10, 2019 at 01:41:06PM +0100, Pete Batard wrote: > Hi Leif, > > On 2019.10.10 09:39, Leif Lindholm wrote: > > On Tue, Oct 08, 2019 at 01:38:37PM +0100, Pete Batard wrote: > > > This patch introduces the capability to also query the Model Name/ > > > Manufacturer Name/CPU Name/Firmware

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Laszlo Ersek
Hi Liming, On 10/10/19 14:18, Liming Gao wrote: >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >> Sent: Thursday, October 10, 2019 3:35 PM >> To: Andrew Fish ; Gao, Liming >> Cc: devel@edk2.groups.io >> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg:

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Laszlo Ersek
Hi Liming, Andrew, On 10/10/19 14:32, Liming Gao wrote: > Laszlo: > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, October 9, 2019 4:22 AM >> To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com >> Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic:

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-10-10 Thread Andrew Fish via Groups.Io
Liming, I'm OK with not regressing OVMF, I understand the concept of technical debt. I'd point out that this is likely a generic issue with the SecurityPkg that was worked around in OVMF. Also it looks to me like passing those flags violate the calling convention [1]. Maybe that is why the

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-10 Thread Laszlo Ersek
On 10/10/19 11:29, Fu, Siyuan wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: 2019年10月10日 16:06 >> To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda, >> Maciej >> Cc: Wu, Jiaxin >> Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove >> ExitBootServices event >> >>

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-10 Thread David Woodhouse
On Thu, 2019-10-10 at 10:00 +0200, Laszlo Ersek wrote: > > Subject: C=HU, ST=Pest, L=Budapest, O=Laszlo Ersek Home Office, > > OU=IPv6 cert, CN=fd33:eb1b:9b36::2 Yeah, you're not actually testing the case I'm talking about. You want a GEN_IP in the x509v3 Subject Alternative Name.

Re: [edk2-devel] [PATCH edk2-platforms 00/12] NXP : Add support of LS1043 SoC.

2019-10-10 Thread Leif Lindholm
Thanks for this. On the whole, the watchdog situation is the only real concern I have with regards to merging this set, the rest is pretty much all code style, and there's not much left of that. Looking forward to a v2, and finally merging some of this - but I warn you that I am on holiday

[edk2-devel] question about qemu+kvm+ovmf+winxp

2019-10-10 Thread Junhao Gao
Hi edk2 members I have a question for your help. I want to enable qemu+kvm+ovmf to boot up windows xp, then ovmf support winxp starting-up? qemu command: qemu-system-x86_64 -hda winxp.img -boot c -enable-kvm -cpu host -bios ./OVMF.fd

Re: [edk2-devel] [PATCH edk2-platforms 11/12] Compilation : Add the fdf, dsc and dec files.

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:17PM +0530, Meenakshi Aggarwal wrote: > The firmware device, description and declaration files. > > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm > --- > Platform/NXP/FVRules.fdf.inc | 93 +++ >

Re: [edk2-devel] [PATCH edk2-platforms 10/12] Platform/NXP: Add Platform driver for LS1043 RDB board

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:16PM +0530, Meenakshi Aggarwal wrote: > Platform driver will be used for platform specific work. > At present, it populate i2c driver structure with platform > specific information and install RTC on i2c. > > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif

Re: [edk2-devel] [PATCH edk2-platforms 06/12] Silicon/NXP: Add support for I2c driver

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:12PM +0530, Meenakshi Aggarwal wrote: > I2C driver produces gEfiI2cMasterProtocolGuid which can be > used by other modules. A few minor comments on this one, inline below. > Signed-off-by: Meenakshi Aggarwal > --- > Silicon/NXP/Drivers/I2cDxe/ComponentName.c | 179

Re: [edk2-devel] [PATCH edk2-platforms 12/12] Readme : Add Readme.md file.

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:18PM +0530, Meenakshi Aggarwal wrote: > Readme.md to explain how to build NXP board packages. > > Signed-off-by: Meenakshi Aggarwal > --- > Platform/NXP/Readme.md | 8 > Readme.md | 3 +++ > 2 files changed, 11 insertions(+) > create mode

Re: [edk2-devel] [PATCH edk2-platforms 08/12] Silicon/NXP : Add MemoryInitPei Library

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:14PM +0530, Meenakshi Aggarwal wrote: > Add MemoryInitPei Library for NXP platforms. > It has changes to get DRAM information from TFA. Changelog information belongs below ---, or in the cover letter. Please reword so this simply states that it retreieves DRAM

Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-10-10 Thread Liming Gao
Laszlo: Option (a) works. Jordan patch can fix this issue. Option (b) doesn't work. Even if disable optimization, CLANG doesn't generate the code with push rbp & pop rbp. So, Jordan patch becomes only option. We can discuss this topic again. But, I don't think this is the block issue

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/RPi3/RpiFirmwareDxe: Add more query functions

2019-10-10 Thread Pete Batard
Hi Leif, On 2019.10.10 09:39, Leif Lindholm wrote: On Tue, Oct 08, 2019 at 01:38:37PM +0100, Pete Batard wrote: This patch introduces the capability to also query the Model Name/ Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware protocol. This is aims at making the driver more

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Pete Batard
Hi Leif, It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I wrote in 0/5 for the v2, because the cover letter this is usually the place I try to clarify elements that may throw off a maintainer, and that don't belong in a commit message. Not so sound flippant here,

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 4:22 AM > To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com > Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove > __inline__ attribute for IO functions > > On 10/08/19

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Liming Gao
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, October 10, 2019 3:35 PM > To: Andrew Fish ; Gao, Liming > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain - > > Hi Andrew, > > On

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

2019-10-10 Thread Chen, Kenji
Having some problems to send the email by git. Sent it by Outlook. Bugzilla Case: https://bugzilla.tianocore.org/show_bug.cgi?id=2236. From: Chen, Kenji Sent: Thursday, October 10, 2019 12:13 AM To: Gao, Liming ; devel@edk2.groups.io Subject: RE: Patch for Bug 2236 on Bugzilla Will do. Track

[edk2-devel] [PATCH v2 0/2] UefiCpuPkg/MpInitLib: introduce PcdCpuBootLogicalProcessorNumber

2019-10-10 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: mpinitlib_bz_1515_v2 Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1515 In version 2, the first patch of the v1 series [edk2-devel] [PATCH 0/4] UefiCpuPkg, OvmfPkg: separate PCDs for boot CPU count vs. max CPU count originally

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

2019-10-10 Thread Laszlo Ersek
- If a platform boots such that the boot CPU count is smaller than PcdCpuMaxLogicalProcessorNumber, then the platform cannot use the "fast AP detection" logic added in commit 6e1987f19af7. (Which has been documented as a subset of use case (2) in the previous patch.) Said logic depends on

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: expand comment on initial AP enumeration

2019-10-10 Thread Laszlo Ersek
Before adding another AP enumeration mode, clarify the documentation on the current logic. No functional changes. Cc: Eric Dong Cc: Ray Ni Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1515 Signed-off-by: Laszlo Ersek --- Notes: v2: - new patch

Re: [edk2-devel] [PATCH edk2-platforms 04/12] SocLib : Add support for initialization of peripherals

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:10PM +0530, Meenakshi Aggarwal wrote: > Add SocInit function that initializes peripherals > and print board and soc information. > > Signed-off-by: Meenakshi Aggarwal > --- > Silicon/NXP/Include/Chassis2/LsSerDes.h | 62 >

Re: [edk2-devel] [PATCH edk2-platforms 03/12] Silicon/NXP : Add support for Watchdog driver

2019-10-10 Thread Leif Lindholm
Hi Meenakshi, As you will have no doubt noticed, edk2-de...@lists.01.org has been retired - we are now using devel@edk2.groups.io, please subscribe (and post patches) to that one instead. I have bounced my replies to your first two patches there, and will try to remember to manually change the

Re: [edk2-devel] [PATCH edk2-platforms 01/12] Silicon/NXP: Add Library to provide Mmio APIs with swapped data.

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:07PM +0530, Meenakshi Aggarwal wrote: > This library provided MMIO APIs for modules need swapping. > > Signed-off-by: Meenakshi Aggarwal This looks good to me. Reviewed-by: Leif Lindholm I will merge this into Silicon/NXP initially once the set is ready to go in,

Re: [edk2-devel] [PATCH edk2-platforms 02/12] Silicon/NXP: Add function to return swapped Mmio APIs pointer

2019-10-10 Thread Leif Lindholm
On Wed, Oct 09, 2019 at 10:19:08PM +0530, Meenakshi Aggarwal wrote: > Add support to return pointer to MMIO APIs on basis of Swap flag. > If Flag is True then MMIO APIs returned in which data > swapped after reading from MMIO and before write using MMIO. > > Signed-off-by: Meenakshi Aggarwal >

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-10 Thread Siyuan, Fu
> -Original Message- > From: Laszlo Ersek > Sent: 2019年10月10日 16:06 > To: Fu, Siyuan ; devel@edk2.groups.io; Rabeda, > Maciej > Cc: Wu, Jiaxin > Subject: Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove > ExitBootServices event > > On 10/10/19 05:32, Fu, Siyuan wrote: > > Hi,

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:41PM +0100, Pete Batard wrote: > The board revision is the proper channel to use to detect the amount of > RAM available as bits [20-22] report the effective RAM size for the board > starting with 256 MB (000b) and doubling in size for each value. > > Signed-off-by:

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:40PM +0100, Pete Batard wrote: > String parsing code is added to BIOSInfoUpdateSmbiosType0() so that > any numeric "x.y" value being passed in PcdFirmwareVersionString is > now used to populate the BIOS major and minor. > > Signed-off-by: Pete Batard > --- >

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/5] Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:39PM +0100, Pete Batard wrote: > This patch cleans up the population SMBIOS entries by removing elements > that we don't have data for, as well as properly filling the ones for > which we do, through the newly added queries from RpiFirmwareDxe. > > Additional minor

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:38PM +0100, Pete Batard wrote: > Improve RpiFirmwareGetSerial() to derive a serial number from the > MAC address, in case the platform returns 0 for the serial number. > > Also fix a typo where "%s" was used instead of "%a". I did not see a reply to my feedback on

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/RPi3/RpiFirmwareDxe: Add more query functions

2019-10-10 Thread Leif Lindholm
On Tue, Oct 08, 2019 at 01:38:37PM +0100, Pete Batard wrote: > This patch introduces the capability to also query the Model Name/ > Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware > protocol. This is aims at making the driver more suitable to cater > for platforms other than the

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

2019-10-10 Thread Laszlo Ersek
On 10/10/19 09:38, Laszlo Ersek wrote: > On 10/10/19 04:52, Ni, Ray wrote: >> Laszlo, >> Can you add comments in the code you changed to describe the two different >> behaviors? > > It's described in the DEC file, near the PCD: > > + # nonzero- PcdCpuApInitTimeOutInMicroSeconds is

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-10 Thread Laszlo Ersek
On 10/10/19 05:32, Fu, Siyuan wrote: > Hi, Maciej > > Considering that this patch has to co-work with corresponding UNDI device > driver > bug fix, in order to avoid potential compatibility problem, please add a PCD > to > NetworkPkg for this fix, and set the default value to disable state (no

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-10 Thread Laszlo Ersek
On 10/09/19 22:34, David Woodhouse wrote: > Can you show result of 'openssl x509 -noout -text -in xx.pem' on > your certs please. Sure. I had thought of that actually (I could have attached the certificates at once), but I figured, let me not share crypto stuff unless specifically asked for

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

2019-10-10 Thread Ni, Ray
Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Thursday, October 10, 2019 3:39 PM > To: Ni, Ray ; Dong, Eric ; > devel@edk2.groups.io > Cc: Igor Mammedov > Subject: Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the > platform's boot CPU count in AP detection > >

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

2019-10-10 Thread Laszlo Ersek
On 10/10/19 04:52, Ni, Ray wrote: > Laszlo, > Can you add comments in the code you changed to describe the two different > behaviors? It's described in the DEC file, near the PCD: + # nonzero- PcdCpuApInitTimeOutInMicroSeconds is ignored. The initial + # AP

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

2019-10-10 Thread Laszlo Ersek
Hi Andrew, On 10/09/19 18:22, Andrew Fish wrote: > I thought the thing we were discussing was compiler flags. > Specifically -mno-mmx -mno-sse. It seems to me if OVMF requires > -mno-mmx -mno-sse then it is a bug in the tools_def.txt definition > for those compilers? As far as I can tell

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

2019-10-10 Thread Sean via Groups.Io
Since the LSV can be managed from within the FmpDeviceLib i don't understand why this change is required.  This adds yet again more complexity to all users of FmpDxe for a very niche use case.  I believe the hooks already exist that would allow you to achieve the same functionality from within