> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 17, 2019 5:34 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/12]
> PciBusDxe: Record the PCI-Express Capability Structure
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2428
The latest TCG PFP specification (TCG PC Client Platform Firmware Profile
Specification, Revision 1.05) added new data structure. For example,
the SPDM device measurement. This patch adds the new content.
Cc: Michael D Kinney
Cc: Liming
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 17, 2019 5:30 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/12]
> PciBusDxe: Integration of setup for PCI feature
Thanks for the review, Ray!
My response in line
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, December 17, 2019 5:26 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/12]
>
Hi Nate,
This patch is good to me.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, December 18, 2019 11:01 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Leif Lindholm
Subject: RE: [edk2-devel] [PATCH]
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Tuesday, December 17, 2019 9:55 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Shi, Steven ;
>Kinney, Michael D
>Subject: [Patch 1/1] BaseTools: Resolve a issue of Incremental build
>
>BZ:
Hi Aiden,
If set kwargs["stdout"] = sys.stdout, then stdout and stderr messages from sub
process will directly write to sys.stdout.
I think this patch works because sys.stdout.encoding is the correct encoding.
So what do you think if we fix this Non-Ascii issue by
Changing the line of
message =
Ray,
I did not name the protocol this way because EmbeddedPkg already describes a
protocol with a similar name that is PLATFORM_BOOT_MANAGER_PROTOCOL. If you
think we can still go ahead with new protocol named
EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL, I can make the necessary changes.
I agree
Sorry for the delay. Somehow I didn't catch the follow-up email. Thanks for
checking my comments, Ray and Ashish.
Yeah, agree. 2.b is better. I will review the code change.
Regards,
Sunny Wang
-Original Message-
From: disc...@edk2.groups.io [mailto:disc...@edk2.groups.io] On Behalf Of
Implement QueryPerformanceCounter() for Emulator on both Unix and Windows.
Signed-off-by: Derek Lin
Signed-off-by: Kitty Chen
---
EmulatorPkg/Unix/Host/EmuThunk.c | 6 --
EmulatorPkg/Win/Host/WinThunk.c | 7 ++-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git
Any chance I could get a code review on this?
Thanks,
Nate
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Friday, December 6, 2019 10:15 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Leif Lindholm
Subject: [edk2-devel] [PATCH]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
Align to SPDM 1.0.0 specification.
Fix Nonce data structure error.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Jiewen Yao
---
MdePkg/Include/IndustryStandard/Spdm.h | 10 +-
1 file changed, 5 insertions(+), 5
Hi Anthony,
I fixed this issue at edk2 master.
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Anthony
PERARD
Sent: Monday, December 16, 2019 10:14 PM
To: devel@edk2.groups.io; Feng, Bob C
Cc: Gao, Liming ; Shi, Steven ;
Kinney,
Sorry Rebecca for the slow reply.
We have identified the issue and will be adding some minor documentation to
pytool docs to help.
In short, nuget relies on new versions of mono. Mono is not getting updated in
linux distro maintained packages as fast as needed.
This resolved the issue for our
Yes. If Pcd type is not DynamicXXX, there is no PCD_TOKEN define generated.
-Original Message-
From: Gao, Liming
Sent: Wednesday, December 18, 2019 10:15 AM
To: devel@edk2.groups.io; Feng, Bob C
Cc: Shi, Steven
Subject: RE: [edk2-devel] [Patch 1/1] BaseTools: Remove PCD_TOKEN define
Bob:
PatchInModule and FeaturePcd don't use Token. Does this patch remove the
token generation for them?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Bob Feng
>Sent: Wednesday, December 18, 2019 10:09 AM
>To:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
UefiDevicePathLibOptionalDevicePathProtocol's implementation isn't
fit its description. It should be implement as blow:
Try to find the DevicePathProtocol, if found then use it to implement
the interface. Else, use the local interface. It
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
The UefiDevicePathLibOptionalDevicePathProtocolConstructor's implementation
isn't match with its instance name.
Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid
because of "Optional".
Add a mandatory instance to force
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
Add the new instance lib for build.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Vitaly Cheptsov
Reviewed-by: Liming Gao
Tested-by: Zhichao Gao
Signed-off-by: Zhichao Gao
---
MdePkg/MdePkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2426
Build tool generate PCD_TOKEN_xxx Macro for FixedAtBuild Pcd
in Autogen.c and Autogen.h but there is no code use that Macro,
so this patch is going to remove this Macro from autogen files.
This change can improve incremental build function.
Alex has verified this change on OVMF boot to shell. I have no other comment
for it. Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Tuesday, December 10, 2019 8:50 AM
>To:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, December 18, 2019 6:52 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update
> PCDs to enable stack
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:36AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> This library implements PlatformBootManagerWaitCallback
> and PlatformBootManagerUnableToBoot which can be linked
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:37AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added a DXE driver that registers the minimum platform
> BDS hook points, to BoardX58Ich10 board.
> These hooks
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:33AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added a DXE driver that registers the minimum platform
> BDS hook points for the GalagoPro3 and KabylakeRvp3
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:34AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added a DXE driver that registers the minimum platform
> BDS hook points, to WhiskeylakeURvp board.
> These hooks
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:32AM +, Agyeman, Prince wrote:
> This library implements a generic PlatformBootManagerWaitCallback
> and PlatformBootManagerUnableToBoot which will be linked Minplatform's
> PlatformBootManager library
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:31AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added BDS hook points to the Minplatform boot manager library
> as defined in the Minimum Platfrom specifcations.
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:30AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> As Minplatform's PlatformBootManager library instance implements
> event signals (as specified in the minimum
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:29AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> This is a sample/generic DXE driver that registers
> all the BDS hook points or callbacks as defined in
>
Hi Prince,
Reviewed-by: Nate DeSimone
Thanks,
Nate
On Sat, Dec 14, 2019 at 01:32:27AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added BDS hook point guids as defined in the
> Minimum Platform specification. These GUIDs
> shall be used in the
Hi Prince,
Feedback inline.
On Sat, Dec 14, 2019 at 01:32:35AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added Board BDS Hook library that implements simics specific
> Bds hook points or callbacks.
>
> Cc: Nate DeSimone
> Cc: Michael Kubacki
Hi Prince,
Feedback inline.
Sat, Dec 14, 2019 at 01:32:28AM +, Agyeman, Prince wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
>
> Added a generic board BDS hook library that implements
> BDS hook points as defined in the Minimum platform specification.
>
> This library
Ashish,
I prefer EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL and could have two fields for
this protocol for now:
Revision and RefreshAllBootOption (IN Options, IN OptionCount, OUT
UpdatedOptions, OUT UpdatedOptionCount)
Usually EDKII puts Count in second and buffer in first.
The reason of using
Add PS2 keyboard support.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2316
This patch adds PS2 keyboard support in boot manager, and
add a build flag PS2_KEYBOARD_ENABLE for PS2 keyboard to
build PS2 keyboard driver and SIO driver. Be default the
build flag is not enabled since PS2
Michael,
I had misunderstanding earlier. Thanks for the explanation.
Thanks,
Ray
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, December 18, 2019 7:58 AM
> To: Ni, Ray
> Cc: Desimone, Nathaniel L ;
> devel@edk2.groups.io; Chiu, Chasel
> ; Agyeman, Prince
>
Hi Ray,
There could be usage of SimpleTextIn->ReadKeyStroke () in
PlatformBootManagerWaitCallback () and PlatformBootManagerUnableToBoot (). The
PlatformBootManagerLib instance introduced in MinPlatformPkg simply forwards
those calls to a library instance of BoardBootManagerLib implemented in
Thanks Maurice. Will add PS2_KEYBOARD_ENABLE for newly added drivers and set to
disabled by default.
Thanks,
Guo
> -Original Message-
> From: Ma, Maurice
> Sent: Tuesday, December 17, 2019 4:17 PM
> To: Dong, Guo
> Cc: You, Benjamin ; u14...@gmail.com;
> devel@edk2.groups.io
>
Hi, Guo,
Since PS2 keyboard is not commonly seen anymore, do you think it is better to
define a control variable in DSC so that the PS2 driver can be easily added or
removed using build command line ?
Thanks
Maurice
> -Original Message-
> From: Dong, Guo
> Sent: Tuesday, December 10,
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, December 17, 2019 2:52 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCDs to
enable stack sharing
From: "Agyeman, Prince"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL)
FSP binary (v 7.0.68.41).
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Add platform boot options protocol which would have platform specific
overrides to the auto enumerated boot options during the call to
EfiBootManagerRefreshAllBootOption function in UefiBootManagerLib.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootOptions.h | 116
Add platform boot options protocol which would have platform specific
overrides to the auto enumerated boot options during the call to
EfiBootManagerRefreshAllBootOption function in UefiBootManagerLib.
This protocol also allows for removing invalid platform specific NV
boot options.
Add platform boot options protocol which would have platform specific
overrides to the auto enumerated boot options during the call to
EfiBootManagerRefreshAllBootOption function in UefiBootManagerLib.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootOptions.h | 114
I have submitted a patch based on 2.b as suggested by Ray. I am open to making
changes in the structure of the protocol functions as well as the verbal
description. Please let me know what you all think about it.
Thanks
Ashish
From: Jeff Brasen
Sent: Thursday,
2 minor comments.
And I suggest you don't change EFI_D_xxx in this patch. Or you could change in
a separate patch.
> > + PCI_CAPABILITY_PCIEXP PciExpStruct;
1. to align "Pci" which buffers the PCI config space, this can be simply
"PciExp".
> > + //
> > + // For SR-IOV
> > +if (CheckOtherPciFeaturesPcd ()) {
> > + //
> > + // the late configuration of PCI features
> > + //
> > + Status = EnumerateOtherPciFeatures (
> > + RootBridge
> > +);
The function name can be "ProgramPcieFeatures"?
Please check comments below.
I may have more comments regarding to the four phases after I finish review of
further patches.
Besides the comments below, I have a general comments to the debug message: can
you please
review the existing debug message in the PciBus driver and make sure your newly
Hi Pierre,
I add comments inline
Thanks,
Bob
From: PierreGondois [mailto:pierre.gond...@arm.com]
Sent: Monday, December 16, 2019 8:34 AM
To: Feng, Bob C ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C
files
Hello Bob,
> I think if we can
Sure, already create the new PR & push label to edk2 master.
Thanks,
Jiaxin
> -Original Message-
> From: Rabeda, Maciej
> Sent: Tuesday, December 17, 2019 6:07 AM
> To: devel@edk2.groups.io; Wu, Jiaxin
> Subject: Re: [edk2-devel] [PATCH v2] Maintainers.txt: Update email address
> and
On Thu, 28 Nov 2019 at 01:25, Jeff Brasen wrote:
>
> Add support for the new UEFI 2.8 runtime services supported variable
> that is used to indicate which runtime services a platform supports.
> Also, add support for initializing this variable based on a PCD.
>
> Change Log:
> v1 - Initial
51 matches
Mail list logo
