Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 01/23/2020 5:00pm-5:30pm #cal-reminder

2020-01-18 Thread Liming Gao
Brian: This time is Chinese New Year Holiday. Most Chinese people will not join this meeting. How about cancel this week meeting? Thanks Liming From: devel@edk2.groups.io Sent: 2020年1月19日 9:00 To: devel@edk2.groups.io Subject: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO -

Re: [edk2-devel] [PATCH 06/13] OvmfPkg/Tcg2PhysicalPresenceLib: Use pcd for user response wait time

2020-01-18 Thread Gao, Zhichao
Hi Laszlo, Sorry for misunderstanding the logic in read key function. That makes the incorrect analysis. The read key function is waiting for "specific" key press not a key press. We should drop all the other pressing-key. That means we should create a hotkey service like BDS one. It is not

Re: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test

2020-01-18 Thread Liming Gao
Heng: The change is good to me. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Heng Luo Sent: 2020年1月14日 16:54 To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] MdeModulePkg: Perform test only if not ignore memory test REF:

[edk2-devel] [Patch 1/1 V2] BaseTools: Fixed a incremental build bug

2020-01-18 Thread Bob Feng
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2451 If removing a header file from source code and file system, the incremental build will fail. This patch is to fix this issue by setting each header file as a target without any actions in makefile. Signed-off-by: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)

2020-01-18 Thread Liming Gao
Phil: Ray talks leave for Chinese New year holiday. I can take back up for him. For those changes, I agree them. Acked-by: Liming Gao Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Philippe Mathieu-Daudé Sent: 2020年1月18日 1:14 To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Fix possible uninitialized 'InitFlag' field

2020-01-18 Thread Wu, Hao A
Thanks all, Patch has been pushed via commit 18fcb37598. Best Regards, Hao Wu > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, January 17, 2020 8:04 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Ni, Ray; Kinney, Michael D > Subject: Re:

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed a incremental build bug

2020-01-18 Thread Liming Gao
Bob: This patch fixes the incremental build issue for the header file removement. Please update the commit message with the detail solution. The code change is good. Reviewed-by: Liming Gao Thanks Liming -Original Message- From: Feng, Bob C Sent: 2020年1月17日 11:28 To:

Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error

2020-01-18 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, January 15, 2020 9:50 AM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: Re: [edk2-devel] [PATCHv2 0/4]

Re: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib

2020-01-18 Thread Xiaoyu Lu
Hi Jian, The date of copyright info should be update to 2020 in each changed file. with these changed: Reviewed-by: Xiaoyu Lu Thanks. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Thursday, January 16, 2020 2:10

Re: [edk2-devel] [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

2020-01-18 Thread Liming Gao
Laszlo: I also agree to handle those file type specified in build_rule.txt. Thanks Liming -Original Message- From: Leif Lindholm Sent: 2020年1月18日 3:37 To: Laszlo Ersek Cc: Gao, Liming ; devel@edk2.groups.io; Feng, Bob C Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 01/23/2020 5:00pm-5:30pm #cal-reminder

2020-01-18 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 23 January 2020, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503276 ) *Organizer:* Brian Richardson