[edk2-devel] Updated Event: TianoCore Design Meeting - APAC/NAMO - Friday, 3 April 2020 #cal-invite

2020-03-31 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200401T052016Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200403T013000Z DTEND:20200403T023000Z

Re: [edk2-devel] [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes

2020-03-31 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > Subject: [Patch V2 3/3] Features/Intel: Correct wrong codes and remove > unnecessary codes > >

Re: [edk2-devel] [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround

2020-03-31 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > Subject: [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to > TemporaryBuildWorkaround > > Ref:

Re: [edk2-devel] [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path

2020-03-31 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Luo, Heng > Sent: Tuesday, March 31, 2020 11:49 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Dong, Eric ; Ni, Ray > Subject: [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to > package path > >

[edk2-devel] How to change RAID Card's configuration without going into its setup ui

2020-03-31 Thread Tiger Liu(BJ-RD)
Hi, Experts: I am studying how to remote control some hardware's configuration. Such as changing RAID Card's configuration without going into its setup ui. So, one question confused me. If RAID Card's firmware is written with UEFI driver model, so I can use some standard UEFI protocol to pass

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Guomin Jiang
It is ok, I have no others confusion. Reviewed-by: Guomin Jiang > -Original Message- > From: Michael Kubacki [mailto:michael.kuba...@outlook.com] > Sent: Wednesday, April 1, 2020 1:12 AM > To: Jiang, Guomin ; devel@edk2.groups.io; Wang, > Jian J > Cc: Bret Barkelew ; Gao, Liming > ;

Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Michael Kubacki
I have those options set correctly in git config. After a quick look, as far as I can tell, this is because the Message-Id in my email is modified such the the In-Reply-To and References headers do not refer to the actual Message-Id in the cover letter: Cover letter: Subject: [edk2-devel]

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 04/01/2020 9:30am-10:30am #cal-reminder

2020-03-31 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 1 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758250 ) *Organizer:* Brian Richardson brian.richard...@intel.com

[edk2-devel] [PATCH] SecurityPkg/MeasureBootLib: Return EFI_ACCESS_DENIED after image check fail

2020-03-31 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2652 If check the File at the begin of function, it will only allow the File is present and forbid image from buffer. It is possible that image come from the memory buffer, so make it can run and check the File after it. It is improvement for

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Allow pin file to be checked out when combo is not in project manifest

2020-03-31 Thread Desimone, Ashley E
When a pin file is based on a combo that is not in the project manifest file but otherwise matches the project print a warning instead of throwing and exception and allow the pin to be checked out. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret

Re: [edk2-devel] How to add ignore "IgnoreFiles" for CharEncodingCheck

2020-03-31 Thread Sean via Groups.Io
On Tue, Mar 31, 2020 at 08:52 AM, Zhang, Shenglei wrote: > > > > "CharEncodingCheck": { > > > > "IgnoreFiles": > [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c)] > > > > > } > > This syntax

Re: [edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation.

2020-03-31 Thread Laszlo Ersek
On 03/31/20 14:22, Maciej Rabeda wrote: > Hi Laszlo, > > Thanks for trying this out! > > The condition in the ASSERTs is reversed, consequently for the ASSERTs > added in this function. > I have added them to fire up when Ip6IsNDOptionValid() fails to properly > react to invalid packet (return

Re: [edk2-devel] [PATCH v3 3/3] Revert "NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

2020-03-31 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu > -Original Message- > From: michael.kuba...@outlook.com > Sent: Saturday, March 28, 2020 5:56 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Fu, Siyuan ; > Maciej Rabeda ; Wu, Jiaxin > > Subject: [PATCH v3 3/3] Revert "NetworkPkg/TlsAuthConfigDxe: fix >

Re: [edk2-devel] [PATCH v3 0/3] Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Laszlo Ersek
Hi Michael, On 03/27/20 22:55, Michael Kubacki wrote: > From: Michael Kubacki > > This patch series updates the GetVariable() implementation > to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned. > > * [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver. > *

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Michael D Kinney
Hi Sean, This lib defines a global variable that is referenced when a compiler detects use of float/double types. If the global is not referenced, then it should be optimized away, so the size impact should be zero. That can be verified as part of the review of this feature. Mike From:

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically

2020-03-31 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Friday, March 27, 2020 1:31 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Philippe Mathieu-Daudé Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo:

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Sean via Groups.Io
Does anyone know off hand if defining this and enabling floating point has any negative side effects if you don't need it?  Size? Optimization? Other?   That is my only concern for enabling in all modules which is why the initial proposal was for a new library. -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve state tracking when checking out pin files

2020-03-31 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Ashley E Sent: Tuesday, March 31, 2020 2:00 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-devel]

[edk2-devel] [PATCH v2] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

2020-03-31 Thread Liran Alon
Previous to this change, PvScsiFreeRings() was not undoing all operations that was done by PvScsiInitRings(). This is because PvScsiInitRings() was both preparing rings (Allocate memory and map it for device DMA) and setup the rings against device by issueing a device command. While

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Sean via Groups.Io
I agree that safeintlib is not doing anything too interesting in this case but that's not really the point.  The argument for it is that it becomes the central point of code to check for safe conversions and an indicator that the developer was thoughtful about this conversion and didn't just

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 7/7] EdkRepo: Update List Repos for archived combos

2020-03-31 Thread Bjorge, Erik C
When running the List Repos command archived combos will not be listed unless the archived flag is provided. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/list_repos_command.py | 37 ++ 1 file

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 5/7] EdkRepo: Update Checkout Pin for archived combos

2020-03-31 Thread Bjorge, Erik C
Added support for archived combos in the Checkout Pin command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/checkout_pin_command.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 3/7] EdkRepo: Update Checkout for archived combos

2020-03-31 Thread Bjorge, Erik C
Now either an active or archived branch combination can be checked out. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/common/common_repo_functions.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/7] EdkRepo: Added ability to display archived combinations

2020-03-31 Thread Bjorge, Erik C
Added support for using the -a / --archived flags to include archived combinations. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/arguments/combo_args.py | 5 +++-- edkrepo/commands/combo_command.py| 19

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 4/7] EdkRepo: Update Sync for archived combos

2020-03-31 Thread Bjorge, Erik C
Added support for archived combos in Sync command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/sync_command.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 6/7] EdkRepo: Update clone for archived combos

2020-03-31 Thread Bjorge, Erik C
Adding support for archived combos in the clone command. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/commands/clone_command.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/7] EdkRepo: Adding support for archiving combos

2020-03-31 Thread Bjorge, Erik C
Adding support to check the archived attribute on branch combos. This allows a combo to be archived and available if required but not dirty up the combo list. Signed-off-by: Erik Bjorge Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman ---

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/7] Adding support for archiving branch combos

2020-03-31 Thread Bjorge, Erik C
Adding the ability to mark a branch combination as archived. This will remove it from the list of valid combinations by default. It should not limit users from accessing the branch combination. The archive flag will allow users to list archived branch combinations in the combo command. Erik

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/31/20 16:36, Kinney, Michael D wrote: > ARM and AARCH64 have a compiler intrinsic lib that is linked against all > modules. > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > # It is not possible to prevent ARM compiler calls to generic intrinsic > functions. > # This library

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

2020-03-31 Thread Liran Alon
On 01/04/2020 1:19, Laszlo Ersek wrote: Hi Liran, On 03/31/20 13:47, Liran Alon wrote: Previous to this change, PvScsiFreeRings() was not undoing all operations that was done by PvScsiInitRings(). This is because PvScsiInitRings() was both preparing rings (Allocate memory and map it for

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

2020-03-31 Thread Laszlo Ersek
Hi Liran, On 03/31/20 13:47, Liran Alon wrote: > Previous to this change, PvScsiFreeRings() was not undoing all > operations that was done by PvScsiInitRings(). > This is because PvScsiInitRings() was both preparing rings (Allocate > memory and map it for device DMA) and setup the rings against

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Liran Alon
On 01/04/2020 1:13, Liran Alon wrote: On 01/04/2020 0:56, Laszlo Ersek wrote: On 03/31/20 17:53, Sean via Groups.Io wrote: A couple of thoughts. 1. I would suggest that ASSERT should not be the only protection for an invalid operation as ASSERT is usually disabled on release builds. 2. We

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Liran Alon
On 01/04/2020 0:56, Laszlo Ersek wrote: On 03/31/20 17:53, Sean via Groups.Io wrote: A couple of thoughts. 1. I would suggest that ASSERT should not be the only protection for an invalid operation as ASSERT is usually disabled on release builds. 2. We do have a library to make this more

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Laszlo Ersek
On 03/31/20 17:53, Sean via Groups.Io wrote: > A couple of thoughts. > 1. I would suggest that ASSERT should not be the only protection for an > invalid operation as ASSERT is usually disabled on release builds. > 2. We do have a library to make this more explicit and common. >

Re: [edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers

2020-03-31 Thread Nikita Leshenko
> On 31 Mar 2020, at 14:02, Liran Alon wrote: > > Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I > will also register myself as a reviewer in Maintainers.txt. > > In addition, as Nikita have assisted the development of the PVSCSI > driver and have developed another

Re: [edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers

2020-03-31 Thread Laszlo Ersek
On 03/31/20 13:02, Liran Alon wrote: > Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I > will also register myself as a reviewer in Maintainers.txt. > > In addition, as Nikita have assisted the development of the PVSCSI > driver and have developed another similar OvmfPkg

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Improve state tracking when checking out pin files

2020-03-31 Thread Desimone, Ashley E
Improves the state tracking when checking out onto a pin file by: (1)moving the call to write_current_combo() after the succesfull checkout, (2)changing the name of the combo written to the format: 'Pin: {pinfilename}', (3)If the current combo is a knon pin file (starts with 'Pin:')

Re: [edk2-devel] [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP servers (more) gracefully

2020-03-31 Thread Maciej Rabeda
Always better than not detecting such stuff at all (or by ASSERT in debug builds). Thanks for the patch! Reviewed-by: Maciej Rabeda On 31-Mar-20 02:47, Laszlo Ersek wrote: When DHCP is misconfigured on a network segment, such that two DHCP servers attempt to reply to requests (and therefore

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Maciej Rabeda
Much appreciated, I'll submit the patch tomorrow :) On 31-Mar-20 16:50, Gao, Zhichao wrote: Acked-by: Zhichao Gao -Original Message- From: Fu, Siyuan Sent: Tuesday, March 31, 2020 7:54 PM To: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray ; Gao, Zhichao Cc:

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Michael Kubacki
That has been spelled incorrectly for about 9 years. The file (like many others) also has other spelling errors such as the following. I suggest this be fixed in a separate commit/series focused on fixing spelling errors. --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Ard Biesheuvel
On 3/31/20 6:26 PM, Sean via Groups.Io wrote: On Mon, Mar 30, 2020 at 11:41 PM, Ard Biesheuvel wrote: Not sure I follow. Which command line are we talking about? @Ard - In this Platform CI, ArmVirt is building and running AARCH64 but not ARM 32bit.  Would it be valuable to build for ARM

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 11:41 PM, Ard Biesheuvel wrote: > > Not sure I follow. Which command line are we talking about? @Ard - In this Platform CI, ArmVirt is building and running AARCH64 but not ARM 32bit.  Would it be valuable to build for ARM too? I prototyped it but want to make sure I am

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Sean via Groups.Io
A couple of thoughts. 1. I would suggest that ASSERT should not be the only protection for an invalid operation as ASSERT is usually disabled on release builds. 2. We do have a library to make this more explicit and common.

[edk2-devel] How to add ignore "IgnoreFiles" for CharEncodingCheck

2020-03-31 Thread Zhang, Shenglei
Hi Sean, I am introducing third party project oniguruma as submodule into edk2, and want to skip CharEncodingCheck for certain files in oniguruma. I tried to add changes like below, but CI build failed. "CharEncodingCheck": { "IgnoreFiles":

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Gao, Zhichao
Acked-by: Zhichao Gao > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, March 31, 2020 7:54 PM > To: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray ; > Gao, Zhichao > Cc: maciej.rab...@linux.intel.com > Subject: RE: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Michael D Kinney
ARM and AARCH64 have a compiler intrinsic lib that is linked against all modules. [LibraryClasses.ARM, LibraryClasses.AARCH64] # # It is not possible to prevent ARM compiler calls to generic intrinsic functions. # This library provides the instrinsic functions generated by a given

Re: [edk2-devel] API breakages and their implications. Was: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-31 Thread Laszlo Ersek
On 03/31/20 11:22, Leif Lindholm wrote: > On Tue, Mar 31, 2020 at 01:53:21 +, Ni, Ray wrote: >> Leif, >> Please understand that the concern of this change is all the platforms that >> uses >> this serial port lib must be changed otherwise build breaks. > > Yes. This is the nature of

Re: [edk2-devel] API breakages and their implications. Was: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-31 Thread Leif Lindholm
Hi Ray, I think it's good to start doing it voluntarily, or for changes expected to affect many platforms. Over time, as people become more familiar with the tool, it would make sense to make it first recommended and then mandatory. For Linux, the coccinelle diff is frequently included in the

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: 2020年3月25日 19:34 > To: Ni, Ray ; Gao, Zhichao > Cc: devel@edk2.groups.io; maciej.rab...@linux.intel.com > Subject: Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: switch to my @arm.com email address

2020-03-31 Thread Ard Biesheuvel
On 3/31/20 2:33 PM, Leif Lindholm wrote: On Tue, Mar 31, 2020 at 13:12:28 +0200, Ard Biesheuvel wrote: I no longer work for Linaro so switch to my ARM email address. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm (Not that I can be trusted on the spelling...) Thanks Pushed as

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/30/20 23:41, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 23:29, Matthew Carlson via Groups.Io > wrote: >> >> So it's not required by OpenSSL, it's required by the compiler whenever >> floating point is used, which can be in multiple places. For example, this >> is used in mu_plus (the

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: switch to my @arm.com email address

2020-03-31 Thread Leif Lindholm
On Tue, Mar 31, 2020 at 13:12:28 +0200, Ard Biesheuvel wrote: > I no longer work for Linaro so switch to my ARM email address. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm (Not that I can be trusted on the spelling...) > --- > Maintainers.txt | 20 ++-- > 1

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Laszlo Ersek
On 03/31/20 09:13, Ard Biesheuvel wrote: > On Tue, 31 Mar 2020 at 03:40, Jiang, Guomin wrote: >> >> Hi Laszlo, >> >> Thanks for you spending time review the changes. >> >> And I just want to present how to reproduce the build error. >> >> When build OvmfPkgX64, you can encounter this issue with

Re: [edk2-devel] [PATCH v2 05/28] Silicon/Maxim: Add comments in Ds1307RtcLib

2020-03-31 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:20 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add comments to explain the register read and write operation > on Ds1307. These comments have been referred from data sheet: > > https://datasheets.maximintegrated.com/en/ds/DS1307.pdf > > Signed-off-by:

Re: [edk2-devel] [PATCH v2 04/28] Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib

2020-03-31 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:19 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > There was a bug in I2C DXE implementation, which caused the Ds1307 RTC > device to issue two operation for register write, while this is a single > operation task. refer page 12 (Slave Receiver Mode (Write

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Laszlo Ersek
On 03/30/20 23:29, Kinney, Michael D wrote: > Hi Laszlo, > > I think using the QEMU feature to map a path from the host as > a FAT formatted driver has value to provision QEMU with a set > of target tests to run. I agree there is no persistent storage > of writes to this type of drive. I

Re: [edk2-devel] [PATCH v2] NetworkPkg/Ip6Dxe: Improve Neightbor Discovery message validation.

2020-03-31 Thread Maciej Rabeda
Hi Laszlo, Thanks for trying this out! The condition in the ASSERTs is reversed, consequently for the ASSERTs added in this function. I have added them to fire up when Ip6IsNDOptionValid() fails to properly react to invalid packet (return with an error and do not proceed with processing

Re: [edk2-devel] [PATCH v4 1/1] BaseTools: Enable file dependencies in .inf files

2020-03-31 Thread PierreGondois
This patch is following the v3 named "BaseTools: Build ASL files before C files ", available at https://edk2.groups.io/g/devel/message/53735 Sorry for messing with the names. Regards, Pierre -Original Message- From: PierreGondois Sent: Monday, March 30, 2020 5:09 PM To:

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Laszlo Ersek
On 03/30/20 23:22, Ard Biesheuvel wrote: > On Mon, 30 Mar 2020 at 22:56, Laszlo Ersek wrote: >> >> On 03/30/20 19:44, Ard Biesheuvel wrote: >>> On Mon, 30 Mar 2020 at 19:11, Sean via Groups.Io >>> wrote: On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: Is there any way

Re: [edk2-devel] API breakages and their implications. Was: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-31 Thread Ni, Ray
Leif, Thanks for introducing such an interesting tool. I see this too is very useful for code refactoring. It's a game changing tool To help me understand, do you suggest MAYBE when incompatible changes like this happen, the change owners propose the semantic patches for all platforms? Thanks,

Re: [edk2-devel] [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP servers (more) gracefully

2020-03-31 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Laszlo Ersek > Sent: 2020年3月31日 8:48 > To: edk2-devel-groups-io > Cc: Wu, Jiaxin ; Maciej Rabeda > ; Philippe Mathieu-Daudé > ; Fu, Siyuan > Subject: [PATCH] NetworkPkg/UefiPxeBcDxe: handle competing DHCP servers > (more) gracefully

Re: [edk2-devel] [PATCH v2 03/28] Silicon/NXP/I2cDxe: Fix I2c Timeout with RTC

2020-03-31 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:18 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > With latest edk2 codebase, sometimes i2c timeout is observed when > Network devices are being probed. > This is happening when gRT->GetTime request is ongoing. > gRT->GetTime triggers a read request to Real

Re: [edk2-devel] [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

2020-03-31 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: michael.kuba...@outlook.com > Sent: 2020年3月25日 11:00 > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Fu, Siyuan ; > Maciej Rabeda ; Wu, Jiaxin > > Subject: [PATCH v2 2/2] Revert "NetworkPkg/TlsAuthConfigDxe: fix > TlsCaCertificate

Re: [edk2-devel] [PATCH v2 01/28] Silicon/NXP: Add I2c lib

2020-03-31 Thread Leif Lindholm
On Fri, Mar 20, 2020 at 20:05:16 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > I2c lib is going to be used in PrePeiCore sec module to get the > System clock information from devices connected to i2c (like fpga > or clock generator) > > since we don't have support of DXE modules this

[edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function

2020-03-31 Thread Liran Alon
Previous to this change, PvScsiFreeRings() was not undoing all operations that was done by PvScsiInitRings(). This is because PvScsiInitRings() was both preparing rings (Allocate memory and map it for device DMA) and setup the rings against device by issueing a device command. While

[edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: switch to my @arm.com email address

2020-03-31 Thread Ard Biesheuvel
I no longer work for Linaro so switch to my ARM email address. Signed-off-by: Ard Biesheuvel --- Maintainers.txt | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 475f7d530b85..0e50b6fdf36a 100644 ---

[edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Liran Alon
Sean reported that VS2019 build produce the following build error: INFO - PvScsi.c INFO - Generating code INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): error C2220: the following warning is treated as an error INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): warning C4244: '=': conversion

[edk2-devel] [PATCH] Maintainers.txt: Add Liran and Nikita as OvmfPkg/PvScsiDxe reviewers

2020-03-31 Thread Liran Alon
Laszlo suggested that as I have contributed the OvmfPkg PVSCSI driver, I will also register myself as a reviewer in Maintainers.txt. In addition, as Nikita have assisted the development of the PVSCSI driver and have developed another similar OvmfPkg SCSI driver, add him as a reviewer to PVSCSI

Re: [edk2-devel] [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

2020-03-31 Thread Leif Lindholm
On Tue, Mar 31, 2020 at 10:23:48 +, Pankaj Bansal (OSS) wrote: > > > -/*++ > > > - > > > -Routine Description: > > > - > > > - > > > - > > > -Arguments: > > > - > > > - FileHandle - Handle of the file being invoked. > > > - PeiServices - Describes the list of possible PEI Services. > > > -

Re: [edk2-devel] [edk2-platforms][PATCH v3 9/9] Maintainers.txt: Update Arm platform

2020-03-31 Thread Ard Biesheuvel
On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > From: Thomas Abraham > > Update the reviewers list for Arm platforms. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Signed-off-by: Aditya Angadi Thanks - I'll take this as a separate patch and apply it right away. >

Re: [edk2-devel] [edk2-platforms][PATCH v3 8/9] Platform/ARM/Sgi: add initial support

2020-03-31 Thread Ard Biesheuvel
Again, please don't use duplicate patch titles in the same series. On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > For RD-Daniel Config-XLR, use multichip mode information from the SGI > platform descriptor HOB to pick the correct ACPI table to be installed. > > Cc: Leif Lindholm > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v3 7/9] Platform/ARM/SgiPkg: add ACPI tables

2020-03-31 Thread Ard Biesheuvel
Please don't use the exact same subject for different patches in the same series. On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > RD-Daniel Config-XLR is a platform in which four identical chips are > connected via a high speed CCIX link. Add Madt and Dsdt tables for the > same. > > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v3 4/9] Platform/ARM/SgiPkg: remove

2020-03-31 Thread Ard Biesheuvel
On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > The number of CPUs depend on the SGI/RD platform. So instead of depends > defining a Fixed PCD to specify the value of core and cluster count, > let each platform define these values. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel >

Re: [edk2-devel] [edk2-platforms][PATCH v3 2/9] Platform/ARM/SgiPkg: move the GIC

2020-03-31 Thread Ard Biesheuvel
On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > Move the ACPI helper macros defines related to GIC structure, > distributor, redistributor and ITS to SgiAcpiHeader.h as these are > common across ARM SGI/RD platforms. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Aditya

Re: [edk2-devel] [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

2020-03-31 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Monday, March 30, 2020 5:49 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon Nettleton > Subject: Re: [PATCH v2 28/28]

Re: [edk2-devel] [PATCH] Maintainers: switch to my Arm email address

2020-03-31 Thread Ard Biesheuvel
On Thu, 5 Mar 2020 at 15:33, Laszlo Ersek wrote: > > On 03/05/20 13:30, Leif Lindholm wrote: > > On Thu, Mar 05, 2020 at 12:23:46 +0100, Ard Biesheuvel wrote: > >> I no longer work for Linaro (and haven't for a while) so in anticipation > >> of losing access to my @linaro.org mailbox, let's

[edk2-devel] How to change RAID Card's configuration without going into its setup ui

2020-03-31 Thread Tiger Liu(BJ-RD)
Hi, Experts: I am studying how to remote control some hardware's configuration. Such as changing RAID Card's configuration without going into its setup ui. So, one question confused me. If RAID Card's firmware is written with UEFI driver model, so I can use some standard UEFI protocol to pass

Re: [edk2-devel] API breakages and their implications. Was: [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-31 Thread Leif Lindholm
On Tue, Mar 31, 2020 at 01:53:21 +, Ni, Ray wrote: > Leif, > Please understand that the concern of this change is all the platforms that > uses > this serial port lib must be changed otherwise build breaks. Yes. This is the nature of collaborative development. This is something we on the ARM

Re: [edk2-devel] [PATCH v1] ShellPkg: Fix 'ping' command Ip4 receive flow.

2020-03-31 Thread Maciej Rabeda
Siyuan/Jiaxin, Can we get this patch reviewed? I cannot give myself green light on this patch :) On 26-Mar-20 04:16, Gao, Zhichao wrote: The ping command implementation would go into the ip4/ip6 protocol. But I am not familiar with the network part. Jiaxin/Siyuan, Can you help to review

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg Variable: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Guomin Jiang
There is a spell error in the comments of VariableServiceGetVariable() in Variable.c. - @return EFI_BUFFER_TO_SMALL DataSize is too small for the result. + @return EFI_BUFFER_TOO_SMALLDataSize is too small for the result. Need create new bugs for it or fix in this comment directly? >

Re: [edk2-devel] [PATCH v3 2/3] MdeModulePkg VariablePei: Return GetVariable() attr if EFI_BUFFER_TOO_SMALL

2020-03-31 Thread Guomin Jiang
Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Monday, March 30, 2020 12:19 PM > To: michael.kuba...@outlook.com; devel@edk2.groups.io > Cc: Bret Barkelew ; Gao, Liming > ; Kinney, Michael D ;

Re: [edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 09:26, Sami Mujawar wrote: > > VS2017 reports 'warning C4028: formal parameter 2 different > from declaration' for the library constructor and destructor > interfaces for the SRAT Generator modules. > > Remove the CONST qualifier for the ImageHandle and the > SystemTable

[edk2-devel] [PATCH v2 1/2] DynamicTablesPkg: SRAT: Fix entry points

2020-03-31 Thread Sami Mujawar
VS2017 reports 'warning C4028: formal parameter 2 different from declaration' for the library constructor and destructor interfaces for the SRAT Generator modules. Remove the CONST qualifier for the ImageHandle and the SystemTable pointer in the library constructor and destructor to make it

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 03:40, Jiang, Guomin wrote: > > Hi Laszlo, > > Thanks for you spending time review the changes. > > And I just want to present how to reproduce the build error. > > When build OvmfPkgX64, you can encounter this issue with your local change. > The error as below: >

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

2020-03-31 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609 The copied pointer (SavedState) will be updated by LoadUnitTestCache call. But the change of SavedState will not update source pointer, which is NewFramework->SavedState in this case. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Ard Biesheuvel
On Tue, 31 Mar 2020 at 08:31, Sean via Groups.Io wrote: > > @Ard - > pflash change: https://github.com/spbrogan/edk2/pull/12 > > Logging change - I actually switched OVMF to use stdio since the log is > captured either way and now it shows up in the web log output. >

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Sean via Groups.Io
@Ard - pflash change: https://github.com/spbrogan/edk2/pull/12 Logging change - I actually switched OVMF to use stdio since the log is captured either way and now it shows up in the web log output. https://github.com/spbrogan/edk2/pull/13 Do you have instructions for the cmdline for Qemu for