[edk2-devel] [PATCH edk2-platforms v3 03/10] Silicon/NXP/PciHostBridgeLib: Fix compilation with MDEPKG_NDEBUG flag

From: Pankaj Bansal when MDEPKG_NDEBUG flag is enabled, RELEASE build fails with this error: error: mPciHostBridgeLibAcpiAddressSpaceTypeStr defined but not used [-Werror=unused-variable] Fix this error by protecting mPciHostBridgeLibAcpiAddressSpaceTypeStr with MDEPKG_NDEBUG macro.

[edk2-devel] [PATCH edk2-platforms v3 05/10] Platform/NXP/LX2160ARDB: Add ArmPlatformLib

From: Pankaj Bansal Add ArmPlatformLib for LX2160ARDB platform that is based on ArmPlatformPkg/Library/ArmPlatformLibNull. Apart from the the interfaces exposed by ArmPlatformLibNull, this library also implements gPlatformGetClockPpi, which is specific to NXP SOCs' based platforms. Refer

[edk2-devel] [PATCH edk2-platforms v3 08/10] Silicon/NXP: Add LX2160A Soc package

From: Pankaj Bansal LX2160A is QorIq Layerscape multicore communications processor with sixteen Arm Cortex-A72 cores. This SOC is based on Layerscape Chassis v3.2. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change V2: - No change

[edk2-devel] [PATCH edk2-platforms v3 04/10] Silicon/NXP: Use edk2 recommended compilation flags

From: Pankaj Bansal edk2 recommends to use MDEPKG_NDEBUG for release builds and to use DISABLE_NEW_DEPRECATED_INTERFACES for all new platforms. Therefore, enable these flags for NXP platforms as well Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change

[edk2-devel] [PATCH edk2-platforms v3 02/10] Platform/NXP: Use Monotonic counter from MdeModulePkg

From: Pankaj Bansal Monotonic counter module from EmbeddedPkg doesn't treat the high 32 bit as non volatile, which is needed as per spec. Therefore, use Monotonic counter module from MdeModulePkg Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change

[edk2-devel] [PATCH edk2-platforms v3 09/10] Platform/NXP: Add LX2160ARDB Platform

From: Pankaj Bansal LX2160A Reference Design Board (RDB) is a high-performance development platform that supports the QorIQ LX2160A Layerscape Architecture SOCs. Signed-off-by: Pankaj Bansal --- Notes: V3: - Alphabetically sorted LibraryClasses in

[edk2-devel] [PATCH edk2-platforms v3 01/10] Silicon/NXP: Use Metronome implementation from MdeModulePkg

From: Pankaj Bansal There are two implementations of Metronome protocol. EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf MdeModulePkg/Universal/Metronome/Metronome.inf Although nowhere it has been specified, which one to use, but we are going by the general practice of preferring MdeModulePkg/MdePkg

[edk2-devel] [PATCH edk2-platforms v3 06/10] Silicon/NXP: Implement PL011UartClockLib for NXP platforms

From: Pankaj Bansal In NXP SOCs the UART clock is derived from System clock after PLL multiplication. Therefore, add the PL011UartClockLib implementation for NXP platforms. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change V2: - No change

[edk2-devel] [PATCH edk2-platforms v3 07/10] Silicon/NXP: Add Chassis3V2 Package

From: Pankaj Bansal Chassis3V2 is the new chassis on which LS1028A and LX2160A SOCs are based. Add the Chassis3V2 package. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change V2: - No change Silicon/NXP/Chassis3V2/Chassis3V2.dec

[edk2-devel] [PATCH edk2-platforms v3 10/10] Platform/NXP/LX2160aRdbPkg: Add VarStore

From: Pankaj Bansal Add VarStore Fd. This Fd is used to store non volatile variables in flash. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V3: - No change V2: - No change Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 1 +

[edk2-devel] [PATCH edk2-platforms v3 00/10] Add LX2160ARDB Platform

From: Pankaj Bansal LX2160A Reference Design Board (RDB) is a high-performance development platform that supports the QorIQ LX2160A Layerscape Architecture SOCs. This Platform is based on Layerscape Chassis3V2. The code structure is same as Chassis2 and LS1043A SOC and LS1043ARDB platform. v2

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

On 5/29/20 5:18 AM, Liming Gao via groups.io wrote: Leif: I get the point that the linux distribution default GCC version may be 10 or above. Without this fix, those developers can’t pass build edk2-stable202005. So, you think this is a critical issue to catch stable tag 202005. Ard: For

Re: [edk2-devel] [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform

> > --- > a/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > +++ > b/Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > > @@ -19,9 +19,12 @@ > >ArmPkg/ArmPkg.dec > >ArmPlatformPkg/ArmPlatformPkg.dec > >Silicon/NXP/NxpQoriqLs.dec > > +

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

Leif: I get the point that the linux distribution default GCC version may be 10 or above. Without this fix, those developers can’t pass build edk2-stable202005. So, you think this is a critical issue to catch stable tag 202005. Ard: For this patch, I have two minor comments. 1) I suggest to

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

Hi Liming, There is a documentation only change to Readme files for the UnitTestFranmeworkPkg. https://edk2.groups.io/g/devel/message/60378 Any objections to adding this update to the stable tag? Mike From: Gao, Liming Sent: Thursday, May 28, 2020 8:01 PM To: devel@edk2.groups.io; Gao,

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

Liming, Sounds good. There is a Stewards meeting next Tuesday so please let us know if there is any other feedback we could give that would be helpful. Thanks, Andrew Fish > On May 28, 2020, at 8:00 PM, Liming Gao wrote: > > Stewards and all: > Leif requests two patches to catch this

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

Laszlo: I agree the proposal to delay few days to collect more feedbacks. I just send the mail to highlight this request in Hard Feature Freeze https://edk2.groups.io/g/devel/message/60421. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek Sent:

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

Stewards and all: Leif requests two patches to catch this stable tag. They fix BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2723. I see the point that the linux distribution default GCC version may be 10 or above. Without this fix, those developers can’t pass build edk2-stable202005. So,

Re: [edk2-devel] [PATCH] BaseTools/Python: Add missing FatalError handling

Hi Irene, For this piece of code +self.feedback_q.put(taskname) +self.feedback_q.put(e.args[0]) I think there will be the case that another autogenworker process insert its taskname before the current autogenworker process do self.feedback_q.put(e.args[0]). If that case

Re: [edk2-devel] AcpiView Patches

Sorry, Pilar. I am busy at other things. Plan to review the shellpkg patch in next two weeks. Thanks, Zhichao From: Tomas Pilar Sent: Thursday, May 28, 2020 6:55 PM To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao Cc: nd Subject: AcpiView Patches Hi, Any chance you had time to look at my

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing __init__.py files

Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Thursday, May 28, 2020 2:31 PM To: Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: RE: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing __init__.py files

Reviewed-by: Nate DeSimone > -Original Message- > From: Desimone, Ashley E > Sent: Thursday, May 28, 2020 2:29 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Pandya, Puja > ; Bjorge, Erik C ; Bret > Barkelew ; Agyeman, Prince > > Subject: [edk2-staging/EdkRepo] [PATCH]

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add missing __init__.py files

Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/common/workspace_maintenance/__init__.py| 8 edkrepo/common/workspace_maintenance/humble/__init__.py | 8

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

-Original Message- From: Irene Park Sent: Thursday, May 28, 2020 3:19 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid From: Irene Park REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On 05/28/20 17:48, Gao, Liming wrote: > Leif: > BZ 2723 is a tiano feature request. This patch adds support for new GCC10. > I agree with Laszlo that this change is like the enhancement instead of the > critical bug fix. So, I suggest to delay it after this stable tag. In

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

On 05/28/20 12:15, Leif Lindholm wrote: > On Wed, May 27, 2020 at 20:34:02 +0200, Laszlo Ersek wrote: >> +Ard, +Leif, and maybe we should consider this for edk2-stable202005? > > Hmm, if this has never worked on MSFT:ARM/AArch64, I don't think it > would qualify even during soft freeze? (Whereas

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

On 05/28/20 12:05, Leif Lindholm wrote: > On Wed, May 27, 2020 at 11:12:23 +0200, Laszlo Ersek wrote: > Oh and I think both this patch and the assembly language implementation > for the atomics should be delayed after the stable tag. gcc-10 is a new > toolchain; so even if we don't

Re: [edk2-devel] [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option

On 05/28/20 11:17, Ard Biesheuvel wrote: > Without ConnectAll() being called on the boot path, the UEFI shell will > be entered with no block devices or anything else connected, and so for > the novice user, this is not a very accommodating environment. Now that > we have made the UiApp the last

Re: [edk2-devel] [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show inactive boot options

On 05/28/20 11:17, Ard Biesheuvel wrote: > UEFI boot options may exist but have the LOAD_OPTION_ACTIVE flag > cleared. This means that the boot option should not be selected > by default, but it does not mean it should be omitted from the > boot selection presented by the boot manager: for this

Re: [edk2-devel] [PATCH 5/5] ShellPkg: add BootManager library to add UEFI Shell menu option

On 05/27/20 19:22, Ard Biesheuvel wrote: > On 5/27/20 5:57 PM, Laszlo Ersek wrote: >> On 05/26/20 18:13, Ard Biesheuvel wrote: >>> Add a plug-in library for UiApp that creates a 'UEFI Shell' menu >>> option at the root level which gives access to a form that allows >>> the UEFI Shell to be

Re: [edk2-devel] [PATCH] BaseTools/Python: Add missing FatalError handling

A gentle reminder and adding Bob Feng and Liming Gao to CC. Thank you, Irene -Original Message- From: Irene Park Sent: Wednesday, May 27, 2020 3:42 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] BaseTools/Python: Add missing FatalError handling From: Irene Park

[edk2-devel] [Patch 1/1] [Edk2Platforms] FitGen: Update FitGen tool to be compliance with the FIT specification revision 1.2

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2687 FIT specification revision 1.2 was recently released to the open community. Revision 1.2 updates CSE Secure Boot Rules in section 4.12, and adds 2 new entry sub-types used to distinguish the CSE entries. Signed-off-by: Jorge

[edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

From: Irene Park REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. Signed-off-by: Irene Park --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c |

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

Leif: BZ 2723 is a tiano feature request. This patch adds support for new GCC10. I agree with Laszlo that this change is like the enhancement instead of the critical bug fix. So, I suggest to delay it after this stable tag. Thanks Liming > -Original Message- > From: Leif Lindholm >

Re: [edk2-devel] [PATCH edk2-platforms v2 8/9] Platform/NXP: Add LX2160ARDB Platform

On Wed, May 27, 2020 at 14:21:34 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > LX2160A Reference Design Board (RDB) is a high-performance development > platform that supports the QorIQ LX2160A Layerscape Architecture SOCs. > > Signed-off-by: Pankaj Bansal Minor style comment below. >

Re: [edk2-devel] [PATCH edk2-platforms v2 0/9] Add LX2160ARDB Platform

On Wed, May 27, 2020 at 14:21:26 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > LX2160A Reference Design Board (RDB) is a high-performance development > platform that supports the QorIQ LX2160A Layerscape Architecture SOCs. > > This Platform is based on Layerscape Chassis3V2. > > The

Re: [edk2-devel] [PATCH edk2-platforms v2 3/9] Silicon/NXP: Use edk2 recommended compilation flags

On Wed, May 27, 2020 at 14:21:29 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > edk2 recommends to use MDEPKG_NDEBUG for release builds and to use > DISABLE_NEW_DEPRECATED_INTERFACES for all new platforms. > > Therefore, enable these flags for NXP platforms as well > > Signed-off-by:

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 29 May 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200528T141409Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200529T013000Z DTEND:20200529T023000Z

Re: [edk2-devel] [PATCH v2 0/3] New RISC-V Patches - Why in edk2-platforms

Hi Abner, Sorry, I should have followed up on this sooner. On Thu, May 21, 2020 at 06:59:20 +, Chang, Abner (HPS SW/FW Technologist) wrote: > > On 5/20/20 6:07 PM, Daniel Schaefer wrote: > > > please reply here, fixed Mike's email address, sorry... > > > > > > On 5/20/20 6:03 PM, Daniel

Re: [edk2-devel] BDS Phase Menu

MdeModulePkg\Application\BootManagerMenuApp From: devel@edk2.groups.io On Behalf Of jim slaughter Sent: Thursday, May 28, 2020 2:46 AM To: devel@edk2.groups.io Subject: [edk2-devel] BDS Phase Menu Hello, Is there a menu available in the bds phase so you can select the OS to transfer control to

Re: [edk2-devel] [PATCH v1 0/3] Compile AML bytecode array into OBJ file

Hi Pierre, Sorry for late response. I'll review the patch in this week and response early in the next week. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois Sent: Thursday, May 28, 2020 7:04 PM To: devel@edk2.groups.io; Pierre Gondois Cc: Feng, Bob

Re: [edk2-devel] [PATCH v1 0/3] Compile AML bytecode array into OBJ file

Hello Bob and Liming, Just a message in case you missed the patch set, Regards, Pierre -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois via groups.io Sent: Friday, May 22, 2020 1:01 PM To: devel@edk2.groups.io; Pierre Gondois Cc: bob.c.f...@intel.com;

[edk2-devel] AcpiView Patches

Hi, Any chance you had time to look at my AcpiView patches? Cheers, Tom -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60396): https://edk2.groups.io/g/devel/message/60396 Mute This Topic: https://groups.io/mt/74519195/21656 Group

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

On Wed, May 27, 2020 at 20:34:02 +0200, Laszlo Ersek wrote: > +Ard, +Leif, and maybe we should consider this for edk2-stable202005? Hmm, if this has never worked on MSFT:ARM/AArch64, I don't think it would qualify even during soft freeze? (Whereas if it was a question of making it work on vs2019

Re: [edk2-devel] [PATCH] MdePkg/Include: AARCH64: disable outline atomics on GCC 10.2+

On Wed, May 27, 2020 at 11:12:23 +0200, Laszlo Ersek wrote: > >>> Oh and I think both this patch and the assembly language implementation > >>> for the atomics should be delayed after the stable tag. gcc-10 is a new > >>> toolchain; so even if we don't introduce a new toolchain tag such as > >>>

Re: [edk2-devel] [PATCH v2] ArmPkg/CompilerIntrinsicsLib: provide atomics intrinsics

On Thu, May 28, 2020 at 09:36:33 +0800, Gary Lin wrote: > On Wed, May 20, 2020 at 01:44:48PM +0200, Ard Biesheuvel wrote: > > Gary reports the GCC 10 will emit calls to atomics intrinsics routines > > unless -mno-outline-atomics is specified. This means GCC-10 introduces > > new intrinsics, and

[edk2-devel] [PATCH v2 5/5] ArmPkg/PlatformBootManagerLib: don't connect all devices on each boot

In order to avoid boot delays from devices such as network controllers that may not even be involved in booting at all, drop the call to EfiBootManagerConnectAll () from the boot path. It will be called by UiApp, so when going through the menu, all devices will be connected as usual, but for the

[edk2-devel] [PATCH v2 4/5] ArmPkg/PlatformBootManagerLib: hide UEFI Shell as a regular boot option

Without ConnectAll() being called on the boot path, the UEFI shell will be entered with no block devices or anything else connected, and so for the novice user, this is not a very accommodating environment. Now that we have made the UiApp the last resort on boot failure, and made the UEFI Shell

[edk2-devel] [PATCH v2 0/5] ArmPkg/PlatformBootManagerLib: play nice without ConnectAll()

Currently, Armpkg's PlatformBootManagerLib connects all controllers to their drivers recursively, even if the active boot option does not require it. There are some historical reasons for this, some of which are being addressed in separate patches. This series addresses the way ArmPkg's

[edk2-devel] [PATCH v2 2/5] ArmPkg/PlatformBootManagerLib: fall back to the UiApp on boot failure

As a last resort, drop into the UiApp application when no active boot options could be started. Doing so will connect all devices, and so it will allow the user to enter the Boot Manager submenu and pick a network or removable disk option. Note that this only occurs if even the default removable

[edk2-devel] [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show inactive boot options

UEFI boot options may exist but have the LOAD_OPTION_ACTIVE flag cleared. This means that the boot option should not be selected by default, but it does not mean it should be omitted from the boot selection presented by the boot manager: for this purpose, another flag LOAD_OPTION_HIDDEN exists.

[edk2-devel] [PATCH v2 1/5] ArmPkg/PlatformBootManagerLib: register 's' as UEFI Shell hotkey

In preparation of hiding the UEFI Shell boot option as an ordinary boot option, make sure we can invoke it directly using the 's' hotkey. Without ConnectAll() having been called, this results in a shell that may have no block devices or other things connected, so don't advertise the 's' in the

[edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg: Add info to readme about working with UnitTests

Cc: Michael D Kinney Signed-off-by: Bret Barkelew --- .pytool/Readme.md | 125 +++- UnitTestFrameworkPkg/ReadMe.md | 82 - 2 files changed, 172 insertions(+), 35 deletions(-) diff --git a/.pytool/Readme.md b/.pytool/Readme.md index

[edk2-devel] [PATCH v1 0/1] UnitTestFrameworkPkg: Add info to readme about working with UnitTests

I did a thing! I updated a readme! Then I followed Laszlo's guide to publication and now here we are. Bret Barkelew (1): UnitTestFrameworkPkg: Add info to readme about working with UnitTests .pytool/Readme.md | 125 +++- UnitTestFrameworkPkg/ReadMe.md | 82

[edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg: Add info to readme about working with UnitTests

Cc: Michael D Kinney Signed-off-by: Bret Barkelew --- .pytool/Readme.md | 125 +++- UnitTestFrameworkPkg/ReadMe.md | 82 - 2 files changed, 172 insertions(+), 35 deletions(-) diff --git a/.pytool/Readme.md b/.pytool/Readme.md index

[edk2-devel] [PATCH v1 0/1] UnitTestFrameworkPkg: Add info to readme about working with UnitTests

I did a thing! I updated a readme! Then I followed Laszlo's guide to publication and now here we are. Bret Barkelew (1): UnitTestFrameworkPkg: Add info to readme about working with UnitTests .pytool/Readme.md | 125 +++- UnitTestFrameworkPkg/ReadMe.md | 82

Re: [edk2-devel] IsaBus driver's usage

+Agyeman Prince On 5/28/20 9:58 AM, Tiger Liu(BJ-RD) wrote: > Hi, expert: > I have a question about IsaBus driver. > > There is a isa bus driver in MdeModulePkg\Bus\Isa\IsaBusDxe. > But i find nobody use it anymore. > > Based on current edk2-platform samples, they just use SioDxe driver plus >

[edk2-devel] IsaBus driver's usage

Hi, expert: I have a question about IsaBus driver. There is a isa bus driver in MdeModulePkg\Bus\Isa\IsaBusDxe. But i find nobody use it anymore. Based on current edk2-platform samples, they just use SioDxe driver plus Ps2Keyboard driver, not use IsaBus driver anymore. So when to use IsaBus

[edk2-devel] Update "Component" and "Package" field in bugzilla system

Hi Mike, In current Bugzilla system, when submit an Edk2 bug, the "Component" and "Package" options like below: Component: 1. Code 2. Documentation 3. Test 4. Tools Package: 1. AppPkg 2. ArmPkg 3. ... 4. All the packages in Edk2 repo, also include some removed

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

Rebecca, I was able to confirm that it was an issue with Git for Windows. Looks like it’s fixed in current snapshots and will be in the next release: https://github.com/git-for-windows/git/issues/2598 Also, ATTN: @Michael Kubacki - Bret From: Bret