Re: [edk2-devel] [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, June 3, 2020 10:27 PM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Feng, Bob C ; Bret Barkelew > ; Kinney, Michael D > ; Gao, Liming ; Sean > Brogan > Subject: Re: [edk2-devel] [PATCH

[edk2-devel] [PATCH V2 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Today's UefiPayloadPkg always uses 0xE000 as the PCIE base address and ignores the value set in AcpiBoardInfo HOB created by the boot loader. This makes the payload binary cannot work in environment where the PCIE base address set by boot loader doesn't equal to 0xE000. The patch enhances

[edk2-devel] [PATCH V2 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo()

All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu ---

[edk2-devel] [PATCH V2 0/2] UefiPayloadPkg: Use PCIE base address set by boot loader

Ray Ni (2): MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB v2: update copyright year in patch 1/2 add missing EFIAPI in patch 2/2 remove PCIE_BASE macro in UefiPayloadPkgIa32X64.dsc in patch 2/2.

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Guo, Thanks for the comments. It's a good cleanup. I will remove PCIE_BASE from DSC. > -Original Message- > From: Dong, Guo > Sent: Thursday, June 4, 2020 1:39 AM > To: Ma, Maurice ; Ni, Ray ; > devel@edk2.groups.io > Cc: You, Benjamin > Subject: RE: [PATCH 2/2] UefiPayloadPkg/Pci: Use

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Maurice, 1. EFIAPI: sure. I will add the missing "EFIAPI". 2. ASSERT: Is below code to avoid dereferencing NULL pointer ok to you? ASSERT (Count != NULL); + if (Count == NULL) { +return NULL; + } Thanks, Ray > -Original Message- > From: Ma, Maurice > Sent: Wednesday, June 3,

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

> On Jun 3, 2020, at 6:43 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > I see the following assembly that reads GDTR and IDTR from > CPU and saves them into the context structure: > > ;; UINT32 Gdtr[2], Idtr[2]; >sub esp, 8 >sidt[esp] >mov eax, [esp + 2] >

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

Hi Andrew, I see the following assembly that reads GDTR and IDTR from CPU and saves them into the context structure: ;; UINT32 Gdtr[2], Idtr[2]; sub esp, 8 sidt[esp] mov eax, [esp + 2] xchgeax, [esp] and eax, 0x mov [esp+4], eax sub

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

> On Jun 3, 2020, at 5:37 PM, Michael D Kinney > wrote: > > Hi Andrew, > > Are you referring to the order the fields are filled in by the C code > before the x86 instruction is executed? I do not think that matters. > Mike, The instructions point to a blob of data that is not UINTN

Re: [edk2-devel] [Patch 1/1] [Edk2Platforms] FitGen: Update tool to meet FIT specification revision 1.2

Push @4a937016142ea084a2aad19e9bd8f1b50fab38d4 -Original Message- From: Hernandez Beltran, Jorge Sent: 2020年6月4日 5:01 To: devel@edk2.groups.io Cc: Gao, Liming ; Lohr, Paul A ; Hernandez Beltran, Jorge Subject: [Patch 1/1] [Edk2Platforms] FitGen: Update tool to meet FIT specification

Re: [edk2-devel] [Patch 1/1] [Edk2Platforms] FitGen: Update FitGen tool to be compliance with the FIT specification revision 1.2

Jorge: You can use git command git format-patch -1 --subject-prefix="Patch V2" to generate the patch. Thanks Liming -Original Message- From: Hernandez Beltran, Jorge Sent: 2020年6月4日 5:17 To: Lohr, Paul A ; Gao, Liming ; devel@edk2.groups.io Subject: RE: [Patch 1/1] [Edk2Platforms]

Re: [edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

Hi Andrew, Are you referring to the order the fields are filled in by the C code before the x86 instruction is executed? I do not think that matters. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Andrew Fish via groups.io > Sent: Wednesday, June 3,

[edk2-devel] Does anyone know the definition of EFI_SYSTEM_CONTEXT_X64.Gdtr[2] and EFI_SYSTEM_CONTEXT_X64.Idtr[2]

The x86 instructions do limit then base, but the code is storing base, then limit. Does anyone remember if this is properly defined some place? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60699):

Re: [edk2-devel] [PATCH 3/3] Maintainers.txt: move StandaloneMmPkg to the right spot

Reviewed by: Jiewen Yao > -Original Message- > From: Laszlo Ersek > Sent: Thursday, June 4, 2020 12:06 AM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Philippe Mathieu-Daudé ; Sami > Mujawar ; Supreeth Venkatesh > > Subject: [PATCH 3/3] Maintainers.txt: move

Re: [edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

On 6/3/20 10:18 PM, Leif Lindholm wrote: On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote: PlatformBootManagerLib now asserts at build time that the correct terminal type is used, and so leaving it unset breaks the ArmPkg DSC build. So fix that. Signed-off-by: Ard Biesheuvel

Re: [edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

On Wed, Jun 03, 2020 at 21:36:35 +0200, Ard Biesheuvel wrote: > PlatformBootManagerLib now asserts at build time that the correct > terminal type is used, and so leaving it unset breaks the ArmPkg > DSC build. So fix that. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm > --- >

[edk2-devel] [PATCH] ArmPkg/ArmPkg.dsc: set terminal type PCD to the right value

PlatformBootManagerLib now asserts at build time that the correct terminal type is used, and so leaving it unset breaks the ArmPkg DSC build. So fix that. Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc

[edk2-devel] [edk2-InfSpecification PATCH] Clarify statement on package ordering

The description of [Packages] sections states, > Packages must be listed in the order that may be required for specifying > include path statements for a compiler. For example, the > MdePkg/MdePkg.dec file must be listed before the > MdeModulePkg/MdeModulePkg.dec file. Clarify that the listing

Re: [edk2-devel] [PATCH 0/2] OvmfPkg/Tcg2ConfigPei: trivial cleanups

On 6/3/20 7:04 PM, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2752 > Repo: https://pagure.io/lersek/edk2.git > Branch: tcg_config_pei_trivial > > Two trivial cleanups after commit 89236992913f ("OvmfPkg: detect TPM 1.2 > in Tcg2ConfigPei", 2020-03-04) and

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Hi Ray, How about set PcdPciExpressBaseAddress to 0 instead of $(PCIE_BASE) by default? We could even remove PCIE_BASE from DSC. Thanks, Guo > -Original Message- > From: Ma, Maurice > Sent: Wednesday, June 3, 2020 8:35 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Guo ; You,

Re: [edk2-devel] [PATCH 0/2] OvmfPkg/Tcg2ConfigPei: trivial cleanups

On 6/3/20 7:04 PM, Laszlo Ersek wrote: Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2752 Repo: https://pagure.io/lersek/edk2.git Branch: tcg_config_pei_trivial Two trivial cleanups after commit 89236992913f ("OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei", 2020-03-04) and commit

[edk2-devel] [PATCH 0/2] OvmfPkg/Tcg2ConfigPei: trivial cleanups

Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2752 Repo: https://pagure.io/lersek/edk2.git Branch: tcg_config_pei_trivial Two trivial cleanups after commit 89236992913f ("OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei", 2020-03-04) and commit 74f90d38c446 ("OvmfPkg/Tcg2ConfigPei: skip

[edk2-devel] [PATCH 2/2] OvmfPkg/Tcg2ConfigPei: restrict BaseLib class dependency to IA32 and X64

BaseLib interfaces (namely, SwapBytesXx()) are only used in "Tpm12Support.c", which is IA32/X64-only. Therefore the BaseLib class dependency should also be restricted to IA32 & X64, in the INF file. The "#include " directive is already present in "Tpm12Support.c" only. (The BaseLib dependency

[edk2-devel] [PATCH 1/2] OvmfPkg/Tcg2ConfigPei: generalize TPM2-only file-top comments

The leading comments in "Tcg2ConfigPei.inf" and "Tcg2ConfigPeim.c" say, "In OvmfPkg, the module only performs TPM2 hardware detection". The statement hasn't been correct since commit 89236992913f ("OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei", 2020-03-04). Replace "TPM2" with "TPM" (without stating

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers

For the series: Reviewed-by: Leif Lindholm Thanks! On Wed, Jun 03, 2020 at 18:06:24 +0200, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2778 > Repo: https://pagure.io/lersek/edk2.git > Branch: sort_maintainers > > We originally meant to keep the subsystem

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers

On 6/3/20 6:06 PM, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2778 > Repo: https://pagure.io/lersek/edk2.git > Branch: sort_maintainers > > We originally meant to keep the subsystem (package) titles sorted, in > "Maintainers.txt". > > However, as of

Re: [edk2-devel] [PATCH 2/3] Maintainers.txt: restore order of OvmfPkg sections

On 6/3/20 6:06 PM, Laszlo Ersek wrote: The OvmfPkg subsystem / section headers are currently ordered in Maintainers.txt as follows: OvmfPkg OvmfPkg: Xen-related modules OvmfPkg: TCG- and TPM2-related modules OvmfPkg: CSM modules OvmfPkg: MptScsi and PVSCSI driver Restore the following

Re: [edk2-devel] [PATCH 3/3] Maintainers.txt: move StandaloneMmPkg to the right spot

On 6/3/20 6:06 PM, Laszlo Ersek wrote: Place StandaloneMmPkg between SourceLevelDebugPkg and UefiCpuPkg, where it belongs in lexicographical order. (Right now it succeeds UnitTestFrameworkPkg, which is a disorder.) Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Philippe Mathieu-Daudé Cc: Sami Mujawar

[edk2-devel] [PATCH 3/3] Maintainers.txt: move StandaloneMmPkg to the right spot

Place StandaloneMmPkg between SourceLevelDebugPkg and UefiCpuPkg, where it belongs in lexicographical order. (Right now it succeeds UnitTestFrameworkPkg, which is a disorder.) Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Philippe Mathieu-Daudé Cc: Sami Mujawar Cc: Supreeth Venkatesh Ref:

[edk2-devel] [PATCH 2/3] Maintainers.txt: restore order of OvmfPkg sections

The OvmfPkg subsystem / section headers are currently ordered in Maintainers.txt as follows: > OvmfPkg > OvmfPkg: Xen-related modules > OvmfPkg: TCG- and TPM2-related modules > OvmfPkg: CSM modules > OvmfPkg: MptScsi and PVSCSI driver Restore the following (alphabetical) order between them: >

[edk2-devel] [PATCH 1/3] Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"

The following two section titles in "Maintainers.txt" are not in (case-sensitive) lexicographical order: > MdeModulePkg: ACPI modules > MdeModulePkg: ACPI S3 modules However, if we simply sorted them, we'd have another problem: the specific "ACPI S3 modules" line would precede the generic "ACPI

[edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers

Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2778 Repo: https://pagure.io/lersek/edk2.git Branch: sort_maintainers We originally meant to keep the subsystem (package) titles sorted, in "Maintainers.txt". However, as of 7191dd3c5990 ("ArmPkg/PlatformBootManagerLib: reject 'default'

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

On 6/3/20 5:47 PM, Andrew Fish wrote: On Jun 2, 2020, at 11:32 PM, Ard Biesheuvel > wrote: On 6/3/20 12:28 AM, Andrew Fish wrote: On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel mailto:ard.biesheu...@linaro.org>> wrote: From: Ard Biesheuvel

Re: [edk2-devel] [Patch 1/1] [Edk2Platforms] FitGen: Update FitGen tool to be compliance with the FIT specification revision 1.2

Thanks Liming. I agree the code changes look good. Paul A. Lohr - Server Firmware Enabling 512.239.9073 (cell) 512.794.5044 (work) -Original Message- From: Gao, Liming Sent: Wednesday, June 3, 2020 9:31 AM To: Hernandez Beltran, Jorge ; devel@edk2.groups.io Cc: Lohr, Paul A Subject:

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

> On Jun 2, 2020, at 11:32 PM, Ard Biesheuvel wrote: > > On 6/3/20 12:28 AM, Andrew Fish wrote: >>> On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel >>> wrote: >>> >>> From: Ard Biesheuvel >>> >>> The ChaosKey driver implements the UEFI driver model, and so it is >>> not guaranteed that any

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Hi, Ray, Thank you very much for making this change. Two minor comments here, - Should we add "EFIAPI" for function GetPciSegmentInfo() since it is standard library interface ? - For ASSERT (Count != NULL), can we have an error handling flow in the code to deal with the case ? Thanks

Re: [edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature

Hi Bret, I don't have any comments on the content of these patches, but I have a couple about metadata: You're submitting the patches from b...@corthon.org, but signing them off with Bret Barkelew . This way the Microsoft authorship metadata is not preserved, which I think is unfortunate. It

Re: [edk2-devel] [PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.

On 06/03/20 05:18, Dong, Eric wrote: > Signed-off-by: Eric Dong > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Debkumar De > Cc: Harry Han > Cc: Catharine West > --- > Maintainers.txt | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt

Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

On 06/03/20 16:57, Laszlo Ersek wrote: > On 06/03/20 05:18, Dong, Eric wrote: >> Signed-off-by: Eric Dong >> Cc: Jiewen Yao >> Cc: Jian J Wang >> Cc: Chao Zhang >> Cc: Min Xu >> --- >> Maintainers.txt | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Maintainers.txt

Re: [edk2-devel] Where to put RISC-V packages

> -Original Message- > From: Schaefer, Daniel (DualStudy) > Sent: Wednesday, June 3, 2020 7:57 PM > To: Sean Brogan ; Kinney, Michael D > ; Chang, Abner (HPS SW/FW Technologist) > ; Bret Barkelew ; > Ard Biesheuvel (ard.biesheu...@linaro.org) ; > Zimmer, Vincent ; Leif Lindholm > > Cc:

Re: [edk2-devel] [PATCH 4/5] Maintainers.txt: Add reviewer for SEC related modules.

On 06/03/20 05:18, Dong, Eric wrote: > Signed-off-by: Eric Dong > Cc: Debkumar De > Cc: Harry Han > Cc: Catharine West > --- > Maintainers.txt | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 318c8388fe..8350ece296 100644 > ---

Re: [edk2-devel] [PATCH 3/5] Maintainers.txt: Add reviewer for UefiCpuPkg.

On 06/03/20 05:18, Dong, Eric wrote: > Signed-off-by: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > Maintainers.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 573084e086..318c8388fe 100644 > --- a/Maintainers.txt >

Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

On 06/03/20 05:18, Dong, Eric wrote: > Signed-off-by: Eric Dong > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Cc: Min Xu > --- > Maintainers.txt | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 954dc567e0..573084e086 100644 >

Re: [edk2-devel] [PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.

On 06/03/20 05:18, Dong, Eric wrote: > Signed-off-by: Eric Dong > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Chao Zhang > Cc: Qi Zhang > Cc: Rahul Kumar > --- > Maintainers.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index

Re: [edk2-devel] [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

Reviewed-by: Maurice Ma > -Original Message- > From: Bret Barkelew > Sent: Tuesday, June 2, 2020 23:58 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo ; > You, Benjamin > Subject: [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to > UefiPayloadPkg platform > >

Re: [edk2-devel] [Patch 1/1] [Edk2Platforms] FitGen: Update FitGen tool to be compliance with the FIT specification revision 1.2

Jorge: The patch is good. But, the commit message is too long than 80. Please update the commit message to be short. You can use edk2\BaseTools\Scripts\PatchCheck.py tool to check the patch format. With the commit message change, Reviewed-by: Liming Gao Thanks Liming > -Original

Re: [edk2-devel] [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

On 06/03/20 10:48, Zhang, Shenglei wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 > As planed we will enable Ecc check for edk2 on open ci. And they are > ready now, but these are V2 series. So I expect that contributors in > edk2 community can try using this script when

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

On 5/19/20 2:23 PM, Ard Biesheuvel wrote: Add build time checks for serial terminal settings, so we don't end up with a non-functional serial console if the PCDs are set incorrectly v1 was just the second patch. v2 adds the first patch switching to STATIC_ASSERT first, and then uses

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

On 06/03/20 13:44, Leif Lindholm wrote: > On Tue, Jun 02, 2020 at 18:20:26 +0200, Laszlo Ersek wrote: >> On 06/02/20 16:20, Leif Lindholm wrote: >>> On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: I have not been aware of the header name collision scenario (nor that the

Re: [edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature

meta: On 06/03/20 08:57, Bret Barkelew wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522 > > The 14 patches in this series add the VariablePolicy feature to the core, > deprecate Edk2VarLock (while adding a compatibility layer to reduce code > churn), and integrate the

Re: [edk2-devel] [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show inactive boot options

> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, June 2, 2020 5:27 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: j...@solid-run.com; Laszlo Ersek ; Leif Lindholm > ; Ni, Ray > Subject: Re: [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show > inactive boot options > >

[edk2-devel] Where to put RISC-V packages

Hi all, (CC edk2 devel ML - shouldn't be a private discussion again) let me try to summarize the points of each: - edk2-platforms isn't a less stable edk2 per se - edk2-platforms can be used for architectural decisions that are not stable yet and therefore different platforms might implement

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

On Tue, Jun 02, 2020 at 18:20:26 +0200, Laszlo Ersek wrote: > On 06/02/20 16:20, Leif Lindholm wrote: > > On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: > >> I have not been aware of the header name collision scenario (nor that > >> the [Packages] ordering was supposed to work around

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

May I know the schedule of pushing this change to edk2-master? Or what's next step I should do? Thanks, Walon -Original Message- From: Bi, Dandan [mailto:dandan...@intel.com] Sent: Sunday, May 24, 2020 3:17 PM To: Li, Walon ; devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Chang, Abner

[edk2-devel] [PATCH edk2-platforms V2 1/2] Silicon/NXP: Add DWC3 USB controller initialization driver

From: Meenakshi Aggarwal Add support of DWC3 controller driver which performs DWC3 controller initialization and register itself as NonDiscoverableMmioDevice Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/NxpQoriqLs.dec | 5 +

[edk2-devel] [PATCH edk2-platforms V2 2/2] Platform/NXP:LX2160: Enable support of USB controller

From: Meenakshi Aggarwal Enable support of USB drives on lx2160 RDB board. LX2160 has DWC3 controller Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/LX2160A/LX2160A.dsc.inc | 4 Silicon/NXP/NxpQoriqLs.dsc.inc | 12

[edk2-devel] [PATCH edk2-platforms V2 0/2] Add USB driver support

This patchset implement USB driver for DWC3 controller and enable USB for LX2160A Platform. Changes in v2: - Indentation changes - Incorporated review comments - create EndOfDxe event and initialize USB in EndOfDxe callback function. Meenakshi Aggarwal (2):

[edk2-devel] [PATCH 0/2] UefiPayloadPkg: Use PCIE base address set by boot loader

Ray Ni (2): MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB MdePkg/Include/Library/PciSegmentInfoLib.h| 1 + .../PciSegmentInfoLib.c | 1 +

[edk2-devel] [PATCH 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo()

All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu ---

[edk2-devel] [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Today's UefiPayloadPkg always uses 0xE000 as the PCIE base address and ignores the value set in AcpiBoardInfo HOB created by the boot loader. This makes the payload binary cannot work in environment where the PCIE base address set by boot loader doesn't equal to 0xE000. The patch enhances

[edk2-devel] [PATCH v5 01/14] MdeModulePkg: Define the VariablePolicy protocol interface

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicy protocol interface header and add to the MdeModulePkg.dec file. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew

[edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2522 The 14 patches in this series add the VariablePolicy feature to the core, deprecate Edk2VarLock (while adding a compatibility layer to reduce code churn), and integrate the VariablePolicy libraries and protocols into Variable Services.

[edk2-devel] [PATCH v5 06/14] EmulatorPkg: Add VariablePolicy engine to EmulatorPkg platform

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Bret Barkelew Signed-off-by: Bret Barkelew --- EmulatorPkg/EmulatorPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc

[edk2-devel] [PATCH v5 14/14] MdeModulePkg: Add a shell-based functional test for VariablePolicy

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 To verify that VariablePolicy is correctly integrated on platforms, add a Shell-based functional test to confirm expected behavior. NOTE: This test assumes that VariablePolicy is built with PcdAllowVariablePolicyEnforcementDisable set to TRUE.

[edk2-devel] [PATCH v5 07/14] ArmVirtPkg: Add VariablePolicy engine to ArmVirtPkg platform

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Laszlo Ersek --- ArmVirtPkg/ArmVirt.dsc.inc | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [PATCH v5 09/14] MdeModulePkg: Connect VariablePolicy business logic to VariableServices

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add connective code to publish the VariablePolicy protocol and wire it to either the SMM communication interface or directly into the VariablePolicyLib business

[edk2-devel] [PATCH v5 05/14] OvmfPkg: Add VariablePolicy engine to OvmfPkg platform

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Bret Barkelew Signed-off-by: Bret Barkelew Reviewed-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 5 + OvmfPkg/OvmfPkgIa32X64.dsc | 5 + OvmfPkg/OvmfPkgX64.dsc | 5

[edk2-devel] [PATCH v5 04/14] MdeModulePkg: Define the VarCheckPolicyLib and SMM interface

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. This is an instance of a VarCheckLib that is backed by the VariablePolicyLib business logic. It also publishes the SMM calling interface for messages from the DXE

[edk2-devel] [PATCH v5 10/14] MdeModulePkg: Allow VariablePolicy state to delete protected variables

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 TcgMorLockSmm provides special protections for the TCG MOR variables. This will check IsVariablePolicyEnabled() before enforcing them to allow variable deletion when policy engine is disabled. Only allows deletion, not modification. Cc: Jian J

[edk2-devel] [PATCH v5 11/14] SecurityPkg: Allow VariablePolicy state to delete authenticated variables

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Causes AuthService to check IsVariablePolicyEnabled() before enforcing write protections to allow variable deletion when policy engine is disabled. Only allows deletion, not modification. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Cc:

[edk2-devel] [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Bret Barkelew Signed-off-by: Bret Barkelew --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 4 UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 4 2 files changed, 8 insertions(+) diff

[edk2-devel] [PATCH v5 03/14] MdeModulePkg: Define the VariablePolicyHelperLib

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 VariablePolicy is an updated interface to replace VarLock and VarCheckProtocol. Add the VariablePolicyHelperLib library, containing several functions to help with the repetitive process of creating a correctly structured and packed

[edk2-devel] [PATCH v5 12/14] MdeModulePkg: Change TCG MOR variables to use VariablePolicy

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 These were previously using VarLock, which is being deprecated. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by: Bret Barkelew --- MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c | 52

[edk2-devel] [PATCH v5 13/14] MdeModulePkg: Drop VarLock from RuntimeDxe variable driver

https://bugzilla.tianocore.org/show_bug.cgi?id=2522 Now that everything should be moved to VariablePolicy, drop support for the deprecated VarLock SMI interface and associated functions from variable RuntimeDxe. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by:

[edk2-devel] [PATCH v2 3/5] pip-requirements.txt: Add Ecc required lib

antlr4-python3-runtime is a lib to support Ecc run with Py3.x. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- pip-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/pip-requirements.txt b/pip-requirements.txt index

[edk2-devel] [PATCH v2 2/5] BaseTools/Scripts: Add EccCheck.py

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 EccCheck.py is a tool to report Ecc issues for commits, which will be run on open ci. But note not each kind of issue could be reported out. It can only handle the issues, whose line number in CSV report accurately map with their code in

[edk2-devel] [PATCH v2 1/5] BaseTools:ECC needs to update the contents of CParser4

From: "Fan, Zhiju" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2676 Because Ecc relies on the antlr extension package, When the antlr version is updated, we need to change the code in it. Currently, if you use the latest version antlr4.8, Ecc will fail We will update the version to

[edk2-devel] [PATCH v2 4/5] .azurepiplines: Add a pipline to check ECC issues for commits

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 Add a pipeline to run the ECC checks on Azure Pipelines agents for edk2 open ci. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .azurepipelines/Windows-EccCheck.yml | 38

[edk2-devel] [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now, but these are V2 series. So I expect that contributors in edk2 community can try using this script when reviewing. And I appreciate receiving feedback and

[edk2-devel] [PATCH v2 5/5] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

This is a sample for users to add exceptions and ignored files for their own use. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.ci.yaml | 8 1 file changed, 8 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml

[edk2-devel] EDK II Stable Tag release edk2-stable202005 completed

Hi, all The tag edk2-stable202005 has been created. https://github.com/tianocore/edk2/releases/tag/edk2-stable202005 git clone -b edk2-stable202005 https://github.com/tianocore/edk2.git The tag edk2-stable202005 has been added into the main EDK II Wiki page.

[edk2-devel] [PATCH v3] BaseTools/PatchCheck.py: Add LicenseCheck

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 For files to be added to the tree, this feature will check whether it has BSD plus patent license. If not, licenses listed in Readme are also accepted but warning will be reported. Otherwise, it should be error. Cc: Bob Feng Cc: Liming Gao

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

Hello Irene, Sure. Will review and send my comments soon. With Warm Regards, Edhay -Original Message- From: Irene Park Sent: 03 June 2020 13:00 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud ; G Edhaya Chandran Cc: eric@intel.com Subject: RE: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -Original Message- From: devel@edk2.groups.io On Behalf Of Samer El-Haj-Mahmoud Sent: Monday, June 1, 2020 4:51 PM

Re: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Irene Park Sent: Wednesday, June 3, 2020 5:59 AM To: devel@edk2.groups.io Cc: Irene Park Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen error occurred From: Irene Park

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

On 6/3/20 12:28 AM, Andrew Fish wrote: On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel wrote: From: Ard Biesheuvel The ChaosKey driver implements the UEFI driver model, and so it is not guaranteed that any controllers will be attached to this driver unless it is connected explicitly. On many