Re: [edk2-devel] [PATCH v6 00/14] Add the VariablePolicy feature

Responses below… - Bret From: Dandan Bi via groups.io Sent: Tuesday, August 11, 2020 6:52 AM To: devel@edk2.groups.io; Bi, Dandan; b...@corthon.com Cc: Yao,

Re: [edk2-devel] [edk2-platforms] Platform/Intel: Remove unnecessary comments in file header

Reviewed-by: Zailiang Sun -Original Message- From: Gao, Liming Sent: Tuesday, August 18, 2020 11:16 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi ; Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric Subject: [edk2-platforms] Platform/Intel: Remove unnecessary comments in

[edk2-devel] [edk2-platforms] Platform/Intel: Remove unnecessary comments in file header

Signed-off-by: Liming Gao Cc: Zailiang Sun Cc: Yi Qian Cc: Chasel Chiu Cc: Nate DeSimone Cc: Eric Dong --- .../PlatformDxe/Observable/Observable.c | 12 .../SecBoardInitLibNull/Ia32/SecBoardInit.nasm | 6 -- .../PlatformInitPei/PlatformEarlyInit.h

Re: [edk2-devel] [PATCH v3 8/8] IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib

Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3 8/8] IntelFsp2WrapperPkg/dsc: add HashLib, >

Re: [edk2-devel] [PATCH v3 4/8] IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.

Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v3 4/8]

Re: [edk2-devel] [PATCH v3 3/8] IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.

Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Zeng, Star ; Zhang, > Qi1 > Subject: [PATCH v3 3/8]

[edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: add crypto algorithms needed by variable protection

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Crypto algorithms, hkdf-sha256/hmac-sha256/aes, are needed to verify integrity of variable data, derive hmac and encryption keys, and encrypt/decrypt varible. Replacing null version source code with real implementations makes sure we can

[edk2-devel] [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix

OvmfPkg is the package, so while there are files to build bhyve separately, they shouldn't have 'Pkg' in the name. Signed-off-by: Rebecca Cran Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Peter Grehan --- OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc} | 2 +-

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

Laszlo, My apologies for the slow response. I'm not the original reporter but just the BZ submitter. And I didn't do deep analysis to this issue. The issues was reported from one internal team. Add John in loop to see if he knows more about it or not. My superficial understanding on such issue

Re: [edk2-devel] [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page.

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Wednesday, August 12, 2020 3:21 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > Subject: [edk2-devel] [edk2-wiki][PATCH v3] Update the Boot

Re: [edk2-devel] [PATCH v3 0/8] Need add a FSP binary measurement

For the whole series, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Wu, Hao A ; Chiu, > Chasel ; Desimone, Nathaniel L > ;

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/18/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 18 August 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816387 ) *Organizer:* Brian Richardson

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

Tom: One build issue is found with CLANGPDB and XCODE tool chain. BZ has been submitted https://bugzilla.tianocore.org/show_bug.cgi?id=2901. Can you fix it for this stable tag? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lendacky, > Thomas > Sent:

Re: [edk2-devel] [PATCH v1-resend 1/1] ShellPkg/AcpiView: PCCT Parser

Hi Marc, Please send the patch to the devel@edk2.groups.io. There are two ways to do this: 1. add below info in the .gitconfig. It would help to send to the email address every time you use 'git send-email *.patch'. [sendemail] to = devel@edk2.groups.io 2. add the email address every

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

Thanks Laszlo. Good feedback. I think we need clarify the role and responsibility for the activity. I provide my understanding and thought, and I would like to have more feedback from other people. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent:

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

> -Original Message- > From: Laszlo Ersek > Sent: Monday, August 17, 2020 1:44 PM > To: Vladimir Olovyannikov ; > Rabeda, Maciej ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1]

Re: [edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload

Thanks for reporting this issue in UEFI payload. We would enhance the UEFI payload to support the PCI resource to be allocated below 4GB and above 4GB at same time. Thanks, Guo > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, August 12, 2020 10:49 AM > To:

Re: [edk2-devel] [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

Not yet, which is also why I’m raising the note ASAP. I’ll respond to the other feedback today to get that moving. - Bret From: Laszlo Ersek Sent: Monday, August 17, 2020 1:46 PM To: Bret Barkelew;

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202008

Hi Bret, On 08/17/20 20:14, Bret Barkelew wrote: > I would like Variable Policy to be considered for this feature freeze. I have > a couple of documentation things to respond to, but no serious functionality > questions (that I know of). Has review completed on the series (before entering the

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 08/17/20 20:29, Vladimir Olovyannikov wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Monday, August 17, 2020 11:01 AM >> To: Rabeda, Maciej ; Vladimir Olovyannikov >> ; Gao, Zhichao >> ; devel@edk2.groups.io >> Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin >> ; Fu, Siyuan ; Ni,

Re: [edk2-devel] [PATCH 0/3] Platform/RasberryPi: Thermal zone

Hi, On 8/17/20 9:31 AM, Ard Biesheuvel via groups.io wrote: On 8/14/20 1:00 AM, Jeremy Linton wrote: This set creates a basic thermal zone, which reads the SOC temp via a direct register read in AML. It also adds an active cooling policy using a GPIO pin for fan control that can optionally be

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

> -Original Message- > From: Laszlo Ersek > Sent: Monday, August 17, 2020 11:01 AM > To: Rabeda, Maciej ; Vladimir Olovyannikov > ; Gao, Zhichao > ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Wu, Jiaxin > ; Fu, Siyuan ; Ni, Ray > ; Gao, Liming ; Nd > > Subject: Re: [PATCH v5 1/1]

Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202008

I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of). - Bret From: devel@edk2.groups.io on behalf of Liming Gao via groups.io

Re: [edk2-devel] [PATCH 3/3] Platform/RaspberryPi: Add entry for user fan control

Hi, Thanks for taking a look at this, I will roll another version with the suggested changes. It seems my space '(' rules are broken :) On 8/17/20 6:10 AM, Pete Batard wrote: More minor style issues: On 2020.08.14 00:00, Jeremy Linton wrote: Add a menu item that allows the user to

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 08/17/20 19:15, Rabeda, Maciej wrote: > Hi Vladimir, > > I cannot apply the patch via 'git am'. > Is your git configured in a manner described here? > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers > > > Laszlo, > >

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

Yes, a big thank you to everyone involved! Tom On 8/17/20 12:03 PM, Laszlo Ersek wrote: > On 08/17/20 06:09, Gao, Liming wrote: >> This patch set have been merged edk2 >> 7f7f511c5a74676523ed48435350f6e35282b62b..7f0b28415cb464832155d5b3ff6eb63612f58645 > > Thank you! > Laszlo > >>

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Vladimir, I cannot apply the patch via 'git am'. Is your git configured in a manner described here? https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Laszlo, Were you able to apply this patch from .eml file? Thanks,

Re: [edk2-devel] [PATCH 0/2] BaseTools: Python 3.9 fixes

On 08/11/20 19:28, Cole wrote: > These patches fix two issues running the BaseTools test suite > on python 3.9 from Fedora rawhide. See patches for individual details > > Cole Robinson (2): > BaseTools: fix ucs-2 lookup on python 3.9 > BaseTools: Work around array.array.tostring() removal in

Re: [edk2-devel] [PATCH v15 00/46] SEV-ES guest support

On 08/17/20 06:09, Gao, Liming wrote: > This patch set have been merged edk2 > 7f7f511c5a74676523ed48435350f6e35282b62b..7f0b28415cb464832155d5b3ff6eb63612f58645 Thank you! Laszlo > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: 2020年8月14日 9:20 > To:

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

Hi Jiewen, On 08/14/20 10:53, Yao, Jiewen wrote: >> To Jiewen, >> Sorry, I don't have environment to reproduce the issue. > > Please help me understand, if you don’t have environment to reproduce the > issue, how do you guarantee that your patch does fix the problem and we don’t > have any

Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

On 08/17/20 08:37, Gao, Liming wrote: > Sami: > I think this change is OK. And, Shenglei and Alexei gave reviewed-by before > soft feature freeze. > > Mike, Leif, Andrew and Laszlo: > Have you any comments to merge this patch to edk2-stable202008 stable tag. I'm OK with merging this

Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Gao, Thanks for reviewing. As you suggest, I will postpone the next patchset submission until NetworkPkg maintainer(s) review. > -Original Message- > From: Gao, Zhichao > Sent: Sunday, August 16, 2020 6:48 PM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Laszlo Ersek ;

Re: [edk2-devel] [PATCH 0/3] Platform/RasberryPi: Thermal zone

On 8/14/20 1:00 AM, Jeremy Linton wrote: This set creates a basic thermal zone, which reads the SOC temp via a direct register read in AML. It also adds an active cooling policy using a GPIO pin for fan control that can optionally be enabled/disabled by the user from the BDS. With the fan

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking

Thanks Ard and Pete. I did use the cover letter, but forgot to add the CC https://edk2.groups.io/g/devel/message/64301 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Monday, August 17, 2020 9:55 AM > To: Samer El-Haj-Mahmoud ; >

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking

On 8/15/20 10:26 PM, Samer El-Haj-Mahmoud wrote: Fix input param error checking for the DisplayDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/84 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud ---

Re: [edk2-devel] [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Fix DwUsbHostDxe ComponentName2 error checking

Same typo as previous patch: On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote: Fix input param error checking for the DwUsbHostDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/86 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel

Re: [edk2-devel] [edk2-platform][PATCH v1 3/3] Platforms/RaspberryPi: Fix BcmGenetDxe ComponentName2 error checking

Same typo as previous patch: On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote: Fix input param error checking for the BcmGenetDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/85 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking

One typo: On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote: Fix input param error checking for the DisplayDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/84 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer

Re: [edk2-devel] [PATCH 3/3] Platform/RaspberryPi: Add entry for user fan control

More minor style issues: On 2020.08.14 00:00, Jeremy Linton wrote: Add a menu item that allows the user to enable GPIO based fan control via SSDT. This should only be seen/enabled on RPI4 because that is what its been tested with. As of this commit its currently limited to only operating on a

Re: [edk2-devel] [PATCH 1/3] Platform/RaspberryPi4: Add a basic thermal zone

Nothing major, just whitespace/style and one minor capitalization issue: On 2020.08.14 00:00, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in

Re: [edk2-devel] [PATCH 2/3] Platform/RaspberryPi4: Create ACPI fan object

Whitespace/style and typos: On 2020.08.14 00:00, Jeremy Linton wrote: Now that we have a thermal zone we can add active cooling by specifying active cooling points (_ACx) which can be tied to fan objects that turn fans on/off using GPIO pins. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei

Re: [edk2-devel] [PATCH v4 0/2] Enable EDKII CI support for DynamicTablesPkg

Sami: I think this change is OK. And, Shenglei and Alexei gave reviewed-by before soft feature freeze. Mike, Leif, Andrew and Laszlo: Have you any comments to merge this patch to edk2-stable202008 stable tag. Thanks Liming -Original Message- From: Sami Mujawar Sent: 2020年8月14日