[edk2-devel] [PATCH v2 1/1] MdePkg/Cpuid.h: Change and add some macro definitions.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3105 Change and add some macro definitions about CPUID_HYBRID_INFORMATION Leaf(1Ah). Signed-off-by: Jason Lou Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar ---

Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

Hi Liming, It trips on the coding style where “Function name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters”. Please see detailed error info here:

Re: [edk2-devel] [PATCH v3 12/18] PcAtChipsetPkg: AcpiTimerLib: Added StandaloneMm instance of AcpiTimerLib

Hi Ray, I updated the file names as suggested on the previous round. Do you have any further comments/feedback? Thanks, Kun From: Kun Qin Sent: Thursday, January 14, 2021 14:37 To: devel@edk2.groups.io Cc: Ray Ni

回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? Thanks Liming 发件人: Kun Qin 发送时间: 2021年1月21日 9:37 收件人: devel@edk2.groups.io 抄送: Bob Feng ; Liming Gao ; Yuwei Chen 主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools:

Re: [edk2-devel] [PATCH v3 05/18] StandaloneMmPkg: StandaloneMmMemLib: Extends support for X64 architecture

Hi Jiewen, Do you have further concerns about this specific patch? I did created a Bugzilla ticket to track the OS memory protection concern here: 3168 – Add non-MMRAM memory protection for Standalone MM environment (tianocore.org). It

回复: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid

This change is correct. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: bounce+27952+70589+4905953+8761...@groups.io > 代表 Joey Gouly > 发送时间: 2021年1月21日 2:20 > 收件人: devel@edk2.groups.io > 抄送: joey.go...@arm.com; ardb+tianoc...@kernel.org; > sami.muja...@arm.com;

Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list

Hi Bob/Liming/Yuwei, Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! Regards, Kun From: Kun Qin Sent: Thursday, January 14, 2021

Re: [edk2-devel] [PATCH v3 03/18] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core

Hi Jiewen/Ard/Sami/Supreeth, I updated this patch in v2 to centralize common implementations for certain library functions. Do you by any chance have more comments on this patch? Any input is appreciated. Regards, Kun From: Kun Qin Sent: Thursday, January 14, 2021

Re: [edk2-devel] [PATCH v6 00/11] Add extra pci roots support for Arm

Hi Laszlo, On 2021/1/21 0:26, Laszlo Ersek wrote: > On 01/19/21 02:12, Jiahui Cen via groups.io wrote: >> v5->v6: >> * Annotate library functions with EFIAPI, IN/OUT, @param[in]/[out]. >> * Split BusMin/BusMax addtion in PciHostBridgeUtilityGetRootBridges() into >> a separate patch [09/11]. >>

Re: [edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

Hi, Patrick In this patch I noticed that we changed the BlSupportDxe dependency from True to gEfiSmbiosProtocolGuid. Since BlSupportDxe is considered as critical for UEFI payload, and on the other side SMBIOS driver could be optional in some case, do you think it is better to handle it

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

Hi, Patrick There is a BaseRngLib in MdePkg package already. I am wondering why a new instance was created under UefiPayloadPkg in the patch. Could we just reuse the same library in MdePkg? If not, what is the reason? Can we try to enhance the library in MdePkg to address it if required?

Re: 回复: [EXTERNAL] [edk2-devel] building the shell for edk2-stable202102

On 01/20/21 02:06, gaoliming wrote: > Laszlo: > Now, all release content (Source code Zip, Submodule Zip and ShellBinPkg > Zip) are manually generated. I will submit one BZ to enhance the release > process and generate them on CI. Right, that's

Re: [edk2-devel] [PATCH v3 11/13] StandaloneMmMmuLib: Allow FF-A calls to set memory region's attributes

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70598): https://edk2.groups.io/g/devel/message/70598 Mute This Topic: https://groups.io/mt/79696448/21656 Group Owner:

Re: [edk2-devel] [PATCH v3 10/13] StandaloneMmMmuLib: Allow FF-A calls to get memory region's attributes

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70597): https://edk2.groups.io/g/devel/message/70597 Mute This Topic: https://groups.io/mt/79696447/21656 Group Owner:

Re: [edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume

On 01/20/21 10:28, Zeng, Star wrote: > Series Reviewed-by: Star Zeng Series merged as commit range e843a21e23ea..339371ef78eb, via . Thanks! Laszlo > >> -Original Message- >> From: Laszlo Ersek >> Sent: Tuesday, January 19, 2021 11:55 PM

Re: [edk2-devel] [PATCH v3 08/13] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70595): https://edk2.groups.io/g/devel/message/70595 Mute This Topic: https://groups.io/mt/79696446/21656 Group Owner:

Re: [edk2-devel] [PATCH v3 06/13] StandaloneMmPkg: Add the SPM version for FF-A

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70594): https://edk2.groups.io/g/devel/message/70594 Mute This Topic: https://groups.io/mt/79696443/21656 Group Owner:

Re: [edk2-devel] [PATCH v3 05/13] StandaloneMmPkg: Add macros for SPM version

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70593): https://edk2.groups.io/g/devel/message/70593 Mute This Topic: https://groups.io/mt/79696442/21656 Group Owner:

Re: [edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT

> -Original Message- > From: Joey Gouly > Sent: Wednesday, January 20, 2021 1:20 PM > To: devel@edk2.groups.io > Cc: Joey Gouly ; ardb+tianoc...@kernel.org; Sami > Mujawar ; Jeff Brasen (jbra...@nvidia.com) > ; ip...@nvidia.com; Samer El-Haj-Mahmoud > ; nd > Subject: [PATCH v1 2/2]

[edk2-devel] [PATCH v1 0/2] Add a Pcd to override the 16650 HID in SSDT

This series adds PcdNonSbsaCompliantSerialHid so that firmware can override the PNP0501 HID used by 16550 UART in the SSDT table, in case they are not compatible with the generic PNP0501 HID. I have tested this with acpiview, some extra testing would be appreciated. Changes available at

[edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: Add an override for 16550 HID in SSDT

Some platforms advertise support for a 16550 UART, but are not compatible with the PNP0500 HID. Allow them to override the HID by setting PcdNonSbsaCompliantSerialHid. Signed-off-by: Joey Gouly --- DynamicTablesPkg/DynamicTablesPkg.dec | 3 +++

[edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Don't use gEfiMdeModulePkgTokenSpaceGuid

Introduce gEdkiiDynamicTablesPkgTokenSpaceGuid and use that instead. Signed-off-by: Joey Gouly --- DynamicTablesPkg/DynamicTablesPkg.dec | 10 ++ DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 8 2 files

Re: [edk2-devel] [PATCH v6 00/11] Add extra pci roots support for Arm

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > v5->v6: > * Annotate library functions with EFIAPI, IN/OUT, @param[in]/[out]. > * Split BusMin/BusMax addtion in PciHostBridgeUtilityGetRootBridges() into > a separate patch [09/11]. > * Add more detailed commit message for patch [10/11].

[edk2-devel] [PATCH] UefiPayloadPkg/BlSupportDxe: Use EfiSmbiosProtocol to install tables

The default EfiSmbiosProtocol operates on an empty SMBIOS table. As the SMBIOS tables are provided by the bootloader, install the SMBIOS tables using the EfiSmbiosProtocol. This fixes the settings menu not showing any hardware information, instead only "0 MB RAM" was displayed. Tests showed that

[edk2-devel] [PATCH 2/2] MdeModulePkg/Usb/Keyboard.c: don't request protocol before setting

From: Matt DeVillier No need to check the interface protocol then conditionally setting, just set it to BOOT_PROTOCOL and check for error. This is what Linux does for HID devices as some don't follow the USB spec. One example is the Aspeed BMC HID keyboard device, which adds a massive boot

[edk2-devel] [PATCH 1/2] MdeModulePkg/Usb/Keyboard.c: remove Get/SetConfig calls

From: Matt DeVillier SetConfig is already called during device enumeration, no need to do it again here. Signed-off-by: Matt DeVillier --- MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 37 1 file changed, 37 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c

[edk2-devel] [PATCH] UefiPayloadPkg: Add RNG support

Uses the RDRAND instruction if available and install EfiRngProtocol. The protocol may be used by iPXE or the Linux kernel to gather entropy. Signed-off-by: Patrick Rudolph --- UefiPayloadPkg/Library/BaseRngLib/BaseRng.c | 199

Re: [edk2-devel] [PATCH v6 11/11] ArmVirtPkg/ArmVirtQemu: Add support for HotPlug

On 01/19/21 02:13, Jiahui Cen via groups.io wrote: > It is necessary to add padding for hotplugable PCI Devices like > pcie-root-port. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Jiahui Cen >

Re: [edk2-devel] [PATCH v6 10/11] ArmVirtPkg/FdtPciHostBridgeLib: Add extra pci root buses support

On 01/19/21 02:13, Jiahui Cen via groups.io wrote: > In order to take advantages of extra pci root buses in ArmVirtPkg, it is > necessary to scan extra root buses when getting root briges. And now > PciHostBridgeUtilityLib already provides a set of utility functions that > support for extra pci

Re: [edk2-devel] [PATCH v6 09/11] OvmfPkg/PciHostBridgeUtilityLib: Extend GetRootBridges() with BusMin/BusMax

On 01/19/21 02:13, Jiahui Cen via groups.io wrote: > Extend parameter list of PciHostBridgeUtilityGetRootBridges() with BusMin/ > BusMax, so that the utility function could be compatible with ArmVirtPkg > who uses mutable bus range [BusMin, BusMax] insteand of [0, PCI_MAX_BUS]. > > BZ:

Re: [edk2-devel] [PATCH v6 08/11] OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of GetRootBridges

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Extend parameter list of PciHostBridgeUtilityGetRootBridges() with > DmaAbove4G, NoExtendedConfigSpace to support for ArmVirtPkg. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v6 03/11] OvmfPkg/PciHostBridgeLib: List missing PcdLib dependency

On 01/20/21 13:14, Laszlo Ersek wrote: > On 01/19/21 02:12, Jiahui Cen via groups.io wrote: >> OvmfPkg/PciHostBridgeLib instance fails to list its PcdLib dependency, >> both between the #include directives, and in the INF file. So let's list >> the dependency. >> >> BZ:

Re: [edk2-devel] [PATCH v6 07/11] OvmfPkg/PciHostBridgeLib: Extract GetRootBridges() / FreeRootBridges()

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Extract PciHostBridgeGetRootBridges() / PciHostBridgeFreeRootBridges() to > PciHostBridgeUtilityLib as common utility functions to share support for > scanning extra root bridges. > > No change of functionality. > > BZ:

Re: [edk2-devel] [PATCH v6 06/11] ArmVirtPkg/FdtPciHostBridgeLib: Refactor init/uninit of root bridge

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Rebase ArmVirtPkg/FdtPciHostBridgeLib to the new > PciHostBridgeUtilityInitRootBridge()/PciHostBridgeUtilityUninitRootBridge() > utility functions. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Laszlo Ersek > Cc: Ard

Re: [edk2-devel] [PATCH v6 05/11] OvmfPkg/PciHostBridgeUtilityLib: Extend parameters of InitRootBridge()

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Extend parameter list of PciHostBridgeUtilityInitRootBridge() with > DmaAbove4G and NoExtendedConfigSpace to prepare for sharing with > ArmVirtPkg. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo

Re: [edk2-devel] [PATCH] NetworkPkg/Library/DxeHttpIoLib: Http boot failure with no initializes timeout value.

Patch merged. PR: https://github.com/tianocore/edk2/pull/1371 Commit: https://github.com/tianocore/edk2/commit/ca272b9513a6de5772e6e8ef5bbecd2e23cf9fb3 On 20-Jan-21 12:54, Maciej Rabeda wrote: Thanks for the patch! Reviewed-by: Maciej Rabeda On 15-Jan-21 07:22, GregX Yeh wrote:

Re: [edk2-devel] [PATCH v6 04/11] OvmfPkg/PciHostBridgeLib: Extract InitRootBridge() / UninitRootBridge()

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Extract InitRootBridge() / UninitRootBridge() to PciHostBridgeUtilityLib > as common utility functions. No change of functionality. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc:

Re: [edk2-devel] [PATCH v6 03/11] OvmfPkg/PciHostBridgeLib: List missing PcdLib dependency

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > OvmfPkg/PciHostBridgeLib instance fails to list its PcdLib dependency, > both between the #include directives, and in the INF file. So let's list > the dependency. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan

Re: [edk2-devel] [PATCH] NetworkPkg/Library/DxeHttpIoLib: Http boot failure with no initializes timeout value.

Thanks for the patch! Reviewed-by: Maciej Rabeda On 15-Jan-21 07:22, GregX Yeh wrote: https://bugzilla.tianocore.org/show_bug.cgi?id=3170 Using PcdHttpIoTimeout to set default timeout value to HttpIoLib. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: GregX Yeh ---

Re: [edk2-devel] [PATCH v6 01/11] OvmfPkg: Introduce PciHostBridgeUtilityLib class

On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > Introduce a new PciHostBridgeUtilityLib class to share duplicate code > between OvmfPkg and ArmVirtPkg. > > Extract function PciHostBridgeUtilityResourceConflict from > PciHostBridgeResourceConflict in OvmfPkg/PciHostBridgeLib. > > BZ:

Re: [edk2-devel] [PATCH] NetworkPkg/Library/DxeHttpIoLib: Http boot failure with no initializes timeout value.

This seems good with me. Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yeh, GregX > Sent: 2021年1月15日 14:23 > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Wu, Jiaxin > ; Fu, Siyuan > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v2 0/4] UefiCpuPkg, OvmfPkg: do not allocate useless register tables for S3 resume

Series Reviewed-by: Star Zeng > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, January 19, 2021 11:55 PM > To: edk2-devel-groups-io > Cc: Ard Biesheuvel ; Dong, Eric > ; Justen, Jordan L ; > Philippe Mathieu-Daudé ; Kumar, Rahul1 > ; Ni, Ray ; Zeng, Star > > Subject: [PATCH

Re: [edk2-devel] [PATCH v1 2/2] UefiCpuPkg/CpuCacheInfoLib: Update reference to the macro definitions.

Yun, You should NOT split the patch because only applying patch #1 will break the build. You can combine them with one patch. Thanks, Ray > -Original Message- > From: Lou, Yun > Sent: Wednesday, January 20, 2021 3:44 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric >