回复: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

Abner: This is a new feature. Can you submit one BZ for it? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Abner Chang > 发送时间: 2021年3月26日 13:55 > 收件人: devel@edk2.groups.io > 抄送: Nickle Wang > 主题: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII >

回复: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: EFI Redfish Discover Protocol

Abner: This is new feature. Can you submit one BZ for it? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Abner Chang > 发送时间: 2021年3月26日 12:54 > 收件人: devel@edk2.groups.io > 抄送: Nickle Wang ; Jiaxin Wu > ; Siyuan Fu ; Fan Wang > ; Jiewen Yao > 主题: [edk2-devel] [PATCH]

Re: [edk2-devel] [edk2-platforms] [PATCH v4 0/4] Add Large Variable Libraries

Change looks good to me, just one comment, would you also add new library class into MinPlatformPkg.dec file for reference? Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, April 7, 2021 11:04 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ;

Re: [edk2-devel] [edk2-platforms] [PATCH v4 0/4] Add Large Variable Libraries

For the series: Reviewed-by: Michael Kubacki On 4/6/2021 8:04 PM, Nate DeSimone wrote: Changes from V3: - Added header guards - Documented the possibility of returning EFI_UNSUPPORTED - Added MM_CORE_STANDALONE to the StandaloneMm library implementations - Documented library

[edk2-devel] [edk2-platforms] [PATCH v4 0/4] Add Large Variable Libraries

Changes from V3: - Added header guards - Documented the possibility of returning EFI_UNSUPPORTED - Added MM_CORE_STANDALONE to the StandaloneMm library implementations - Documented library constructor return status - Moved LargeVariableReadLib and LargeVariableWriteLib into a single

[edk2-devel] [edk2-platforms] [PATCH v4 2/4] MinPlatformPkg: Add VariableWriteLib

VariableWriteLib is a phase agnostic library for writing to UEFI Variables. This library provides the MinSetVariable(), MinQueryVariableInfo(), MinIsVariableRequestToLockSupported(), and MinVariableRequestToLock() APIs which are usable in DXE and SMM. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric

[edk2-devel] [edk2-platforms] [PATCH v4 4/4] MinPlatformPkg: Add LargeVariableWriteLib

LargeVariableWriteLib is used to store large data sets using the UEFI Variable Services. At time of writting, most UEFI Variable Services implementations to not allow more than 64KB of data to be stored in a single UEFI variable. This library will split data sets across multiple variables as

[edk2-devel] [edk2-platforms] [PATCH v4 1/4] MinPlatformPkg: Add VariableReadLib

VariableReadLib is a phase agnostic libary for reading UEFI Variables. This library provides the MinGetVariable() and MinGetNextVariableName() APIs which are usable PEI, DXE, and SMM. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki Cc: Isaac Oram Signed-off-by: Nate DeSimone

[edk2-devel] [edk2-platforms] [PATCH v4 3/4] MinPlatformPkg: Add LargeVariableReadLib

LargeVariableReadLib is used to retrieve large data sets using the UEFI Variable Services. At time of writting, most UEFI Variable Services implementations to not allow more than 64KB of data to be stored in a single UEFI variable. This library will split data sets across multiple variables as

Re: [edk2-devel] [edk2-platforms] [PATCH v3 3/4] MinPlatformPkg: Add LargeVariableReadLib

Hi Michael, Thank you for the great feedback! I believe I have all of it addressed in V4. Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Tuesday, April 6, 2021 3:01 PM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel ;

Re: [edk2-devel] [PATCH 0/4] UefiCpuPkg: Add MicrocodeLib for loading microcode

On Tue, Apr 6, 2021 at 08:03 PM, Laszlo Ersek wrote: > > (1) I think we should use a new TianoCore feature request BZ for this > feature, and the commit messages should link it. (I understand the > library only factors out existent logic, but still.) sure.

回复: [edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

Nhi: So far, I don’t receive edk2 feature planning on the latest UEFI 2.8 & 2. 9 spec in edk2 community except for Redfish. So, I suggest to keep current UEFI version 2.7 in system table. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nhi Pham via > groups.io > 发送时间:

回复: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Use TianoCore mirror of cmocka repository

Mike: I agree this change. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年4月7日 4:12 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Liming Gao ; > Andrew Fish ; Laszlo Ersek ; Leif > Lindholm > 主题:

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

On Wed, 2021-04-07 at 00:21 +, Xu, Min M wrote: > Hi, Laszlo > > For Intel TDX supported guest, all processors start in 32-bit > protected > mode, while for Non-Td guest, it starts in 16-bit real mode. To make > the > ResetVector work on both Td-guest and Non-Td guest, ResetVector are >

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

On Tue, 2021-04-06 at 14:16 +0200, Laszlo Ersek wrote: > On 04/06/21 10:11, Xu, Min M wrote: > > Hi, Singh > > I have a concern about the sevSnpBlock in ResetVectorVtf0.asm. > > Actually > > SEV has inserted 3 blocks in ResetVectorVtf0.asm and the total > > bytes are > > (26 + 22 + 20 = 68 bytes).

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

Hi, Laszlo For Intel TDX supported guest, all processors start in 32-bit protected mode, while for Non-Td guest, it starts in 16-bit real mode. To make the ResetVector work on both Td-guest and Non-Td guest, ResetVector are updated as below:

Re: [edk2-devel] [edk2-platforms] [PATCH v3 3/4] MinPlatformPkg: Add LargeVariableReadLib

Hi Nate, Feedback is inline. Please carry over applicable feedback to LargeVariableWriteLib, I did not duplicate the response there. Thanks, Michael On 4/6/2021 12:24 PM, Nate DeSimone wrote: LargeVariableReadLib is used to retrieve large data sets using the UEFI Variable Services. At time

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/4] MinPlatformPkg: Add VariableReadLib

Hi Nate, Feedback is inline. Most of the items carry over to the VariableWriteLib patch as well but I didn't duplicate the response to that patch. Thanks, Michael On 4/6/2021 12:24 PM, Nate DeSimone wrote: VariableReadLib is a phase agnostic libary for reading UEFI Variables. This library

Re: [edk2-devel] [RFC] UnitTestFrameworkPkg cmocka submodule alternatives

Hi Rebecca, Thank you for the reminder. I have entered a BZ and sent a patch for review https://bugzilla.tianocore.org/show_bug.cgi?id=3301 https://edk2.groups.io/g/devel/message/73744 Mike > -Original Message- > From: Rebecca Cran > Sent: Sunday, February 14, 2021 4:43 PM > To:

[edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Use TianoCore mirror of cmocka repository

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3301 The cmocka repository https://git.cryptomilk.org/projects/cmocka.git has gone down a few times in past year. When it is down, it blocks EDK II CI. A mirror of this repository has been created in the TianoCore organization at

Re: [edk2-devel] [Patch 1/1] MdeModulePkg/PiDxeS3BootScriptLib: Rename mAcpiS3Enable to avoid dup symbol

Looks good to me Mike. Thank you! Paul A. Lohr - Server Firmware Enabling 512.239.9073 (cell) 512.794.5044 (work) -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Monday, April 5, 2021 5:31 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ;

[edk2-devel] [PATCH v1 0/1] Add buffer size check before save state read

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 This change is validated on two different physical platforms. v2 mainly focus on feedback for v1 patche, including: a. Adding "Reviewed-by" tags; b. Updated return code description for modified function; Patch v2 branch:

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 Current SMM Save State routine does not check the number of bytes to be read, when it comse to read IO_INFO, before casting the incoming buffer to EFI_SMM_SAVE_STATE_IO_INFO. This could potentially cause memory corruption due to extra bytes

[edk2-devel] [edk2-platforms] [PATCH v3 0/4] Add Large Variable Libraries

Changes from V2: - Added comment to LargeVariableLib INF and header files describing the usage for drivers that cannot assume that PcdMaxVariableSize has been set to a certain minimum value. Changes from V1: - Changed prefix from "Min" to "VarLib" - Better comments - Added more

[edk2-devel] [edk2-platforms] [PATCH v3 2/4] MinPlatformPkg: Add VariableWriteLib

VariableWriteLib is a phase agnostic library for writing to UEFI Variables. This library provides the MinSetVariable(), MinQueryVariableInfo(), MinIsVariableRequestToLockSupported(), and MinVariableRequestToLock() APIs which are usable in DXE and SMM. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric

[edk2-devel] [edk2-platforms] [PATCH v3 3/4] MinPlatformPkg: Add LargeVariableReadLib

LargeVariableReadLib is used to retrieve large data sets using the UEFI Variable Services. At time of writting, most UEFI Variable Services implementations to not allow more than 64KB of data to be stored in a single UEFI variable. This library will split data sets across multiple variables as

[edk2-devel] [edk2-platforms] [PATCH v3 1/4] MinPlatformPkg: Add VariableReadLib

VariableReadLib is a phase agnostic libary for reading UEFI Variables. This library provides the MinGetVariable() and MinGetNextVariableName() APIs which are usable PEI, DXE, and SMM. Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki Cc: Isaac Oram Signed-off-by: Nate DeSimone

[edk2-devel] [edk2-platforms] [PATCH v3 4/4] MinPlatformPkg: Add LargeVariableWriteLib

LargeVariableWriteLib is used to store large data sets using the UEFI Variable Services. At time of writting, most UEFI Variable Services implementations to not allow more than 64KB of data to be stored in a single UEFI variable. This library will split data sets across multiple variables as

Re: [edk2-devel] GSoC 2021 (MinPlatform, Ext2, ACPICA, etc)

Hi Nate, Andrew, Sounds great! I'll finish up my proposal and submit it tonight. Thank you all for your advice! Hopefully we'll see each other again in the summer :D Thanks, Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

Hi Laszlo, Thanks for the feedback. I will update the description in v2. Regards, Kun On 04/06/2021 05:09, Laszlo Ersek wrote: On 03/27/21 00:41, Kun Qin wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 Current SMM Save State routine does not check the number of bytes to be

Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

Hi Laszlo, I believe this is an actual bug. I updated the commit message to clarify this in a v2 patch: https://edk2.groups.io/g/devel/message/73732 Thanks, Michael On 4/6/2021 7:29 AM, Laszlo Ersek wrote: On 03/26/21 01:42, Michael Kubacki wrote: From: Michael Kubacki

[edk2-devel] [PATCH v2 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3277 Initializes the Status variable in TcgMmReadyToLock(). Fixes a Clang build failure: Tcg2Smm.c - SecurityPkg\Tcg\Tcg2Smm\Tcg2Smm.c:254:7: error: variable 'Status' is used uninitialized whenever 'if' condition is false

Re: [EXTERNAL] Re: [edk2-devel] [GSoC proposal] Secure Image Loader

You’ve got my vote! This sounds amazing! - Bret From: Marvin Häuser via groups.io Sent: Tuesday, April 6, 2021 3:10 AM To: devel@edk2.groups.io; Desimone, Nathaniel L; Laszlo

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

I'll attach the bug for the build tools to the BZ shortly. Laszlo, thanks for that. I don't know their email addresses though. And yes, I was going to make it device independent, as the majority (if not all) of UEFI protocols are. On 4/6/21, Laszlo Ersek wrote: > On 03/31/21 08:41, Nate DeSimone

Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

On 03/26/21 01:42, Michael Kubacki wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3277 > > Initializes the Status variable in TcgMmReadyToLock(). > > Fixes a Clang build failure: > Tcg2Smm.c - SecurityPkg\Tcg\Tcg2Smm\Tcg2Smm.c:254:7: error: > variable

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Support detect SMM shadow stack overflow

Ray, On 03/29/21 07:13, Yao, Jiewen wrote: > Thank you very much! > > Reviewed-by: Jiewen Yao can you please review and merge this patch? You were the UefiCpuPkg reviewer on the following two commits as well: 3eb69b081c68 ("UefiCpuPkg/PiSmmCpu: Add Shadow Stack Support for X86 SMM.",

Re: [edk2-devel] Enabling Secure boot

On 04/01/21 11:03, sent...@gmail.com wrote: > Hi, >  I have enable the secure boot for CorebootPayloadPkg in EDK 2017 and > got the secure boot configuration in the boot menu. But the problem is > Attempt secure boot is disabled. Also when I changed from standard mode > to custom mode to add

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

On 03/31/21 08:41, Nate DeSimone wrote: > Another option is to put the protocol definition in MdeModulePkg and > mark it with the EDKII_ prefix. For my last “code first” UEFI spec > contribution I did this with the PPI that added up getting added. The new audio protocol should be generic, only

[edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RaspberryPi: Fix mini UART clock divisor calculation

The VPU clock divisor has changed in this commit: https://github.com/raspberrypi/firmware/commit/1e5456a, thus breaking the mini UART clock divisor calculation on the Pi 4. Fix this by reading the core clock from the mailbox instead. Signed-off-by: Mario Bălănică ---

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/2] Enable SMMUv3 for Arm SGI/RD platforms

Hi Vivek, Thanks for this patch series. Pushed as: bc8a8b16bd4b..7fe9704893f1 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73724): https://edk2.groups.io/g/devel/message/73724 Mute This Topic:

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

On 04/06/21 10:11, Xu, Min M wrote: > Hi, Singh > I have a concern about the sevSnpBlock in ResetVectorVtf0.asm. Actually > SEV has inserted 3 blocks in ResetVectorVtf0.asm and the total bytes are > (26 + 22 + 20 = 68 bytes). If sevSnpBlock is added, then the total bytes > will be (68 +26 = 94

Re: [edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

+ Liming Gao I'm also interested in the plan for the edk2 in compliance with UEFI 2.8 specification. -Nhi From: devel@edk2.groups.io on behalf of Lin, Derek (HPS SW) via groups.io Sent: Wednesday, March 31, 2021 12:52 PM To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

On 03/27/21 00:41, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 > > Current SMM Save State routine does not check the number of bytes to be > read, when it comse to read IO_INFO, before casting the incoming buffer > to EFI_SMM_SAVE_STATE_IO_INFO. This could

Re: [edk2-devel] [PATCH 0/4] UefiCpuPkg: Add MicrocodeLib for loading microcode

Hi Ray, On 04/02/21 07:58, Ni, Ray wrote: > The patch set creates a new MicrocodeLib for loading microcode. > Then updates all platforms to include this lib in DSC. > Then updates the MpInitLib to consume this lib. > > Edk2-platforms change will be sent out in a separate patch set. > > > Ray

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation

Hi Mario, Please re-send a v2 with a commit message that explains the issue that is being fixed. Thanks. For the record, I ran some tests that show that the divisor was changed from 1 to 2 with the latest Pi Foundation firmware (which is confirmed by the fact that if you switch your

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Good day Nate, Comments are inline. Best regards, Marvin On 06.04.21 11:41, Nate DeSimone wrote: Hi Marvin, Great to meet you and welcome back! Glad you hear you are interested! Completing a formal verification of a PE/COFF loader is certainly impressive. Was this done with some sort of

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Hi Marvin, Great to meet you and welcome back! Glad you hear you are interested! Completing a formal verification of a PE/COFF loader is certainly impressive. Was this done with some sort of automated theorem proving? It would seem a rather arduous task doing an inductive proof for an

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue

Hi Tung Lun, The fix looks good, but please help to re-send with correct patch format. Thanks, Chasel 1. remove Change-id 2. cc all reviewers/maintainers 3. add bugzilla link to describe the issue you are fixing. 4. enrich commit message to describe the fix. > -Original Message-

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, 6 April 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 04/06/2021 6:30pm-7:30pm #cal-reminder

Hi, all Few issues are reported this week. Let’s cancel this week TianoCore Bug Triage meeting. 2180 EDK2 Tools michael.tur...@microsoft.com UNCO GenFw always zeros the timestamp

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

On Sat, Apr 3, 2021 at 09:45 PM, Benjamin Doron wrote: > Yes, Boot Guard is disabled on this laptop (and fused, which is a slight > shame). While SPI PRRs cover most of flash and BIOS control bits are > partially enabled by the vendor firmware (perhaps the lock wasn't set by > default,

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

Hi, Singh I have a concern about the sevSnpBlock in ResetVectorVtf0.asm. Actually SEV has inserted 3 blocks in ResetVectorVtf0.asm and the total bytes are (26 + 22 + 20 = 68 bytes). If sevSnpBlock is added, then the total bytes will be (68 +26 = 94 bytes). I am not sure whether there will be more

Re: [edk2-devel] GSoC 2021 (MinPlatform, Ext2, ACPICA, etc)

Hi Pedro, I agree with Andrew Fish. I’d say for the first half try to have an initial (but probably broken) implementation of the driver done. Then your second half can be fixing bugs, writing tests, and documenting your work. Thanks, Nate From: Pedro Falcato Date: Sunday, April 4, 2021 at