Re: [edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

Thanks for the review, Pete. I just sent v2 for addressing all your comments except the one below. > -#define BOOT_PROMPT L"ESC (setup), F1 (shell), ENTER (boot)" > > +#define BOOT_PROMPT L"ESC (setup), F1 (shell), ENTER (boot)\n" Why are you adding the carriage return? Was there an issue with

[edk2-devel] [PATCH v2 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

This is a fix for https://github.com/pftf/RPi4/issues/114. Changes: 1. Add a setup option called Boot Policy and consume the setting during boot to whether perform or skip ConnectAll. 2. The Default setting is set to Full discovery because it is not worth enabling Fast boot by

Re: [edk2-devel] [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined

> -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Tuesday, April 13, 2021 10:38 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io; Kinney, Michael D > Cc: Liming Gao ; Liu, Zhiguang > ; Andrew Fish > Subject: RE: [Patch

Re: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

Liming, The BZ contains an example of MAKE_FLAGS in DSC that breaks the build. With this change, that example passes and shows the additional make tool output. Mike > -Original Message- > From: gaoliming > Sent: Monday, April 12, 2021 6:31 PM > To: devel@edk2.groups.io; Kinney,

Re: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions

> -Original Message- > From: gaoliming > Sent: Monday, April 12, 2021 6:28 PM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, > Guomin ; Liu, Zhiguang ; > Feng, Bob C ; Chen, > Christine ; 'Andrew Fish' ; 'Abner > Chang' >

Re: [edk2-devel] [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined

> -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Monday, April 12, 2021 6:57 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Liming Gao ; Liu, Zhiguang > ; Andrew Fish > Subject: RE: [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be >

Re: [edk2-devel] [PATCH v3 00/10] Added support for FT2000/4 chip

Hi Leif, It's been a few days since I sent V3 patches. Do you have any suggestions for this patches? Looking forward to your reply！ Best Regards, Ling > -原始邮件- > 发件人: "Ling Jia" > 发送时间: 2021-03-17 15:26:37 (星期三) > 收件人: devel@edk2.groups.io > 抄送: "Leif Lindholm" , "Ling Jia" > 主题:

Re: [edk2-devel] [Patch 3/3] BaseTools/Source: Remove CPU architecture assumptions

> -Original Message- > From: Michael D Kinney [mailto:michael.d.kin...@intel.com] > Sent: Thursday, April 8, 2021 2:33 PM > To: devel@edk2.groups.io > Cc: Bob Feng ; Liming Gao > ; Yuwei Chen ; > Andrew Fish ; Chang, Abner (HPS SW/FW Technologist) > > Subject: [Patch 3/3]

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

Pushed @ 54211ab10fcd8532b49f4024ebdb601a8eb07e3e Regards, Jian > -Original Message- > From: Michael Kubacki > Sent: Tuesday, April 13, 2021 1:54 AM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ; > Kun Qin > Subject: Re:

Re: [edk2-devel] [Patch 2/3] CryptoPkg/Library/Include: Allow CPU specific defines to be predefined

Reviewed-by: Abner Chang > -Original Message- > From: Michael D Kinney [mailto:michael.d.kin...@intel.com] > Sent: Thursday, April 8, 2021 2:33 PM > To: devel@edk2.groups.io > Cc: Jiewen Yao ; Jian J Wang > ; Xiaoyu Lu ; Guomin Jiang > ; Andrew Fish ; Chang, Abner > (HPS SW/FW

Re: [edk2-devel] [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined

> -Original Message- > From: Michael D Kinney [mailto:michael.d.kin...@intel.com] > Sent: Thursday, April 8, 2021 2:33 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Zhiguang Liu > ; Andrew Fish ; Chang, Abner > (HPS SW/FW Technologist) > Subject: [Patch 1/3] MdePkg/Include: Allow

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 04/13/2021 6:30pm-7:30pm #cal-reminder

Hi, all The following issues will be discussed on this week Bug Triage meeting. And, this week meeting will use Teams. Please get the meeting information from https://edk2.groups.io/g/devel/calendar. 3300 EDK2 Code

回复: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

Mike: I don't see the issue in the code change. I want to know what unit test has been done for this change. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年4月10日 5:49 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen > 主题:

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 04/13/2021 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 13 April 2021, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45 View Event (

回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions

Mike: Is this update for new ARCH support? With this patch set, new ARCH support doesn't need to modify BaseTools. Right? For this patch set 3/3 BaseTools/Source, I may suggest to split it to two patches, one is for C tools, another is for Python tools. For other patch, they are good to

回复: [edk2-devel] [PATCH v1 1/1] Fix AsmReadMsr64() and AsmWriteMsr64() with GCC toolchain

Naito: The fix is correct. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Takuto Naito > 发送时间: 2021年4月12日 23:07 > 收件人: devel@edk2.groups.io > 抄送: Takuto Naito ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > 主题: [edk2-devel] [PATCH v1 1/1] Fix

[edk2-devel] GSoC (Google Summer of Code) Application Deadline Approaching

Hi Everyone, Quick heads up, the GSoC application deadline is 17 hours from now. I still see 5 applications in draft status. Google is very strict about their deadlines, even if you are 1 minute late they won't accept it. Please make sure that all applications are submitted and marked as final

回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

I create PR https://github.com/tianocore/edk2/pull/1557 for this patch. 发件人: devel@edk2.groups.io 代表 Bret Barkelew via groups.io 发送时间: 2021年4月13日 0:24 收件人: devel@edk2.groups.io; hao.a...@intel.com; Bret Barkelew 抄送: Wang, Jian J 主题: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize

回复: [edk2-devel] [PATCH v3 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Anthony > PERARD via groups.io > 发送时间: 2021年4月12日 21:30 > 收件人: devel@edk2.groups.io > 抄送: Laszlo Ersek ; Jordan Justen > ; Ard Biesheuvel ; > xen-de...@lists.xenproject.org; Anthony PERARD > ; Julien Grall ; Michael D >

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Hi Marvin, I agree with Mike K that having both the new strict loader and the old loader co-exist for some time may be the best option. That will give the ecosystem time to test the new loader and correct any issues that arise from its introduction. Best Regards, Nate -Original

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

Hi Benjamin, Since Google is expecting students to only work 18 hours a week on their GSoC projects this year that should be totally fine. It might not be a bad idea to mention it in your application just so we have a good paper trail. Best Regards, Nate From: Benjamin Doron Sent: Monday,

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Hi Marvin, If it has not already been considered, one option is to submit a new instance of the PE/COFF Library, so both the existing one and the new one are available to the ecosystem. This allows you to be successful in submitting code outlined in your proposal and gives the ecosystem time to

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, 6 May 2021 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - Thursday, 6 May 2021 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

Sunny, Thanks for sending this! This was tested by several RPi4 users and confirmed to fix at least the following issue: https://github.com/pftf/RPi4/issues/144 https://github.com/pftf/RPi4/issues/114 It *may* also fix the following issues (to be confirmed):

Re: [edk2-devel] [RFC PATCH 00/19] Add AMD Secure Nested Paging (SEV-SNP) support

On 4/12/21 11:23 AM, Laszlo Ersek wrote: > On 04/10/21 00:43, Brijesh Singh wrote: >> On 4/9/21 7:24 AM, Laszlo Ersek wrote: >>> On 04/08/21 13:59, Brijesh Singh wrote: On 4/8/21 4:58 AM, Laszlo Ersek wrote: > On 03/24/21 16:31, Brijesh Singh wrote: >> At this time we only support

[edk2-devel] [edk2-platforms][PATCH V3 0/6] Platform/Sgi: improvements in RD platform support

Changes since V2: - Rebase the patches on top of latest master branch - Addressed comments from Sami Changes since V1: - Rebase the patches on top of latest master branch - Add three more patches to the series - Picked up Sami's R-b tags on applicable patches This patch series contains assorted

[edk2-devel] [edk2-platforms][PATCH V3 6/6] Platform/Sgi: add SMMU and timer entries to memory description table

Add PCDs for base address and address space size for generic timer and SMMU controllers. Use those PCDs to add platform memory map entries. The ServerReady SBSA tests, when executed, accesses these controllers and so the memory mapping for generic timer and SMMU controllers are required. In

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

Hi again, I forgot to mention previously that I will likely be taking one university course during the summer, likely occupying 3-5 hours per week. I don't imagine this would be an issue, but let me know if I should mention it in my project proposal (or if mentioning it here is sufficient). >

[edk2-devel] [edk2-platforms][PATCH V3 4/6] Platform/Sgi: update ACPI table revision

Fix the ACPI DSDT/SSDT table version numbers. As per ACPI 6.3 specification, the DSDT/SSDT table should use version 2 instead of 1. In addition to this, update 'PcdAcpiExposedTableVersions' to avoid building RSDT table into ACPI firmware volume because the platforms supported under SgiPkg are

[edk2-devel] [edk2-platforms][PATCH V3 5/6] Platform/Sgi: define PCD for timer interrupt numbers

The generic timer and watchdog timer interrupt numbers on the RD-N2 platform is different than those on the other platforms supported by SgiPkg. So in order to reuse the existing GTDT ACPI table for all the supported platforms including RD-N2, introduce and use PCD to provide the interrupt numbers

[edk2-devel] [edk2-platforms][PATCH V3 3/6] Platform/Sgi: fix CPU acpi-id for RD-V1-MC platform

Fix the incorrect ACPI _UID (Unique ID) object for CPU devices listed for the RD-V1-MC platform. Signed-off-by: Pranav Madhu Reviewed-by: Sami Mujawar --- Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc | 24 ++-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[edk2-devel] [edk2-platforms][PATCH V3 2/6] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform

RD-V1-MC platform has four CPUs in each of its four coherently connected chips. So remove a incorrect CPU device entry in DSDT table that lists a additional non-existent CPU. Signed-off-by: Pranav Madhu Reviewed-by: Sami Mujawar --- Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 6 -- 1

[edk2-devel] [edk2-platforms][PATCH V3 1/6] Platform/Sgi: include SSDT table for RD-V1 platform

Ssdt ACPI table in SgiPkg describes the PCIe controller and the root complex resources. Include this table for RD-V1 and RD-V1-MC platforms. Signed-off-by: Pranav Madhu Reviewed-by: Sami Mujawar --- Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 1 +

Re: [EXTERNAL] Re: [edk2-devel] [GSoC proposal] Secure Image Loader

As always, we volunteer the UEFI Talkbox Discord for conversations of this nature.  https://discord.gg/cuqjER3Juw - Bret From: Marvin Häuser via groups.io Sent: Monday, April 12, 2021 10:24 AM To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable

Hi Laszlo and SecurityPkg maintainers, This is a relatively straightforward patch. Please let me know if anything else is needed for you to submit it. Thanks, Michael On 4/7/2021 9:06 AM, Laszlo Ersek wrote: On 04/06/21 20:12, mikub...@linux.microsoft.com wrote: From: Michael Kubacki

Re: [EXTERNAL] [edk2-devel] Build Failed for QEMU35Pkg

Hey All, Thank you for your thoughts and responses. I have figured it out. The branch has been updated with fix which I missed! Got the successful build done. Thank you, Shivanshi From: Bret Barkelew Sent: Monday, April 12, 2021 11:32 AM To: Andrew Fish; edk2-devel-groups-io Cc: Pandya,

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

Hi Laszlo, Thanks for the help. Regards, Kun On 04/12/2021 10:36, Laszlo Ersek wrote: On 04/07/21 18:08, Laszlo Ersek wrote: On 04/06/21 21:52, Kun Qin wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 Current SMM Save State routine does not check the number of bytes to be

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: PiSmmCpuDxeSmm: Check buffer size before accessing

On 04/07/21 18:08, Laszlo Ersek wrote: > On 04/06/21 21:52, Kun Qin wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3283 >> >> Current SMM Save State routine does not check the number of bytes to be >> read, when it comse to read IO_INFO, before casting the incoming buffer >> to

Re: [edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

On Mon, 12 Apr 2021 at 15:03, Pete Batard wrote: > > Hi Sunny, > > Functionaly, I see no issues with this patch, and it's indeed a good > solution to the problem of trying to satisfy everyone while fixing the > issues we are seeing. > > There are however a few minor typos and whitespace issues,

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

Good day Nate, As you seem to be mostly in charge of the GSoC side of things, I direct this at you, but of course everyone is welcome to comment. I think I finished my first round of investigations just in time for the deadline. You can find a list of BZs attached[1]. Please note that 1)

Re: [EXTERNAL] [edk2-devel] Build Failed for QEMU35Pkg

To my knowledge, we do not currently have a required version; the current state is it either works or it doesn’t, and if it doesn’t it’s on you to figure that out from the failures. I’m not opposed to adding one – if there’s interest. I’d have to think about the best place to add it. The idea

Re: [EXTERNAL] [edk2-devel] Build Failed for QEMU35Pkg

> On Apr 9, 2021, at 6:33 PM, Bret Barkelew via groups.io > wrote: > > Andrew, > Not a scheme that I would consider a “good” scheme. You can see what we’re > running CI against (in Mu and EDK, both), by checking for the > “UsePythonVersion” command in the .azurepipelines/pr-gate-steps.yml

Re: [edk2-devel] [RFC PATCH 00/19] Add AMD Secure Nested Paging (SEV-SNP) support

On 04/10/21 00:43, Brijesh Singh wrote: > > On 4/9/21 7:24 AM, Laszlo Ersek wrote: >> On 04/08/21 13:59, Brijesh Singh wrote: >>> On 4/8/21 4:58 AM, Laszlo Ersek wrote: On 03/24/21 16:31, Brijesh Singh wrote: > At this time we only support the pre-validation. OVMF detects all > the

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

Looks like we have the requisite approvals. Shall I create a PR? - Bret From: Wu, Hao A via groups.io Sent: Sunday, April 11, 2021 7:23 PM To: Bret Barkelew; devel@edk2.groups.io Cc: Wang, Jian

Re: [edk2-devel] [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure

Reviewed-by: Sai Chaganty -Original Message- From: Ni, Ray Sent: Monday, April 12, 2021 1:45 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V Subject: [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure The commit 7e4c6f982a0accd5aa86337b46d20199db989aeb updated

[edk2-devel] GCC49 DEBUG AARCH64 and ARM builds use -O0

I noticed the GCC49 (and GCC48) AARCH64 and ARM DEBUG builds use -O0, unlike IA32 and X64 platforms which build with -Os. e.g. from https://github.com/tianocore/edk2/blob/master/BaseTools/Conf/tools_def.template : DEBUG_GCC49_AARCH64_CC_FLAGS = DEF(GCC49_AARCH64_CC_FLAGS) -O0 Is that

[edk2-devel] [PATCH v1 1/1] Fix AsmReadMsr64() and AsmWriteMsr64() with GCC toolchain

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3325 1. AsmReadMsr64() in X64/GccInlinePriv.c AsmReadMsr64 can return uninitialized value if FilterBeforeMsrRead returns False. This causes build error with the CLANG toolchain. 2. AsmWriteMsr64() in X64/GccInlinePriv.c In the case that

[edk2-devel] [PATCH v1 0/1] Fix AsmReadMsr64() and AsmWriteMsr64() with GCC toolchain

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3325 This patch fixes the problems of AsmReadMsr64/AsmWriteMsr64 for the GCC toolchain introduced when RegisterFilterLib support was added. Patch v1 branch: https://github.com/naitaku/edk2/tree/patch/fix_read_msr_with_gcc Cc: Michael D

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

Hi James and Laszlo, I was planning to work to add the support to reserve the Secrets and CPUID page in E820 map and then create the EFI configuration table entry for it so that guest OS can reach to it. We have two packages "SecretDxe" and "SecretPei" in OvmfPkg/AmdSev. Any issues if I use them

Re: [edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

On Mon, 2021-04-12 at 11:54 +, Yao, Jiewen wrote: > I totally agree with you that from security perspective, the best > idea to isolate AMD SEV/Intel TDX from standard OVMF. There's a big difference between building tuned binaries and separating the subsystems entirely. Ideally we don't want

[edk2-devel] [PATCH v3 2/7] MdePkg: Allow PcdFSBClock to by Dynamic

We are going to want to change the value of PcdFSBClock at run time in OvmfXen, so move it to the PcdsDynamic section. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek Reviewed-by: Liming Gao --- Notes: CC: Michael D Kinney

[edk2-devel] [PATCH v3 0/7] OvmfXen: Set PcdFSBClock at runtime

Patch series available in this git branch: git://xenbits.xen.org/people/aperard/ovmf.git br.apic-timer-freq-v3 Changes in v3: - typos and codying style Changes in v2: - main change is to allow mapping of Xen pages outside of the RAM see patch: "OvmfPkg/XenPlatformPei: Map extra physical

[edk2-devel] [PATCH v3 5/7] OvmfPkg/XenPlatformPei: Map extra physical address

Some information available in a Xen guest can be mapped anywhere in the physical address space and they don't need to be backed by RAM. For example, the shared info page. While it's easier to put those pages anywhere, it is better to avoid mapping it where the RAM is. It might split a nice 1G

[edk2-devel] [PATCH v3 7/7] OvmfPkg/OvmfXen: Set PcdFSBClock

Update gEfiMdePkgTokenSpaceGuid.PcdFSBClock so it can have the correct value when SecPeiDxeTimerLibCpu start to use it for the APIC timer. Currently, nothing appear to use the value in PcdFSBClock before XenPlatformPei had a chance to set it even though TimerLib is included in modules run before

[edk2-devel] [PATCH v3 6/7] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency

Calculate the frequency of the APIC timer that Xen provides. Even though the frequency is currently hard-coded, it isn't part of the public ABI that Xen provides and thus may change at any time. OVMF needs to determine the frequency by an other mean. Fortunately, Xen provides a way to determines

[edk2-devel] [PATCH v3 3/7] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO

We are going to use new fields from the Xen headers. Apply the EDK2 coding style so that the code that is going to use it doesn't look out of place. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- Notes: v2: - fix

[edk2-devel] [PATCH v3 1/7] OvmfPkg/XenResetVector: Silent a warning from nasm

To avoid nasm generating a warning, replace the macro by the value expected to be stored in eax. Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds Reported-by: Laszlo Ersek Signed-off-by: Anthony PERARD Reviewed-by: Laszlo Ersek --- OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 2 +-

[edk2-devel] [PATCH v3 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

We are going to use the page table structure in yet another place, collect the types and macro that can be used from another module rather than making yet another copy. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 Signed-off-by: Anthony PERARD Acked-by: Tom Lendacky --- Notes:

Re: [edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

Hi Sunny, Functionaly, I see no issues with this patch, and it's indeed a good solution to the problem of trying to satisfy everyone while fixing the issues we are seeing. There are however a few minor typos and whitespace issues, that I'm detailing below. So could you please send a v2 to

Re: [edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

I totally agree with you that from security perspective, the best idea to isolate AMD SEV/Intel TDX from standard OVMF. Do you want to propose move AMD SEV support to another SEC? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dr. David > Alan Gilbert > Sent: Monday,

Re: [edk2-devel] [edk2-platforms][PATCH V2 6/6] Platform/Sgi: add SMMU and timer entries to memory description table

Hi Pranav, Can you sort the PCDs in alphabetical order in the inf, dec and dsc.inc, please? With that changed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 06:36, "Pranav Madhu" wrote: Add PCDs for base address and address space size for generic timer and SMMU

Re: [edk2-devel] [edk2-platforms][PATCH V2 5/6] Platform/Sgi: define PCD for timer interrupt numbers

Hi Pranav, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 06:36, "Pranav Madhu" wrote: The generic timer and watchdog timer interrupt numbers on the RD-N2 platform is different than those on the other platforms supported by SgiPkg.

Re: [edk2-devel] [edk2-platforms][PATCH V2 3/6] Platform/Sgi: fix CPU acpi-id for RD-V1-MC platform

Hi Pranav, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 06:36, "Pranav Madhu" wrote: Fix the incorrect ACPI _UID (Unique ID) object for CPU devices listed for the RD-V1-MC platform. Signed-off-by: Pranav Madhu ---

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/6] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform

Hi Pranav, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 06:36, "Pranav Madhu" wrote: RD-V1-MC platform has four CPUs in each of its four coherently connected chips. So remove a incorrect CPU device entry in DSDT table that lists a

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of Base instance.

On 04/12/21 05:09, Ni, Ray wrote: > Laszlo, > This is also related to CpuTimerLib. I assume that you won't have any concern > if I merge today > > We need the INF change very urgently because with the removal of > DxeCpuTimerLib, DXE module must use > BaseCpuTImerLib but the INF doesn't allow

Re: [edk2-devel] [PATCH] DynamicTablesPkg: add validation for PcdNonBsaCompliant16550SerialHid

Hi Joey, Can you confirm that your sign-off ID is correct, please? Otherwise this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73944):

Re: [edk2-devel] [edk2-platforms][PATCH V2 7/7] Platform/ARM/Morello: Add virtio net support

Hi Chandni, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 15:36, "Chandni Cherukuri" wrote: This patch registers a virtio net device for Morello FVP platform. Signed-off-by: Chandni Cherukuri ---

Re: [edk2-devel] [edk2-platforms][PATCH V2 5/7] Platform/ARM/Morello: Add initial support for Morello Platform

Hi Chandni, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 15:36, "Chandni Cherukuri" wrote: From: Anurag Koul This patch adds the initial support for Morello FVP platform. Co-authored-by: Chandni Cherukuri Signed-off-by:

Re: [edk2-devel] [edk2-platforms][PATCH V2 6/7] Platform-ARM-Morello: Add Readme.md file

Hi Chandni, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 01/04/2021, 15:36, "Chandni Cherukuri" wrote: This patch adds Readme.md file for Morello Platform. The document consists of information regarding the platform, steps to build and boot till

[edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Setup option for disabling Fast Boot

This is a fix for https://github.com/pftf/RPi4/issues/114. Changes: 1. Add a setup option called Boot Policy and consume the setting during boot to whether perform or skip ConnectAll. 2. The Default setting is set to Full discovery because it is not worth enabling Fast boot by

[edk2-devel] [PATCH] IntelSiliconPkg/ShadowMicrocode: Fix build failure

The commit 7e4c6f982a0accd5aa86337b46d20199db989aeb updated ShadowMicrocode module to consume MicrocodeLib. But the change caused the build failure. The patch fixed the build failure and also verified the change in real platform. Signed-off-by: Ray Ni Cc: Rangasai V Chaganty ---

Re: [edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

* Laszlo Ersek (ler...@redhat.com) wrote: > On 04/09/21 15:44, Yao, Jiewen wrote: > > Hi Laszlo > > Thanks. > > > > We did provide a separate binary in the beginning - see > > https://github.com/tianocore/edk2-staging/tree/TDVF, with same goal - easy > > to maintain and develop. A clean

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

Reviewed-by: Nickle Wang Got it. Thanks Abner. Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Monday, April 12, 2021 12:20 PM To: Wang, Nickle (HPS SW) ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII