Merge at fdf3666f01a2dd02d83a808f609b9c744a74c652
发件人: devel@edk2.groups.io 代表 gaoliming
发送时间: 2021年5月21日 13:28
收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; ashishsingha@nvidia.
com; 'Samer El-Haj-Mahmoud' ;
michael.d.kin...@intel.com; zhiguang@intel.com
主题: 回复: [edk2-devel]
Merge at 197e27c90aeb603eed98a2554746dd966f04fc28
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming
> 发送时间: 2021年6月1日 9:27
> 收件人: devel@edk2.groups.io; samer.el-haj-mahm...@arm.com;
> m...@semihalf.com
> 抄送: liming@intel.com; michael.d.kin...@intel.com; l...@nuviainc.com;
>
Merge at d3ff5dbe1dfc3420e5254d290500c0b6f6282d17
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 gaoliming
> 发送时间: 2021年6月1日 9:26
> 收件人: devel@edk2.groups.io; kuqi...@gmail.com
> 抄送: 'Michael D Kinney' ; 'Zhiguang Liu'
>
> 主题: 回复: [edk2-devel] [PATCH v1 1/1] MdePkg: MmControl: Fix function
>
It would be better if having function comments in the
PlatformBootManagerOverride.h.
Reviewed-by: Guo Dong
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, May 26, 2021 1:53 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Dong, Guo
> ; You, Benjamin
> Subject:
This error was found while compiling VirtioMmioDeviceLib for X64
with the GCC5 toolchain, where EFIAPI makes a difference.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 +
OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1
Yes, very good comments, thanks for reviewing.
Will update it in PATCH V4
Regards,
Daoxiang
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75934): https://edk2.groups.io/g/devel/message/75934
Mute This Topic:
From: Daoxiang Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3424
Processor location information check needs to updated
When Core 0 is disabled
Signed-off-by: Daoxiang Li
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c
From: Daoxiang Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3424
Processor location information check needs to updated
When Core 0 is disabled.
In C1e.c, change MSR_FEATURE_CONFIG to MSR_NEHALEM_POWER_CTL in comments
to match the correct MSR name.
Signed-off-by: Daoxiang Li
Cc:
Agree with Patrick.
In this patch, it removed gBS->InstallConfigurationTable(), it should also add
AcpiTableDxe.inf to avoid regression.
Thanks,
Guo
From: Patrick Rudolph
Sent: Wednesday, May 26, 2021 6:50 AM
To: devel@edk2.groups.io; Liu, Zhiguang
Cc: Ma, Maurice ; Dong, Guo ; You,
Reviewed-by: Guo Dong
> -Original Message-
> From: Liu, Zhiguang
> Sent: Monday, May 24, 2021 12:13 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Dong, Guo
> ; You, Benjamin
> Subject: [PATCH 6/9] UefiPayloadPkg: Creat gPldSmbiosTableGuid Hob
>
> From SysTableInfo Hob, get
When reviewing V2, I only focused on whether the C code change is good.
I am ok that this patch contains not just processor location check logic
update, but also updates to comments
that are not related to the location check.
2 minor comments:
1. Change the commit message title to
On 6/2/21 10:16 AM, gaoliming wrote:
Laszlo:
Thanks for the detail information about QemuFwCfgLib. So, this library is
arch generic. Now, it is only consumed by ARM and AARCH64.
Daniel:
Can you show more on how RiscV64 uses this QemuFwCfgLib?
See below. QEMU for the generic RISCV64
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: pierre.gond...@arm.com
> 发送时间: 2021年6月2日 6:05
> 收件人: devel@edk2.groups.io; dandan...@intel.com;
> gaolim...@byosoft.com.cn; michael.d.kin...@intel.com;
> sami.muja...@arm.com; alexei.fedo...@arm.com
> 主题: [PATCH v1 1/2] MdePkg/MdeModulePkg: Move
Ray:
Original CLANGELF tool chain is verified on CLANG8. Can you verify it to see
whether it meet with your requirement?
If yes, this tool chain can be renamed to CLANGDWARF to match current
CLANGPDB tool chain.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ni, Ray
>
Laszlo:
Thanks for the detail information about QemuFwCfgLib. So, this library is
arch generic. Now, it is only consumed by ARM and AARCH64.
Daniel:
Can you show more on how RiscV64 uses this QemuFwCfgLib?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Laszlo Ersek
> 发送时间:
In C1e.c, the MSR_FEATURE_CONFIG is better to be corrected to
MSR_NEHALEM_POWER_CTL.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, June 1, 2021 11:25 PM
To: Li, Daoxiang ; devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek ; Kumar,
From: Pierre Gondois
Use the newly introduced defined value in:
MdePkg/Include/IndustryStandard/AcpiAml.h
Signed-off-by: Pierre Gondois
---
.../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 4 ++--
.../AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 4 ++--
From: Pierre Gondois
A NameSeg is made 4 chars.
Cf. ACPI 6.4 s20.2.2 "Name Objects Encoding":
NameSeg :=
Notice that NameSegs shorter than 4 characters are filled
with trailing underscores (‘_’s).
AML_NAME_SEG_SIZE is currently defined in:
- DynamicTablesPkg/Library/Common/AmlLib/AmlDefines.h
From: Pierre Gondois
There is currently multiple AML_NAME_SEG_SIZE define in the edk2
repository. One in the MdeModulePkg and one in the DynamicTablesPkg
package. Since the value can be inferred from the ACPI specification,
it could be moved to MdePkg/Include/IndustryStandard/ and avoid
On 5/24/21 10:52 PM, Sayanta Pattanayak via groups.io wrote:
> This patch series adds secure boot support for Arm's reference design
> platforms. The first patch refactors the existing StandaloneMM platform
> description file and splits into three different files. This is required
> to
Pushed as 8cdd4cb7c71e..f7c08b9bae56
Thanks.
Regards,
Sami Mujawar
On 25/05/2021 11:57 AM, Pranav Madhu wrote:
Changes since V1:
- Updated the MADT table to fix the incorrect base addresses mentioned
for GICC, GICR, GICV and GICH.
- Addressed comments from Sami
- Picked up Sami's
On 06/01/21 15:20, Ard Biesheuvel wrote:
> On Tue, 1 Jun 2021 at 14:12, Laszlo Ersek wrote:
>>
> ...
>> - A major complication for hashing all three of: kernel, initrd,
>> cmdline, is that the *fetching* of this triplet is split between two
>> places. (Well, it is split between *three* places in
Reviewed-by: Ray Ni
> -Original Message-
> From: Li, Daoxiang
> Sent: Tuesday, June 1, 2021 3:25 PM
> To: devel@edk2.groups.io
> Cc: Li, Daoxiang ; Dong, Eric ;
> Ni, Ray ; Laszlo Ersek
> ; Kumar, Rahul1
> Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor
>
Liming,
I happen to notice the below patches which you sent out two years ago:
https://edk2.groups.io/g/devel/topic/31354044#41053
It seems to me that I can drop my CLANGDWARF change completely and use your
patches.
Correct?
Thanks,
Ray
From: devel@edk2.groups.io On Behalf Of gaoliming
Sent:
Pushed as 86984c17d562..8cdd4cb7c71e, with minor changes to patch 4 and 7.
Thanks.
Regards,
Sami Mujawar
On 24/05/2021 03:28 PM, Pranav Madhu wrote:
Changes since V3:
- Add UpdateMemorySize API to update memory size information as suggested by
Sami.
Changes since V2:
- Addressed comments
Hi Rebecca,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/05/2021 07:29 PM, Rebecca Cran wrote:
The repo with the Visual Studio support no longer exists.
fiptool from the prebuilt_tools repo doesn't work due to a missing
dependency on libcrypto.so.1.0.0,
This patch adds platform specific DSDT generator
and Clk dsdt properties for LS1046AFRWY platform.
Signed-off-by: Vikas Singh
---
.../AcpiTablesInclude/Dsdt/Clk.asl| 60
.../AcpiTablesInclude/Dsdt/Dsdt.asl | 15 ++
.../AcpiTablesInclude/PlatformAcpiDsdtLib.inf |
Summary -
1.Configuration Manager(CM) is a common implementation
and should not evaluate the SoC version using macro's
However CM must directly consume SoC ver string from
platfrom who is extending CM services for ACPI table
generation.
2.Platforms who extends CM services for themselves
This patch set extends Configuration Manager (CM) and
its services to leverage the Dynamic ACPI support for
NXP's LS1046aFrwy platform.
Refer-https://edk2.groups.io/g/devel/message/71710
Signed-off-by: Vikas Singh
---
.../NXP/LS1046aFrwyPkg/Include/Platform.h | 155 ++
This change set intend to add a generic method to get
access to SoC's Silicon Version Register (SVR) and its
handling for LS1046aFrwy platform.
Signed-off-by: Vikas Singh
---
Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 16
1 file changed, 16 insertions(+)
diff --git
This patch series basically aims to extend the Dynamic ACPI
framework towards NXP's LS1046AFRWY platform.
Refer- https://edk2.groups.io/g/devel/message/71709
The change set in the series is in below order -
(1)Introducing a new platform specific macro "PLAT_SOC_NAME"
This macro will be consumed
Hi Rebecca,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/05/2021 07:30 PM, Rebecca Cran wrote:
Arm now provides the latest gcc toolchains for aarch64 and arm: the
Linaro page that was linked to no longer exists.
Signed-off-by: Rebecca Cran
---
On Tue, 1 Jun 2021 at 14:12, Laszlo Ersek wrote:
>
...
> - A major complication for hashing all three of: kernel, initrd,
> cmdline, is that the *fetching* of this triplet is split between two
> places. (Well, it is split between *three* places in fact, but I'm going
> to ignore
This commit add option which allows reset content of Secure Boot
keys and databases to default variables.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
| 1 +
This commits adds modules related to initialization and
usage of default Secure Boot key variables to SecurityPkg.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/SecurityPkg.dec | 14 ++
SecurityPkg/SecurityPkg.dsc | 4
2 files changed, 18 insertions(+)
diff --git
This application allows user to force key enrollment from
Secure Boot default variables.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.inf | 47
+
SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c | 107
This driver initializes default Secure Boot keys and databases
based on keys embedded in flash.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDefaultKeysDxe.inf
| 46 +
This commits add library, which consist functions related
creation/removal Secure Boot variables. Some of the functions
was moved from SecureBootConfigImpl.c file.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/SecurityPkg.dsc
| 1 +
This commits add file which can be included by platform Flash
Description File. It allows to specify certificate files, which
will be embedded into binary file. The content of these files
can be used to initialize Secure Boot default keys and databases.
Signed-off-by: Grzegorz Bernacki
---
This commit allows to initialize Secure Boot default key
and databases from data embedded in firmware binary.
Signed-off-by: Grzegorz Bernacki
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 5 -
Platform/RaspberryPi/RPi4/RPi4.fdf | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git
This patchset adds support for initialization of default
Secure Boot variables based on keys content embedded in
flash binary. This feature is active only if Secure Boot
is enabled and DEFAULT_KEY is defined. The patchset
consist also application to enroll keys from default
variables and secure
On 05/29/21 23:34, KAAIRA GUPTA wrote:
> Fix typographical error in the README by correcting the 'an' mistyped as
> 'and'.
>
> Signed-off-by: Kaaira Gupta
> ---
> OvmfPkg/README | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/README b/OvmfPkg/README
> index
Hi Gerd,
On 05/28/21 16:16, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 +
> OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 +
> 2 files changed, 2 insertions(+)
Thanks for the patch!
(1)
On 05/28/21 15:33, Brian J. Johnson wrote:
> On 5/27/21 5:12 AM, Laszlo Ersek wrote:
>> On 05/26/21 19:08, Devon Bautista wrote:
>>> Currently, the largest volume size for building OVMF images is 4MB. With
>>> the growth of the Linuxboot project, maintainers have had to maintain a
>>> fork
Ard,
I'll have a specific question for you below; please feel free to jump
forward (search for your name). Thanks.
Dov, my comments below:
On 05/25/21 07:31, Dov Murik wrote:
> Booting with SEV prevented the loading of kernel, initrd, and kernel
> command-line via QEMU fw_cfg interface because
On 28/05/2021 18:16, Pedro Falcato wrote:
2) Although I'd love to avoid journaling, which is a matter I'm not too
familiar with, I'm not entirely sure what simplifications may be done
because for one,
what happens if the power cuts during a write? It's unclear to me how a
FW filesystem driver
On 06/01/21 09:24, Daoxiang wrote:
> From: Daoxiang Li
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3424
>
> Processor location information check needs to updated
> When Core 0 is disabled
>
> Signed-off-by: Daoxiang Li
> CC: Eric Dong
> CC: Ray Ni
> CC: Laszlo Ersek
> CC: Rahul
On 06/01/21 02:56, gaoliming wrote:
> Seemly, Edk2\ArmVirtPkg\Library\QemuFwCfgLib\QemuFwCfgLib.inf is not arch
> specific library. It can also be used in RISCV64.
>
>
>
> Ard and Laszlo:
>
> If ArmVirtPkg\Library\QemuFwCfgLib is arch generic, can it be moved from
> ArmVirtPkg into OvmfPkg?
Hi Sami,
> -Original Message-
> From: Sami Mujawar
> Sent: Saturday, May 29, 2021 3:44 PM
> To: Jianyong Wu ; devel@edk2.groups.io;
> ler...@redhat.com; ardb+tianoc...@kernel.org
> Cc: hao.a...@intel.com; Justin He ; Leif Lindholm
> ; nd
> Subject: Re: [PATCH v2 4/5] ArmVirtPkg:
On 05/31/21 17:06, Philippe Mathieu-Daudé wrote:
> On 5/27/21 10:55 AM, Laszlo Ersek wrote:
>> On 05/27/21 09:34, Ard Biesheuvel wrote:
>>> On Wed, 26 May 2021 at 22:15, Laszlo Ersek wrote:
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Repo:
50 matches
Mail list logo
