On October 19, 2021 9:23 PM, Sami Mujawar wrote:
> > //
> > // Read the EFI Partition Table Header
> > //
> > @@ -156,6 +224,15 @@ Tcg2MeasureGptTable (
> > if (PrimaryHeader == NULL) {
> > return EFI_OUT_OF_RESOURCES;
> > }
> > +
> > + //
> > + //
Hi Samer
Thanks for the patch.
I overlook this one when I check the title, it is quite similar to previous
one. The only difference is signed v.s. unsigned.
It seems make sense. But I have same feedback as previous one.
Would you please:
1) Fila a Bugzilla - https://bugzilla.tianocore.org/ for
Hi Pierre,
This patchset is an unambiguous improvement on the current state, and
improves the state of Platform/ARM substantially.
For the series:
Acked-by: Leif Lindholm
/
Leif
On Tue, Oct 26, 2021 at 15:06:28 +0100, Pierre Gondois wrote:
> Hi Leif,
>
> This patch-set resolves:
>
>
Hi Jiewen, Jian, and Min,
Can you please review this patch? We have a corresponding UEFI Spec "code
first" ECR (https://bugzilla.tianocore.org/show_bug.cgi?id=3561), and need to
clarify a couple of cases in the code.
Thanks,
--Samer
> -Original Message-
> From: devel@edk2.groups.io
Hi Jiewen, Jian, and Min,
Can you please review this patch? We have a corresponding UEFI Spec "code
first" ECR (https://bugzilla.tianocore.org/show_bug.cgi?id=3561), and need to
clarify a couple of cases in the code.
Thanks,
--Samer
> -Original Message-
> From: devel@edk2.groups.io
On Tue, Oct 19, 2021 at 01:14 AM, PierreGondois wrote:
>
> Hi Khasim,
>
> 2 minor comments:
>
> On 10/10/21 19:29, Khasim Mohammed via groups.io wrote:
>
>> This patch creates Dsdt.asl, SsdtPci.asl and SsdtRemotePci.asl files
>> to provide the platform specific APCI table entries.
>>
>>
This patch enables ACPI tables and configuration manager for N1SDP
Signed-off-by: Sami Mujawar
Signed-off-by: Khasim Syed Mohammed
---
Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h | 35
Platform/ARM/N1Sdp/N1SdpPlatform.dec | 1 +
The dynamic tables framework utilizes the configuration manager
protocol to get the platform specific information required for
building the firmware tables.
The configuration manager is a platform specific component that
collates the platform hardware information and builds an abstract
platform
This patch creates Dsdt.asl, SsdtPci.asl and SsdtRemotePci.asl files
to provide the platform specific APCI table entries.
Three PCI root ports are available on N1Sdp, PCI0 is the default root port
PCI1 is the CCIX root port and PCI2 is the Remote host root port.
The Remote host specific entries
This patch adds PCDs and updates the fdf file for N1Sdp
platform specific configurations.
Signed-off-by: Deepak Pandey
Signed-off-by: Khasim Syed Mohammed
---
Platform/ARM/N1Sdp/N1SdpPlatform.dec | 98
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 37 ++-
Add an initial platform DXE driver and support for ramdisk devices.
Signed-off-by: Deepak Pandey
Signed-off-by: Khasim Syed Mohammed
---
.../N1Sdp/Drivers/PlatformDxe/PlatformDxe.c | 59 +++
.../N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf | 47 +++
2 files changed,
This patch adds missing documentation for few of the functions
and fixes few formatting changes.
Signed-off-by: Khasim Syed Mohammed
---
.../Library/PlatformLib/PlatformLib.c | 46 +--
1 file changed, 41 insertions(+), 5 deletions(-)
diff --git
This patch introduces new PCDs required to enable
chip to chip interface and corresponding memory map is updated.
Signed-off-by: Chandni Cherukuri
Signed-off-by: Khasim Syed Mohammed
---
.../Library/PlatformLib/PlatformLib.inf | 28 +--
.../Library/PlatformLib/PlatformLibMem.c |
Enable the physical presence interface for TPM 1.2. It is required for
the TPM 1.2 menu to work.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Signed-off-by: Stefan Berger
---
OvmfPkg/Include/Library/QemuPPI.h |
From: Gerd Hoffmann
When building OVMF with TPM 1.2 support enabled
do also include the configuration menu.
Suggested-by: Stefan Berger
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 +
OvmfPkg/OvmfTpmDxe.fdf.inc | 1 +
2 files changed, 2 insertions(+)
Modify SavePpRequest to look like its TPM 2 equivalent SaveTcg2PpRequest
and have it submit the physical presence opcode to the PreOS function so
that we can choose our own method for how to store it.
Move the existing code into DxeTcgPhysicalPresenceLib.c and adapt the
return codes.
Cc: Jiewen
This series adds support for the full TPM 1.2 Physical Presence Interface
(PPI) and activates the TPM 1.2 menu at the end. PPI is a prerequisite for
the menu to work.
The modifications to the original code are mostly due to the fact that we
are using a memory region for PPI in QEMU. I tried to
TPM 1.2 and TPM 2 share QEMU's PPI memory/device and for the TPM 2 code
not to initilize over the TPM 1.2 initilization, leave the init function
early without touching that memory.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Signed-off-by: Stefan Berger
---
.../DxeTcg2PhysicalPresenceLib.c
This patch introduces new PCDs required to enable
chip to chip interface and corresponding memory map is updated.
Signed-off-by: Chandni Cherukuri
Signed-off-by: Khasim Syed Mohammed
---
.../Library/PlatformLib/PlatformLib.inf | 28 +--
.../Library/PlatformLib/PlatformLibMem.c |
This patch adds missing documentation for few of the functions
and fixes few formatting changes.
Signed-off-by: Khasim Syed Mohammed
---
.../Library/PlatformLib/PlatformLib.c | 46 +--
1 file changed, 41 insertions(+), 5 deletions(-)
diff --git
Hi Ray, Sai,
Could you take a look on this patch?
Pasting below questions and answers from previous patch for a reference.
What's the difference between SOC and CPU?
SOC die differs from typical CPU die in Intel's chiplet design.
What the purpose of "DieIndex"?
We want to have an indication
I have incorporated all the review comments and suggestions
on v2 patches.
1) Was able to successfully run the CI on edk2-platforms enabled by Pierre
https://github.com/PierreARM/edk2-platforms/tree/review/N1Sdp_v2
2) Observed three false positive for Dependency Check
From: Pierre Gondois
Add a JunoPkg.ci.yaml file to enable the CI for the JunoPkg.
Change-Id: Ib43aa7918b38256dd6fe2a87f8cca2e5975fcb76
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sami Mujawar
Signed-off-by: Pierre Gondois
From: Pierre Gondois
These files are copies of the files from the tianocore/edk2
repository. Any modification to the tianocore/edk2 files must be
reflected on the tianocore/edk2-platforms copies.
Initial commid-id in the edk2 repository: ab060128768b
Initial message:
Add directory for the
From: Pierre Gondois
To enable CI support of the tianocore/edk2-platforms repository,
add YML configuration files used to run Continuous Integration (CI)
checks on Azure Pipelines agents.
These files are copies of the files from the tianocore/edk2
repository. Any modification to the
From: Pierre Gondois
To enable CI support of the tianocore/edk2-platforms repository,
add a .pytool directory containing the following files:
- .pytool/CISettings.py
- .pytool/Readme.md
These files are largely inspired from the same files available in
the edk2 repository. The .pytool/Plugin/*
From: Pierre Gondois
To enable CI support of the tianocore/edk2-platforms repository,
add pip requirements file to install the python modules
required to perform EDK II Continuous Integration (CI) builds.
This file is a copy of the file from the tianocore/edk2
repository. Any modification to
From: Pierre Gondois
Add the edk2 repository as a submodule:
https://github.com/tianocore/edk2
Platforms in edk2-platforms often relies on modules available
in the edk2 repository. In order to enable an upstream CI
for edk2-platforms, adding edk2 as a submodule is a convenient
way to advertise
From: Pierre Gondois
v4:
- Checkout edk2 repository in Ubuntu-PatchCheck.yml to
get the PatchCheck.py script. [Pierre]
v3:
- Replace Readme(s)'s by a reference to the initial Readmed(s) in
tianocore repository. [Sean]
- Align CI files with the latest version in the edk2 repository.
Reviewed-by: Maurice Ma
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, October 26, 2021 1:06
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Ma, Maurice
> ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH] IntelFsp2Pkg/SplitFspBin.py: adopt FSP 2.3 specification.
>
Hi Leif,
This patch-set resolves:
https://bugzilla.tianocore.org/show_bug.cgi?id=3259
without removing the Platform/ARM prefix used in the Platform/ARM/ folder (cf
https://bugzilla.tianocore.org/show_bug.cgi?id=3264). Does it look sensible ?
Regards,
Pierre
On 10/19/21 12:22, PierreGondois
On Fri, Oct 22, 2021 at 12:56:02 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides function to initialize PCIe PHY on
> Ampere Altra processor.
>
> Commits in this patchset can be found at:
>
Hi Nhi,
I have finished review of this revision. I did spot a couple of
large-ish things (enums and watchdog) that I had not noticed in
previous revisions, but the majority of the comments are on the new
code.
Best Regards,
Leif
On Fri, Oct 22, 2021 at 13:17:38 +0700, Nhi Pham wrote:
> This
On Fri, Oct 22, 2021 at 13:18:09 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> There are secure and non-secure watchdog timers supported in the Mt.
> Jade system. They are used to monitor the system booting like system
> firmware, UEFI, and OS. The system will be reset if the timer expires.
> So,
On Fri, Oct 22, 2021 at 13:18:05 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide memory screen with below info:
> * Memory total capacity
> * Memory RAS and Performance Configuration
> * Per DIMM Information
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
>
On Fri, Oct 22, 2021 at 13:18:03 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This change allows to configure the PCIe bifurcation mode and update
> the ACPI IORT tables based on the PCIe User setting.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D
On Fri, Oct 22, 2021 at 13:18:02 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This menu screen allows the user to:
> - Enable/Disable each Root Complex
> - Enable/Disable SMMU support
> - Enable/Disable Strong Ordering
> - Set Bifurcation mode for each Root Complex
>
> Cc: Thang Nguyen
> Cc:
On Fri, Oct 22, 2021 at 13:17:57 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Add IORT and MCFG tables to let the OS discover the PCIe resources. This
> driver also fixup the DSDT table to adapt with the difference between 1P
> and 2P system.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong
On Fri, Oct 22, 2021 at 13:17:54 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides functions to handle the PCIe configuration requests. The target
> Root Complex is selected based on the segment number parsed from the input
> address.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
On Fri, Oct 22, 2021 at 13:17:53 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides the number of supported RootBridges and the resource allocated
> for each RootBridge. These information are essential to the HostBridge
> driver to initialize the PCIe subsystem.
>
> Cc: Thang Nguyen
> Cc:
On Fri, Oct 22, 2021 at 13:17:52 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This driver takes responsibility for:
> - Parsing platform settings to build the Root Complex info HOB
> - Initializing each Root Complex
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
>
On Fri, Oct 22, 2021 at 13:17:51 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide Mt. Jade specific segment number for each Root Complex and
> function to handle the PCIe PERST.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard
On Fri, Oct 22, 2021 at 13:17:50 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides essential functions to initialize the PCIe Root Complex on
> Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
On Fri, Oct 22, 2021 at 13:17:49 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide common data structures and macros which will be consumed by
> various PCIe modules.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
>
On Fri, Oct 22, 2021 at 13:17:46 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This change supports storing the UEFI non-volatile varibles on the
> Flash through below modules:
> * FlashPei driver helps to restore the saved variables from
> flash on each boot.
> * FlashFvbDxe driver provides
Hi Nhi,
On Fri, Oct 22, 2021 at 13:17:41 +0700, Nhi Pham wrote:
> The FailSafeDxe is a driver for the FailSafe feature which reverts the
> system's configuration to known good values if the system fails to boot
> up multiple times. Also, this driver implements the Watchdog Timer
> Architectural
On October 26, 2021 6:25 PM, Gerd Hoffmann wrote:
> Hi,
>
> > > > So it has to be implemented inside the exception lib.
> > >
> > > Well, no, you can also change the code to avoid triggering an exception.
> > >
> > > Adding a new lib for the exception means the lib must be added into
> > >
Corrects the function declaration/definition
by adding EFIAPI.
Removes duplicate functions.
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Supreeth Venkatesh
Signed-off-by: Abdul Lateef Attar
---
Resubmitting patch with correct format and email ids.
Corrects the function declaration/definition
by adding EFIAPI.
Removes duplicate functions.
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Carolyn Gjertsen
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Supreeth Venkatesh
On Fri, Oct 22, 2021 at 13:17:40 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides functions to access the NVRAM, NVRAM2 and FailSafe region on the
> Flash over MM communication.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard
On Fri, Oct 22, 2021 at 13:17:39 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This commit adds the support for Ampere’s Altra processor-based Mt. Jade
> platform that provides up to 160 processor cores in a dual socket
> configuration. The essential modules are wired up enough to boot system
>
Hi,
> > > So it has to be implemented inside the exception lib.
> >
> > Well, no, you can also change the code to avoid triggering an exception.
> >
> > Adding a new lib for the exception means the lib must be added into each
> > and every *.dsc file (either the tdx impl or the null variant),
Acked-by: Ray Ni
Sean, Bret, Mike, Liming, any comments?
> -Original Message-
> From: Tan, Dun
> Sent: Friday, October 8, 2021 5:45 PM
> To: devel@edk2.groups.io; Tan, Dun
> Cc: Sean Brogan ; Bret Barkelew
> ; Kinney, Michael D
> ; Liming Gao ; Ni, Ray
>
> Subject: RE: [edk2-devel]
On October 26, 2021 2:12 PM, Gerd Hoffmann wrote:
> On Tue, Oct 26, 2021 at 05:06:21AM +, Xu, Min M wrote:
> > On October 12, 2021 6:27 PM, Gerd Hoffmann wrote:
> > > > + if (ExceptionType == VE_EXCEPTION) {
> > > > +EFI_STATUS Status;
> > > > +//
> > > > +// #VE needs to be
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3705
FSP 2.3 has updated FSP_INFO_HEADER to support ExtendedImageRevision
and SplitFspBin.py needs to support it.
Also updated script to display integer value basing on length.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
(for the mailing list archives:)
This bug was fixed by commit 36b561623a4b ("OvmfPkg/AmdSev: update the
fdf to use new workarea PCD" by Brijesh Singh).
The fix was merged to edk2 master branch on 2021-10-19:
https://github.com/tianocore/edk2/pull/2080
Thanks Brijesh, Min, Gerd, and Jiewen for
> -Original Message-
> From: Chiu, Ian
> Sent: Friday, October 22, 2021 5:15 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Ian ; Chiu, Ian ; Chu,
> Maggie ; Ni, Ray ; Wu, Hao A
>
> Subject: [PATCH] MdeModulePkg\UfsBlockIoPei: UFS MMIO address size
> support both 32/64 bit
>
> From: Ian Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699
The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated
interface VariableLockRequestToLockc. So I changed the code in
FmpDevicePkg using RegisterBasicVariablePolicy, instead of the
deprecated interface.
Signed-off-by: Yang
On Tue, Oct 26, 2021 at 05:06:21AM +, Xu, Min M wrote:
> On October 12, 2021 6:27 PM, Gerd Hoffmann wrote:
> > > + if (ExceptionType == VE_EXCEPTION) {
> > > +EFI_STATUS Status;
> > > +//
> > > +// #VE needs to be handled immediately upon enabling exception
> > > handling
> > >
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699
The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated
interface VariableLockRequestToLockc. So I changed the code in
FmpDevicePkg using RegisterBasicVariablePolicy, instead of the
deprecated interface.
Signed-off-by: Yang
60 matches
Mail list logo
