> -Original Message-
> From: Ni, Ray
> Sent: Friday, February 11, 2022 3:29 PM
> To: Rehan, MohammedX ;
> devel@edk2.groups.io; Esakkithevar, Kathappan
> ; Gao, Zhichao
> ; Pethaiyan, Madhan
>
> Cc: Thirupugal, MadhaviX
> Subject: RE: [PATCH V2 1/1] ShellPkg: Fix Ping GetTimerPeriod
Reviewed-by: Ray Ni
-Original Message-
From: Rehan, MohammedX
Sent: Thursday, February 10, 2022 2:51 PM
To: devel@edk2.groups.io; Esakkithevar, Kathappan
; Gao, Zhichao ; Ni,
Ray ; Pethaiyan, Madhan
Cc: Thirupugal, MadhaviX ; Rehan, MohammedX
Subject: [PATCH V2 1/1] ShellPkg: Fix
Hi Mike,
I don't see this covered by the PI specification (it's soo huge).
Which chapter describes this?
The original issue was a boot hang observed on real hardware as the
MtrrLib can't handle
specific corner cases. Not calling into MtrrLib fixes the issue.
An alternative approach would be to
在 2/10/22 8:28 PM, Sami Mujawar 写道:
> Hi Ming,
>
> Thank you for this patch.
>
> I have a few comments, marked inline as [SAMI].
>
> With those addressed,
>
> Reviewed-by: Sami Mujawar
>
> Regards,
>
> Sami Mujawar
>
> On 09/02/2022 01:54 AM, Ming Huang wrote:
>> These definitions are
Hello,
Inline comments below:
> -Original Message-
> From: Sean Rhodes
> Sent: Friday, February 11, 2022 5:27 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Matt DeVillier
> ; Patrick Rudolph
>
> Subject: [PATCH 13/18] MdeModulePkg/Usb/Keyboard.c: don't request
> protocol before
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
Hello,
I think we have encountered some devices that will take as long as 1 second to
respond.
How about adding a new PCD called
gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue (in microsecond
unit) in MdeModulePkg.dec '[PcdsFixedAtBuild, PcdsPatchableInModule]' section?
Please
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
Hello,
(Add Ray as the initial author for this driver.)
Inline comments below:
> -Original Message-
> From: Sean Rhodes
> Sent: Friday, February 11, 2022 5:26 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Matt DeVillier
>
> Subject: [PATCH 12/18] Ps2KbdCtrller: Make wait for SUCCESS
Thank you for approval.
Hi Mike and Sean,
I found all the CI test failed. The error message is [error]No hosted
parallelism has been purchased or granted. To request a free parallelism grant,
please fill out the following form
https://aka.ms/azpipelines-parallelism-request
Ard:
I am OK to merge this issue for this stable tag. It is a clear bug fix.
Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel
> 发送时间: 2022年2月10日 17:18
> 收件人: edk2-devel-groups-io ; Rebecca Cran
> ; Liming Gao (Byosoft address)
>
> 抄送: James Bottomley ; Min Xu
> ; Jiewen Yao ; Tom Lendacky
Ming:
You can refer to wiki
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
to know how to create PR.
You can refer to wiki
https://github.com/tianocore/tianocore.github.io/wiki/Reporting-issues to know
how to apply for Bugzilla account.
Thanks
Liming
>
> On Feb 9, 2022, at 9:33 PM, Ni, Ray wrote:
>
> Jeff,
> I understand what “EFI_SYSTEM_CONTEXT” is. I am curious of the need of
> “BOOLEAN ProcessSystemContext”.
>
Ray,
ProcessSystemContext may not be needed…
My thinking was if you pass ProcessSystemContext == TRUE there is some implied
From: Ken Lautner
Update to the newest pytools and resolves the API change for
GetAbsolutePathOnThisSytemFromEdk2RelativePath
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Kenneth Lautner
Reviewed-by: Sean Brogan
---
From: Ken Lautner
Update to the newest pytools and resolves the API change for
GetAbsolutePathOnThisSytemFromEdk2RelativePath
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Kenneth Lautner
---
.azurepipelines/Ubuntu-PatchCheck.yml
From: Matt DeVillier
Add PlatformGopPolicy to use external GOP driver
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Matt DeVillier
---
.../PlatformGopPolicy/PlatformGopPolicy.c | 161 ++
.../PlatformGopPolicy/PlatformGopPolicy.h | 62
I think we can resolve in coreboot, I will close the PR :)
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86593): https://edk2.groups.io/g/devel/message/86593
Mute This Topic: https://groups.io/mt/88963238/21656
Group Owner:
Hi Sean,
By disabling the MTRR lib in this way, the UefiPayloadPkg has no means to
adjust cachability if it needs to in the future, and it breaks conformance
with the PI Specification.
What modules in the UefiPayloadPkg are changing cachability? Is that
appropriate?
Should those modules be
Hi Liming
It is standard coreboot code that provides it this way.
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86591): https://edk2.groups.io/g/devel/message/86591
Mute This Topic: https://groups.io/mt/88963238/21656
Hi Liming
It's not based on spec, just behaviour seen with coreboot and UefiPayloadPkg. I
can wrap it in a build option if that would be preferable?
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86590):
Hook PRIORITISE_INTERNAL build option to PrioritiseInternal PCD.
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index
From: Matt DeVillier
This prevents some internally-attached USB devices
(card readers, etc) from defaulting ahead of SATA/NVMe/eMMC drives.
Signed-off-by: Matt DeVillier
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 10 --
From: Patrick Rudolph
The MTRRs have already been programmed by FSB.
Signed-off-by: Patrick Rudolph
---
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 4
UefiCpuPkg/Library/MtrrLib/MtrrLib.inf | 2 +-
UefiCpuPkg/UefiCpuPkg.dec | 4
UefiCpuPkg/UefiCpuPkg.uni | 8
From: Patrick Rudolph
This fixes an issue where the framebuffer provided by coreboot or
slimbootloader will only work on the primary VGA device. If the
framebuffer corresponds to a different device the screen will stay black.
In addition, the code doesn't work for multiple graphic cards, has
From: Patrick Rudolph
Uses the RDRAND instruction if available and install EfiRngProtocol.
The protocol may be used by iPXE or the Linux kernel to gather entropy.
Signed-off-by: Patrick Rudolph
---
UefiPayloadPkg/Library/BaseRngLib/BaseRng.c | 199 ++
From: Matt DeVillier
No need to check the interface protocol then conditionally setting,
just set it to BOOT_PROTOCOL and check for error.
This is what Linux does for HID devices as some don't follow the USB spec.
One example is the Aspeed BMC HID keyboard device, which adds a massive
boot
From: Matt DeVillier
Recent model Chromebooks only return ACK, but not
BAT_SUCCESS, which causes hanging and failed ps2k init.
To mitigate this, make the absence of BAT_SUCCESS reply
non-fatal, and reduce the no-reply timeout from 4s to 1s.
Tested on google/dracia and purism/librem_14
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 14b7cc55f5..7b57310dfd 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++
From: Matt DeVillier
Signed-off-by: Matt DeVillier
Change-Id: Id5b077ad6c79717a9d97d4228145791ef062962c
---
UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c
From: Matt DeVillier
Previous 1s timeout causeed stalls on boot splash with no benefit.
Reduced to 100ms and no interruptions to boot when no SD card inserted.
Signed-off-by: Matt DeVillier
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 2 +-
1 file changed, 1 insertion(+), 1
Fix case match in to avoid build failure on
Linu.
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/BlSupportSmm/BlSupportSmm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.h
b/UefiPayloadPkg/BlSupportSmm/BlSupportSmm.h
index
When build option ABOVE_4G_MEMORY is set to true, nothing will change
and EDKII will use all available memory.
Setting it to false will create memory type information HOB in
payload entry, so that EDKII will reserve enough memory below 4G
for EDKII modules. This option is useful for bootloaders
Provide a build option to use [Esc] instead of [F2] for devices
such as Chromebooks that don't have F-keys.
Signed-off-by: Sean Rhodes
---
.../PlatformBootManager.c | 44 +--
.../PlatformBootManagerLib.inf| 2 +
Hook FOLLOW_BGRT_SPEC build option to FollowBGRTSpec PCD.
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 282435ceec..82adf98a45 100644
---
Add option to centre the Boot Logo 38.2% from the top of screen, following
the BGRT specification.
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++-
MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 3 +++
MdeModulePkg/MdeModulePkg.dec
Provide a build option to use a Boot Splash logo.
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 5 +
.../PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++
UefiPayloadPkg/UefiPayloadPkg.dec | 3 +++
# TianoCore Community Meeting
**Highlights:**
- GSOC Call for Mentors Mid-May thru Mid-August (few hours per week)
- Andrew’s GDB scripts Committed. Discussed in Stewards Meeting Needs to be
re-submitted to BaseTools
- Suggestion for new community meeting focusing on CI and BaseTools
-
Andrew: We discussed your patch from August last year in today's
Community Meeting.
The patch is https://edk2.groups.io/g/devel/message/78906, but it sounds
as though there needs to be a v2 to move the files into
BaseTools/Scripts based on recent discussions.
Mike: it looks like there
Chasel,
The changes look good to me in general. The request I have is to please add
error return paths related to locking the variables. Given the sensitivity
related to UEFI variables, I don't think asserts are sufficient for error
flows. We should get explicit errors if anything fails in
please update to the latest pytools which is 0.11.2 and 0.15.2 and 0.1.13.
With that this looks good and will solve some of the pytool issues.
Reviewed-by: Sean Brogan
On 2/2/2022 4:49 PM, Kenneth Lautner wrote:
|tu-PatchCheck.yml | 2 +-
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
Thanks!
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 2/10/22 09:19, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3808
Changes the default for the "OutputFileDiffs" configuration option
to "True" so the formatting suggestions detected
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20201011T015911Z
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, February 10, 2022 8:19 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
> ; Bret Barkelew
> Subject: [PATCH v1 1/1]
Code review was provided well before soft freeze and passed all CI tests.
I agree that this can go into the stable tag.
Mike
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, February 10, 2022 2:15 AM
> To: devel@edk2.groups.io; Gao, Liming
> Cc: Chen, Christine ; 'Pedro
Patches applied cleanly & built with no issues. No issues spotted in functional
testing & passes the SCT tests required by SBBR.
-Jeff
On Sat, Jan 1, 2022 at 09:49 PM, Jeremy Linton wrote:
>
> The RPi4 has a SPI flash with unused capacity. This set detects if
> that capacity is sufficient for
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3808
Changes the default for the "OutputFileDiffs" configuration option
to "True" so the formatting suggestions detected by Uncrustify
will be output in the test case log. The diff is printed in unified
diff format.
This
Reviewed-by: Maurice Ma
> -Original Message-
> From: Jiang, Guomin
> Sent: Wednesday, February 9, 2022 19:03
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; Ni, Ray ; Ma,
> Maurice ; You, Benjamin
> Subject: [Patch V2 1/1] UefiPayloadPkg/PayloadLoaderPeim: Force UINTN
> before save Ptr
>
Hi Ming,
Thank you for this patch.
I have a few comments, marked inline as [SAMI].
With those addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/02/2022 01:54 AM, Ming Huang wrote:
These definitions are added according UEFI spec.
Signed-off-by: Ming Huang
---
Hi,
We are using a custom board based Ampere SOC. We have two Renesas USB
controller uPD720201 in our setup.
1. Renesas USB controller on custom module based on Ampere SOC.
- Connected to Pcie Root complex port directly.
2. Renesas USB controller on custom carrier board.
-
Thank you Liming.
Hi Stewards,
This patch set can resolve the build failure issue with GCC 11, so I plan to
have it in this stable tag.
https://edk2.groups.io/g/devel/message/86077
https://edk2.groups.io/g/devel/message/86078
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io
Hi Liming,
I can't log in to bugzilla. How can I register a new account?
I have not created pull request for this change and I don't know how to do that.
I am sorry.
Best Regards.
在 2/10/22 9:19 AM, gaoliming 写道:
> Ming:
> Can you submit one BZ in https://bugzilla.tianocore.org/ for this
On Thu, 10 Feb 2022 at 10:17, Ard Biesheuvel wrote:
>
> (+ Liming)
>
... for real this time.
> On Fri, 4 Feb 2022 at 21:28, Rebecca Cran wrote:
> >
> > XCODE5 reported the following warning:
> >
> > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note:
> > uninitialized use occurs here
(+ Liming)
On Fri, 4 Feb 2022 at 21:28, Rebecca Cran wrote:
>
> XCODE5 reported the following warning:
>
> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note:
> uninitialized use occurs here
>Compacted
>^
>
> Initialize the 'Compacted' variable to fix the
Hi, Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: 2022年2月9日 0:31
> To: devel@edk2.groups.io; Li, Zhihao ; Kinney, Michael D
>
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul1
> Subject: Re: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Extend SMM
Thanks Nate!
Best Regards,
Xiaoqiang Zhang
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, February 9, 2022 11:27 AM
To: Zhang, Xiaoqiang ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Oram, Isaac W
Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs
Hi,
We are using a custom board based on Ampere SOC. We have two Renesas USB
controller uPD720201 in our setup.
1. Renesas USB controller on custom module based on Ampere SOC.
- Connected to Pcie Root complex port directly.
2. Renesas USB controller on custom carrier board.
-
57 matches
Mail list logo
