Yes, that's my GitHub ID.
Can add reviewed-by or acked-by. Whatever makes sense here.
Thanks,
Daniel
On 7/21/22 11:14, Michael D Kinney wrote:
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Daniel Schaefer
> Cc: Sean Rhodes
> Cc: Debkumar De
> Cc: Erdem Aktas
> Cc: Gary Lin
> Signed-off-by:
The spec looks wrong to me.
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Thursday, July 21, 2022 11:16 AM
To: Zeng, Star ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L
Subject: RE: [PATCH v3] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
Hi Star, this is following current
Hi Star, this is following current specification.
Thanks,
Chasel
> -Original Message-
> From: Zeng, Star
> Sent: Wednesday, July 20, 2022 8:07 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [PATCH v3] IntelFsp2Pkg: Add
Cc: Harry Han
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 608cdf749c3c..958d7f037d51 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -372,7 +372,6 @@ F:
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Cc: Gary Lin
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
XenTimerDxe has been removed from the OvmfPkg. Remove
file pattern for XenTimerDxe reviews from Maintainers.txt.
Cc: Anthony Perard
Cc: Julien Grall
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git
Cc: Anthony Perard
Cc: Julien Grall
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Cc: Harry Han
Cc: Gary Lin
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Michael D Kinney (3):
Maintainers.txt: Remove OvmfPkg/XenTimerDxe reference
Is the reserved bytes number correct for FSPI_ARCH_UPD alignment?
UINT16 BootloaderSmmFvContextDataLength;
UINT8Reserved1[24];
Thanks,
Star
-Original Message-
From: Chiu, Chasel
Sent: Thursday, July 21, 2022 10:29 AM
To: devel@edk2.groups.io
Cc: Chiu,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Bi, Dandan
> 发送时间: 2022年7月21日 9:42
> 收件人: Lai, Cosmo ; devel@edk2.groups.io
> 抄送: Wang, Jian J ; Gao, Liming
>
> 主题: RE: [PATCH v5] MdeModulePkg/Include: Long debug string is truncated
> to 104 char
>
> Reviewed-by: Dandan Bi
>
>
>
> Thanks,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Also fixed a bug in SplitFspBin.py for FSP-I support.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Thank you for your reviews, Sami! I will incorporate your suggestions in
v2 patch and send for review after validation.
Regards,
Kun
On 7/20/2022 4:00 AM, Sami Mujawar wrote:
Hi Kun,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI], otherwise this
patch looks
Thank you for the review, Pierre! We will update the patches per your
feedback and send v2 after validation.
Regards,
Kun
On 7/20/2022 6:38 AM, PierreGondois wrote:
Except for:
[PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check
for installed tables
[PATCH v1 5/6]
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Lai, Cosmo
Sent: Tuesday, July 19, 2022 1:59 PM
To: devel@edk2.groups.io
Cc: Lai, Cosmo ; Wang, Jian J ;
Gao, Liming ; Bi, Dandan
Subject: [PATCH v5] MdeModulePkg/Include: Long debug string is truncated to 104
char
Reviewed-by: Guo Dong
-Original Message-
From: Lu, James
Sent: Tuesday, July 19, 2022 11:58 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Dong, Guo ; Guo, Gua
Subject: RE: [PATCH] UefiPayloadPkg: Fix RelaAddress type always mismatch in if
condition
Hi Ray,
Any comment on this patch?
Pushed as a2763c425e..f5306c2b07
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, July 20, 2022 3:17 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Gao, Liming ; Chiu, Chasel
Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/5] Resolve GCC compilation
warnings
For
For the series...
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Oram, Isaac W
> Sent: Thursday, June 30, 2022 5:14 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Desimone, Nathaniel L
> ; Gao, Liming
> ; Chiu, Chasel
> Subject: [edk2-devel][edk2-platforms][PATCH V1 0/5]
Arm SBBR specification includes the list of required and recommended
SMBIOS tables. Tables of types 16 (Physical Memory Array),
17 (Memory Device), and 19 (Memory Array Mapped Address) are required,
but are not included in the current SbsaQemu SMBIOS driver. The current
SMBIOS driver provides a
XenTimerDxe has been removed from the OvmfPkg. Remove
file pattern for XenTimerDxe reviews from Maintainers.txt.
Cc: Anthony Perard
Cc: Julien Grall
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
Cc: Harry Han
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
---
Maintainers.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 5a87bc116647..d8d91f7ba122 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -372,7 +372,6 @@ F:
Cc: Anthony Perard
Cc: Julien Grall
Cc: Daniel Schaefer
Cc: Sean Rhodes
Cc: Debkumar De
Cc: Erdem Aktas
Cc: Harry Han
Cc: Andrew Fish
Cc: Leif Lindholm
Signed-off-by: Michael D Kinney
Michael D Kinney (3):
Maintainers.txt: Remove OvmfPkg/XenTimerDxe reference
Maintainers.txt: Add
Pushed as 773ac505b7..a2763c425e
-Original Message-
From: Desimone, Nathaniel L
Sent: Tuesday, July 19, 2022 5:47 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Dong, Eric ;
Gao, Liming
Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add
Pushed as 0f836bd4e3..773ac505b7
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, July 20, 2022 2:07 PM
To: Oram, Isaac W ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Gao, Liming
; Dong, Eric
Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 0/2] Add MinPlatformPkg
NOOPT
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3951
Add CONNECT HTTP command to create a tunnel from HTTPS Proxy Server to EndPoint
Server.
Add support to connect through proxy server using multi-URI DevicePath
sent to the Boot Manager.
Cc: Maciej Rabeda
Cc: Wu Jiaxin
Cc: Siyuan Fu
Cc:
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, July 20, 2022 2:05 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH v2] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
>
> REF:
Thanks Nate! I have sent V2 to add this comment, please review again.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, July 20, 2022 1:52 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
>
> Hi
For the series...
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, July 19, 2022 12:43 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming
> ; Dong, Eric
> Subject:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/FspEas/FspApi.h | 71
Hi Chasel,
Please see feedback inline.
Thanks,
Nate
> -Original Message-
> From: Chiu, Chasel
> Sent: Wednesday, July 20, 2022 12:02 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD.
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993
Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping up,
and some comments for clarification.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/Include/FspEas/FspApi.h | 69
Hey
This patch add dependency that SecurityPkg will depend on ArmPkg.
I am not sure it is good idea. As alternative, why not put all those to ArmPkg?
Then you don’t need change the package dependency.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
>
Hi,
I know this patch-set might be long to review, but I wanted to ask
if somebody already had some comments,
Note the following patch-sets are depending on this patch-set:
- [PATCH v1 0/7] Add AesLib and ArmAesLib
https://edk2.groups.io/g/devel/message/90878
- [PATCH RESEND v1 0/9] Add
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and nasm are pinned to avoid
unintended upgrades during image rebuild.
Do not
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop
downloading gcc from external locations; use the
toolchains provided by the container image instead.
The image needs to set the GCC5_*_PREFIX accordingly.
Signed-off-by: Oliver Steffen
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21
Fix pip install.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 6 ++
.azurepipelines/templates/pr-gate-steps.yml| 6 ++
2 files changed, 12 insertions(+)
diff --git a/.azurepipelines/templates/platform-build-run-steps.yml
Use the Python supplied by the container image.
Signed-off-by: Oliver Steffen
---
.azurepipelines/templates/platform-build-run-steps.yml | 1 +
.azurepipelines/templates/pr-gate-steps.yml| 1 +
2 files changed, 2 insertions(+)
diff --git
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom
containers.
The container image provides the required compiler toolchains and Qemu
for the supported architectures. These are then no longer downloaded at
runtime, avoiding CI failures due to download errors. This approach also
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/GenSec/GenSec.c | 171 -
1 file changed, 169 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/GenSec/GenSec.c
b/BaseTools/Source/C/GenSec/GenSec.c
index 35a1ac64ea..d86cc197cc 100644
---
EFI_SECTION_FREEFORM_SUBTYPE_GUID is a leaf section type that contains
a single EFI_GUID in the header to describe the raw data.
Currently is is not possible to generate such section.
This patch adds initial support for the generation of such sections.
The added syntax for this type of section
Except for:
[PATCH v1 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check for
installed tables
[PATCH v1 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve
ECAM space
where I had some remarks,
Reviewed-by: Pierre Gondois
Thanks!
On 7/19/22 02:22, Kun Qin via
Hello Kun,
On 7/19/22 02:22, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
This change added an extra step to allow check for installed ACPI tables.
For FADT, MADT, GTDT, DSDT and DBG2 tables, either pre-installed or
supplied through AcpiTableInfo can
Hello Kun,
On 7/19/22 02:22, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
Certain OSes will complain if the ECAM config space is not reserved in
the ACPI namespace.
This change adds a function to reserve PNP motherboard resources for a
given PCI node.
From: Anthony PERARD
Fix path to follow naming convention of "AArch64", and allow the path
in "Maintainers.txt" to work as expected.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3982
Signed-off-by: Anthony PERARD
---
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd
Print 'SubtypeGuid' field from the EFI_FREEFORM_SUBTYPE_GUID_SECTION
structure.
This value describes the raw data inside the section.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git
Hi Kun,
Thank you for this patch.
I have some minor suggestions marked inline as [SAMI], otherwise this
patch looks good to me.
With that updated.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF:
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
This change added more token fixers for other node types, including
Reviewed-by: Ray Ni
> -Original Message-
> From: Shindo, Miki
> Sent: Wednesday, July 20, 2022 4:28 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ni, Ray
> Subject: [PATCH] EmulatorPkg/PosixFileSystem: Add NULL check on memory
> allocation
>
> REF:
Hi Kun,
Thank you for this fix.
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The content of token should be derived from the data section of the
`CmObject`
Hi Kun,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/07/2022 01:22 am, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib,
such as
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c| 5 +
.../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++
This will allow the OS to display the logo whilst booting.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
2 files changed, 8 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
Bugzilla: 3995 (https://bugzilla.tianocore.org/show_bug.cgi?id=3995)
ACPI 6.4 spec states that if the revision field in the DSDT header is less
than 2, then all integers are restricted in width to 32 bits, including in
SSDTs.
Arm Base boot requirements state that platforms must conform to ACPI
Hi, Leif/Ard/Abner/Daniel
Since you're maintainers/reviewers of EmbeddedPkg. Do you have any comments to
this patch?
Thanks
Min
> -Original Message-
> From: Xu, Min M
> Sent: Sunday, June 26, 2022 11:06 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Leif Lindholm
> ; Ard Biesheuvel ;
On Wed, Jul 20, 2022 at 06:38:32AM +, Xu, Min M wrote:
> Hi, Gerd
> Do you have any comments to this patch-set?
With this in place it should be possible to allow secure boot builds for
AmdSev and Microvm, that is something I plan to try for additional
verification. Havn't found the time to
Merged as f0064ac3afa2..19a87683654a
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91567): https://edk2.groups.io/g/devel/message/91567
Mute This Topic: https://groups.io/mt/92260869/21656
Group Owner:
Hi all,
According to the instructions of edk2-platforms, I can build MinnowMax.cap and
CapsuleApp.efi.
Build command: build -a IA32 -a X64 -n 5 -t VS2019 -b DEBUG -p
Vlv2TbltDevicePkg\PlatformPkgX64.dsc
reference:
Hi Ray,
Any comment on this patch?
Thanks,
James
-Original Message-
From: Lu, James
Sent: Monday, July 11, 2022 1:06 PM
To: devel@edk2.groups.io
Cc: Lu, James ; Ni, Ray ; Dong, Guo
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Fix RelaAddress type always mismatch in if
condition
Hi, Gerd
Do you have any comments to this patch-set?
Thanks Min
> -Original Message-
> From: Xu, Min M
> Sent: Friday, July 1, 2022 7:29 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Leif Lindholm
> ; Ard Biesheuvel ;
> Chang, Abner ; Schaefer, Daniel
> ; Aktas, Erdem ;
> James
58 matches
Mail list logo
