[AMD Official Use Only - General]
PR updated
https://github.com/tianocore-docs/edk2-CCodingStandardsSpecification/pull/2/commits.
Please check it.
Thanks
Abner
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, October 4, 2022 10:18 PM
> To: Chang, Abner ;
On Tue, Oct 04, 2022 at 05:57:46PM +0200, Laszlo Ersek wrote:
> On 10/04/22 15:47, Gerd Hoffmann wrote:
> > In case the 64-bit pci mmio window is larger than the default size
> > of 32G be generous and hand out larger chunks of address space for
> > prefetchable mmio bridge windows.
> > +
Patch series have been merged:
https://github.com/tianocore/edk2/commit/f054beec548eb3cc718b35be20efa9d344fe7097
https://github.com/tianocore/edk2/commit/1bd2ff18664b9564a5802d0ac153b5023f2fa41e
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
Updates several debug macros in TigerlakeSiliconPkg to correctly
match print specifiers to actual arguments.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
Updates several debug macros in KabylakeSiliconPkg to correctly
match print specifiers to actual arguments.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
Updates several debug macros in CoffeelakeSiliconPkg to correctly
match print specifiers to actual arguments.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4095
Fixes several debug macros in Silicon/Intel that have a mismatched
number of print specifiers to arguments.
The original author's intention is not always 100% obvious. Though,
this series is relatively
Yes. Thanks Michael!
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, October 4, 2022 8:09 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Kinney,
> Michael D
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: Re: [edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4094
Updates several debug macros in WhitleyOpenBoardPkg to correctly
match print specifiers to actual arguments.
Note: The "EFI_D_ERROR" macro was changed to "DEBUG_ERROR" in
FspWrapperHobProcessLib.c to pass PatchCheck
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4094
Removes an argument passed to a debug macro without a print
specifier. The argument appears to be useless.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Cc: Isaac Oram
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4094
Updates several debug macros in MinPlatformPkg to correctly match
print specifiers to actual arguments.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4094
Fixes several debug macros in Platform/Intel that have a mismatched
number of print specifiers to arguments.
The original author's intention is not always 100% obvious. Though,
this series is relatively
Reviewed-by: Michael Kubacki
On 10/4/2022 9:22 PM, Chiu, Chasel wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
Duplicate library class header issue will be resolved and CI
exception for FspWrapperPlatformMultiPhaseLib should be removed too.
Cc: Nate DeSimone
Cc: Star Zeng
Hi Michael Kubacki,
Please help to review below patch series which will resolve the duplicate
library header in DEC issue.
Thanks,
Chasel
https://edk2.groups.io/g/devel/message/94725
https://edk2.groups.io/g/devel/message/94726
https://edk2.groups.io/g/devel/message/94727
> -Original
For the series:
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, October 4, 2022 11:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming
> ; Kinney, Michael D
> ; Sean Brogan
> Subject: [PATCH v1 0/3]
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Michael Kubacki
Signed-off-by: Chasel Chiu
Reviewed-by: Nate DeSimone
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
Duplicate library class header issue will be resolved and CI
exception for FspWrapperPlatformMultiPhaseLib should be removed too.
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Michael Kubacki
Signed-off-by: Chasel Chiu
---
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the handle manager [GM].
Best Regards
Girish
On 9/12/2022 8:57 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for this patch and
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, October 4, 2022 1:34 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.
REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092
To comply with coding style rule each library class
should have its own header even if it is just a private child library
instance consumed by parent public library in the same package.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
Patch has been merged:
https://github.com/tianocore/edk2-platforms/commit/ae75c51f27e21036b6ee021a2d5b9f365f951413
Thanks,
Chasel
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ;
BEGIN:VCALENDAR
METHOD:REQUEST
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
BEGIN:VTIMEZONE
TZID:India Standard Time
BEGIN:STANDARD
DTSTART:16010101T00
TZOFFSETFROM:+0530
TZOFFSETTO:+0530
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T00
TZOFFSETFROM:+0530
TZOFFSETTO:+0530
END:DAYLIGHT
From: Zachary Clark-Williams
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845
Enables KVM and One Click Recovery WLAN capability with WiFi Profile
Sync feature and protocol. Adding WiFiProfileSyncProtocol, which
supports the profilesync driver operations for transferring WiFi profiles
Hi Jeremy,
> That is unfortunate. Which revision/how much RAM? Can you paste the
> before/after kernel/pci output like:
My RPi4 is a 8GB revision d03114.
Here's the pci output before applying your ranges tweak:
[3.697773] brcm-pcie fd50.pcie: host bridge /scb/pcie@7d50 ranges:
[
Hi Mike,
I agree that it is a design issue and I had a patch for it in the v1
series. It did not fix the issue but took a different approach to work
around it for CI enabling.
See the following conversation between Chasel and I regarding that patch:
With one comment that IntelFsp2WrapperPkg.dec file needs a new
issue opened to resolve 2 library classes pointing to same
include file.
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, September 15, 2022 11:55 AM
>
Michael,
This looks like a design issue in the IntelFsp2WrapperPkg for 2
lib classes to point to the same include file.
Do you have a recommended fix for this issue?
I am ok with this YAML file that ignores the error, but I think
a new issue should be opened to fix this package to follow the
On 10/04/22 15:47, Gerd Hoffmann wrote:
> In case the 64-bit pci mmio window is larger than the default size
> of 32G be generous and hand out larger chunks of address space for
> prefetchable mmio bridge windows.
>
> Cc: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
> ---
>
Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, September 6, 2022 10:05 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Barkelew, Bret
> ; Kinney, Michael D
> ; Gao, Liming ; Wang,
> Jian J
> Subject: [PATCH v1 0/2]
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, October 4, 2022 8:19 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Kinney, Michael D ; Sean
> Brogan
> Subject: [PATCH v1 0/3] SourceLevelDebugPkg:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Adds SourceLevelDebugPkg to the "OTHER" CI matrix job so it is built
in edk2 CI.
Cc: Sean Brogan
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Hao A Wu
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Adds the package as a supported package to .pytool/CISettings.py
and adds a CI YAML for the package so it can be run in CI.
Cc: Hao A Wu
Cc: Michael D Kinney
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
Fixes spelling errors in the package so the SpellCheck CI plugin can
be enabled.
Cc: Hao A Wu
Cc: Michael D Kinney
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4091
1. Fixes pre-existing spelling errors in the package.
2. Adds SourceLevelDebugPkg to edk2 CI.
CI results are available in the PR:
https://github.com/tianocore/edk2/pull/3439
Cc: Hao A Wu
Cc: Liming Gao
Cc:
Hi Sami
Response inline.[GM]
Best Regards
Girish
On 10/4/2022 2:16 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
There are 2 cases that need handling. Please see my response inline
marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 04:01 am,
Prevents potential math over and underflows when comparing buffers
for SMM validity.
Original patch uploaded to bugzilla by Bret Barkelew .
I've adapted the patch to latest master, uncristified, dropped MU
comments.
Ref: CVE-2021-38578
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3387
I would not add link to Wiki from EDK II C Coding Standard Specification.
We want documents published from tianocore-docs to support standalone
formats such as PDF and if there is a link in one of those documents,
we want to know that it is a permanent link. I am concerned we may
reorganize Wiki
[AMD Official Use Only - General]
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, October 4, 2022 12:54 AM
> To: devel@edk2.groups.io; Chang, Abner ;
> quic_llind...@quicinc.com; Ni, Ray ; Attar, AbdulLateef
> (Abdul Lateef) ; Sunil V L
> ; Kinney, Michael D
>
> Cc:
Try detect physical address space, when successful use it.
Otherwise go continue using the current guesswork code path.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 13 +
1 file changed, 13 insertions(+)
diff --git
In case the 64-bit pci mmio window is larger than the default size
of 32G be generous and hand out larger chunks of address space for
prefetchable mmio bridge windows.
Cc: Laszlo Ersek
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf | 1 +
In case we have a reliable PhysMemAddressWidth use that to dynamically
size the 64bit address window. Allocate 1/8 of the physical address
space and place the window at the upper end of the address space.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 28
Add some qemu specific quirks to PlatformAddressWidthFromCpuid()
to figure whenever the PhysBits value returned by CPUID is
something real we can work with or not.
See the source code comment for details on the logic.
Also apply some limits to the address space we are going to use:
* Place a
For historical reasons ovmf is quite conservative on address space
usage, to play safe and avoid using more than 36 physical address bits
(the guaranteed minimum) if possible. With devices (specifically GPUs)
becoming larger and larger pci memory bars this becomes increasingly
problematic.
This
While the actual implementation (using qemu fw_cfg) is qemu-specific,
the idea to store the boot order as configured by the VMM in EFI
variables is not. So lets give the variables a more neutral name while
we still can (i.e. no stable tag yet with the new feature).
While being at it also fix the
Hello Girish,
On 10/4/22 05:01, Girish Mahadevan wrote:
Hello Sami,
My apologies for the late response. I had one question/comment.
Comment marked with [GM] inline.
Best Regards
Girish
On 9/12/2022 8:18 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
The
Hi Girish,
There are 2 cases that need handling. Please see my response inline
marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 04:01 am, Girish Mahadevan wrote:
Hello Sami,
My apologies for the late response. I had one question/comment.
Comment marked with [GM] inline.
Best Regards
47 matches
Mail list logo
