Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-08-22 Thread Chris Li OS via groups.io
Thanks and will send v4 soon. From: Kinney, Michael D Sent: Wednesday, August 23, 2023 1:47 AM To: Chris Li OS; Nong, Foster; devel@edk2.groups.io; Gao, Liming Cc: Yao, Jiewen; Ni, Ray; Open Source Submission; Kinney, Michael D Subject: RE: [edk2-devel]

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-08-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Please see my answers inline. > -Original Message- > From: disc...@edk2.groups.io On Behalf Of > Konstantin Aladyshev via groups.io > Sent: Wednesday, August 23, 2023 1:54 AM > To: Chang, Abner > Cc: disc...@edk2.groups.io; devel@edk2.groups.io >

[edk2-devel] [PATCH v2 6/6] uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked with Key State test cases -Add remaining Assertions 33 - 49 from SCT spec -Add Test Case to

[edk2-devel] [PATCH v2 1/6] uefi-sct/SctPkg: TCG Platform Reset Check Test

2023-08-22 Thread Abhimanyu Singh
From: "Abhi.Singh" SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test infrastructure for all test cases including updates to: CommonGenFramework.sh, UEFI_SCT.dsc, and Category.ini. -Add Guid.c and

[edk2-devel] [PATCH v2 5/6] uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Locked No Key State test cases -Add Assertions 23 - 32 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G

[edk2-devel] [PATCH v2 3/6] uefi-sct/SctPkg: TCG MORLOCK SetVariable Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLockSetVariable test cases -Add Assertions 9 through 18 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G

[edk2-devel] [PATCH v2 4/6] uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlLock Unlocked State test cases -Add Assertions 19, 20, 21, and 22 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest

[edk2-devel] [PATCH v2 0/6] TCG MemoryOverwriteRequest Tests

2023-08-22 Thread Abhimanyu Singh
These tests support platform firmware that implement MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock UEFI variables in accordance with TCG PC Platform Reset Attack Mitigation Specification. The 6 patches are split up according to the six sections documented in the SCT spec

[edk2-devel] [PATCH v2 2/6] uefi-sct/SctPkg: TCG MOR SetVariable Test

2023-08-22 Thread Abhimanyu Singh
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement MemoryOverwriteRequestControlSetVariable test cases -Add Assertions 5, 6, 7, and 8 from SCT spec -Add Test Case to MemoryOverwriteRequestFunctionTest Cc: G Edhaya

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCG MemoryOverwriteRequest

2023-08-22 Thread Stuart Yoder
Hi Abhi, See inline comments... On 8/17/23 11:10 AM, Abhimanyu Singh via groups.io wrote: From: "Abhi.Singh" SCT Platform Reset Check Test SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374 Test: https://bugzilla.tianocore.org/show_bug.cgi?id=4419 -Implement initial test

Re: [edk2-devel] [PATCH edk2-platforms v5 1/1] Platform/SbsaQemu: add GIC ITS support

2023-08-22 Thread Leif Lindholm
On Tue, Aug 22, 2023 at 18:53:43 +0200, Marcin Juszkiewicz wrote: > From: Shashi Mallela > > SBSA Reference Platform has GIC ITS support. Let make use of it to have > complex PCI Express setups. > > Base address is read from TF-A via SMC call. > > If firmware is used with QEMU 8.0 or older

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-22 Thread Abhimanyu Singh
Working BZ link: 3759 – SCT test fails when RouteConfig returns EFI_ACCESS_DENIED (tianocore.org) ( https://bugzilla.tianocore.org/show_bug.cgi?id=3759 ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107959):

[edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-22 Thread Abhimanyu Singh
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3759 HIIConfigAccess and HIIConfigRouting Protocol RouteConfig tests assertions store a failure when RouteConfig returns EFI_ACCESS_DENIED. In the UEFI SPEC RouteConfig in both protocols can return EFI_ACCESS_DENIED when the action violates a

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-08-22 Thread Konstantin Aladyshev
Thanks for the answer! I was a little bit confused about the part, that in the same package I actually need to provide different library implementations for the same 'ManageabilityTransportLib', thanks for the clarification! I think your DSC example should go into the package documentation. As

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-08-22 Thread Michael D Kinney
Yes. Mike > -Original Message- > From: Chris Li OS > Sent: Tuesday, August 22, 2023 2:42 AM > To: Nong, Foster ; Kinney, Michael D > ; devel@edk2.groups.io; Gao, Liming > > Cc: Yao, Jiewen ; Ni, Ray ; Open > Source Submission > Subject: Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: file descriptor leak in rename()

2023-08-22 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Monday, August 21, 2023 8:22 PM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D ; > Kloper, Dimitry > Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: file

[edk2-devel] [PATCH edk2-platforms v5 0/1] Platform/QemuSbsa: add GIC ITS

2023-08-22 Thread Marcin Juszkiewicz
SBSA Reference Platform can have GIC ITS present. And when it has then we can have complex PCI Express setup (and some other things). On systems with GIC ITS support it's address is read from TF-A via SMC call. IORT is generated, MADT has ITS information. Linux boots and sees GIC ITS as expected.

[edk2-devel] [PATCH edk2-platforms v5 1/1] Platform/SbsaQemu: add GIC ITS support

2023-08-22 Thread Marcin Juszkiewicz
From: Shashi Mallela SBSA Reference Platform has GIC ITS support. Let make use of it to have complex PCI Express setups. Base address is read from TF-A via SMC call. If firmware is used with QEMU 8.0 or older then there will be no GIC ITS support. In such case we would not add information

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-08-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Aladyshev, We use library class to specify the desire transport interface for the management protocol, such as MCTP, PLDM and IPMI. This way we can flexibly support any transport interface for the management protocol. Here is the example of using

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-22 Thread Andrew Fish via groups.io
My understanding is zero length arrays have not been legal C code since C89. They may still function as a compiler extension. struct foo { size_t len; char. Str[]0]; }; I seem to remember the reason we did not use the C99 flexible array members is back in the day as Visual Studio 2003

[edk2-devel] PLDM messages via MCTP over KCS

2023-08-22 Thread Konstantin Aladyshev
Hi! I'm trying to build `ManageabilityPkg` from the edk2-platforms repo to issue PLDM messages via MCTP over KCS. Is it possible with the current code? I see all the building blocks, but have trouble putting it all together. The main question that bothers me is what implementation should I set

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-08-22 Thread Chris Li OS via groups.io
Hi Mike and Foster, So the preferred definition is as below? RegisterBlock[]; // offset 0x0C From: Nong, Foster Sent: Monday, August 21, 2023 9:59 AM To: Kinney, Michael D; Chris Li OS; devel@edk2.groups.io; Gao, Liming Cc: Yao,

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-22 Thread Ard Biesheuvel
On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote: > > Instead of relying on raising the TPL to protect the critical sections > > that manipulate the global bitmask that keeps track of bounce buffer > > allocations, use

Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config

2023-08-22 Thread Sunil V L
Hi Liming, This is a bug fix and can cause data loss if the variable size > 4k. Can it be included for the edk2-stable202308? Let me know if it requires a BZ id. I tried running the CI tests for this patch. But 2 of tests failed and I don't think it has anything to do with this patch. If you are

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-22 Thread Gerd Hoffmann
On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote: > Instead of relying on raising the TPL to protect the critical sections > that manipulate the global bitmask that keeps track of bounce buffer > allocations, use compare-and-exchange to manage the global variable, and > tweak the

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-08-22 Thread Gerd Hoffmann
On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote: > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to > preserve the original execution of INIT-SIPI-SIPI. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Ard Biesheuvel > Cc: Jiewen Yao

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti

2023-08-22 Thread Gerd Hoffmann
On Wed, Aug 16, 2023 at 03:11:46PM -0500, Michael Roth wrote: > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is > true by default, but needs to be disabled for QEMU/OVMF where early INIT > is not