Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static

Merged https://github.com/tianocore/edk2/pull/4770 > -Original Message- > From: Michael Kubacki > Sent: Wednesday, August 30, 2023 7:14 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian J > > Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make >

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Socket completion functions are not called on Linux Compilation

Reviewed-by: Jayaprakash N Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Monday, August 28, 2023 4:01 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper, Dimitry Subject: [edk2-devel] [edk2-libc

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg: small improvements to UsbNetwork

Hi Rebecca, We have tried the patch. It works on my device. I think it could be add it into UsbNetwork source. Do you think? Thanks, Richard -Original Message- From: Mike Maslenkin Sent: 2023年8月26日 9:58 AM To: devel@edk2.groups.io Cc: Richard Ho (何明忠) ; rebe...@bsdio.com; Mike Maslenkin

Re: [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 6/6] RedfishClientPkg: spelling

Re: [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 5/6] RedfishClientPkg: fix

Re: [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write.

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 4/6] RedfishClientPkg: fix memory

Re: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 3/6] RedfishClientPkg: fix leak of

Re: [edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable

Thanks for fixing this issue, Mike. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2

Re: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable.

Reviewed-by: Nickle Wang @abner.ch...@amd.com, I am thinking that we may need to provide allocation function for CS structure so caller does not need to handle linked-list initialization like this one, or other stuff requies understanding to CS structure

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, August 29, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, August 29, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static

Reviewed-by: Jiewen Yao > -Original Message- > From: Michael Kubacki > Sent: Wednesday, August 30, 2023 7:14 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian J > > Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make > mTcg2Protocol static > > Hello, >

Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck

Hi all, Now that the stable tag is out, I would appreciate reviews for this series. Thanks, Michael On 8/14/2023 4:48 PM, Michael Kubacki wrote: From: Michael Kubacki Adds a new script and build plugin called DebugMacroCheck. The script verifies that the number of print specifiers match

Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static

Hello, Can you please help review this change when you get a chance? Thanks, Michael On 8/15/2023 11:50 AM, Michael Kubacki wrote: From: Michael Kubacki The global variable has a common name that can conflict with other TCG modules. For example, Tcg2Dxe has a similarly named global that is

Re: [edk2-devel] [PATCH v2 20/25] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg

On 8/29/23 4:17 AM, Gerd Hoffmann wrote: Hi, - SetDxeMemoryProtectionSettings (, DxeMemoryProtectionSettingsPcd); - SetMmMemoryProtectionSettings (, MmMemoryProtectionSettingsPcd); + Status = QemuFwCfgParseString (DXE_MEMORY_PROTECTION_PROFILE_FWCFG_FILE, , String); + if (!EFI_ERROR

Re: [edk2-devel] [PATCH v2 19/25] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

On 8/29/23 3:46 AM, Gerd Hoffmann wrote: --- a/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h +++ b/MdeModulePkg/Include/Library/SetMemoryProtectionsLib.h @@ -17,6 +17,10 @@ typedef struct { } DXE_MEMORY_PROTECTION_PROFILES; typedef enum { + DxeMemoryProtectionSettingsDebug

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ExceptionSupport: Support backtrace through an exception

On 8/29/23 15:29, Ard Biesheuvel wrote: > Laszlo reports that the efi_gdb.py script fails to produce a full > backtrace when attaching it to an ARM firmware build that has halted on > an unhandled exception. > > The reason is that the asm code that processes the exception was not > implemented

[edk2-devel] [PATCH v3 2/2] ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 -

[edk2-devel] [PATCH v3 1/2] MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

This patch adds below definitions from SMBIOS 3.7.0 into Smbios.h - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 -

[edk2-devel] [PATCH v3 0/2] Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0

Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 to edk2 sources Eduardo Cuevas Farfan (2): MdePkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0 MdePkg/Include/IndustryStandard/SmBios.h | 14 ++--

[edk2-devel] [PATCH 1/1] ArmPkg/ExceptionSupport: Support backtrace through an exception

Laszlo reports that the efi_gdb.py script fails to produce a full backtrace when attaching it to an ARM firmware build that has halted on an unhandled exception. The reason is that the asm code that processes the exception was not implemented with this in mind, and therefore lacks any handling of

Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

Thanks all - merged as 14bf2cb411ca. On Wed, Aug 23, 2023 at 11:21:02 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran > > On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote: > > The CLANGDWARF progfile sets both -Wno-tautological-compare and > >

Re: [edk2-devel] [PATCH v6 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification

Hello, Just a ping in case this was forgotten. The patches were already reviewed by Sami and Liming (thanks for this), the approval of a SecurityPkg Maintainer would be ideal, Regards, Pierre On 8/11/23 16:33, PierreGondois via groups.io wrote: From: Pierre Gondois v6: - Added

Re: [edk2-devel] [PATCH v2 20/25] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg

Hi, > - SetDxeMemoryProtectionSettings (, > DxeMemoryProtectionSettingsPcd); > - SetMmMemoryProtectionSettings (, MmMemoryProtectionSettingsPcd); > + Status = QemuFwCfgParseString (DXE_MEMORY_PROTECTION_PROFILE_FWCFG_FILE, > , String); > + if (!EFI_ERROR (Status)) { > +DEBUG

Re: [edk2-devel] [PATCH v2 19/25] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

> > // PROFILE CONFIGURATIONS // > > > DXE_MEMORY_PROTECTION_PROFILES > DxeMemoryProtectionProfiles[DxeMemoryProtectionSettingsMax] = { > + { > +.Name= L"Debug", > +.Description = L"Development profile ideal for

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Thanks for sharing your inputs Jiewen. Dear TCG Experts, Can you please share your feedback on below proposals Thanks & Regards Karunakar Poosapalli Firmware Principal Engineer, Client BIOS Customer BIOS | Dell Core BIOS CPG Software Engineering | Dell Technologies Mobile +91 9951902957

Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support

Reviewed-by: Yuwei Chen > -Original Message- > From: Srinivasan, ManickamX > Sent: Wednesday, August 23, 2023 3:29 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX ; Feng, Bob C > ; Gao, Liming ; Chen, > Christine ; T V, Krishnamoorthy > > Subject: [PATCH] Platform/Intel:

Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support

Reviewed-by: Bob Feng -Original Message- From: Srinivasan, ManickamX Sent: Wednesday, August 23, 2023 3:29 PM To: devel@edk2.groups.io Cc: Srinivasan, ManickamX ; Feng, Bob C ; Gao, Liming ; Chen, Christine ; T V, Krishnamoorthy Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID

[edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- .../ComputerSystemCollectionDxe.c | 6 +++--- .../Features/MemoryCollectionDxe/MemoryCollectionDxe.c | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-)

[edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Readme.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/RedfishClientPkg/Readme.md b/RedfishClientPkg/Readme.md index 18a27633cf45..0aec0580aa5c 100644 --- a/RedfishClientPkg/Readme.md +++ b/RedfishClientPkg/Readme.md

[edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write.

Signed-off-by: Mike Maslenkin --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 6 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable.

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index

[edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 .../Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemDxe.c| 4 RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 4 3 files changed, 12 insertions(+) diff --git

[edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable

This patch fixes access to uninitialized variable, causing ASSERT from FreePool at least. Before this patch RedfishSettingsResponse was initialized by GetResourceByUri under 'if (JsonValue != NULL)' condition. But freed under 'if (Private->Payload != NULL)' condition. Thus uninitialized pointers

[edk2-devel] [PATCH v2 0/6] RedfishClientPkg: fix issues with local variables.

This patchset contains fixes that resolve crashes while working with uninitialized variables and a number of fixes for leaked memory. Diff from v1: fixed uncrustify check fail for patch 3 added patch 6. Corresponding PR https://github.com/tianocore/edk2-redfish-client/pull/46 Cc: Abner Chang

Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables.

Hi Mike, Yes, if you don't mind, please send v2 patch set for community review. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 7:19 AM > To: devel@edk2.groups.io; Nickle Wang > Cc: abner.ch...@amd.com; ig...@ami.com > Subject: Re: