[edk2-devel] [PATCH 1/1] Maintainers.txt: Update maintainers list

From: Abner Chang - Add two entries of MdePkg and MdeModulePkg for manageability modules and files. - Add one entry of UefiCpuPkg AMD related files. Signed-off-by: Abner Chang Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Jian J Wang

[edk2-devel] [PATCH 0/1] Add new entries in Maintainers.txt

From: Abner Chang - Add entry of MdePkg for manageability industry standard C header files. - Add entry of MdeModulePkg for manageability modules and files. - Add entry of UefiCpuPkg for AMD implementation. This change will be merged with at least one steward and at lease one maintainer or

[edk2-devel] [PATCH] IntelFsp2Pkg\Tools\ConfigEditor: Added new USF config workstream support - Config Edit utility addition/changes.

This patch is to enable config editor to have a new feature that can load and view the configuration data of compiled VFR or HFR in form of YAML. This can help users to understand and track the configuration data when modifications are made. Running Configuration Editor: python ConfigEditor.py

[edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

With the fact that CSM is not supported, the request is to remove the cache setting for memory under 1MB. This can be treated as the missing part of legacy CSM deprecation. This patch only set the 0 to 9 and C to F as Write Back. A-B range is still uncacheable for VGA.

[edk2-devel] [PATCH v1 0/1] Enable EDK2 on StarFive VisionFive 2 board

Boot flow in VF2 using EDK2 as bootloader: BootROM -> U-Boot SPL -> OpenSBI -> EDK2 -> Linux -> OS Currently, we rely on U-Boot SPL to initialize DDR and load OpenSBI and EDK2 into DDR from multiple boot sources, including SD Card, eMMC, or QSPI Flash. Furthermore, our EDK2 code is capable of

[edk2-devel] [PATCH v1 6/6] StarFive/JH7110Pkg: Add JH7110 Silicon Package

From: mindachen1987 Cc: Sunil V L Co-authored-by: John Chew Signed-off-by: mindachen1987 --- Silicon/StarFive/JH7110Pkg/Include/IndustryStandard/JH7110.h | 24 +++ Silicon/StarFive/JH7110Pkg/JH7110Pkg.dec | 45 2 files changed, 69

[edk2-devel] [PATCH v1 5/6] StarFive/JH7110Pkg: Implement boot services memory allocation driver

Some DXE drivers such as MMC's DMA can only work with 32-bit addressing. So, EfiBootServicesData need to set within 32-bit range only. This is achieved by setting all EfiConventionalMemory to EfiBootServicesData before any memory allocations in the early stage of DXE. Cc: Sunil V L

[edk2-devel] [PATCH v1 4/6] StarFive/JH7110Pkg: Add PlatformBootManagerLib library

From: JohnChew For JH7110 with graphic console Cc: Sunil V L Co-authored-by: Yong Li Signed-off-by: John Chew --- Silicon/StarFive/JH7110Pkg/Library/PlatformBootManagerLib/PlatformBm.c | 1014

[edk2-devel] [PATCH v1 3/6] StarFive/JH7110Pkg: Add firmware volume block protocol

Support for efi variable to store in QSPI flash Cc: Sunil V L Signed-off-by: John Chew --- Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.c | 909 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/FvbDxe/FvbDxe.h | 138 +++

[edk2-devel] [PATCH v1 2/6] StarFive/JH7110Pkg: Add SPI protocol and driver support

Cc: Sunil V L Signed-off-by: John Chew --- Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.c | 893 Silicon/StarFive/JH7110Pkg/Driver/SpiFvbServicesDxe/SpiDxe/SpiDxe.h | 188 +

[edk2-devel] [PATCH v1 1/6] StarFive/JH7110Pkg: Add Pci controller driver

From: mindachen1987 Cc: Sunil V L Co-authored-by: John Chew Signed-off-by: mindachen1987 --- Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 249 Silicon/StarFive/JH7110Pkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 48 +

[edk2-devel] [PATCH v1 0/6] Patches for JH7110 SoC platform

In this patches it include all the platform specific drivers/protocol that is being use for JH7110 SoC platform. All the drivers includes: 1. PCIE driver for NVME and USB (GT710 graphic in progress) 2. QSPI Flash driver for efi variable 3. FVB driver for efi variable 4. Boot service memory

[edk2-devel] [PATCH v1 4/4] DesignWare/DwEmmcDxe: Add handling for SDMMC

From: mindachen1987 Add base address PCD for eMMC and SDMMC Add application command for SDMMC Add PCD for Ultra High Speed (UHS) option Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sunil V L Cc: Li Yong Co-authored-by: John Chew Signed-off-by: mindachen1987 ---

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Ignore TAB in string input

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Li, Oscar Sent: Monday, September 18, 2023 3:26 PM To: devel@edk2.groups.io Cc: Li, Oscar ; Chiang, Dakota ; Bi, Dandan ; Dong, Eric Subject: [PATCH v1] MdeModulePkg: Ignore TAB in string input From: Oscar Li REF:

[edk2-devel] [PATCH v1 2/4] DesignWare/DwEmmcDxe: Add CPU little endian option

From: mindachen1987 Add PCD for little endian CPU. During RX, the endianess of data receive via DMA will be swap. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sunil V L Cc: Li Yong Co-authored-by: mindachen1987 Signed-off-by: John Chew --- Silicon/Synopsys/DesignWare/DesignWare.dec

[edk2-devel] [PATCH v1 3/4] DesignWare/DwEmmcDxe: Remove ARM dependency library

From: mindachen1987 This driver do not have dependency on ArmLib. It will cause compilation error when compile with risv architecture. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sunil V L Cc: Li Yong Signed-off-by: mindachen1987 ---

[edk2-devel] [PATCH v1 1/4] DesignWare/DwEmmcDxe: Enabled Internal IDMAC interrupt RX/TX register

From: mindachen1987 Remove DMA enable in CTRL register Added DMA polling handling for RX/TX Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sunil V L Cc: Li Yong Co-authored-by: John Chew Signed-off-by: mindachen1987 --- Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmc.h| 6 +++

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, October 19, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, October 19, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH v1 0/4] Designware MMCDXE changes and enhancement

This patch series involves the following changes: 1. Remove DMA enable in CTRL register 2. Added DMA polling handling for RX/TX 3. Integrate SD MMC handling into the driver Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sunil V L Cc: Li Yong mindachen1987 (4): DesignWare/DwEmmcDxe: Enabled

[edk2-devel] Question about OvmfPackage cxl emulation support

Hi, I findd qemu supports cxl emulation, but it uses seabios as virtual machine firmware. Does UEFI OvmfPackage have a plan to support CXL device enumeration and declaration? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH v3 2/2] StandaloneMmPkg: Arm: Update to use the new StandaloneMmCpu driver

Hi Sami, Not sure if you can merge this series or let me know who can do it. Thanks, From: Sami Mujawar Date: Thursday, October 5, 2023 at 4:12 AM To: Tuan Phan , devel@edk2.groups.io Cc: ardb+tianoc...@kernel.org , ray...@intel.com , huangm...@linux.alibaba.com , suni...@ventanamicro.com ,

[edk2-devel] [PATCH] OvmfPkg/VirtioFsDxe: tolerate opening an abs. pathname rel. to a reg. file

Referring to a file relative to a regular file makes no sense (or at least it cannot be implemented consistently with how a file is referred to relative to a directory). VirtioFsSimpleFileOpen() has enforced this strictly since the beginning, and a few months ago I reported USWG Mantis ticket

Re: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error

Reviewed-by: Rebecca Cran On 9/22/23 00:47, Yuwei Chen wrote: As the error is changed to warning, Trim.py will skip the build error when the source code have exactly issue. This patch change warning to error to opens the checking. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

Thanks! I've found some issues with the current PLDM code, I hope I will get back with complete feedback on how to make everything work by Friday. I was also thinking about the response buffer interface in the MctpProtocol/PldmProtocols. Currently the caller should provide the response buffer

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

On 10/18/23 15:44, Ard Biesheuvel wrote: > On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek wrote: >> >> On 10/12/23 11:10, Laszlo Ersek wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >>> >>> The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly >>> declares a function

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

On 10/18/23 17:15, Sami Mujawar wrote: > Hi Laszlo, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/10/2023, 14:42, "Laszlo Ersek" > wrote: > > > Hi Sami, > > > On 10/12/23 14:33, Sami Mujawar wrote: >> Hi Laszlo, >> >>

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

Hi Laszlo, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 18/10/2023, 14:42, "Laszlo Ersek" mailto:ler...@redhat.com>> wrote: Hi Sami, On 10/12/23 14:33, Sami Mujawar wrote: > Hi Laszlo, > > Thank you for this patch. > These changes look good to me. > >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 15:13, Gerd Hoffmann wrote: > Hi, > >>> - if (!VirtioFsFile->IsDirectory) { >>> + if (!VirtioFsFile->IsDirectory && FileName[0] != '\\') { > >> It's nice to see this topic pop up on edk2-devel; apparently you started >> testing shim on top of virtio-fs. :) > > Indeed. For

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, October 19, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, October 19, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

Dear Maintainers, Just a friendly reminder to ask if you could take a look at my patch. I'd really appreciate your feedback and help. Thank you! =) -Original Message- From: YuinYee Chew Sent: Friday, September 29, 2023 9:35 PM To: 'Heinrich Schuchardt' Cc: Sunil V L ; Li Yong ; Leif

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

Hi Laszlo, Thank you for your comments. I will commit a new patch to add the maintainers to the "Maintainers.txt" file in the root directory of the edk2-platforms project. Please let us know if you have more suggestions. Thanks, Yuqing Cai At 2023-10-18 17:47:04, "Laszlo Ersek"

[edk2-devel] [PATCH v1 1/1] MdePkg ACPI65: Add 0x0B/Platform Runtime Mechanism (PRM) in Address Space ID of Generic Address Structure (GAS)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4567 ACPI_Spec_6_5_Aug29 Table 5.1, add 0x0B/Platform Runtime Mechanism (PRM) in Address Space ID of Generic Address Structure (GAS) Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Jinlong Xu --- MdePkg/Include/IndustryStandard/Acpi65.h

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Wednesday, October 18, 2023 9:08 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout **CAUTION: The

Re: [edk2-devel] [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message

Thanks for the review, Liming Gao. Any further comments on this change? Thanks, Jake From: gaoliming Sent: Saturday, October 7, 2023 1:05 AM To: Jake Garver ; devel@edk2.groups.io Cc: michael.d.kin...@intel.com ; zhiguang@intel.com Subject: 回复: [PATCH v2]

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

W dniu 18.10.2023 o 15:36, Laszlo Ersek pisze: EDK2 expects some random version of uncrustify. It is not part of BaseTools so I use upstream version. And it looks like they format in different way using the same config file. Project URL (to clone and build):

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 15:08, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 13:33, Pedro Falcato wrote: >>> On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: On 10/18/23 12:33, Gerd Hoffmann wrote: > VirtiofsDxe throws an error in case the

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On 10/18/23 14:21, Sunil V L wrote: > On Wed, Oct 18, 2023 at 02:11:17PM +0200, Laszlo Ersek wrote: >> On 10/18/23 13:21, 蔡雨晴 wrote: >>> Hi Laszlo, >>> >>> Thank you for your comments. I will commit a new patch to add the >>> maintainers to the "Maintainers.txt" file in the root directory of the

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek wrote: > > On 10/12/23 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > > declares a function called LibRtcVirtualNotifyEvent(). No component

Re: [edk2-devel] [PATCH 0/5] EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib class

On 10/12/23 11:10, Laszlo Ersek wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > declares a function called LibRtcVirtualNotifyEvent(). No component ever > calls this function across module boundaries; all

Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent

Hi Sami, On 10/12/23 14:33, Sami Mujawar wrote: > Hi Laszlo, > > Thank you for this patch. > These changes look good to me. > > Reviewed-by: Sami Mujawar > > Tested by booting a Linux guest using Kvmtool guest firmware > (ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64. > Tested-by: Sami Mujawar

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, October 18, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce >

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On 10/18/23 13:28, Marcin Juszkiewicz wrote: > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: >> On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz >> wrote: >>> >>> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3

Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

On 10/18/23 13:55, Yuanhao Xie wrote: > With the fact that CSM is not supported, > the request is to remove the cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. > > This patch only set the 0 to 9 and C to F as Write Back. >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

Hi, > > - if (!VirtioFsFile->IsDirectory) { > > + if (!VirtioFsFile->IsDirectory && FileName[0] != '\\') { > It's nice to see this topic pop up on edk2-devel; apparently you started > testing shim on top of virtio-fs. :) Indeed. For starters just passed the host /boot/efi into the guest to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: > > On 10/18/23 13:33, Pedro Falcato wrote: > > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > >> > >> On 10/18/23 12:33, Gerd Hoffmann wrote: > >>> VirtiofsDxe throws an error in case the caller tries to open a file or > >>> directory

[edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout

Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe driver. The SendReceiveTimeout is hard-code value in Redfish discover driver. With this PCD, platform owner can configure timeout value easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy ---

[edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR

190: Device (PCI0) Warning 3073 - Multiple types ^ (Device object requires either a _HID or _ADR, but not both) PCI Firmware specification does not require _ADR for Host bridges. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 1 - 1 file changed, 1

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On Wed, Oct 18, 2023 at 02:11:17PM +0200, Laszlo Ersek wrote: > On 10/18/23 13:21, 蔡雨晴 wrote: > > Hi Laszlo, > > > > Thank you for your comments. I will commit a new patch to add the > > maintainers to the "Maintainers.txt" file in the root directory of the > > edk2-platforms project. > > > >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 13:33, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 12:33, Gerd Hoffmann wrote: >>> VirtiofsDxe throws an error in case the caller tries to open a file or >>> directory using an handle with is not a directory, claiming that opening >>>

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On 10/18/23 13:21, 蔡雨晴 wrote: > Hi Laszlo, > > Thank you for your comments. I will commit a new patch to add the > maintainers to the "Maintainers.txt" file in the root directory of the > edk2-platforms project. > > Please let us know if you have more suggestions. I do have one, but it's not

[edk2-devel] [PATCH edk2-platforms v5 4/4] SbsaQemu: disable XHCI in DSDT if not present

We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Set DSDT node to be disabled so operating system will not try to initialize not-existing hardware. Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v5 3/4] SbsaQemu: initialize XHCI only if it exists

We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c| 49 +++- 1 file changed, 27 insertions(+), 22

[edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

With the fact that CSM is not supported, the request is to remove the cache setting for memory under 1MB. This can be treated as the missing part of legacy CSM deprecation. This patch only set the 0 to 9 and C to F as Write Back. A-B range is still uncacheable for VGA. M:

[edk2-devel] [PATCH edk2-platforms v5 1/4] SbsaQemu: introduce macro to compare platform version

We want to check "if platver < 0.3" in an easy way. Signed-off-by: Marcin Juszkiewicz --- .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 1 file changed, 25 insertions(+) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h

[edk2-devel] [PATCH edk2-platforms v5 0/4] Provide XHCI USB controller only for newer hardware

Platform version 0.3 introduced XHCI USB controller instead of EHCI one. But we did it in a way that there is no in-EDK2 check for platform version (XHCI is always given). This behaviour works with Linux as it complains about being unable to initialize EHCI and goes on. Free/Net/Open BSD systems

[edk2-devel] [PATCH edk2-platforms v5 2/4] SbsaQemu: add AcpiLib

It will be needed for playing with disabling XHCI later. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc index 36723e21d7b5..1e650350cb63

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On Wed, Oct 18, 2023 at 12:28 PM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: > > On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz > > wrote: > >> > >> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > >>> Acked-by: Nhi Pham > >>> > >>> Nit: I think you want to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > > On 10/18/23 12:33, Gerd Hoffmann wrote: > > VirtiofsDxe throws an error in case the caller tries to open a file or > > directory using an handle with is not a directory, claiming that opening > > something relative to a file does not make

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz wrote: W dniu 18.10.2023 o 12:32, Nhi Pham pisze: Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3 as well :) Done, will check other changes too. I have a strong

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 12:32, Nhi Pham pisze: > > Acked-by: Nhi Pham > > > > Nit: I think you want to run uncrustify for Patch 3 as well :) > > Done, will check other changes too. > > I have a strong feeling that Qemu part of EDK2 needs

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

On 10/18/23 12:33, Gerd Hoffmann wrote: > VirtiofsDxe throws an error in case the caller tries to open a file or > directory using an handle with is not a directory, claiming that opening > something relative to a file does not make sense. > > The claim is correct, but the code throws errors for

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

W dniu 18.10.2023 o 12:32, Nhi Pham pisze: Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3 as well :) Done, will check other changes too. I have a strong feeling that Qemu part of EDK2 needs a bit bigger patch when it comes to formatting:

[edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

VirtiofsDxe throws an error in case the caller tries to open a file or directory using an handle with is not a directory, claiming that opening something relative to a file does not make sense. The claim is correct, but the code throws errors for both relative and absolute paths. Add a check to

Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

Acked-by: Nhi Pham Nit: I think you want to run uncrustify for Patch 3 as well :) Regards, Nhi On 10/18/2023 5:07 PM, Marcin Juszkiewicz wrote: We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Set

Re: [edk2-devel] [PATCH edk2-platforms v3 1/4] SbsaQemu: introduce macro to compare platform version

W dniu 18.10.2023 o 10:46, Ard Biesheuvel pisze: I don't mind adding this here but it is slightly unidiomatic so I'd like Leif's take on this too. ... and it also lacks a s-o-b line Oops. Added in local copy. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present

W dniu 18.10.2023 o 10:47, Ard Biesheuvel pisze: Nit: EDK2 Coding Style says that you need a space before (. Ah, right. forgot to crucify the source. Is it necessary to handle the result of Status? EDK2 is full of handling Status on touching ACPI tables. So I followed. Can you just do

[edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Set DSDT node to be disabled so operating system will not try to initialize not-existing hardware. Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v4 3/4] SbsaQemu: initialize XHCI only if it exists

We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c| 47 +++- 1 file changed, 25 insertions(+), 22

[edk2-devel] [PATCH edk2-platforms v4 2/4] SbsaQemu: add AcpiLib

It will be needed for playing with disabling XHCI later. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc index 36723e21d7b5..1e650350cb63

[edk2-devel] [PATCH edk2-platforms v4 0/4] Provide XHCI USB controller only for newer hardware

Platform version 0.3 introduced XHCI USB controller instead of EHCI one. But we did it in a way that there is no in-EDK2 check for platform version (XHCI is always given). This behaviour works with Linux as it complains about being unable to initialize EHCI and goes on. Free/Net/Open BSD systems

[edk2-devel] [PATCH edk2-platforms v4 1/4] SbsaQemu: introduce macro to compare platform version

We want to check "if platver < 0.3" in an easy way. --- .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 1 file changed, 25 insertions(+) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h

Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document.

On 10/13/23 05:03, caiyuqing...@163.com wrote: > diff --git a/Platform/Sophgo/Maintainers.md b/Platform/Sophgo/Maintainers.md > new file mode 100644 > index ..4cb32c359a31 > --- /dev/null > +++ b/Platform/Sophgo/Maintainers.md > @@ -0,0 +1,105 @@ > +##Project Name: EDK2 Sophgo SG2042 >

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On Wed, 18 Oct 2023 at 10:49, YuinYee Chew wrote: > > Dear Maintainers, > > Just a friendly reminder to ask if you could take a look at my patch. I'd > really appreciate your feedback and help. > Thanks for the reminder. I don't have time to review this myself but I'm happy to merge it if

Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return

On Tue, 17 Oct 2023 at 00:55, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > > > Looks like this is still waiting to be merged by an ArmPkg maintainer. > > Thanks for the reminder Really queued up now > > On 6/29/23 14:46, Jeff Brasen wrote: > > Add EFI_NOT_READY return if the CPU can

Re: [edk2-devel] [PATCH edk2-platforms v3 4/4] SbsaQemu: disable XHCI in DSDT if not present

On Wed, 18 Oct 2023 at 07:56, Marcin Juszkiewicz wrote: > > W dniu 18.10.2023 o 05:28, Nhi Pham pisze: > > Hi Marcin, > > > > There is a nitpicking below. > > > > Other than, it looks good to me. > > > > Acked-by: Nhi Pham > > > >>

Re: [edk2-devel] [PATCH edk2-platforms v3 1/4] SbsaQemu: introduce macro to compare platform version

On Wed, 18 Oct 2023 at 10:45, Ard Biesheuvel wrote: > > On Tue, 17 Oct 2023 at 15:23, Marcin Juszkiewicz > wrote: > > > > We want to check "if platver < 0.3" in an easy way. > > --- > > .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 > > > > 1 file changed, 25

Re: [edk2-devel] [PATCH edk2-platforms v3 1/4] SbsaQemu: introduce macro to compare platform version

On Tue, 17 Oct 2023 at 15:23, Marcin Juszkiewicz wrote: > > We want to check "if platver < 0.3" in an easy way. > --- > .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 > > 1 file changed, 25 insertions(+) > > diff --git >

Re: [edk2-devel] [PATCH edk2-platforms v5 0/7] EDK2 on RISC-V Sophgo SG2042 platform

For the series, Acked-by: Sunil V L On Fri, Oct 13, 2023 at 11:01:09AM +0800, caiyuqing...@163.com wrote: > From: caiyuqing379 > > Description: > Deploy EDK2 to run on 64-core CPU under RISC-V architecture, and > successfully boot to OS. > Implementation can be seen at: > >