Re: [edk2-devel] [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance

2023-10-26 Thread Ni, Ray
Please ignore my comments. That's an existing file for IA32 build. Your patch adds a NULL instance for all archs. Thanks, Ray From: Ni, Ray Sent: Friday, October 27, 2023 1:54 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu,

Re: [edk2-devel] [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance

2023-10-26 Thread Ni, Ray
TdxLibNull.c is missing in the patch. Thanks, Ray From: Tan, Dun Sent: Friday, October 27, 2023 1:42 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Ni, Ray Subject: [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance Create

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-10-26 Thread Ni, Ray
I am not sure which driver is responsible for producing the ACPI tables. + Foster Thanks, Ray From: Yoshinoya Sent: Friday, October 27, 2023 9:29 AM To: devel@edk2.groups.io Cc: jonathan.came...@huawei.com ; Laszlo Ersek ; kra...@redhat.com ; Ni, Ray ;

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

2023-10-26 Thread Yao, Jiewen
HI Since this impact TDX and SEV, would you please let me know what kind of test you have done? Have you validated TDX and SEV before you submit the patch? Please describe that clearly in your patch description. Also please include AMD SEV reviewer in this patch series. Thank you Yao, Jiewen

Re: [edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv.

2023-10-26 Thread Ni, Ray
Wei, Thanks for fixing the 3 issues. Can you kindly separate the one patch to at least 2 patches? One patch is to fix minor issues. The other is to add support of nested uncompressed FV. Thanks, Ray From: Xu, Wei6 Sent: Friday, October 27, 2023 8:59 AM To:

[edk2-devel] [PATCH 7/7] MdePkg:remove BaseIoLibIntrinsicSev related code

2023-10-26 Thread duntan
Remove BaseIoLibIntrinsicSev related code in MdePkg. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ray Ni --- MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 -

[edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files

2023-10-26 Thread duntan
Use BaseIoLibIntrinsic.inf in dsc files. The BaseIoLibIntrinsic supports Tdx and sev now. The BaseIoLibIntrinsicSev will be removed in the following patches. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Ray Ni ---

[edk2-devel] [PATCH 5/7] OvmfPkg: Add CcProbeLib in PlatformInitLib.inf

2023-10-26 Thread duntan
PlatformInitLib uses the CcProbe API in MemDetect.c but doensn't add CcProbeLib in .inf LibraryClasses section. Add CcProbeLib to fix the build error. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Ray Ni ---

[edk2-devel] [PATCH 4/7] MdePkg:support Tdx and sev in BaseIoLibIntrinsic

2023-10-26 Thread duntan
Change IA32 and X64 arch source files for BaseIoLibIntrinsic to support Tdx and sev. Use IoFifoRead/Write API in IoLibFifo.c and the IoLibInternalTdx.c instead of IoFifoSev.nasm for BaseIoLibIntrinsic. With this change, BaseIoLibIntrinsic can also support Tdx guest and sev. Then the assembly code

[edk2-devel] [PATCH 3/7] MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c

2023-10-26 Thread duntan
Simplify IoRead/WriteFifo implement in IoLibFifo.c by repeatedly calling IoRead/Write API in C code. This can avoid calling assembly code to use string I/O instructions and avoid checking if sev feature is enabled. Then the code flow is simplified. Signed-off-by: Dun Tan Cc: Michael D Kinney

[edk2-devel] [PATCH 2/7] MdePkg: Add CcProbeLibNull and TdxLibNull implement

2023-10-26 Thread duntan
Add CcProbeLibNull and TdxLibNull implement in the MdeLibs.dsc.inc. The IoLib instance BaseIoLibIntrinsic will consume the two lib instance in the following patch. Add the two null instance in this file to avoid build failure. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Cc:

[edk2-devel] [PATCH 1/7] MdePkg: Create TdxLibNull.inf instance

2023-10-26 Thread duntan
Create null instance for TdxLib. The IoLib instance BaseIoLibIntrinsic.inf will consume the TdxLibNull to pass build. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ray Ni --- MdePkg/Library/TdxLib/TdxLibNull.inf | 21 + MdePkg/MdePkg.dsc

[edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

2023-10-26 Thread duntan
The goal is to have single BaseIoLibIntrinsic instance that can also used for sev and Tdx. In this patch set, string I/O instructions are deleted in IoRead/WriteFifo API. Then change the source file of BaseIoLibIntrinsic to also support Tdx and sev feature. So BaseIoLibIntrinsicSev and related

Re: [edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition in StdLib

2023-10-26 Thread Jayaprakash, N
Reviewed-by : Jayaprakash Nevara Regards, JP -Original Message- From: devel@edk2.groups.io On Behalf Of Jayaprakash, N Sent: Thursday, October 26, 2023 9:00 PM To: devel@edk2.groups.io Cc: Jayaprakash, N Subject: [edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition in

[edk2-devel] [PATCH 2/2] StandaloneMmPkg/Core: Consumes Standalone Mm Core Platform Hook Lib.

2023-10-26 Thread Xu, Wei6
Call platform hooks before and after invoking registered MMI handlers. Platform can perform specific tasks in the hooks. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Signed-off-by: Wei6 Xu --- StandaloneMmPkg/Core/StandaloneMmCore.c | 7 ++- StandaloneMmPkg/Core/StandaloneMmCore.h

[edk2-devel] [PATCH 1/2] StandaloneMmPkg: Add Standalone Mm Core platform hook lib.

2023-10-26 Thread Xu, Wei6
Add header file for the definition of StandaloneMmCorePlatformHookLib. Add NULL instance for StandaloneMmCorePlatformHookLib. This library class defines a set of platform hooks called by the Standalone Mm Core. With this library, platform can perform specific tasks before and after invoking

[edk2-devel] [PATCH 0/2] Add Platform Hook Lib into StandaloneMmCore

2023-10-26 Thread Xu, Wei6
This patch set is to add StandaloneMmCorePlatformHookLib into StandaloneMmCore. This library class defines a set of platform hooks called by the Standalone Mm Core. With this library, platform can perform specific tasks before and after invoking registered MMI handlers. We need this library to

[edk2-devel] [PATCH v3 2/5] StarFive/JH7110Pkg: Add SPI protocol and driver support

2023-10-26 Thread John Chew
This patch include QSPI driver and Flash driver protocol. QSPI driver: 1. Used indirect read/write 2. Master mode only 3. Require to setup qspi driver after located protocol 4. Require to free device if no longer needed 5. Support command read/write & data

[edk2-devel] [PATCH v3 3/5] StarFive/JH7110Pkg: Add firmware volume block protocol

2023-10-26 Thread John Chew
Support for efi variable to store in QSPI flash. This driver is responsible to initialize both QSPI and Flash driver. Firmware Volume(FV) Initialization: 1. Copy flash content into allocated shadow buffer (RAM) 2. Check FV header validity 3. If not valid, erase flash based

[edk2-devel] [PATCH v3 4/5] StarFive/JH7110Pkg: Add JH7110 Silicon Package

2023-10-26 Thread John Chew
From: mindachen1987 - Add a new JH7110 silicon package. - These files Contain platfrom specific Guids, PCDs and defines used for JH7110 SoC. Cc: Sunil V L Cc: Leif Lindholm Cc: Michael D Kinney Cc: Li Yong Co-authored-by: John Chew Signed-off-by: mindachen1987 ---

[edk2-devel] [PATCH v3 1/5] StarFive/JH7110Pkg: Add Pci controller driver

2023-10-26 Thread John Chew
From: mindachen1987 Implement Pci Host Bridge and Pci Segment driver: JH7110 SoC contains two PCI segment: - PCI Segment 0 (USB): 32-bit Memory: 0x3000_ ~ 0x3FFF_ 64-bit Memory: 0x9__ ~0x9_4000_ - PCI Segment 1 (NVME): 32-bit Memory: 0x3800_ ~ 0x37FF_

[edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform

2023-10-26 Thread John Chew
v3: - Combine "Add VisionFive 2 platform" patch series with "Patches for JH7110 SoC platform" patch series [Sunil] - Change commit message for [1/5], [4/5], [5/5] in this patch series [Sunil] v2: - Change PlatformBootManagerLib to:

Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

2023-10-26 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4957 > -Original Message- > From: Vivian Nowka-Keane > Sent: Thursday, October 26, 2023 2:08 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update > > Yes the sign-off

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 11/11] RedfishFeatureCoreDxe: add check for memory allocation failure

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2

Re: [edk2-devel] [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:51 AM > To: Chang, Abner > Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com > Subject: Re: [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments > > Caution: This

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg: Fix the failure to find uncompressed inner FV.

2023-10-26 Thread Xu, Wei6
Hi Laszlo, Thanks a lot for the review. I send review the patch v2 to fix: - memory leaks on error paths - missing object size checks before casting pointers to header types (https://edk2.groups.io/g/devel/message/110160) Regarding to 'unbounded recursion', I couldn't come up with a good

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg

2023-10-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Liming and Nate Please review this change, which removes duplicated IpmiCommandLib.h from IpmiFeaturePkg. This is also similar to the patch that removes IpmiCommandLib.h from ManageabilityPkg. Thanks Abner > -Original Message- > From:

Re: [edk2-devel] [PATCH v2 1/1] StarFive/VisionFive2: Add VisionFive 2 platform

2023-10-26 Thread John Chew
Hi Sunil, Actually, I submitted 3 series for ease of reviewing which are: 1. DesignWare MMC (5 patches) 2. JH7110 SoC (4 patches) 3. VisionFive 2 (1 patch) Ouh!! I misunderstood the guidelines. Let me correct the commit message in v3. v3 todo: 1. Update the following patch commit message:

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-10-26 Thread Yoshinoya
Hi, Thanks for reply! I download code from this git https://github.com/SayantaP-arm/edk2-platforms/ For this ARM edk2 sample package, it provided cxldxe driver which being executed after UEFI DXE PciBus enumeration finishes. This ppt (https://lpc.events/event/16/contributions/1254/)

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-10-26 Thread Yoshinoya
Hi, Thanks for reply! I download code from this git https://github.com/SayantaP-arm/edk2-platforms/ For this ARM edk2 sample package, it provided cxldxe driver which being executed after UEFI DXE PciBus enumeration finishes. This ppt (https://lpc.events/event/16/contributions/1254/) describes

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix some issues in function MmCoreFfsFindMmDriver.

2023-10-26 Thread Xu, Wei6
1. The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. When an inner FV is uncompressed, StandaloneMmCore will miss the FV and all the MM drivers in the FV will not be dispatched. Add checks for uncompressed inner FV to fix this issue. 2. If FileHeader is an

[edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv.

2023-10-26 Thread Xu, Wei6
V1: This patch is to fix the issue that StandaloneMmCore fails to detect uncompressed inner FV. PR: https://github.com/tianocore/edk2/pull/4943 V2: Based on V1, fix some other issues 1. Add Missing object size checks before casting pointers to header types a. InnerFvHeader =

[edk2-devel] [PATCH V1 2/2] OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA

2023-10-26 Thread sunceping
From: Ceping Sun REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572 According to section 3.2 of the [GHCI] document, if the result of MapGPA is "TDG.VP.VMCALL_RETRY", TDVF must retry mapping for pages in that region, starting with the GPA specified in R11. Reference: [GHCI]: TDX

[edk2-devel] [PATCH V1 1/2] OvmfPkg/BaseMemEncryptTdxLib: Add TdVmCallMapGPA

2023-10-26 Thread sunceping
From: Ceping Sun REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572 According to section 3.2 of the [GHCI] spec, if the return status is "TDG.VP.VMCALL_RETRY", TD must retry this operation for the pages in the region starting at the GPA specified in R11. Currently, TDVF has not handled

[edk2-devel] [PATCH V1 0/2] OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA

2023-10-26 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572 According to section 3.2 of the [GHCI] documentation, if the result is "TDG.VP.VMCALL_RETRY" for TDG.VP.VMCALL, TD must retry the mapping for the pages in the region starting at the GPA specified in r11. Currently, TDVF does not properly

[edk2-devel] [edk2-redfish-client][PATCH v2 10/11] RedfishFeatureCoreDxe: replace __FUNCTION__ with __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 11/11] RedfishFeatureCoreDxe: add check for memory allocation failure

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c index

[edk2-devel] [edk2-redfish-client][PATCH v2 08/11] RedfishClientPkg: fix pragma pack usage

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h index

[edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Mike Maslenkin
StrnCpyS accepts string length in characters, not in bytes. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 07/11] RedfishClientPkg: fix memory leak

2023-10-26 Thread Mike Maslenkin
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 05/11] RedfishClientPkg: reduce identation level by adding early return

2023-10-26 Thread Mike Maslenkin
This functions contain memory leaks. Less identation helps to solve this issues. Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 289 +- 1 file changed, 146 insertions(+), 143 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 06/11] RedfishClientPkg: fix memory leaks while applying feature settings

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 11 +++ 1 file changed, 11 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 04/11] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 30 +++ 1 file changed, 30 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 02/11] RedfishClientPkg: fix DEBUG macro arguments

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c

[edk2-devel] [edk2-redfish-client][PATCH v2 03/11] RedfishLib: remove redudant zeroing

2023-10-26 Thread Mike Maslenkin
Memory allocated by calloc() is filled with bytes of value zero. Signed-off-by: Mike Maslenkin --- .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c

[edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

2023-10-26 Thread Mike Maslenkin
This patchset contains fixes of wrong format and number of arguments passed to DEBUG macro. Also a number of memory leaks were fixed. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/52 Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike

[edk2-devel] [edk2-redfish-client][PATCH v2 01/11] RedfishClientPkg: fix format used for output __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index

Re: [edk2-devel] [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Mike Maslenkin
On Mon, Oct 2, 2023 at 5:56 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Saturday, September 30, 2023 5:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nick...@nvidia.com; > > ig...@ami.com; Mike

[edk2-devel] EDK II Release Planning: update content for edk2-stable202311

2023-10-26 Thread Laszlo Ersek
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#edk2-stable202311-tag-planning I've scanned the edk2 git commit range edk2-stable202308..f945b72331d7, and collected (and when necessary, closed/updated) TianoCore BZs. When TianoCore BZs were not available, I tried

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Laszlo Ersek
On 10/26/23 17:21, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 17:19, Laszlo Ersek wrote: >> >> On 10/26/23 16:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: On 10/10/23 09:43, Ard Biesheuvel wrote: > Thanks for looking into this - a cleanup was

Re: [edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

2023-10-26 Thread Pedro Falcato
On Thu, Oct 26, 2023 at 4:32 PM Jake Garver via groups.io wrote: > > In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, be sure to change the > opcode to ADRP. Prior to this change, we updated the address, but not > the opcode. > > This resolves an issue experienced when building a StandaloneMm

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

2023-10-26 Thread Laszlo Ersek
On 10/26/23 15:41, Laszlo Ersek wrote: > On 10/25/23 13:42, Yuanhao Xie wrote: >> Aim: >> - To solve the assertion that checks if CpuMpData->FinishedCount >> equals (CpuMpData->CpuCount - 1). The assertion arises from a timing >> discrepancy between the BSP's completion of startup signal checks

Re: [edk2-devel] [PATCH edk2-platforms v6 4/4] SbsaQemu: disable XHCI in DSDT if not present

2023-10-26 Thread Leif Lindholm
On Thu, Oct 26, 2023 at 19:33:52 +0200, Marcin Juszkiewicz wrote: > We need platform version to be at least 0.3 to have XHCI > in virtual hardware. On older platforms there is non-working > EHCI which we ignore. > > Set DSDT node to be disabled so operating system will not try > to initialize

[edk2-devel] [PATCH edk2-platforms v6 1/4] SbsaQemu: introduce macro to compare platform version

2023-10-26 Thread Marcin Juszkiewicz
We want to check "if platver < 0.3" in an easy way. Signed-off-by: Marcin Juszkiewicz --- .../IndustryStandard/SbsaQemuPlatformVersion.h | 25 1 file changed, 25 insertions(+) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuPlatformVersion.h

[edk2-devel] [PATCH edk2-platforms v6 4/4] SbsaQemu: disable XHCI in DSDT if not present

2023-10-26 Thread Marcin Juszkiewicz
We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Set DSDT node to be disabled so operating system will not try to initialize not-existing hardware. Signed-off-by: Marcin Juszkiewicz ---

[edk2-devel] [PATCH edk2-platforms v6 3/4] SbsaQemu: initialize XHCI only if it exists

2023-10-26 Thread Marcin Juszkiewicz
We need platform version to be at least 0.3 to have XHCI in virtual hardware. On older platforms there is non-working EHCI which we ignore. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c| 49 +++- 1 file changed, 27 insertions(+), 22

[edk2-devel] [PATCH edk2-platforms v6 2/4] SbsaQemu: add AcpiLib

2023-10-26 Thread Marcin Juszkiewicz
It will be needed for playing with disabling XHCI later. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc index 806651fc55a0..fa85bd8dab89

[edk2-devel] [PATCH edk2-platforms v6 0/4] Provide XHCI USB controller only for newer hardware

2023-10-26 Thread Marcin Juszkiewicz
Platform version 0.3 introduced XHCI USB controller instead of EHCI one. But we did it in a way that there is no in-EDK2 check for platform version (XHCI is always given). This behaviour works with Linux as it complains about being unable to initialize EHCI and goes on. Free/Net/Open BSD systems

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

2023-10-26 Thread jacopo . r00ta
In order to install the certificate I did something very naive: 1) I deployed an OS to the machine 2) Stored rootCA.der under /boot/efi/EFI/BOOT/ 3) Restarted the machine 4) press F2 and install the certificate as it was available in the storage 5) select HTTPS boot in the boot list. My nginx

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: PCI node in DSDT does not need _ADR

2023-10-26 Thread Leif Lindholm
On Wed, Oct 18, 2023 at 14:38:26 +0200, Marcin Juszkiewicz wrote: > 190: Device (PCI0) Warning 3073 - > Multiple types ^ (Device object requires either a _HID or _ADR, but not both) > > PCI Firmware specification does not require _ADR for Host bridges. > > Signed-off-by: Marcin Juszkiewicz

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

2023-10-26 Thread jacopo . r00ta
Hi Laszlo, First of all thank you very much for your reply! I'm using QEMU with OVMF. All the steps to reproduce this are: * generate the root key > > openssl genrsa -out rootCA.key 4096 * create and sign the root certificate > > openssl req -x509 -new -nodes -key rootCA.key -sha256 -days

Re: [edk2-devel] [PATCH edk2-platforms v5 4/4] SbsaQemu: disable XHCI in DSDT if not present

2023-10-26 Thread Leif Lindholm
Couple of minor comments on this patch, rest of set good to go: On Wed, Oct 18, 2023 at 13:55:41 +0200, Marcin Juszkiewicz wrote: > We need platform version to be at least 0.3 to have XHCI > in virtual hardware. On older platforms there is non-working > EHCI which we ignore. > > Set DSDT node to

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-10-26 Thread Laszlo Ersek
On 10/26/23 18:19, Laszlo Ersek wrote: > On 10/26/23 15:53, Neal Gompa wrote: >> From: Neal Gompa >> >> Currently, the ReadyToBoot event is only signaled when a formal Boot >> Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). >> >> However, the introduction of Platform Recovery

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

2023-10-26 Thread Laszlo Ersek
On 10/26/23 14:37, jacopo.r0...@gmail.com wrote: > Hi there, > > I was trying to HTTPs boot a virtual machine with the following scenario: > > 1) I have a self signed root CA /root.crt /and then I use it to sign > another self signed certificate /myip.crt /for the IP address X.X.X.X > 2) I have

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-10-26 Thread Laszlo Ersek
On 10/26/23 15:53, Neal Gompa wrote: > From: Neal Gompa > > Currently, the ReadyToBoot event is only signaled when a formal Boot > Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > > However, the introduction of Platform Recovery in UEFI 2.5 makes it > necessary to signal

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-10-26 Thread Leif Lindholm
On Thu, Oct 26, 2023 at 16:35:52 +0100, Leif Lindholm wrote: > On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote: > > From: Narinder Dhillon > > > > Current Marvell package structure makes it difficult to add new silicon > > packages that reuse common elements without creating

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

2023-10-26 Thread Laszlo Ersek
On 10/26/23 16:17, Jayaprakash, N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574 > > This commit is for processing the below PR on edk2-libc repo > https://github.com/tianocore/edk2-libc/pull/10 > The realpath function signature in stdlib of edk2-libc doesn't match > signature

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Laszlo Ersek
On 10/26/23 16:55, Ard Biesheuvel wrote: > On Thu, 26 Oct 2023 at 16:46, Julien Grall wrote: >> >> Hi, >> >> On 26/10/2023 15:21, Peter Maydell wrote: >>> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: On 10/10/23 09:43, Ard Biesheuvel wrote: > Thanks for looking into this - a

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-10-26 Thread Leif Lindholm
On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote: > From: Narinder Dhillon > > Current Marvell package structure makes it difficult to add new silicon > packages that reuse common elements without creating nested DEC files. > > This patch creates a new MarvellSiliconPkg folder

Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

2023-10-26 Thread Jayaprakash, N
Reviewed-by: Jayaprakash Nevara It's simple fix to align the function signature as per the standards. Regards, JP -Original Message- From: Jayaprakash, N Sent: Thursday, October 26, 2023 7:47 PM To: devel@edk2.groups.io Cc: Jayaprakash, N ; Rebecca Cran ; Kinney, Michael D ; Kloper,

[edk2-devel] [PATCH] BaseTools/GenFw: Change opcode when converting ADR to ADRP

2023-10-26 Thread Jake Garver via groups.io
In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, be sure to change the opcode to ADRP. Prior to this change, we updated the address, but not the opcode. This resolves an issue experienced when building a StandaloneMm image with stack protection enabled on GCC 10.5. This scenario generates an ADR

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Laszlo Ersek
On 10/26/23 16:46, Julien Grall wrote: > Hi, > > On 26/10/2023 15:21, Peter Maydell wrote: >> On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >>> On 10/10/23 09:43, Ard Biesheuvel wrote: Thanks for looking into this - a cleanup was overdue here. I will take a look in more detail

[edk2-devel] [edk2-libc Patch 0/1] fix missing nanf definition in StdLib

2023-10-26 Thread Jayaprakash, N
This patch fixes the issue of missing definition of nanf in StdLib. This has been extracted from the below PR submitted on edk2-libc. https://github.com/tianocore/edk2-libc/pull/9 Jayaprakash N (1): ek2-libc: fix missing nanf definition in StdLib StdLib/LibC/LibC.inf| 1 +

[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: fix missing nanf definition in StdLib

2023-10-26 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4576 File StdLib/Include/math.h:406 defines NAN constant as __nanf.__val. The problem is that __nanf is never defined. Fix is simple: define __nanf in similar way as __infinityf This fix has been provided through the below PR on edk2-libc repo

Re: [edk2-devel] [edk2-platforms PATCH v1 1/4] Silicon/Marvell: Retructure package

2023-10-26 Thread Leif Lindholm
Hi Nharinder, Apologies for delay in responding - this was sent out during UEFI plugfest, and then I brought home a cold from there. On Wed, Oct 11, 2023 at 10:53:20 -0700, ndhil...@marvell.com wrote: > From: Narinder Dhillon > > Current Marvell package structure makes it difficult to add new

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Ard Biesheuvel
On Thu, 26 Oct 2023 at 17:19, Laszlo Ersek wrote: > > On 10/26/23 16:21, Peter Maydell wrote: > > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: > >> On 10/10/23 09:43, Ard Biesheuvel wrote: > >>> Thanks for looking into this - a cleanup was overdue here. > >>> > >>> I will take a look in

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Laszlo Ersek
On 10/26/23 16:21, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: >> On 10/10/23 09:43, Ard Biesheuvel wrote: >>> Thanks for looking into this - a cleanup was overdue here. >>> >>> I will take a look in more detail later, but one thing that occurred >>> to me when

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/SbsaQemu: use non-deprecated BaseRngLibTimerLib

2023-10-26 Thread Leif Lindholm
On Mon, Oct 09, 2023 at 09:36:58 +0200, Marcin Juszkiewicz wrote: > During boot of debug build I noticed this message: > > Warning: This BaseRngTimerLib implementation will be deprecated. > Please use the MdeModulePkg implementation equivalent. > > Signed-off-by: Marcin Juszkiewicz

[edk2-devel] [PATCH v1 0/1] UefiPayloadPkg: Fix incorrect code on FIT function.

2023-10-26 Thread brucex . wang
From: "Brucex.Wang" v1: 1.MultiImage[Index] should be deleted if fv path of MultiImage[Index] not exist. 2.Remove redundant code. Brucex.Wang (1): UefiPayloadPkg: Fix incorrect code on Fit function. UefiPayloadPkg/Tools/MkFitImage.py | 2 ++ UefiPayloadPkg/UniversalPayloadBuild.py |

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Fix incorrect code on Fit function.

2023-10-26 Thread brucex . wang
From: "Brucex.Wang" 1. MultiImage[Index] should be deleted if fv path of MultiImage[Index] not exist. 2. Remove redundant code. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: BruceX Wang --- UefiPayloadPkg/Tools/MkFitImage.py | 2 ++

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Peter Maydell
On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: > On 10/10/23 09:43, Ard Biesheuvel wrote: > > Thanks for looking into this - a cleanup was overdue here. > > > > I will take a look in more detail later, but one thing that occurred > > to me when reading this overview is that having a separate

[edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

2023-10-26 Thread jacopo . r00ta
Hi there, I was trying to HTTPs boot a virtual machine with the following scenario: 1) I have a self signed root CA root.crt and then I use it to sign another self signed certificate myip.crt for the IP address X.X.X.X 2) I have an NGINX server configured to use SSL with the myip.crt

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Ard Biesheuvel
On Thu, 26 Oct 2023 at 16:46, Julien Grall wrote: > > Hi, > > On 26/10/2023 15:21, Peter Maydell wrote: > > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: > >> On 10/10/23 09:43, Ard Biesheuvel wrote: > >>> Thanks for looking into this - a cleanup was overdue here. > >>> > >>> I will take a

Re: [edk2-devel] [PATCH 0/9] ArmVirtPkg: support two PL011 UARTs

2023-10-26 Thread Julien Grall
Hi, On 26/10/2023 15:21, Peter Maydell wrote: On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote: On 10/10/23 09:43, Ard Biesheuvel wrote: Thanks for looking into this - a cleanup was overdue here. I will take a look in more detail later, but one thing that occurred to me when reading this

[edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard

2023-10-26 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574 This commit is for processing the below PR on edk2-libc repo https://github.com/tianocore/edk2-libc/pull/10 The realpath function signature in stdlib of edk2-libc doesn't match signature as per the standard definition of this function given

[edk2-devel] [edk2-libc Patch 0/1] realpath function signature doesn't match standard

2023-10-26 Thread Jayaprakash, N
This patch fixes the function signature of realpath to match with the standard defined signature. This patch bas been extracted from the below pull request raised on edk2-libc. https://github.com/tianocore/edk2-libc/pull/10 Jayaprakash N (1): ek2-libc: realpath function signature doesn't

[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-10-26 Thread Neal Gompa
From: Neal Gompa Currently, the ReadyToBoot event is only signaled when a formal Boot Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). However, the introduction of Platform Recovery in UEFI 2.5 makes it necessary to signal ReadyToBoot when a Platform Recovery boot loader runs

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

2023-10-26 Thread Laszlo Ersek
On 10/25/23 13:42, Yuanhao Xie wrote: > Aim: > - To solve the assertion that checks if CpuMpData->FinishedCount > equals (CpuMpData->CpuCount - 1). The assertion arises from a timing > discrepancy between the BSP's completion of startup signal checks and > the APs' incrementation of the

Re: [edk2-devel] [Patch V3] UefiCpuPkg/MpInitLib: Wait for all APs to finish initialization

2023-10-26 Thread Laszlo Ersek
On 10/25/23 13:42, Yuanhao Xie wrote: > Aim: > - To solve the assertion that checks if CpuMpData->FinishedCount > equals (CpuMpData->CpuCount - 1). The assertion arises from a timing > discrepancy between the BSP's completion of startup signal checks and > the APs' incrementation of the

Re: [edk2-devel] question about cxl device enumeration in pci bus driver

2023-10-26 Thread Jonathan Cameron via groups.io
On Thu, 26 Oct 2023 11:49:28 +0200 "Laszlo Ersek" wrote: > On 10/26/23 10:33, Gerd Hoffmann wrote: > > On Thu, Oct 26, 2023 at 10:36:35AM +0800, Yoshinoya wrote: > > > >> CXL Host Bridge / Root Port / Switch / Device enumeration / HDM Config, > >> maybe could be integrated into pci drivers

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-26 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy Reviewed the whole PATCH -Original Message- From: Nickle Wang Sent: Thursday, October 26, 2023 9:20 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-26 Thread Nickle Wang via groups.io
According to my experience, BIOS Redfish is usually the owner to handle Redfish task request, not the user to create task. So, I think that BIOS has no chance to read HTTP header in DELETE request/response. But from specification perspective, Redfish task URI can be returned in HTTP header in

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-26 Thread Igor Kulchytskyy via groups.io
You mean, for the Redfish task functionality other functions will be used? Thank you, Igor -Original Message- From: Nickle Wang Sent: Thursday, October 26, 2023 8:58 AM To: Igor Kulchytskyy ; Chang, Abner ; devel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3]

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-26 Thread Nickle Wang via groups.io
Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return HTTP header to caller so caller can get Task URI. But from BIOS Redfish perspective, I don't see this use case yet. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday,

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller

2023-10-26 Thread Igor Kulchytskyy via groups.io
Hi Nickle, Just one quick question. Is there any sense to return the headers for DELETE request? Thank you, Igor -Original Message- From: Chang, Abner Sent: Thursday, October 26, 2023 2:10 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL]

Re: [edk2-devel] [PATCH 1/2] MdePkg/Include: Definitions of IPMI Get System Interface Capabilities

2023-10-26 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Michael D > Kinney ; Liming Gao ; >

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Include: API of IPMI Get System Interface Capabilities

2023-10-26 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, October 10, 2023 4:36 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Jian J Wang > ; Liming Gao > Subject:

Re: [edk2-devel] [PATCH v2 11/11] DynamicTablesPkg: Remove check for _CPC field

2023-10-26 Thread Leif Lindholm
On Wed, Oct 25, 2023 at 13:25:40 +0200, pierre.gond...@arm.com wrote: > From: Pierre Gondois > > When generating _CPC objects, some fields are mandatory. Mandatory by spec or mandatory by current API? If the former, could we either warn or add a Pcd to enable the more lenient behaviour? /

Re: [edk2-devel] [PATCH v2 10/11] DynamicTablesPkg: Add ArmScmiInfoLib

2023-10-26 Thread Leif Lindholm
On Wed, Oct 25, 2023 at 13:25:39 +0200, PierreGondois wrote: > From: Pierre Gondois > > The SCP holds some power information that could be advertised > through the _CPC object. The communication with the SCP is done > through SCMI protocols (c.f. ArmScmiDxe). > > Use the SCMI protocols to query

  1   2   >