Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Nickle Wang ; Igor Kulchytskyy
>
> Subject: [PATCH 4/4] RedfishClientPkg: use Json
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Mike
> Maslenkin via groups.io
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Abner Chang
> ; Nickle Wang ; Igor Kulchytskyy
>
>
Hi Mike,
Thanks for incorporating my suggestion to address memory issue. For the name
"CollectionUri", I know this is from my suggestion, but I think Abner is right.
Could you please change it to "BiosUri" or "ResourceUri" since BIOS resource is
not a Redfish collection?
@Abner
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Igor Kulchytskyy
> ; Nickle Wang ; Abner Chang
>
> Subject: [PATCH 1/4]
On Tuesday, February 20, 2024 5:07 PM, Gerd Hoffmann wrote:
> Subject: [PATCH v3 0/6] OvmfPkg: Add support for 5-level paging
>
> Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a 5-level
> enabled build runs in 4-level paging mode.
>
> Patch #2 - #4 update OvmfPkg ResetVector,
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 3/5] UefiCpuPkg/MpInitLib: Add
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Zhou, Jianfeng
> Sent: Wednesday, February 21, 2024 9:25 AM
> To: devel@edk2.groups.io
> Cc: Zhou, Jianfeng ; Ni, Ray ;
> Laszlo Ersek ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH] UefiCpuPkg: add volatile qualifier
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Zhou, Jianfeng
> Sent: Wednesday, February 21, 2024 9:25 AM
> To: devel@edk2.groups.io
> Cc: Zhou, Jianfeng ; Ni, Ray ;
> Laszlo Ersek ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH] UefiCpuPkg: Fix IN OUT parameters
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Clark-williams, Zachary
> Sent: Tuesday, February 20, 2024 9:18 PM
> To: devel@edk2.groups.io
> Cc: Clark-williams, Zachary ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Liming Gao ;
> Dong, Eric
> Subject: [PATCH]
From: Zachary Clark-Williams
PhatAcpiLib update to match all file names to PhatAcpiLib
and add the library to CoreDxeLib for use.
Hsd-es-id: 22019504949
Change-Id: Ic184715a2b5ab117d464bad5cb251c674416e0dd
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by:
From: Michael Kubacki
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this creates an invalid path.
An example of when this may be an issue is in external dependencies
where an INF is within the
>
> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF);
Above formula assumes the maximum HOB length could be 0x.
But actually the maximum HOB length could be only 0xFFF8 because
PeiCore::PeiCreateHob() contains following
>
> Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
> covering all CPUs in the system.
>
> Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs
> are
The commit message may need to be updated as "HaveMpHandOff" variable is gone
in this version.
With that,
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 2/5] UefiCpuPkg/MpInitLib: Add
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 2/5] UefiCpuPkg/MpInitLib: Add
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add support for multiple
> HOBs to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
Bug 4689 - GetInfo() of Adapter Information Protocol
should have a provision for IHV to return no data for
UEFI Spec compliance 2.9 [mantis #1866]
Cc: Ray Ni
Signed-off-by: Gahan Saraiya
---
Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
Bug 4689 - GetInfo() of Adapter Information Protocol
should have a provision for IHV to return no data for
UEFI Spec compliance 2.9 [mantis #1866]
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Gahan
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Nickle Wang
> ; Chang, Abner ; Igor
> Kulchytskyy
> Subject: [PATCH 2/4] RedfishClientPkg: refine
>
[AMD Official Use Only - General]
Looks good, thank you!
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Chang, Abner
> ; Nickle Wang ; Igor
> Kulchytskyy
> Subject:
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Chang, Abner
> ; Nickle Wang ; Igor
> Kulchytskyy
> Subject: [PATCH 3/4]
[AMD Official Use Only - General]
One comment below,
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, February 21, 2024 8:13 AM
> To: devel@edk2.groups.io
> Cc: Mike Maslenkin ; Igor Kulchytskyy
> ; Nickle Wang ; Chang, Abner
>
> Subject: [PATCH 1/4]
[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> symbol issue
[AMD Official Use Only - General]
As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
[AMD Official Use Only - General]
As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
[AMD Official Use Only - General]
As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
[AMD Official Use Only - General]
One comment below.
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:41 PM
> To: devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Chang, Abner
> ; Nick Ramirez
> Subject: [PATCH 2/6] RedfishPkg: implement Redfish HTTP protocol
Hi Everyone,
It appears that a merge commit was introduced to edk2-non-osi due to a PR merge:
https://github.com/tianocore/edk2-non-osi/commit/61b65fccfe4c75bc9ecb7b542412a436e3db5de6
I would like to remind everyone that we generally don't accept submissions via
PRs yet. At the very least
[AMD Official Use Only - General]
As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, February 20, 2024 2:41 PM
> To: devel@edk2.groups.io
> Cc: Igor Kulchytskyy ; Chang, Abner
> ; Nick Ramirez
From: Zachary Clark-Williams
PhatAcpiLib update to match all file names to DxePhatAcpiLib
and add the library to CoreDxeLib for use.
Hsd-es-id: 22019504949
Change-Id: Ic184715a2b5ab117d464bad5cb251c674416e0dd
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by:
This patch replaces value Private->Json with Json used as second argument
for RedfishIdentifyResource(). Currently Json argument is not used at all
and the pattern for caller side is:
Status = RedfishIdentifyResourceCommon (Private, Private->Json);
So in scope of RedfishIdentifyResourceCommon
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
Use local variable for CollectionUri passed to HandleResource() to avoid
problems in case of Private->Uri is overriden down the call stack.
Suggested-by: Nickle Wang
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
This set contains a trivial fix for a leak reviewed on Feb 1 [1]
and a fix for а leak discussed in [2].
PR: https://github.com/tianocore/edk2-redfish-client/pull/76
[1] https://edk2.groups.io/g/devel/message/114925
[2] https://edk2.groups.io/g/devel/message/114765
Signed-off-by: Mike Maslenkin
On Tue, Feb 20, 2024 at 10:39 AM Gahan wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
>
> Bug 4689 - GetInfo() of Adapter Information Protocol
> should have a provision for IHV to return no data for
> UEFI Spec compliance 2.9 [mantis #1866]
Hi Gahan,
FYI, your commit
Hi Zack,
Usually we would like the LIBRARY_CLASS to be "phase agnostic" so we can share
the same API cross different phase implementation.
Please see if we only need to update DxePhatAcpiLib.inf LIBRARY_CLASS and add
INF to CoreCommon.dsc
Thanks,
Chasel
> -Original Message-
>
On 2/20/24 03:06, Gerd Hoffmann wrote:
Compile the OVMF ResetVector with 5-level paging support in case
PcdUse5LevelPageTable is TRUE.
When enabled the ResetVector will check at runtime whenever support for
5-level paging and gigabyte pages is available. In case both features
are supported it
Hi Ard,
I suspected this one BZ/patch would get some discussion.
This is an attempt to address the fundamental issue that we do not
get timely reviews of patches. When I look at the ones that are
delayed, in many cases, there are no Cc lines in the commit message
and no Cc in the email.
There
From: Zachary Clark-Williams
PhatAcpiLib update to match all file names to DxePhatAcpiLib
and add the library to CoreCommonPkg for use.
Change-Id: I6e18ecf5acfdbc2053cf60b9a151b891e4e0fdfe
Hsd-es-id: 22019504949
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by:
On 2/20/24 03:06, Gerd Hoffmann wrote:
When running in SEV mode do not uninstall the #vc handler in
CheckSevFeatures. Keep it active and uninstall it later in
SevClearPageEncMaskForGhcbPage.
This allows using the cpuid instruction in SetCr3ForPageTables64,
which is needed to check for la57 &
[AMD Official Use Only - General]
Hi Feng & Laszlo,
Thank you for the feedback, I have changed the title of this email and the
title of the commit message of this patch.
The new patch as attached. If this patch looks good to you, could you please
help to add reviewed-by?
Thanks!
Regards,
Neo
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:48 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH 2/2] Update Maintainers for Intel packages
>
> Update
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:47 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
> Subject: [PATCH 1/2] Add maintainers for EaglestreamSiliconBinPkg and
>
As mentioned by Mike K, please add [edk2-non-osi] to the subject line in the
future.
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:48 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
>
As mentioned by Mike K, please add [edk2-non-osi] to the subject line in the
future.
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Haller, Nathaniel D
> Sent: Friday, February 16, 2024 5:47 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Chiu, Chasel
>
>
On 2/20/24 18:45, Laszlo Ersek wrote:
> (I'm using quotes around "subroutines" and "call" because we don't have
> a stack at this point yet, IIUC, so all our "one time calls" are
> actually just normal jumps, with some NASM macro magic. That's fine,
> we're only talking a handful of assembly
Add support for splitting Hand-Off data into multiple HOBs. This is
required for VMs with thousands of CPUs. The actual CPU count per HOB
is much smaller (128) for better test coverage.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 44 +++--
1
Rename the MpHandOff parameter to FirstMpHandOff. Add a loop so the
function inspects all HOBs present in the system.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git
Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
covering all CPUs in the system.
Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs are
present, using the MpHandOff pointer for that does not work because the
variable will be NULL after looping over all HOBs.
Rename the function to GetNextMpHandOffHob(), add MP_HAND_OFF parameter.
When called with NULL pointer return the first HOB, otherwise return the
next in the chain.
Also add the function prototype to the MpLib.h header file.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/MpLib.h
Needed to boot guests with thousands of vcpus.
v2:
- rework HOB loops for better performance: O(n) instead of O(n^2).
Gerd Hoffmann (5):
UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob
UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetBspNumber()
Rename the MpHandOff parameter to FirstMpHandOff. Add loops so the
function inspects all HOBs present in the system.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
UefiCpuPkg/Library/MpInitLib/MpLib.c | 35 ++--
2 files changed, 24
On 2/20/24 10:06, Gerd Hoffmann wrote:
> Compile the OVMF ResetVector with 5-level paging support in case
> PcdUse5LevelPageTable is TRUE.
>
> When enabled the ResetVector will check at runtime whenever support for
> 5-level paging and gigabyte pages is available. In case both features
> are
This is a UEFI Driver that depends on the Driver Binding Protocol
and use of ConnectController(). These drivers cannot be used
until the BDS phase when the active consoles and boot devices
are evaluated and the smallest set of drivers required to boot
are connected.
It does not make sense to have
On 2/20/24 10:06, Gerd Hoffmann wrote:
> When running in SEV mode do not uninstall the #vc handler in
> CheckSevFeatures. Keep it active and uninstall it later in
> SevClearPageEncMaskForGhcbPage.
>
> This allows using the cpuid instruction in SetCr3ForPageTables64,
> which is needed to check
Thank you Samer.
The test case spec is consolidated and upstreamed by:
https://github.com/tianocore/edk2-test/commit/f999690054b56780f5efbe0999507d7176bd87f6
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115661):
On 2/20/24 04:41, Wu, Jiaxin wrote:
>> From C11 "5.1.2.4 Multi-threaded executions and data races":
>>
>> - paragraph 4: "Two expression evaluations conflict if one of them
>> modifies a memory location and the other one reads or modifies the same
>> memory location."
>>
>> - paragraph 25: "The
For the purpose of UEFI debug prints enablement in DXE phase,
Serial driver should load earlier. Separate .inf file is created
in order to make minimal changes to current implementation.
Signed-off-by: Alan Borzeszkowski
---
.../PciSioSerialDxe/PciSioSerialDxeEarly.inf | 80 +++
On Intel platforms, we use LPSS UART for debug prints in DXE phase. Current
implementation involves using custom driver.
In order to reduce code maintenance cost and flash usage, we want to switch to
EDK2 Serial driver.
To achieve that, we need to load Serial driver shortly after DXE Core is
Since ACPI SPCR table has been upgraded with new revision Rev-4,
SerialPortConsoleRedirectionTable.h file should be added with
new field members which are added in Rev-4.
Signed-off-by: Praveen Sankar N praveensank...@ami.com
To: praveensank...@ami.com
---
Reviewed-by: Gua Guo
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Tuesday, February 20, 2024 11:26 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Guo, Gua ;
Prakashan, Krishnadas Veliyathuparambil
; K N, Karthik
Subject: [PATCH v1 1/1]
From: Michael Kubacki
Resolves a new CodeQL error due to the value being incremented in the
loop being a narrower type than the variable it is being compared
against.
The variable is changed to a UINT32 type so it has the same width as
the type it is being compared against.
Issue explanation:
From: Michael Kubacki
Checks that an offset used to access array elements is within the
expected range before accessing the array item.
Cc: Liming Gao
Cc: Ray Ni
Cc: Rebecca Cran
Cc: Richard Ho
Signed-off-by: Michael Kubacki
---
MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
Hello Mike,
I understand the desire to be pedantic about cc'ing the right
maintainers, but I'm not convinced this is the way.
- the presence of a cc: tag does not guarantee that the person was
cc'ed - only git send-email will take CC:s in the message body into
account by default (but this can
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
Bug 4689 - GetInfo() of Adapter Information Protocol
should have a provision for IHV to return no data for
UEFI Spec compliance 2.9 [mantis #1866]
Cc: Ray Ni
Signed-off-by: Gahan Saraiya
---
Drivers/OptionRomPkg/UndiRuntimeDxe/Undi32.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
Bug 4689 - GetInfo() of Adapter Information Protocol
should have a provision for IHV to return no data for
UEFI Spec compliance 2.9 [mantis #1866]
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Gahan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4689
Bug 4689 - GetInfo() of Adapter Information Protocol
should have a provision for IHV to return no data for
UEFI Spec compliance 2.9 [mantis #1866]
Cc: Marcin Wojtas
Cc: Leif Lindholm
Signed-off-by: Gahan Saraiya
---
Adjust physical address space logic for la57 mode (5-level paging).
With a larger logical address space we can identity-map a larger
physical address space.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Laszlo Ersek
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 57 ++---
1 file
Add comments, rename some of the PAGE_* flags and combined attributes.
Specifically use "LARGEPAGE" instead of "2M" because that bit is used
for both 2M and 1G large pages.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Laszlo Ersek
---
OvmfPkg/ResetVector/Ia32/PageTables64.asm | 39
PcdUse5LevelPageTable documentation says:
Indicates if 5-Level Paging will be enabled in long mode. 5-Level
Paging will not be enabled when the PCD is TRUE but CPU doesn't support
5-Level Paging.
So running in 4-level paging mode with PcdUse5LevelPageTable=TRUE is
possible. The only
Compile the OVMF ResetVector with 5-level paging support in case
PcdUse5LevelPageTable is TRUE.
When enabled the ResetVector will check at runtime whenever support for
5-level paging and gigabyte pages is available. In case both features
are supported it will run OVMF in 5-level paging mode,
When running in SEV mode do not uninstall the #vc handler in
CheckSevFeatures. Keep it active and uninstall it later in
SevClearPageEncMaskForGhcbPage.
This allows using the cpuid instruction in SetCr3ForPageTables64,
which is needed to check for la57 & 1G page support.
Signed-off-by: Gerd
Rename Page5LevelSupported to Page5LevelEnabled.
The variable is set to true in case 5-paging level is enabled (64-bit
PEI) or will be enabled (32-bit PEI), it does *not* tell whenever the
5-level paging is supported by the CPU.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Laszlo Ersek
---
Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a
5-level enabled build runs in 4-level paging mode.
Patch #2 - #4 update OvmfPkg ResetVector, adding support for 5-level
paging (setup 5-level page tables in case both la57 and gigabyte pages
are supported by the vCPU).
Patch #5
On Tue, Feb 20, 2024 at 06:27:21AM +, Min Xu wrote:
> On Monday, February 12, 2024 11:22 PM, Gerd Hoffmann wrote:
> > On Thu, Feb 01, 2024 at 10:38:43AM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > > Can you confirm (a) this patch is OK for
> > > > > "OvmfPkg/IntelTdx/Sec/SecMain.c",
This is beacuse UEFI only allocates the first memory node memory space for
SbsaQemu platform, i refer to implemet of "OvmfPkg/Fdt/HighMemDxe" and add the
support for other memory nodes via GCD services. Maybe you can apply patch
"support multi memory nodes" together with this patch.
77 matches
Mail list logo
