This commit adds the initial support for BOSC's
nanhu platform which provides up to 2 RISC-V RV64
processor cores.
Signed-off-by: Yang Wang
Signed-off-by: Ran Wang
Signed-off-by: YunFeng Yang
Signed-off-by: YaXing Guo
Cc: Bamvor Jian ZHANG
Cc: Sunil V L
---
.../NanhuDev/DeviceTree.fdf.inc
Some feedback:
1) 0002-MdePkg-GHCB-APIC-ID-retrieval-support-definitions
MdePkg only contains the definition in the standard.
Question: Is EFI_APIC_IDS_GUID definition in some AMD/SVSM specification?
2) 0012-UefiCpuPkg-CcSvsmLib-Create-the-CcSvsmLib-library-to-support-an-SVSM
I am not sure
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Shang, Qingyu
> Sent: Monday, February 26, 2024 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen
> Subject: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function
> description
>
> Refer to Uefi spec 2.10 section
Thanks for the update.
First, would you please clarify which test you have done for this patch set.
Have you tested all previous function to ensure it still works?
Second, would you please clarify if there is any compatibility issue to follow
the new UEFI 2.10?
For example, what if the core HII
On 2/22/24 12:54, Gerd Hoffmann wrote:
> When running in SEV mode keep the VC handler installed.
> Add a function to uninstall it later.
>
> This allows using the cpuid instruction in SetCr3ForPageTables64,
> which is needed to check for la57 & 1G page support.
>
> Signed-off-by: Gerd Hoffmann
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Removes the GetSevCBitMaskAbove31 OneTimeCall because we need that twice
> (for 4-level and 5-level paging). Open code the single instruction left
> in that function instead.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/ResetVector/Ia32/AmdSev.asm
On 2/22/24 12:54, Gerd Hoffmann wrote:
> BSP workflow is quite simliar to the non-coco case.
>
> TDX_WORK_AREA_PGTBL_READY is used to record the paging mode:
> 1 == 4-level paging
> 2 == 5-level paging
>
> APs will look at TDX_WORK_AREA_PGTBL_READY to figure whenever
> they should enable
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/OvmfPkg/ResetVector/Ia32/PageTables64.asm
> b/OvmfPkg/ResetVector/Ia32/PageTables64.asm
> index
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Add macros to check for 5-level paging and gigabyte page support.
> Enable 5-level paging for the non-confidential-computing case.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/ResetVector/ResetVector.inf | 1 +
>
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Use separate control flows for SEV and non-CoCo cases.
>
> SevClearPageEncMaskForGhcbPage and GetSevCBitMaskAbove31 will now only
> be called when running in SEV mode, so the SEV check in these functions
> is not needed any more.
>
> No functional change.
Hi Tuan,
On Mon, Feb 26, 2024 at 08:34:22PM -0800, Tuan Phan wrote:
> Hi Sunil/ Andrei,
> Any comments on this series?
>
Did I miss your response to Laszlo's feedback on PATCH 2 - [1]? Apart
from that, don't we need to handle EFI_MEMORY_WT similar to
EFI_MEMORY_WC?
[1] -
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Create a separate control flow for TDX BSP.
>
> TdxPostBuildPageTables will now only be called when running in TDX
> mode, so the TDX check in that function is not needed any more.
>
> No functional change.
>
> Signed-off-by: Gerd Hoffmann
> ---
>
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Move code to create 4-level page tables to a nasm macro.
> No functional change.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 70 +--
> 1 file changed, 39 insertions(+), 31 deletions(-)
>
>
On 2/22/24 12:54, Gerd Hoffmann wrote:
> Move code to clear the page tables to a nasm macro.
> No functional change.
>
> Signed-off-by: Gerd Hoffmann
> ---
> OvmfPkg/ResetVector/Ia32/PageTables64.asm | 35 ---
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff
On 2/27/24 12:41, Gerd Hoffmann wrote:
> Move the WaitLoopExecutionMode and StartupSignalValue fields to a
> separate HOB with the new struct.
>
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++--
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
>
On 2/27/2024 10:43 PM, Laszlo Ersek wrote:
On 2/27/24 17:04, Michael Kubacki wrote:
Hi Gerd,
There is a way to suppress results explained here:
https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns
A real-world example is here:
On 2/27/24 12:41, Gerd Hoffmann wrote:
> Move the WaitLoopExecutionMode and StartupSignalValue fields to a
> separate HOB with the new struct.
>
> Signed-off-by: Gerd Hoffmann
> ---
> UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++--
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
>
On 2/27/24 17:04, Michael Kubacki wrote:
> Hi Gerd,
>
> There is a way to suppress results explained here:
> https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns
>
> A real-world example is here:
>
In last patch, we add code support to unregister MMI handler inside
itself. However, the code doesn't support unregister MMI handler
insider other MMI handler. While this is not a must-have usage.
So add check to disallow unregister MMI handler in other MMI handler.
Cc: Liming Gao
Cc: Jiaxin Wu
To support unregister MMI handler inside MMI handler itself,
get next node before MMI handler is executed, since LIST_ENTRY that
Link points to may be freed if unregister MMI handler in MMI handler
itself.
Cc: Liming Gao
Cc: Jiaxin Wu
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Sami
In last patch, we add code support to unregister SMI handler inside
itself. However, the code doesn't support unregister SMI handler
insider other SMI handler. While this is not a must-have usage.
So add check to disallow unregister SMI handler in other SMI handler.
Cc: Liming Gao
Cc: Jiaxin Wu
This patch set is to support to unregister SMI handler inside SMI handler,
also add check to not allow unregister SMI handler in other SMI handler.
This patch set also have the same logic in StandaloneMmPkg.
Because no change on the first patch, I kept the R-B for it.
Zhiguang Liu (4):
To support unregister SMI handler inside SMI handler itself,
get next node before SMI handler is executed, since LIST_ENTRY that
Link points to may be freed if unregister SMI handler in SMI handler
itself.
Cc: Liming Gao
Cc: Jiaxin Wu
Reviewed-by: Ray Ni
Reviewed-by: Laszlo Ersek
[AMD Official Use Only - General]
Hi Nickle,
As this change is in the autogenerate source files. We have to update the
script here: https://github.com/DMTF/Redfish-Schema-C-Struct-Generator
Not sure if you have access to this repo, however I am pleased inviting you to
update the script on DMTF
edk2-basetools is finally fixed and releases can once again be published
to PyPI.
However, in moving from setup.py to pyproject.toml the process has
changed, and Joey suggested the old way might have been chosen
deliberately to be different from edk2-pytool-library and
Reviewed-by: Zhichao Gao
> -Original Message-
> From: gaoliming
> Sent: Monday, February 26, 2024 9:33 PM
> To: Lou, Yun ; devel@edk2.groups.io
> Cc: Gao, Zhichao
> Subject: 回复: [PATCH v4 2/2] ShellPkg/SmbiosView: Support New
> ProcessorFamily for SMBIOS Type4
>
> Reviewed-by: Liming
Thanks. Not sure how I missed that.
I will refresh the series/PR and make sure there are no issues.
Mike
> -Original Message-
> From: Pedro Falcato
> Sent: Tuesday, February 27, 2024 3:56 PM
> To: devel@edk2.groups.io; Kinney, Michael D
>
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Oliver
Merged as 3e91e421365027ee3e655feab33c67a4f544c777.
--
Rebecca Cran
On 2/6/24 00:02, Jayaprakash N wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4666
This commit fixes the issue reported through BZ4666.
The Syntax warning related to invalid escape sequence
for \C is seen on
On Tue, Feb 27, 2024 at 11:46 PM Michael D Kinney
wrote:
>
> Hi Pedro,
>
> Looks like this series got set aside waiting for some additional feedback.
Hi,
This is odd, I did reply back in June
(https://edk2.groups.io/g/devel/message/105817). You probably missed
the email or maybe for some
Hi Pedro,
Looks like this series got set aside waiting for some additional feedback.
I would like to see this C++ Keyword issue resolved.
Thanks,
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, June 6, 2023 10:57 AM
> To: Pedro Falcato
> Cc:
edk2-basetools v0.1.50 has just been published so we're back up and running.
I'll work my way through the backlog of BaseTools changes in the next
few days.
--
Rebecca Cran
On 2/24/24 13:59, Laszlo Ersek wrote:
v1 posting:
https://edk2.groups.io/g/devel/message/115193
msgid
ImagePropertiesRecordLib is currently creating Image Records that
are not accurate. It is setting the CodeSegmentSize to be the size
of the raw data in the image file, however, when the image is
loaded into memory, the raw data size is aligned to the
section alignment. This caused the memory
Merged as
dae8c29dab546fad2801e70967855a9f6ae14ae0...6d571c0070161b1b96049410f8584c0955d73536
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
REF:
For the series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
* Reject patches that match Author email "devel@edk2.groups.io"
* Update the current check for " via Groups.Io" to perform a
Merged as e59a40b92ce92f17e3d8d99917868c5678d408b7.
--
Rebecca Cran
On 2/12/2024 10:41 AM, Leif Lindholm via groups.io wrote:
On Sun, Feb 11, 2024 at 16:10:32 -0700, Rebecca Cran wrote:
I'm guessing there haven't been any reviews because so few people are
familiar with the PRACTICE scripting
Is the idea to refactor PciSioSerialDxe to extract functions that access the HW
and wrap it in the SerialPortLib instance? That solution would still save us
some maintenance cost. However exploring the idea further I see following
problems:
1. Relying on driver binding produces a fairly nice
Hi Gerd,
There is a way to suppress results explained here:
https://github.com/tianocore/edk2/tree/master/BaseTools/Plugin/CodeQL#filter-patterns
A real-world example is here:
https://github.com/microsoft/mu_basecore/blob/release/202311/CodeQlFilters.yml
That can currently operate at the
Hello Abdul,
From the HPET spec:
"""
For the case where there may be additional Event Timer Blocks implemented in
the system, their base
addresses would be described in ACPI Name space.
"""
So it seems it might be good (but not necessary) to to add a description in
a SSDT/DSDT table of the
Hello Abdul,
I reviewed this patch first, so comments here may apply to other patches.
---
AcpiView (ShellPkg/Library/UefiShellAcpiViewCommandLib) doesn't seem
to be able to parse this ACPI table. Maybe a parser could also be added
along with the table generation.
On 2/20/24 07:48, Abdul
Hello Abdul,
There is an ongoing effort to open the package a bit more to other
architectures (https://edk2.groups.io/g/devel/message/114790).
This patch seems to duplicate some objects from the Arm namespace:
- EArmObjPowerManagementProfileInfo
- EArmObjBootArchInfo
to the Arch namespace:
-
On 2/27/24 04:18, Gerd Hoffmann wrote:
On Thu, Feb 22, 2024 at 11:29:46AM -0600, Tom Lendacky wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The SNP_PAGE_STATE_MAX_ENTRY is based on the number of entries that can
fit in the GHCB shared buffer. As a result, the
Reviewed-by: Rebecca Cran
On 2/20/2024 9:22 PM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this creates an invalid path.
An
On 2/27/2024 1:33 AM, Michael D Kinney wrote:
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Monday, February 26, 2024 8:39 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Joey Vagedes
; Kinney, Michael D
Subject: [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Sunday, February 25, 2024 9:44 PM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C
Structure DXE
Reviewed-by: Igor Kulchytskyy
Reviewed the whole patch v3.
Regards,
Igor
-Original Message-
From: Nickle Wang
Sent: Monday, February 26, 2024 7:44 PM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nick
Ramirez
Subject: [EXTERNAL] [PATCH v3 0/6] Introduce Redfish http
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Sunday, February 25, 2024 11:55 PM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy ; Mike
Maslenkin
Subject: [EXTERNAL] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify
On 27.02.24 07:37, Chao Li wrote:
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a
bug, code:
SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof
(DNS_DEVICE_PATH)));
DNS is a pointer, which is increased by a structure size and converted
to EFI_IPv4_ADDRESS*, which will
On 2/27/24 09:44, Gerd Hoffmann wrote:
> On Thu, Feb 15, 2024 at 09:24:41AM +0100, Laszlo Ersek wrote:
>>
>> Reviewed-by: Laszlo Ersek
>>
>> This series is now ready for merging, as far as I'm concerned (thanks
>> for the updates in the other patches too, I've re-checked them). Please
>> send a
Apologies for the delay.
Merged as 74b5309da9fb..ba9c3ceaf83d
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116042): https://edk2.groups.io/g/devel/message/116042
Mute This Topic:
Hi Liming,
can you please check the first two patches in the series? They should be
easy to review.
Thanks!
Laszlo
On 2/22/24 11:54, Gerd Hoffmann wrote:
> Patch #1 + #2 fix MdeModulePkg/DxeIplPeim to not assert in case a
> 5-level enabled build runs in 4-level paging mode.
>
> Patch #3
Check and see if JSON object type is desired type before
getting its value. According to the Redfish schema, attribute
value can be null value. Add this error handling to avoid
system assertion while getting attribute value.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc:
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
Add the following sentence at the end of the Image parameter
description. "May be NULL with a zero ImageSize in order to determine
the size of the buffer needed".
Modify the description of "EFI_INVALID_PARAMETER" return code as "The
ImageSize is
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
Add the following sentence at the end of the Image parameter
description. "May be NULL with a zero ImageSize in order to determine
the size of the buffer needed".
Modify the description of "EFI_INVALID_PARAMETER" return code as "The
ImageSize is
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
Add the following sentence at the end of the Image parameter
description. "May be NULL with a zero ImageSize in order to determine
the size of the buffer needed".
Modify the description of "EFI_INVALID_PARAMETER" return code as "The
ImageSize is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4651
In FirmwarePerformanceCommonEntryPoint there is a MmLocateProtocol
which will locate the gEfiMmRscHandlerProtocolGuid and then
ASSERT_EFI_ERROR(Status) if the locate protocol fails when build is
debug enabled.
if the build is debug
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4696
>
> Refer to the [GHCI] spec, TDVF should clear the BIT5 for RBP in the mask.
> And TDVF should clear the regitsers to avoid leaking secrets to VMM.
>
> Reference:
> [GHCI]: TDX Guest-Host-Communication Interface v1.5
>
On 2/27/24 07:28, Ni, Ray wrote:
> Thank you, Laszlo!
> The changes you made look good to me.
>
> By the way, is the following a common way to call out additional changes?
>> +[ler...@redhat.com: define one local variable per line [Ray]]
I don't know of any other project that uses it.
I
On 2/27/24 05:49, Sivaraman Nainar wrote:
> Hi Laszlo,
>
> We can see the issue not only with SLES, it can be seen with Ubuntu 22 also.
>
> Do we have any channel to work with grub team to fix this issue?
No particular channel. Oliver has been participating in upstream grub2
development (CC'd),
On Thu, Feb 22, 2024 at 11:29:52AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> The MpInitLib library will be updated to use the new CcSvsmLib library.
> To prevent any build breakage, update the UefiPayloadPkg DSC file to
> include the CcSvsmLib NULL
On Thu, Feb 22, 2024 at 11:29:51AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> In order to support an SEV-SNP guest running under an SVSM at VMPL1 or
> lower, a new CcSvsmLib library must be created.
>
> This library includes an interface to detect if
On Thu, Feb 22, 2024 at 11:29:50AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> The SVSM specification relies on a specific register calling convention to
> hold the parameters that are associated with the SVSM request. The SVSM is
> invoked by
Move the WaitLoopExecutionMode and StartupSignalValue fields to a
separate HOB with the new struct.
Signed-off-by: Gerd Hoffmann
---
UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++--
UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
UefiCpuPkg/Library/MpInitLib/MpLib.c | 38
Hi,
> I am hoping we can work together to improve the overall quality of the
> code and minimize the number of CodeQL alerts.
Seems CodeQL now runs as part of CI and flags issues it has found.
It complains about a possible NULL pointer dereference:
On Thu, Feb 22, 2024 at 11:29:48AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> When building the Page State Change entries for a range of memory, it can
> happen that multiple calls to BuildPageStateBuffer() need to be made. If
> the size of the input
> --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c
> +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c
> @@ -23,6 +23,8 @@ STATIC BOOLEAN mAddressEncMaskChecked = FALSE;
> STATIC UINT64 mAddressEncMask;
> STATIC PAGE_TABLE_POOL
Add support for
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
.../IndustryStandard/UefiTcgPlatform.h| 186 +-
1 file changed, 184 insertions(+), 2
Update Spdm.h to support 1.2 new features, such as:
Authentication and measurement. It wil be used in DeviceSecurity.
The DeviceSecurity feature is from
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Update Spdm.h to support 1.2 new features,
such as: Authentication and measurement.
It wil be used in DeviceSecurity.
The DeviceSecurity is from
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by:
The patch is upstreamed through the commit:
https://github.com/tianocore/edk2-test/commit/cabb98d44be94e7547605435a0be7c4946d10f8b
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116022): https://edk2.groups.io/g/devel/message/116022
Mute
On Thu, Feb 22, 2024 at 11:29:46AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> The SNP_PAGE_STATE_MAX_ENTRY is based on the number of entries that can
> fit in the GHCB shared buffer. As a result, the SNP_PAGE_STATE_CHANGE_INFO
> structure maps the
On Thu, Feb 22, 2024 at 11:29:45AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> Calculate the amount of memory that can be use to build the Page State
> Change data (SNP_PAGE_STATE_CHANGE_INFO) instead of using a hard-coded
> size. This allows for
On Thu, Feb 22, 2024 at 11:29:44AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> In prep for follow-on patches, fix an area of the code that does not meet
> the uncrustify coding standards.
>
> Signed-off-by: Tom Lendacky
Reviewed-by: Gerd Hoffmann
On Thu, Feb 22, 2024 at 11:29:43AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> Currently, the first time an AP is started for an SEV-SNP guest, it relies
> on the VMSA as set by the hypervisor. If the list of APIC IDs has been
> retrieved, this is not
Hi,I found smm code privilege switch sample code in project mu.For example :
switch ring0 to ring3 through tss gate call.So, is there any plan to introduce
it to udk smm sample code?
Thanks
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
On Thu, Feb 22, 2024 at 11:29:42AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> If the hypervisor supports retrieval of the vCPU APIC IDs, retrieve
> them before any APs are actually started. The APIC IDs can be used
> to start the APs for any SEV-SNP
On Fri, Feb 23, 2024 at 12:16:54AM +, Ni, Ray wrote:
>
> > +//
> > +// Get APIC IDs
> > +//
> > +#define EFI_APIC_IDS_GUID \
> > + { 0xbc964338, 0xee39, 0x4fc8, { 0xa2, 0x24, 0x10, 0x10, 0x8b, 0x17, 0x80,
> > 0x1b }}
> > +extern EFI_GUID gEfiApicIdsGuid;
>
> Since the above GUID is
On Thu, Feb 22, 2024 at 11:29:40AM -0600, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
>
> The AsmRmpAdjust() function returns a UINT32, however in SevSnpIsVmpl0()
> the return value is checked with EFI_ERROR() when it should just be
> compared to 0. Fix the error
Hi Edhay,
OK, thank you!
Thanks,
Chao
On 2024/2/27 17:19, G Edhaya Chandran wrote:
Hi Li Chao,
As per the maintenance process, I will raise a PR on your behalf
based on your patch.
And will later close your PR.
With Warm Regards,
Edhay
*From:* Chao Li
*Sent:* Tuesday, February 27,
Hi Li Chao,
As per the maintenance process, I will raise a PR on your behalf based on
your patch.
And will later close your PR.
With Warm Regards,
Edhay
From: Chao Li
Sent: Tuesday, February 27, 2024 1:34 PM
To: devel@edk2.groups.io; G Edhaya Chandran
Subject: Re: [edk2-devel]
On Thu, Feb 15, 2024 at 09:24:41AM +0100, Laszlo Ersek wrote:
>
> Reviewed-by: Laszlo Ersek
>
> This series is now ready for merging, as far as I'm concerned (thanks
> for the updates in the other patches too, I've re-checked them). Please
> send a reminder after the stable tag.
Friendly
Current DSC files contains a lot of files which are
specific to X86 arch. Need to move around files under
arch specific sections.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval Sharma
Reviewed-by: Gua Guo
---
Notes:
v1:
- Updated RB tab
Current DSC files contains a lot of files which are
specific to X86 arch. Need to move around files under
arch specific sections.
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval Sharma
Dhaval (1):
UefiPayloadPkg: Make Dsc accomodative of other archs
Hi Edhaya,
Thanks for you review, I have created a PR on Github:
https://github.com/tianocore/edk2-test/pull/87
Thanks,
Chao
On 2024/2/27 15:50, G Edhaya Chandran wrote:
Hi Li Chao, Thank you for the solution.
Reviewed OK.
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
83 matches
Mail list logo
