Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

2024-03-07 Thread Laszlo Ersek
On 3/7/24 23:00, Tuan Phan wrote: > > > On Mon, Mar 4, 2024 at 10:01 AM Laszlo Ersek > wrote: > > On 3/2/24 00:20, Tuan Phan wrote: > > Thanks for the detailed review. Please see my comments below. > > > > On Fri, Mar 1, 2024 at 4:14 AM Laszlo Ersek

[edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-07 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds WSMT parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++ .../Parsers/Wsmt/WsmtParser.c

[edk2-devel] [PATCH v2 1/2] ShellPkg/Acpiview: Adds HPET parser

2024-03-07 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds HPET parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++ .../Parsers/Hpet/HpetParser.c

[edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

2024-03-07 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar PR : https://github.com/tianocore/edk2/pull/5449 Adds HPET and WSMT parser for acpiview. V2 delta changes: Addressed review comments. Added validation functions as per the comments. Cc: Zhichao Gao Cc: Pierre Gondois Abdul Lateef Attar (2): ShellPkg/Acpiview:

Re: [edk2-devel] [PATCH v1 1/2] ShellPkg/Acpiview: Adds HPET parser

2024-03-07 Thread Abdul Lateef Attar via groups.io
Thanks Pierre for review, I'll address the review comment and submit the V2 patch. On 07-03-2024 16:07, Pierre Gondois wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hello Abdul, With the

Re: [edk2-devel] [PATCH v3 2/3] UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension

2024-03-07 Thread Tuan Phan
On Mon, Mar 4, 2024 at 10:01 AM Laszlo Ersek wrote: > On 3/2/24 00:20, Tuan Phan wrote: > > Thanks for the detailed review. Please see my comments below. > > > > On Fri, Mar 1, 2024 at 4:14 AM Laszlo Ersek > > wrote: > > > > On 3/1/24 02:29, Tuan Phan wrote: > >

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, March 7, 2024 #cal-notice

2024-03-07 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, March 7, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com (

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, March 7, 2024 #cal-reminder

2024-03-07 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, March 7, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com (

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

2024-03-07 Thread Laszlo Ersek
On 3/7/24 10:04, joeyli via groups.io wrote: > Hi Laszlo, > > On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: >> On 3/4/24 12:37, joeyli via groups.io wrote: >>> Hi, >>> >>> On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: On Wed, Feb 07, 2024 at 03:55:49PM

Re: [edk2-devel] [PATCH v1 1/2] ShellPkg/Acpiview: Adds HPET parser

2024-03-07 Thread PierreGondois
Hello Abdul, With the comments resolved: Reviewed-by: Pierre Gondois On 3/5/24 12:12, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds HPET parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar ---

Re: [edk2-devel] [PATCH v1 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parser

2024-03-07 Thread PierreGondois
Hello Abdul, I just have one comment, with that: Reviewed-by: Pierre Gondois On 3/5/24 12:12, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds WSMT parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar ---

Re: [edk2-devel] [PATCH v2 08/10] IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl

2024-03-07 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek Sent: Thursday, March 7, 2024 5:10 AM To: edk2-devel-groups-io Cc: S, Ashraf Ali ; Chiu, Chasel ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted

Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

2024-03-07 Thread Laszlo Ersek
On 3/7/24 07:11, Liu, Zhiguang wrote: > Hi Laszlo, > > We talked about how to unregister SMI handler inside other SMI handler. > And the conclusion was there is no such usage so we don't need support it. > However, I find some platform does need to unregister SMI handler inside > other SMI

Re: [edk2-devel] [PATCH] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date again

2024-03-07 Thread joeyli via groups.io
Hi Laszlo, On Tue, Mar 05, 2024 at 09:53:33AM +0100, Laszlo Ersek wrote: > On 3/4/24 12:37, joeyli via groups.io wrote: > > Hi, > > > > On Wed, Feb 07, 2024 at 04:02:52PM +0800, joeyli via groups.io wrote: > >> On Wed, Feb 07, 2024 at 03:55:49PM +0800, joeyli wrote: > >>> Hi Laszlo, > >>> > >>>

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

2024-03-07 Thread Gerd Hoffmann
On Tue, Mar 05, 2024 at 12:38:33PM +0100, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442