[edk2-devel] [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT

2024-03-31 Thread duntan
Change AcpiProcessorUid in CpuApicIdOrderTable to the index in MpService regardless of disabled core. Let's take a simple example: There are 2 enabled cores and 1 disabled core. APICID Index in MpService 0x_0 0x_0010(disbaled) 1 0x_0040

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-03-31 Thread John Chew
Hi Michael, Thanks for the tool recommendation. However, the tools are useful for x86, arm, and IPF platforms. I'm working on a RISC-V platform. I wanted to compile the tools for RISC-V, but the link is not found:

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-03-31 Thread John Chew
On Sat, Mar 30, 2024 at 06:10 AM, Andrew Fish wrote: > > You can make a ReadOnly file system out of contents on an FV (Firmware > Volume): > https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Universal/FvSimpleFileSystemDxe > > FV is defined in the PI Spec as a layout for flash that

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

2024-03-31 Thread Aaron Li
Hi Liming, Could you please help review and merge it? Thanks. Best, Aaron -Original Message- From: Liu, Zhiguang Sent: Monday, April 1, 2024 10:06 AM To: Li, Aaron ; devel@edk2.groups.io Cc: Bi, Dandan ; Liming Gao ; Liu, Yun Y ; Yao, Jiewen ; Ni, Ray ; Kinney, Michael D Subject:

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

2024-03-31 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu > -Original Message- > From: Li, Aaron > Sent: Tuesday, March 26, 2024 3:58 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Bi, Dandan > ; Liming Gao ; Liu, Yun Y > ; Yao, Jiewen ; Ni, Ray > ; Kinney, Michael D > Subject: [PATCH v2 1/1]

Re: [edk2-devel] [PATCH v2 0/3] CryptoPkg/BaseCryptLib: add additional RSAES-OAEP crypto functions

2024-03-31 Thread Li, Yi
Appreciate your efforts in optimization of unit test, for this patch set: Looks good to me. Reviewed-by: Yi Li -Original Message- From: devel@edk2.groups.io On Behalf Of Chris Ruffin via groups.io Sent: Sunday, March 31, 2024 6:00 AM To: devel@edk2.groups.io Cc: Chris Ruffin Subject:

Re: [edk2-devel] [edk2-redfish-client][PATCH V5 1/2] RedfishClientPkg: Set SettingsObject URI as the config language

2024-03-31 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Mike, Just letting you know that I merged this patch set to clean up the backlogs. I believe your comment was addressed in V5. Just let me know if you still find any improper code. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type

2024-03-31 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Saturday, March 30, 2024 1:23 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu >

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, April 1, 2024 #cal-reminder

2024-03-31 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, April 1, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform

2024-03-31 Thread Sami Mujawar
Merged as  344be33d497d..b64443f7b8c3 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117268): https://edk2.groups.io/g/devel/message/117268 Mute This Topic: https://groups.io/mt/104862625/21656 Group

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform

2024-03-31 Thread Sami Mujawar
Hi Prabin, I am going to drop patch 7/9 that adds the SMBIOS support, and merge the remaining series. Please fix patch 7/9 and send it as a separate patch that adds SMBIOS support for RD-Fremont. Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: Changes since V4: -

Re: [edk2-devel] [edk2-platforms][PATCH v5 9/9] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI specification. The implementation uses AMU registers accessible as

Re: [edk2-devel] [edk2-platforms][PATCH v5 8/9] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: RD-Fremont platform supports two LPI states, LPI1 (Standby WFI) and LPI3 (Power-down). The cluster supports LPI2 (Power-down) state.

Re: [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support for RD-Fremont platform

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: The RD-Fremont fixed virtual platform simulates 16 CPUs and 8GB of RAM. Add initial support for this platform by adding the required

Re: [edk2-devel] [edk2-platforms][PATCH v5 5/9] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: From: Shriram K RD-Fremont is the next platform in the Arm's reference design platform series. This platform includes 32 CPUs but

Re: [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: In preparation of adding the next generation of reference design platform that have different memory map, refactor the

Re: [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. Minor, EDKII does not have u32 and u64 types, otherwise  these changes look good to me. I will reword the commit message before merging. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: From: Vivek Gautam On

Re: [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: The reference design platform currently lacks the CPPC (Collaborative Processor Performance Control) performance limited register as

Re: [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-03-31 Thread Sami Mujawar
I am going to fix this locally before merging. With that, Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117259): https://edk2.groups.io/g/devel/message/117259 Mute This Topic:

Re: [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. This patch does not cleanly apply on the latest edk2-platforms master branch. Can you check, please? Regards, Sami Mujawar On 11/03/2024 01:14 pm, Prabin CA wrote: Extend the SMBIOS support for RD-Fremont platform. RD-Fremont is a 16 core platform with

Re: [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. On Mon, Mar 11, 2024 at 06:14 AM, Prabin CA wrote: > > #define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS = > \ > - ((14 + (FixedPcdGet32 (PcdChipCount) * 2)) + = > \ > + ((13 + (FixedPcdGet32 (PcdChipCount) * 2)) + = > \ > + (FeaturePcdGet (PcdPcieEnable)) + = > \

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-03-31 Thread Sami Mujawar
Merged patches 1 to 4 as 7c26299112f3..344be33d497d. Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117256): https://edk2.groups.io/g/devel/message/117256 Mute This Topic:

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/6] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform

2024-03-31 Thread Sami Mujawar
Hi Prabin, To me the RD-V2 support appears to be incomplete (or the required information is not clear). Therefore, instead of stalling the entire series, I am going to drop patch 5/6 and 6/6 and merge the remaining patches. Please reply back to my queries for patch 5/6 and send a separate

Re: [edk2-devel] [edk2-platforms][PATCH v5 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-03-31 Thread Sami Mujawar
Hi Prabin, Thank you for this patch. On Fri, Mar 1, 2024 at 08:30 AM, Prabin CA wrote: > > Add RD-V2 platform identification values including the part number > and configuration number. This information will be used in populating > the SMBIOS tables. In the cover letter you mention the