agleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc -t GCC5
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek
Reviewed-by: Ard Biesheuvel
> ---
> Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +-
On Mon, 4 Mar 2024 at 18:49, Oliver Smith-Denny
wrote:
>
> Hi Ard,
>
> On 3/1/2024 3:58 AM, Ard Biesheuvel wrote:
> > Hi Oliver,
> >
> > On Tue, 27 Feb 2024 at 21:27, Oliver Smith-Denny
> > wrote:
> >>
> >> When an ImageRe
uplicate it at multiple places.
>
> Can you let me know if I can merge this patch, please?
>
I have no problems with that, please go ahead.
Acked-by: Ard Biesheuvel
I will note that we will have to clean this up in the future, though:
the architected GIC pieces should not be p
emitting sections
either using a non-1:1 file:memory mapping, or with unallocated holes
in the file representation?
> Cc: Liming Gao
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Taylor Beebe
>
> Signed-off-by: Oliver Smith-Denny
> ---
> MdeModulePkg/Lib
On Wed, 21 Feb 2024 at 23:16, Laszlo Ersek wrote:
>
> On 2/20/24 15:48, Ard Biesheuvel wrote:
> > Hello Mike,
> >
> > I understand the desire to be pedantic about cc'ing the right
> > maintainers, but I'm not convinced this is the way.
> >
> > - th
On Wed, 21 Feb 2024 at 16:05, Michael D Kinney
wrote:
>
> Hi Ard,
>
> I disagree. We have never allowed a force push to the main
> branch of TianoCore repos. This has happened before and
> was discussed and the policy is to not fix. Even the edk2
> repo has some merge commits in its history
Update guard commit message, comments, and static assert to use
> the correct types
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Liming Gao
>
> Oliver Smith-Denny (3):
> MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
> MdeModulePkg: D
mfPkg/PlatformInitLib: add 5-level paging support
>
I'm fine with all this but I haven't looked in great detail, so
Acked-by: Ard Biesheuvel
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115726): https://edk2.groups.io/g/devel/
On Wed, 21 Feb 2024 at 02:49, Nate DeSimone
wrote:
>
> Hi Everyone,
>
> It appears that a merge commit was introduced to edk2-non-osi due to a PR
> merge:
>
> https://github.com/tianocore/edk2-non-osi/commit/61b65fccfe4c75bc9ecb7b542412a436e3db5de6
>
> I would like to remind everyone that we
Hello Mike,
I understand the desire to be pedantic about cc'ing the right
maintainers, but I'm not convinced this is the way.
- the presence of a cc: tag does not guarantee that the person was
cc'ed - only git send-email will take CC:s in the message body into
account by default (but this can
gle commit. Not the entire PR.
> 2) The information about what CI checks to skip are part of the
>commit message and the commit history so the information can be
>reused if needed in downstream CI.
> 3) The information is in the commit message, so it is available for both
>PR CI checks and 'push' CI checks.
> 4) No new behavi
On Fri, 16 Feb 2024 at 15:20, Laszlo Ersek wrote:
>
> On 2/15/24 14:45, Rebecca Cran wrote:
> > On 2/15/2024 4:28 AM, Laszlo Ersek wrote:
> >> mail-archive.com is an important secondary archive because it offers
> >> message-id-based lookup. "git am --message-id" captures patch email
> >> message
On Thu, 15 Feb 2024 at 20:55, Oliver Smith-Denny
wrote:
>
> On 2/14/2024 11:50 PM, Ard Biesheuvel wrote:
> > I looked at the EFI spec again, and EfiACPIReclaimMemory is not
> > actually listed as a memory type that has this 64k alignment
> > requirement. This makes sense
On Thu, 15 Feb 2024 at 18:08, Oliver Smith-Denny
wrote:
>
> On 2/14/2024 11:50 PM, Ard Biesheuvel wrote> On Thu, 15 Feb 2024 at
> 01:34, Oliver Smith-Denny
> > wrote >> This could also be fixed with
> > rearchitecting the heap guard system to
> >> r
;
> A patchset for Juno-r2 platforms will be submitted to demonstrate
> this functionality.
>
> [1] https://edk2.groups.io/g/devel/message/111901
>
> Pierre Gondois (11):
> ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION
> ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL s
On Mon, 22 Jan 2024 at 03:34, Nhi Pham via groups.io
wrote:
>
> From: Laszlo Ersek
>
> The current dependency evaluator violates the memory access permission
> when patching depex grammar directly in the read-only depex memory area.
>
> Laszlo pointed out the optimization issue in the thread (1)
eInterrupts(), which also sets both
> flags).
>
> Tested by patching ArmPkg's TimerDxe to use NestedInterruptTplLib and
> verifying that ArmVirtQemu passes the NestedInterruptTplLib self-tests
> for both ARM and AARCH64.
>
> Cc: Ard Biesheuvel
> Signed-off-by: Michael Brown
On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io
wrote:
>
> From: Laszlo Ersek
>
> The current dependency evaluator violates the memory access permission
> when patching depex grammar directly in the read-only depex memory area.
>
> Laszlo pointed out the optimization issue in the thread (1)
On Thu, 18 Jan 2024 at 21:28, Laszlo Ersek wrote:
>
> On 1/16/24 18:10, Gerd Hoffmann wrote:
> > This is a little series containing the flash corruption fix sent
> > yesterday with an slightly improved commit message and some small
> > improvements on top of this.
> >
> > v3:
> > - fix diagram
>
(cc Jiewen. Laszlo)
On Tue, 16 Jan 2024 at 16:42, Gerd Hoffmann wrote:
>
>
>
> Gerd Hoffmann (2):
> OvmfPkg: remove TPM1_ENABLE build option
> OvmfPkg/Tcg2Config: remove unused TPM 1.2 support
>
Good riddance
Acked-by: Ard Biesheuvel
-=-=-=-=-=-=-=-=-=-=-=-
Groups.
On Tue, 16 Jan 2024 at 10:37, Laszlo Ersek wrote:
>
> On 1/15/24 18:56, Ard Biesheuvel wrote:
> > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote:
> >>
> >> On 1/12/24 12:37, Gerd Hoffmann wrote:
> >>> This is a little series containing the
On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote:
>
> On 1/12/24 12:37, Gerd Hoffmann wrote:
> > This is a little series containing the flash corruption fix sent
> > yesterday with an slightly improved commit message and some small
> > improvements on top of this.
> >
> > Gerd Hoffmann (4):
> >
bug.cgi?id=1468526. The bug is
> > still occuring for CloudHv guests because the PlatformScanE820
> > utility is not currently supported for CloudHv.
> >
> > My working branch for these changes can be found here:
> > https://github.com/thomasbarrett/edk2/tree/cloud-hv-1tb-ram
On Mon, 15 Jan 2024 at 16:32, Ard Biesheuvel wrote:
>
> On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote:
> >
> > On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote:
> > > This series adds support for cloud-hypervisor guests with >1TiB
> > &
2/tree/cloud-hv-1tb-ram
> >
> > Cc: Anatol Belski
> > Cc: Ard Biesheuvel
> > Cc: Gerd Hoffmann
> > Cc: Jianyong Wu
> > Cc: Jiewen Yao
> > Cc: Laszlo Ersek
> > Cc: Rob Bradford
> >
> > Thomas Barrett (3):
> > OvmfPkg: Add
On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote:
>
> On 1/12/2024 4:45 PM, Laszlo Ersek wrote:
> > (Independently: I think that's a valid thing to do for *SMM* drivers,
> > because the entry point functions of those drivers are permitted to use
> > both SMM and DXE/UEFI protocols. But whether the
From: Ard Biesheuvel
Remove me as reviewer for ARM development platforms: I am no longer
employed by ARM and have no access to or knowledge about ARM
development/reference hardware.
Signed-off-by: Ard Biesheuvel
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git
On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote:
>
> It is possible to find variable entries with State being 0xff,
> i.e. not updated since flash block erase. This indicates the
> header write was not completed (and therefore State was not set
> to VAR_HEADER_VALID_ONLY). Treat this as
FER_SIZE_IN_BYTES)) {
> + if ((*NumBytes + (Offset & BOUNDARY_OF_32_WORDS)) <= (4 *
> P30_MAX_BUFFER_SIZE_IN_BYTES)) {
> // Check to see if we need to erase before programming the data into NOR.
> // If the destination bits are only changing from 1s to 0s we can j
to handle updates larger
> than two P30_MAX_BUFFER_SIZE_IN_BYTES blocks, even though the patch
> does not actually change the size limit.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Ard Biesheuvel
Nit below
> ---
> OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 31
log. This should have been 0xff.
>
> This patch fixes the calculation.
>
> Signed-off-by: Gerd Hoffmann
Thanks a lot for taking the time to track this down and fix it.
Reviewed-by: Ard Biesheuvel
> ---
> OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 2 +-
> 1 file changed,
On Thu, 11 Jan 2024 at 09:35, Guo, Gua wrote:
>
> CC: @Mathews, John and @Zimmer, Vincent
>
> Hi @Gerd Hoffmann
>
> My company teammate share me your patch can resolved
> https://bugzilla.tianocore.org/show_bug.cgi?id=4166. So the signed-off name
> is your name.
>
Again, a signed-off-by line
On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote:
>
> Since we are updating the DT memory map and telling it how
> we have configured the PCIe, there isn't a reason for moving the
> MMIO window. In fact this appears to fix OpenBSD+DT as well as
> it makes the linux XHCI reset sequence happier.
>
On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote:
>
> Its a complete tossup whether removing the mailbox call after we have
> set up the XHCI works for a given kernel+distro in DT mode. So lets
> give users which want to try DT the option of flipping this on/off.
>
> Users that don't want to
Hi Jeremy,
Thanks for the patches.
On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote:
>
> The rpi's config.txt controls which uart (pl011, or miniuart) is
> selected as the console. TFA and edk2 follow its lead, but if the
> miniuart is selected as the primary and the machine is booted in ACPI
On Thu, 11 Jan 2024 at 07:52, Ard Biesheuvel wrote:
>
> On Thu, 11 Jan 2024 at 06:15, wrote:
> >
> > From: Gerd Hoffmann
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
> >
> > Fix integer overflow in various CreateHob instances.
>
ses.
>
> Reported-by: Marc Beatove
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Abner Chang
> Cc: John Mathew
> Signed-off-by: Gerd Hoffmann
This is missing a signed-off line from the sender.
(the signoff is not a statement of authorship, it is a promise by the
sender
> performing the following operation:
> ```
> HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
> ```
>
> No checks are performed to ensure this value doesn't
> overflow, and could lead to CreateHob() returning a smaller
> HOB than requested, which could lead to OOB HOB access
On Tue, 9 Jan 2024 at 10:17, Laszlo Ersek wrote:
>
> On 1/5/24 01:05, Rebecca Cran via groups.io wrote:
> > I noticed recent commits by Jeff Brasen, Jake Garver, Joey Vagades and
> > Michael Roth have funky Author lines, which I think means .mailmap needs
> > updated?
> >
> > Author: Jeff Brasen
On Fri, 5 Jan 2024 at 12:49, levi.yun wrote:
>
> Serial port used by the DEBUG macro is initialised in StandaloneMmMain
> by the DebugLib constructor.
>
> When we use a serial port initialised by TF-A it is not a problem.
> However, if we use a serial port that is not initialised by TF-A,
> the
On Fri, 5 Jan 2024 at 06:15, Rebecca Cran
wrote:
>
> The calculation of the timer period was broken. Introduce a global
> mTimerPeriod so the calculation can be removed. Since mTimerFrequencyHz
> is only used in one place, remove the global and make it a local
> variable. Do the same with
On Fri, 5 Jan 2024 at 06:15, Rebecca Cran
wrote:
>
> Fixes and improvements to GenericWatchdogDxe.
>
What is the difference between v2 and v3?
> PR: https://github.com/tianocore/edk2/pull/5176
>
> Rebecca Cran (3):
> ArmPkg: Update GenericWatchdogDxe to allow setting full 48-bit offset
>
, there might be more than 1 HOB
> instance of this gMpInformationHobGuid2.
> There is no change in ARM related code in the new patch set.
>
> Thanks,
> Dun
>
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, January 3, 2024 11:12 PM
> To: d
Hi Rebecca,
On Wed, 3 Jan 2024 at 21:44, Rebecca Cran
wrote:
>
> Fix the calculation of the timer period in GenericWatchdogDxe: we need
> to multiply before dividing to keep the values as integers.
>
> Signed-off-by: Rebecca Cran
> ---
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c |
On Thu, 9 Nov 2023 at 03:51, duntan wrote:
>
> Remove MpInformation.h in StandaloneMmPkg since
> it has been moved to UefiCpuPkg
>
> Signed-off-by: Dun Tan
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Ray Ni
Doesn't this break the ARM build?
> ---
(cc Samer and Jose)
Hello Dun Tan,
On Fri, 17 Nov 2023 at 10:57, Tan, Dun wrote:
>
> Hi Ard,
>
> I'm working on moving gMpInformationHobGuid from StandaloneMmPkg to
> UefiCpuPkg in this patch series. Currently in Edk2, the HOB is only consumed
> by StandaloneMmCpu.inf.
>
> As we know that
On Thu, 28 Dec 2023 at 21:47, Jeff Brasen wrote:
>
> Adding Mock support for DtPlatformLoaderLib and changing ci.yaml to support
> this
> Adding ReallocatePool support to PrePi Library.
>
> Passing CI in https://github.com/tianocore/edk2/pull/5197
>
> Change log
> v2 -
> Fix uncrustify errors
On Sun, 31 Dec 2023 at 12:07, Marcin Wojtas wrote:
>
> Commit ec5de71d83 ("Silicon/Marvell: Restructure package")
> broke Armada80x0Db build by unintentional removal of
> device tree component. Restore it.
>
> Signed-off-by: Marcin Wojtas
Applied, thanks.
> ---
>
On Tue, 26 Dec 2023 at 00:03, Marcin Wojtas wrote:
>
> I no longer use m...@semihalf.com email. Update Marvell entry with
> my alternative address. As there are more than one SolidRun
> pltaforms, on the occasion extend the scope.
>
> Signed-off-by: Marcin Wojtas
Applied, thanks.
> ---
>
From: Ard Biesheuvel
Drop the CLANG3x build options, and add ones for CLANGDWARF so that
SynQuacer based platforms can be built with it.
Instead of copying the -no-integrated-as option that CLANG3x used, let's
fix the assembler code so it can be built with Clang's integrated
assembler. Also
On Fri, 22 Dec 2023 at 03:37, Ni, Ray wrote:
>
> Good to me.
>
>
>
> Thanks,
>
> Ray
>
> From: Chao Li
> Sent: Friday, December 22, 2023 9:15 AM
> To: devel@edk2.groups.io; a...@kernel.org; Ni, Ray
> Cc: Kumar, Rahul R ; Gerd Hoffmann
> ; Leif L
On Thu, 21 Dec 2023 at 15:39, Ard Biesheuvel wrote:
>
> On Mon, 18 Dec 2023 at 03:23, Chang, Abner wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Reviewed-by: Abner Chang
> >
>
> I've queued this up, along with the mock one - thanks.
>
On Mon, 18 Dec 2023 at 03:23, Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang
>
I've queued this up, along with the mock one - thanks.
> > -Original Message-
> > From: Jeff Brasen
> > Sent: Monday, December 11, 2023 11:48 PM
> > To:
On Thu, 21 Dec 2023 at 13:41, Chao Li wrote:
>
...
> A given platform will either be able to use port IO, or it will need
> to use MMIO translation. So a driver that can do both based on a PCD
> is not very useful, it makes more sense to have two different drivers,
> and the platform incorporates
On Thu, 21 Dec 2023 at 13:11, Chao Li wrote:
>
> Hi Ard,
>
>
> Thanks,
> Chao
> On 2023/12/21 15:31, Ard Biesheuvel wrote:
>
> On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
>
> ...
>
> Ard,
>
> PcdPciIoTranslationIsEnabled is only use for whether
; 30cc:f460adrpx0, 0x92000
> > 30d0:912ec000add x0, x0, #0xbb0
> >
> > Note that we're now setting the stack canary from the wrong address,
> > resulting in an erroneous stack fault.
> >
> > After this fix, the offset will be calcu
On Thu, 21 Dec 2023 at 04:48, Chao Li wrote:
>
...
> Ard,
>
> PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio read
> or write, it seem that only x86 or x64 need them, not others.
>
> When I was submitted the patch V2, CpuIo2Dxe was private to LoongArch, just
> like Arm
On Wed, 20 Dec 2023 at 10:11, Ray Ni wrote:
>
> Load-module-at-fixed-address feature does not work in standalone MM core.
>
> The patch removes the 2 dead functions and related global variables
> that are related to the feature.
>
> Signed-off-by: Ray Ni
> Cc: Sami Mu
On Wed, 20 Dec 2023 at 13:28, Ni, Ray wrote:
>
> Thanks for pointing it out.
> I found it in ACPI spec that tells how to use "Resource Type Specific Flags"
> to describe a MEM resource while maps to IO,
> and an IO resource while maps to MEM.
>
> I assume that the IO port accesses are all from
On Wed, 20 Dec 2023 at 10:44, Ni, Ray wrote:
>
> Ard,
> Let me try to understand:
>
> 1. CPU does not support IO instructions to access IO ports.
> 2. PCI devices contain IO space.
> 3. A special PCI host bridge can be configured to map a range of MMIO space
> from CPU side to another range of
his
seems unnecessary to me. But perhaps I missed something?
>
> From: Chao Li
> Sent: Tuesday, December 19, 2023 9:04 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Kumar, Rahul R ; Gerd Hoffmann
> ; Leif Lindholm ; Ard
> Biesheuvel ; Sami Mujawar
> Subject: Re: [edk2-
Jake Garver
> Sent: Wednesday, December 13, 2023 2:47 PM
> To: Pedro Falcato ; Ard Biesheuvel
> Cc: devel@edk2.groups.io ; rebe...@bsdio.com
> ; gaolim...@byosoft.com.cn ;
> bob.c.f...@intel.com ; yuwei.c...@intel.com
>
> Subject: Re: [edk2-devel] [PATCH] BaseTools/Gen
From: Ard Biesheuvel
AMD Seattle support in edk2-platforms is implemented using a number of
closed source components delivered as binary drivers via edk2-non-osi,
some of which have dependencies on internal EDK2 APIs that are not
considered stable, and some of which have evolved over the years
-Haj-Mahmoud
> >
> > 主题: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib:
> > Signal ReadyToBoot on platform recovery
> >
> > On Mon, Dec 18, 2023 at 22:55:21 +0100, Ard Biesheuvel wrote:
> > > Hello all,
> > >
> > > Same quest
3 1:02 PM
> To: Xu, Wei6 ; devel@edk2.groups.io
> Cc: Laszlo Ersek ; Ard Biesheuvel
> ; Sami Mujawar
> Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in
> uncompressed inner fv.
>
> Reviewed-by: Ray Ni
>
> Can you kindly update the PR
On Fri, Dec 15, 2023 at 12:56 PM Mike Beaton wrote:
>
> > For the exception handler case, we can just drop the #Ifdefs around
> > the definition of BaseName () entirely given that it will now always
> > be referenced. But that does depend a lot on how other toolchains deal
> > with this (VS201x
.
On Tue, 12 Dec 2023 at 09:11, Ard Biesheuvel wrote:
>
> (cc Mike, Leif)
>
> On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote:
> >
> > (cc Liming)
> >
> > On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote:
> > >
> > > On Fri, Nov 24, 2023 at 6:36 PM
ve WSL, I have stopped using Cygwin.
> Also, this patch looks good to me.
>
> Reviewed-by: Sami Mujawar
>
Merged as #5148
Thanks all
>
> On Thu, Dec 14, 2023 at 10:20:46 +0100, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel mailto:a...@kernel.org>>
> >
> > The Deb
On Thu, 14 Dec 2023 at 10:37, Mike Beaton wrote:
>
> > IOW, please don't send a v6 until the discussion comes to a conclusion.
>
> Apologies, I did _not_ see this before sending.
>
> > > - #if !defined (MDEPKG_NDEBUG)
> > > + #if defined (__CC_ARM) || defined (__GNUC__)
> >
> > No, this is not
From: Ard Biesheuvel
The DebugPeCoffExtraActionLib implemention in ArmPkg contains some cruft
that dates back to the original RVCT based ARM port, and support for
RVCT was dropped a while ago.
Also drop the handling of Cygwin specific paths, which is highly
unlikely to be still depended upon
Please stop sending patches.
On Thu, 14 Dec 2023 at 10:12, Mike Beaton wrote:
>
> Repeats V5, but with a hopefully clearer (on motivation and history) commit
> message.
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112512):
On Thu, 14 Dec 2023 at 08:40, Ard Biesheuvel wrote:
>
> On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote:
> >
> > From: Mike Beaton
> >
> > This is no longer required since the revised DEBUG macro automatically
> > compiles away unused var accesses when M
(cc Michael)
On Thu, 14 Dec 2023 at 08:58, Mike Beaton wrote:
>
> From: Mike Beaton
>
> The variant provided when MDEPKG_NDEBUG is defined will be optimised
> away in RELEASE builds, but by referencing the argument list, avoids
> unused variable errors from valid debug code, for example when
(cc MdePkg and BaseTools maintainers)
On Thu, 14 Dec 2023 at 00:08, Mike Beaton wrote:
>
> From: Mike Beaton
>
> The variant provided when MDEPKG_NDEBUG is defined will be optimised
> away in RELEASE builds, but by referencing the argument list, avoids
> unused variable errors from valid debug
On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote:
>
> From: Mike Beaton
>
> This is no longer required since the revised DEBUG macro automatically
> compiles away unused var accesses when MDEPKG_NDEBUG is defined;
> keeping these lines is incompatible with the updated DEBUG macro, as
> there has
On Wed, 13 Dec 2023 at 15:58, Jake Garver wrote:
>
> Totally understand and agree, Ard.
>
> In the meantime, I've now experienced the issue with Ubuntu22's GCC 12.3.
> Originally, we didn't see the issue on this toolchain, but a developer ran
> into when preparing a change. Even more
On Tue, 12 Dec 2023 at 22:46, Mike Beaton wrote:
>
> From: Mikhail Krichanov
>
> Provides a variant of the DEBUG macro for clang when MDEPKG_NDEBUG is
> defined, which uses but discards the contained expression. This means
> clang can tell that it has optimised away variable usage as part of
>
On Tue, 12 Dec 2023 at 11:08, Gerd Hoffmann wrote:
>
> On Tue, Dec 12, 2023 at 09:36:00AM +0100, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Shim's PE loader uses the EFI memory attributes protocol in a way that
> > results in an immediate crash when inv
On Mon, 11 Dec 2023 at 16:48, Jeff Brasen wrote:
>
> Add implementation of ReallocatePool which is defined in the
> MemoryAllocationLib header file to allow components to not
> need special handling for PrePi module types.
>
> Signed-off-by: Jeff Brasen
Reviewed-
On Tue, 12 Dec 2023 at 09:49, Mike Beaton wrote:
>
> From: Mike Beaton
>
> Provides a variant of the DEBUG macro for clang when MDEPKG_NDEBUG is defined,
> which uses but discards the contained expression, this means clang can tell
> that it has optimised away variable usage, therefore we can
On Wed, 6 Dec 2023 at 17:51, Jake Garver wrote:
>
> Thanks, Pedro and Ard,
>
> An update on this issue:
>
> It seems to be very specific to Ubuntu20's 10.5 build of GCC.
> I could not reproduce it using a crosstool-ng build of 10.5, even after
> trying to configure it identically to Ubuntu20's.
From: Ard Biesheuvel
Shim's PE loader uses the EFI memory attributes protocol in a way that
results in an immediate crash when invoking the loaded image, unless the
base and size of its executable segment are both aligned to 4k.
If this is not the case, it will strip the memory allocation
(cc Mike, Leif)
On Thu, 7 Dec 2023 at 08:40, Ard Biesheuvel wrote:
>
> (cc Liming)
>
> On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote:
> >
> > On Fri, Nov 24, 2023 at 6:36 PM Neal Gompa wrote:
> > >
> > > On Thu, Nov 2, 2023 at 6:35 AM Laszlo Ersek
On Tue, 12 Dec 2023 at 08:17, Mike Beaton wrote:
>
> > > A completely different approach, which allows clang to spot that the
> > > usage has been 'optimised away' and so to not complain (and therefore
> > > allows us to re-enable the warning in CLANGDWARF as well), is the
> > > following:
> > >
On Mon, 11 Dec 2023 at 15:33, Laszlo Ersek wrote:
>
> On 12/11/23 11:55, Gerd Hoffmann wrote:
> >> + //
> >> + // Work around shim's terminally broken use of the EFI memory attributes
> >> + // protocol, by uninstalling it if requested on the QEMU command line.
> >> + //
> >> + // E.g.,
> >>
From: Ard Biesheuvel
Shim's PE loader uses the EFI memory attributes protocol in a way that
results in an immediate crash when invoking the loaded image, unless the
base and size of its executable segment are both aligned to 4k.
If this is not the case, it will strip the memory allocation
On Mon, Dec 11, 2023 at 10:06 AM Gerd Hoffmann wrote:
>
> On Thu, Dec 07, 2023 at 11:06:03AM +0100, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Shim's PE loader uses the EFI memory attributes protocol in a way that
> > results in an immediate crash
IC (and adding a comment) in the relevant line in
> VirtioSerialDxe.
>
Removing STATIC means that (modulo LTO) the compiler will not know
whether or not the definition can be dropped. It also pollutes the
global namespace.
IMO, lack of the use of STATIC where appropriate is a severe iss
On Sat, 9 Dec 2023 at 01:20, Rebecca Cran
wrote:
>
> Update the debug level comments in ArmVirt.dsc.inc to sync with
> MdePkg/Include/Library/DebugLib.h.
>
> Signed-off-by: Rebecca Cran
Reviewed-by: Ard Biesheuvel
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 42 ++---
Thanks for the review.
On Fri, 8 Dec 2023 at 15:34, Laszlo Ersek wrote:
>
> On 12/7/23 11:06, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Shim's PE loader uses the EFI memory attributes protocol in a way that
> > results in an immediate crash when inv
On Thu, 7 Dec 2023 at 11:06, Ard Biesheuvel wrote:
>
> From: Ard Biesheuvel
>
> Shim's PE loader uses the EFI memory attributes protocol in a way that
> results in an immediate crash when invoking the loaded image, unless the
> base and size of its executable segment are
mul.c#L133-L134
> [2]
> https://github.com/tianocore/edk2/blob/fb044b7fe893a4545995bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157
> [3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274389
>
> Signed-off-by: Corvin Köhne
> Reviewed-by: Laszlo Ersek
> Re
Hi Gerd,
On Thu, 7 Dec 2023 at 10:44, Gerd Hoffmann wrote:
>
> Extend the ValidateFvHeader function, additionally to the header checks
> walk over the list of variables and sanity check them.
>
> In case we find inconsistencies indicating variable store corruption
> return EFI_NOT_FOUND so the
From: Ard Biesheuvel
Shim's PE loader uses the EFI memory attributes protocol in a way that
results in an immediate crash when invoking the loaded image, unless the
base and size of its executable segment are both aligned to 4k.
If this is not the case, it will strip the memory allocation
On Tue, 5 Dec 2023 at 10:56, Marcin Juszkiewicz
wrote:
>
...
>
> I use 'sbsa-ref' with QEMU and upstream EDK2. And cannot use either RHEL
> 9.3 nor CentOS Stream 9 installers because they hang.
>
> And this is not the only platform where upstream EDK2 is used.
>
> Sure, I can hack something, use
t more sensical.
>
No worries - and congrats!
> On 12/6/2023 5:23 AM, Ard Biesheuvel wrote:
> > But what we might do is invent a way to avoid setting the XP attribute
> > on the entire region based on some heuristic. Given that the main
> > purpose of the EFI memory attri
(cc Liming)
On Thu, 7 Dec 2023 at 05:48, Neal Gompa wrote:
>
> On Fri, Nov 24, 2023 at 6:36 PM Neal Gompa wrote:
> >
> > On Thu, Nov 2, 2023 at 6:35 AM Laszlo Ersek wrote:
> > >
> > > On 10/31/23 23:27, Jeremy Linton wrote:
> > > > On 10/31/23 12:37, Neal Gompa via groups.io wrote:
> > > >>
t; From: Gerd Hoffmann
> Date: Wed, 6 Dec 2023 13:00:53 +0100
> Subject: [PATCH 1/1] ArmVirtPkg: add runtime option to enable/disable
> MemoryAttributesProtocol
>
> Based on a patch by Ard Biesheuvel
>
> Usage:
> qemu-system-aarch64 $args \
> -fw_cfg name=opt
On Mon, 4 Dec 2023 at 15:52, Gerd Hoffmann wrote:
>
> Hi,
>
> > > > That way you at least you know who you trust. Just remove shim. Have a
> > > > look
> > > > at how Amazon Linux 2023 did it [2] :))
>
> > > You are in the luxurious position to run your own distro on your own
> > > platform,
On Mon, 4 Dec 2023 at 13:38, Alexander Graf wrote:
>
>
> On 04.12.23 13:20, Gerd Hoffmann wrote:
> >Hi,
> >
> >> (hint: You really don't want or need shim on ARM. The only reason for shim
> >> is that on most x86 desktop systems, users will have the MS keys
> >> preinstalled. The MS Secure
101 - 200 of 3132 matches
Mail list logo
