[edk2-devel] [PATCH] EmbeddedPkg/PrePiLib: Drop unused PCD PcdPrePiCpuIoSize

2023-02-03 Thread Ard Biesheuvel
-by: Sunil V L Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf index 3c749ca22943..090bfe888f52 100644 --- a/EmbeddedPkg/Library

Re: [edk2-devel] [PATCH v1 3/4] ArmVirtPkg: require self-signed PK when secure boot is enabled

2023-02-03 Thread Ard Biesheuvel
On Fri, 20 Jan 2023 at 23:59, Jan Bobek wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2506 > > In all DSC files that define SECURE_BOOT_ENABLE, opt-in into requiring > self-signed PK when SECURE_BOOT_ENABLE is TRUE. > > Cc: Ard Biesheuvel > Cc: Leif Lind

Re: [edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table

2023-02-03 Thread Ard Biesheuvel
On Fri, 3 Feb 2023 at 09:25, Marvin Häuser wrote: > > Hi Ard, > > Short story: No, TE is not a concern for RT drivers, at least not upstream > [1]. > > Long story: Even if a downstream added support for RT relocation itself, TE > images are loaded misaligned by DxeCore, because it lacks a

Re: [edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table

2023-02-03 Thread Ard Biesheuvel
racking this for the PE/COFF spec. > > > > Unfortunately, I don't have more firm info right now but I suggest > > holding off on alternatives for the time being and I will reply back as > > soon as the next steps are known. > > > > Thanks, > > Michael

Re: [edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table

2023-02-02 Thread Ard Biesheuvel
ly to be used for runtime DXE images in firmware volumes? > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Thursday, February 2, 2023 10:04 AM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Kinney, Michael D > > ; Gao, Liming ; Ya

[edk2-devel] [RFC PATCH 3/3] ArmVirtPkg/ArmVirtQemu: Implement BTI for runtime regions

2023-02-02 Thread Ard Biesheuvel
-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 0f1c6395488a..0a67fe250d86 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -32,6 +32,7 @@ [Defines

[edk2-devel] [RFC PATCH 2/3] MdeModulePkg: Enable forward edge CFI in mem attributes table

2023-02-02 Thread Ard Biesheuvel
the firmware volumes, we must assume that setting the CFI flag in the memory attributes table is unsafe. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Core/Dxe/DxeMain.h| 2 ++ MdeModulePkg/Core/Dxe/DxeMain.inf | 1 + MdeModulePkg/Core/Dxe/Image/Image.c

[edk2-devel] [RFC PATCH 1/3] MdePkg: Update MemoryAttributesTable to v2.10

2023-02-02 Thread Ard Biesheuvel
UEFI v2.10 introduces a new flag to the memory attributes table to inform the OS whether or not runtime services code regions were emitted by the compiler with guard instructions for forward edge control flow integrity enforcement. So update our definition accordingly. Signed-off-by: Ard

[edk2-devel] [RFC PATCH 0/3] enable IBT/BTI codegen and reporting to the OS

2023-02-02 Thread Ard Biesheuvel
Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Cc: Michael Kubacki Cc: Sean Brogan Cc: Rebecca Cran Cc: Leif Lindholm Cc: Sami Mujawar Cc: Taylor Beebe Ard Biesheuvel (3): MdePkg: Update MemoryAttributesTable to v2.10 MdeModulePkg: Enable forward edge CFI in mem attributes table

[edk2-devel] [PATCH v2 3/3] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-02 Thread Ard Biesheuvel
Expose the protocol introduced in v2.10 that permits the caller to manage mapping permissions in the page tables. Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 + ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 + ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2

[edk2-devel] [PATCH v2 2/3] ArmPkg/CpuDxe: Unify PageAttributeToGcdAttribute helper

2023-02-02 Thread Ard Biesheuvel
In preparation for introducing an implementation of the EFI memory attributes protocol that is shared between ARM and AArch64, unify the existing code that converts a page table descriptor into a EFI_MEMORY_xxx bitfield, so it can be called from the generic code. Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH v2 1/3] MdePkg: Add Memory Attribute Protocol definition

2023-02-02 Thread Ard Biesheuvel
Add the Memory Attribute Protocol definition, which was adopted and included in version 2.10 of the UEFI specification. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519 Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Protocol/MemoryAttribute.h | 142 MdePkg

[edk2-devel] [PATCH v2 0/3] ArmPkg: implement EFI memory attributes protocol

2023-02-02 Thread Ard Biesheuvel
v2: - drop patch to bump exposed UEFI revision to v2.10 - add missing permitted return values to protocol definition Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Cc: Michael Kubacki Cc: Sean Brogan Cc: Rebecca Cran Cc: Leif Lindholm Cc: Sami Mujawar Cc: Taylor Beebe Ard

Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-02-02 Thread Ard Biesheuvel
unlikely (I think) is that by default, all unallocated space has the XP attribute set already, and so allocating a page table with XP attributes should not result in the need for a block entry split, and therefore no allocation for a next level table. Perhaps we need some asserts to diagnose th

Re: [edk2-devel] 回复: [PATCH 1/4] MdePkg: Add Memory Attribute Protocol definition

2023-02-02 Thread Ard Biesheuvel
h. Can you help > confirm? > I just took the Project Mu version without realizing this - I can fix that up in v2. > > -邮件原件----- > > 发件人: Ard Biesheuvel > > 发送时间: 2023年2月1日 6:36 > > 收件人: devel@edk2.groups.io > > 抄送: Ard Biesheuvel ; Michael Kinney > > ;

Re: [edk2-devel] [PATCH] OvmfPkg: Fix SevMemoryAcceptance memory attributes

2023-02-01 Thread Ard Biesheuvel
On Tue, 31 Jan 2023 at 20:18, Dionna Amalie Glaze wrote: > > > > > efi: mem94: [Conventional| | |CC| | | | | | | | | | | ] > > range=[0x0001-0x00023fff] (5120MB) > > > > This does not have the cache capabilities one would expect for system > > memory,

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-01 Thread Ard Biesheuvel
On Wed, 1 Feb 2023 at 13:59, Oliver Steffen wrote: > > > > On Wed, Feb 1, 2023 at 12:52 PM Ard Biesheuvel wrote: >> >> On Wed, 1 Feb 2023 at 10:14, Oliver Steffen wrote: >> > >> > Hi everyone! >> > >> > On Thu, Jan 19, 2023 at 2:21

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-02-01 Thread Ard Biesheuvel
On Wed, 1 Feb 2023 at 10:14, Oliver Steffen wrote: > > Hi everyone! > > On Thu, Jan 19, 2023 at 2:21 PM Ard Biesheuvel wrote: > > > > On Thu, 19 Jan 2023 at 13:55, Oliver Steffen wrote: > > > > > > Quoting Gerd Hoffmann (2023-01-19 13:00:21) > >

Re: [edk2-devel] [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10

2023-01-31 Thread Ard Biesheuvel
is patch. But please ack patch #1 if you are happy for it to go in. Thanks, Ard. > > -Original Message- > > From: Ard Biesheuvel > > Sent: Tuesday, January 31, 2023 2:36 PM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Kinney, Michael D >

[edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol

2023-01-31 Thread Ard Biesheuvel
Expose the protocol introduced in v2.10 that permits the caller to manage mapping permissions in the page tables. Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 + ArmPkg/Drivers/CpuDxe/CpuDxe.h | 3 + ArmPkg/Drivers/CpuDxe/CpuDxe.inf| 2

[edk2-devel] [PATCH 3/4] ArmPkg/CpuDxe: Unify PageAttributeToGcdAttribute helper

2023-01-31 Thread Ard Biesheuvel
In preparation for introducing an implementation of the EFI memory attributes protocol that is shared between ARM and AArch64, unify the existing code that converts a page table descriptor into a EFI_MEMORY_xxx bitfield, so it can be called from the generic code. Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10

2023-01-31 Thread Ard Biesheuvel
Now that we are adding implementations of protocols added in v2.10, let's bump the version we expose to v2.10 as well. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Uefi/UefiSpec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg

[edk2-devel] [PATCH 1/4] MdePkg: Add Memory Attribute Protocol definition

2023-01-31 Thread Ard Biesheuvel
From: Sean Brogan Add the Memory Attribute Protocol definition, which was adopted and included in version 2.10 of the UEFI specification. Taken from Project Mu's mu_basecore repository. Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3519 Signed-off-by: Ard Biesheuvel --- MdePkg/Include

[edk2-devel] [PATCH 0/4] ArmPkg: implement EFI memory attributes protocol

2023-01-31 Thread Ard Biesheuvel
Cc: Michael Kinney Cc: Liming Gao Cc: Jiewen Yao Cc: Michael Kubacki Cc: Sean Brogan Cc: Rebecca Cran Cc: Leif Lindholm Cc: Sami Mujawar Ard Biesheuvel (3): MdePkg: Bump implemented UEFI version to v2.10 ArmPkg/CpuDxe: Unify PageAttributeToGcdAttribute helper ArmPkg/CpuDxe

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00

2023-01-31 Thread Ard Biesheuvel
I0 or PC00. > Thanks for the explanation. I think this is a rather ugly hack, but I suppose it is really needed. > > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, January 31, 2023 3:32 PM > To: devel@edk2.groups.io; Chen, Aryeh > Cc: Chiu, Chasel ; Desimon

Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

2023-01-31 Thread Ard Biesheuvel
Do you mean that I need to send my last patch again with corrected > the .inf files? > > BR, > > by Tommy > Please resend the patch with me on cc. It seems the list management software has corrupted the patch. > > -Original Message- >

Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

2023-01-31 Thread Ard Biesheuvel
On Mon, 30 Jan 2023 at 03:09, Tommy Huang wrote: > > 1. Correct all INF_VERSION value. > > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ryan Chen > Cc: BMC-SW > > Signed-off-by: Tommy Huang This patch does not apply Please generate your patch

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00

2023-01-30 Thread Ard Biesheuvel
On Tue, 31 Jan 2023 at 06:46, Chen, Aryeh wrote: > > From: Aryeh Chen > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329 > > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 > on MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL

Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h

2023-01-30 Thread Ard Biesheuvel
On Mon, 30 Jan 2023 at 17:27, Kinney, Michael D wrote: > > Hi Ard, > > Can you explain the process being followed here for content like this. > > The EDK II Code First Process as detailed below requires all content to only > be added to edk2-staging repo and used from there before spec changes

Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support

2023-01-30 Thread Ard Biesheuvel
On Mon, 30 Jan 2023 at 03:35, Bob Feng wrote: > > Hi Ard, > > I have no objections. For the patch series, > > Acked-by: Bob Feng > Merged as #3971 Thanks all -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99312):

Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in PrePiDxeCis.h

2023-01-30 Thread Ard Biesheuvel
On Sun, 29 Jan 2023 at 06:16, gaoliming via groups.io wrote: > > Reviewed-by: Liming Gao > Merged as #3970 Thanks all > > -邮件原件- > > 发件人: Dionna Amalie Glaze > > 发送时间: 2023年1月28日 8:02 > > 收件人: Xu, Min M > > 抄送: devel@edk2.groups.io; Yao, Jiewen ; Kinney, > > Michael D ; Gao,

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: StandaloneMmMemLib: Change max address computation

2023-01-30 Thread Ard Biesheuvel
(cc Damian) On Sat, 28 Jan 2023 at 01:27, Girish Mahadevan wrote: > > Currently the standalonemmlibinternal assumes the max physical bits > to be 36 which is causing issues on v8 architectures. > Instead use the MAX_ADDRESS macro to determine the maximum allowed address > rather than recomputing

[edk2-devel] [PATCH] ArmPkg/DefaultExceptionHandler: Dump ESR and FAR in RELEASE builds

2023-01-27 Thread Ard Biesheuvel
, but not in RELEASE builds. Signed-off-by: Ard Biesheuvel --- .../AArch64/DefaultExceptionHandler.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c b/ArmPkg/Library

Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support

2023-01-27 Thread Ard Biesheuvel
On Fri, 27 Jan 2023 at 18:14, Michael D Kinney wrote: > > Hi Ard, > > Acked-by: Michael D Kinney > > I have no objections. Bob may not be online until early next week. > Thanks, There is no rush - this is just janitorial stuff so I'm happy to wait a couple of days. -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support

2023-01-27 Thread Ard Biesheuvel
ks for the respin. For the series, Acked-by: Ard Biesheuvel Liming, Bob: unless there are any objections, I intend to merge this, including the BaseTools/ changes, beginning of next week. Thanks, Ard. > ArmVirtPkg/ArmVirt.dsc.inc

Re: [edk2-devel] [PATCH v5 0/2] ArmPkg: Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64

2023-01-27 Thread Ard Biesheuvel
On Fri, 27 Jan 2023 at 05:10, Rebecca Cran wrote: > > Could I get some more reviews on this please? > > Reviewed-by: Ard Biesheuvel Thanks a lot for your persistence. Queued up here https://github.com/tianocore/edk2/pull/3956 > > On 1/16/23 21:57, Rebecca Cran wr

Re: [edk2-devel] [PATCH 1/1] tools_def: Remove duplicated -Os

2023-01-27 Thread Ard Biesheuvel
e not necessary anymore. > Remove them. > > Reported-by: Laszlo Ersek > Signed-off-by: Pierre Gondois Acked-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/B

Re: [edk2-devel] [PATCH 1/1] BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories

2023-01-27 Thread Ard Biesheuvel
sicsLib.lib | > Bin 36072 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib | > Bin 36072 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.lib | > Bin 11504 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/

Re: [edk2-devel] Question/bug in ArmPkg (ArmArchTimerLib)

2023-01-27 Thread Ard Biesheuvel
On Thu, 26 Jan 2023 at 13:06, Gierszynski, Przemyslaw wrote: > > Hi All, > > My name is Przemysław Gierszyński and I work as a Firmware Engineer in Intel > Technology Poland. > I was doing some work that required review of some parts of EDK2 and I think > I have found a small bug in ArmPkg

Re: [edk2-devel] [PATCH v11 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol

2023-01-26 Thread Ard Biesheuvel
> > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Ard Biesheuvel > > Cc: "Min M. Xu" > > Cc: Andrew Fish > > Cc: "Michael D. Kinney" > > > > Signed-off-by: Dionna Glaze > > --- > >

Re: [edk2-devel] [PATCH v11 0/4] Add safe unaccepted memory behavior

2023-01-26 Thread Ard Biesheuvel
gt; Cc: "Min M. Xu" > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Tom Lendacky > Cc: Jiewen Yao > Cc: Erdem Aktas > Cc: Andrew Fish > Cc: "Michael D. Kinney" > > Signed-off-by: Dionna Glaze > > Dionna Glaze (4): > Ov

Re: [edk2-devel] [PATCH v11 4/4] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted

2023-01-26 Thread Ard Biesheuvel
On Thu, 26 Jan 2023 at 22:17, Dionna Glaze wrote: > > Instead of eagerly accepting all memory in PEI, only accept memory under > the 4GB address. This allows a loaded image to use the > MEMORY_ACCEPTANCE_PROTOCOL to disable the accept behavior and indicate > that it can interpret the memory type

Re: [edk2-devel] [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol

2023-01-26 Thread Ard Biesheuvel
On Thu, 26 Jan 2023 at 18:04, Dionna Amalie Glaze wrote: > > > As Gerd and I discussed before, this protocol should be in OvmfPkg. > > Please move to > > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Include/Protocol > > > > Ah, I misinterpreted your response to Gerd's message. v11 will

Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe

2023-01-26 Thread Ard Biesheuvel
: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Ard Biesheuvel > Cc: "Min M. Xu" > Cc: Andrew Fish > Cc: "Michael D. Kinney" > > Signed-off-by: Dionna Glaze > --- > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 109

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix BuildResourceDescriptorHob call in PlatformAddHobCB()

2023-01-26 Thread Ard Biesheuvel
l@edk2.groups.io > > Cc: Pawel Polawski ; Tom Lendacky > > ; Yao, Jiewen ; Oliver > > Steffen ; Gerd Hoffmann ; Ard > > Biesheuvel ; Justen, Jordan L > > > > Subject: [edk2-devel] [PATCH 1/1] OvmfPkg: fix BuildResourceDescriptorHob > > call > >

Re: [edk2-devel] [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf

2023-01-26 Thread Ard Biesheuvel
On Thu, 26 Jan 2023 at 09:03, Ard Biesheuvel wrote: > > On Thu, 26 Jan 2023 at 02:42, Yao, Jiewen wrote: > > > > Reviewed-by: Jiewen Yao > > > > Thanks, I'll go and merge this. > > Merged as #3947, thanks > > > -Original Message- > &

Re: [edk2-devel] [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf

2023-01-26 Thread Ard Biesheuvel
On Thu, 26 Jan 2023 at 02:42, Yao, Jiewen wrote: > > Reviewed-by: Jiewen Yao > Thanks, I'll go and merge this. > > -Original Message- > > From: Kinney, Michael D > > Sent: Thursday, January 26, 2023 3:44 AM > > To: Jake Garver ; devel@edk2.groups.io > > Cc: jbra...@nvidia.com;

Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior

2023-01-25 Thread Ard Biesheuvel
On Wed, 25 Jan 2023 at 13:10, Gerd Hoffmann wrote: > > On Wed, Jan 25, 2023 at 12:44:13PM +0100, Ard Biesheuvel wrote: > > On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann wrote: > > > > > > On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote: > > >

[edk2-devel] arm64 support for stuart

2023-01-25 Thread Ard Biesheuvel
Hello all, Given some recent issues with OVMF and ArmVirtPkg, where regressions were not caught, or resulted in different behavior between TCG (emulation) and KVM (virtualized executon) when running under KVM. So I have started with increasing the test coverage for ArmVIrtPkg, even for

Re: [edk2-devel] [PATCH v2 0/6] ArmVirtPkg: Increase PlatformCI coverage

2023-01-25 Thread Ard Biesheuvel
On Wed, 25 Jan 2023 at 10:42, Gerd Hoffmann wrote: > > On Tue, Jan 24, 2023 at 05:34:11PM +0100, Ard Biesheuvel wrote: > > We recently experienced some build breakage in one of the ArmVirtPkg > > platforms that is not covered by PlatformCI, in the PrePi component > > which

Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior

2023-01-25 Thread Ard Biesheuvel
On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann wrote: > > On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote: > > > Exactly. And my Fedora kernel has those bits enabled by default. > > > > So I suppose the way forward here is to expose this protocol only on

Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior

2023-01-25 Thread Ard Biesheuvel
On Tue, 24 Jan 2023 at 23:42, Lendacky, Thomas via groups.io wrote: > > On 1/16/23 04:28, Gerd Hoffmann via groups.io wrote: > > On Fri, Jan 13, 2023 at 10:34:15AM -0800, Dave Hansen wrote: > >> On 1/13/23 10:23, Dionna Glaze via groups.io wrote: > However, *NONE* of this points me in the

[edk2-devel] [PATCH v2 6/6] ArmVirtPkg/PlatformCI: Perform build test of ArmVirtKvmTool

2023-01-24 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 25 +++ ArmVirtPkg/PlatformCI/KvmToolBuild.py | 32 2 files changed, 57 insertions(+) diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b

[edk2-devel] [PATCH v2 5/6] ArmVirtPkg/PlatformCI: Add CI coverage for ArmVirtQemuKernel

2023-01-24 Thread Ard Biesheuvel
. This ensures that the relocatable PrePi and other components in EmbeddedPkg don't regress on ARM as they are being updated for use on TDVF. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 43 ArmVirtPkg/PlatformCI/PlatformBuildLib.py

[edk2-devel] [PATCH v2 3/6] ArmVirtPkg/PlatformCI: factor out reusable PlatformBuildLib.py

2023-01-24 Thread Ard Biesheuvel
-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 12 ArmVirtPkg/PlatformCI/{PlatformBuild.py => PlatformBuildLib.py} | 19 ++-- ArmVirtPkg/PlatformCI/QemuBuild.py | 31 3 files chan

[edk2-devel] [PATCH v2 1/6] ArmVirtPkg/PrePi: Ensure timely execution of library constructors

2023-01-24 Thread Ard Biesheuvel
that. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PrePi/PrePi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c index c15dc305fced..3d943b2138d3 100755 --- a/ArmVirtPkg/PrePi/PrePi.c +++ b/ArmVirtPkg/PrePi/PrePi.c @@ -60,6 +60,9

[edk2-devel] [PATCH v2 4/6] ArmVirtPkg/PlatformCI: Enable optional features on Qemu AARCH64 builds

2023-01-24 Thread Ard Biesheuvel
To increase the CI coverage, enable secure boot, TPM2 support and HTTPS boot on ArmVirtQemu builds used in CI. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmVirtPkg/PlatformCI

[edk2-devel] [PATCH v2 2/6] ArmVirtPkg/ArmVirtQemu: enlarge initial flash mapping

2023-01-24 Thread Ard Biesheuvel
The initial ID map used by ArmVirtQemu only covers 2 MiB of NOR flash, while the NOOPT build can be up to 3 MiB in size, resulting in a crash if the unmapped 1 MiB is accessed before the real page tables are up. So increate the initial flash mapping to 4 MiB. Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH v2 0/6] ArmVirtPkg: Increase PlatformCI coverage

2023-01-24 Thread Ard Biesheuvel
Cc: Jiewen Yao Cc: Oliver Steffen Ard Biesheuvel (6): ArmVirtPkg/PrePi: Ensure timely execution of library constructors ArmVirtPkg/ArmVirtQemu: enlarge initial flash mapping ArmVirtPkg/PlatformCI: factor out reusable PlatformBuildLib.py ArmVirtPkg/PlatformCI: Enable optional features

Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size

2023-01-24 Thread Ard Biesheuvel
On Tue, 24 Jan 2023 at 13:20, Milosek, Damian wrote: > > > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Monday, January 23, 2023 6:46 PM > To: Milosek, Damian > Cc: devel@edk2.groups.io; sami.muja...@arm.com; Yao, Jiewen

Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size

2023-01-23 Thread Ard Biesheuvel
On Mon, 23 Jan 2023 at 17:14, Milosek, Damian wrote: > > > > -Original Message----- > From: Ard Biesheuvel > Sent: Monday, January 23, 2023 5:05 PM > To: Milosek, Damian > Cc: devel@edk2.groups.io; sami.muja...@arm.com; Yao, Jiewen > > Subjec

Re: [edk2-devel] [PATCH 2/3] ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel

2023-01-23 Thread Ard Biesheuvel
On Thu, 19 Jan 2023 at 10:14, Gerd Hoffmann wrote: > > > diff --git a/ArmVirtPkg/PlatformCI/QemuKernelBuild.py > > b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py > > new file mode 100644 > > index ..1c652478cb41 > > --- /dev/null > > +++ b/ArmVirtPkg/PlatformCI/QemuKernelBuild.py > > In

Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size

2023-01-23 Thread Ard Biesheuvel
On Mon, 23 Jan 2023 at 16:51, Milosek, Damian wrote: > > > > > > From: devel@edk2.groups.io On Behalf Of Milosek, Damian > Sent: Monday, January 16, 2023 2:51 PM > To: devel@edk2.groups.io > Cc: Milosek, Damian > Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update >

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

2023-01-23 Thread Ard Biesheuvel
On Mon, 23 Jan 2023 at 10:23, Oliver Steffen wrote: > > Quoting Rebecca Cran (2023-01-20 22:22:55) > > Related to this, I've been wondering if we might want to commit a .vscode > > directory with project configuration file(s)? > > As long as project settings for other IDEs (should > there be a

Re: [edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-20 Thread Ard Biesheuvel
On Fri, 20 Jan 2023 at 10:25, Laszlo Ersek wrote: > > On 1/19/23 14:43, Ard Biesheuvel wrote: > > QEMU for x86 has a nasty CPU hotplug bug of which the ramifications are > > difficult to oversee, even though KVM acceleration seems to be > > unaffected. This has been ad

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Ard Biesheuvel
On Fri, 20 Jan 2023 at 09:50, Laszlo Ersek wrote: > > a couple of requests to Oliver below: > > On 1/19/23 12:27, Ard Biesheuvel wrote: > > On Thu, 19 Jan 2023 at 12:01, Laszlo Ersek wrote: > >> > >> In QEMU v5.1.0, the CPU hotplug register block misbe

[edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-19 Thread Ard Biesheuvel
. So let's enable this for Windows-VS2019, and remove it again once it is no longer needed. Cc: Laszlo Ersek Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Michael Brown Cc: Oliver Steffen Cc: Michael Kubacki Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250 Signed-off-by: Ard Biesheuvel

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Ard Biesheuvel
On Thu, 19 Jan 2023 at 13:55, Oliver Steffen wrote: > > Quoting Gerd Hoffmann (2023-01-19 13:00:21) > > Hi, > > > > > > I tried the most recent Qemu master (v7.2.50) and also v7.0.0, > > > > on the 5.14 (RHEL) kernel and on 6.1.6-200.fc37.aarch64 (from Fedora). > > > > No luck. > > > > > > > >

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Ard Biesheuvel
On Thu, 19 Jan 2023 at 12:56, Marc Zyngier wrote: > > On Thu, 19 Jan 2023 11:11:34 +0000, > Ard Biesheuvel wrote: > > > > (cc Marc) > > > > Context: > > - on my TX2 (with the S1PTW r/o memslot fix applied), the new version > > of ArmVirtQemu that

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-19 Thread Ard Biesheuvel
;QEMU bug) > 1010 broken CPU count caught (boot hangs) > 10 1 1 broken CPU count caught, bug check >overridden, boot continues > 1100

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-19 Thread Ard Biesheuvel
this ID map is activated. More details at the end. On Thu, 19 Jan 2023 at 12:03, Oliver Steffen wrote: > > Quoting Ard Biesheuvel (2023-01-18 10:22:12) > > On Wed, 18 Jan 2023 at 09:48, Ard Biesheuvel wrote: > > > > > > On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrot

[edk2-devel] [PATCH 3/3] ArmVirtPkg: CI: Perform build test of ArmVirtKvmTool

2023-01-19 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 25 +++ ArmVirtPkg/PlatformCI/KvmToolBuild.py | 215 2 files changed, 240 insertions(+) diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b

[edk2-devel] [PATCH 2/3] ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel

2023-01-19 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 43 ArmVirtPkg/PlatformCI/QemuKernelBuild.py | 268 2 files changed, 311 insertions(+) diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b

[edk2-devel] [PATCH 1/3] ArmVirtPkg/PrePi: Ensure timely execution of library constructors

2023-01-19 Thread Ard Biesheuvel
that. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/PrePi/PrePi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c index c15dc305fced..3d943b2138d3 100755 --- a/ArmVirtPkg/PrePi/PrePi.c +++ b/ArmVirtPkg/PrePi/PrePi.c @@ -60,6 +60,9

[edk2-devel] [PATCH 0/3] ArmVirtPkg: Increase PlatformCI coverage

2023-01-19 Thread Ard Biesheuvel
, which hadn't been reported yet. Cc: Gerd Hoffmann Cc: Michael Kubacki Cc: Jiewen Yao Ard Biesheuvel (3): ArmVirtPkg/PrePi: Ensure timely execution of library constructors ArmVirtPkg: CI: Perform build and boot test of ArmVirtQemuKernel ArmVirtPkg: CI: Perform build test

Re: [edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg

2023-01-19 Thread Ard Biesheuvel
On Thu, 19 Jan 2023 at 08:55, Gerd Hoffmann wrote: > > On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote: > > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > > second input parameter in FfsFindSectionData. This change breaks the build > > of ArmVirtPkg. To fix this

Re: [edk2-devel] [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 02:19, Isaac Oram wrote: > > Reviewed-by: Isaac Oram > NAK This version updates VERSION_STRING not INF_VERSION INF_VERSION must be 1.29 VERSION_STRING can be anything you like > -Original Message- > From: Tommy Huang > Sent: Tuesday, January 17, 2023 4:39 PM

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 17:41, Yao, Jiewen wrote: > > I think it is feasible. > > For example, https://github.com/tianocore/edk2/tree/master/OvmfPkg/PlatformCI > includes multiple xxxBuild.py. Each GetDscName() will return different dsc. > > But

Re: [edk2-devel] [PATCH v2] x86/efi: Safely enable unaccepted memory in UEFI

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 16:41, Dave Hansen wrote: > > On 1/18/23 07:09, Ard Biesheuvel wrote: > > However, I guess we're at a point where SEV and TDX really want > > different solutions, so I think divergence might be the way to > > proceed. > > I don't think the

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 14:43, Gerd Hoffmann wrote: > > On Wed, Jan 18, 2023 at 12:07:52PM +, Yao, Jiewen wrote: > > Hey Ard > > I am worried about the CI for ArmVirtPkg. > > Can we add such ArmVirtPkg build into CI? > > CI builds one of the ArmVirtPkg configs (ArmVirtQemu.dsc specifically), >

Re: [edk2-devel] [PATCH v2] x86/efi: Safely enable unaccepted memory in UEFI

2023-01-18 Thread Ard Biesheuvel
(cc'ing some folks whom I've discussed this with off-list today) Full discussion here: https://lore.kernel.org/linux-efi/20230113212926.2904735-1-dionnagl...@google.com/ On Mon, 16 Jan 2023 at 23:46, Tom Lendacky wrote: > > On 1/16/23 15:22, Dave Hansen wrote: > > On 1/16/23 02:56, Gerd

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 12:50, Laszlo Ersek wrote: > > On 1/18/23 08:25, Gerd Hoffmann wrote: > > On Tue, Jan 17, 2023 at 05:43:53PM +0100, Ard Biesheuvel wrote: > >> On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote: > >>> > >>> Hi, > >>

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

2023-01-18 Thread Ard Biesheuvel
916 > > > -Original Message- > > From: Gerd Hoffmann > > Sent: Tuesday, January 17, 2023 6:58 PM > > To: Xu, Min M > > Cc: devel@edk2.groups.io; Leif Lindholm ; Ard > > Biesheuvel ; Abner Chang > > ; Daniel Schaefer ; Aktas, > > Erde

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 09:48, Ard Biesheuvel wrote: > > On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrote: > > > > Quoting Ard Biesheuvel (2023-01-18 08:34:32) > > > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > > > > > On

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-18 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrote: > > Quoting Ard Biesheuvel (2023-01-18 08:34:32) > > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > > >> > > >&g

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-17 Thread Ard Biesheuvel
On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: >> >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: >> > >> > Hi Ard, Hi everyone, >> > >> > Thanks for the work! >>

Re: [edk2-devel][edk2-non-osi][PATCH 1/1] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

2023-01-17 Thread Ard Biesheuvel
Note that the value in the INF_VERSION field cannot be chosen arbitrarily - it should be the latest version of the INF spec, so 1.29 (you don't need to put a hex value here, just "1.29" is fine) On Tue, 17 Jan 2023 at 23:40, Isaac Oram wrote: > > Reviewed-by: Isaac Oram > > Note that you do not

Re: [edk2-devel] [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs

2023-01-17 Thread Ard Biesheuvel
ge from the tianocode/containers repository which > pins down version numbers of gcc, iasl, and nasm in the Dockerfile. > > v2: > - Images are now hosted under the Tianocore Organization > https://github.com/tianocore/containers > > v1: > - Thread: https://edk2.groups.

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformInitLib: pass through reservations from qemu

2023-01-17 Thread Ard Biesheuvel
On Mon, 16 Jan 2023 at 21:10, Tom Lendacky wrote: > > On 1/16/23 11:09, Ard Biesheuvel wrote: > > On Thu, 12 Jan 2023 at 18:09, Tom Lendacky wrote: > >> > >> On 12/6/22 23:32, Gerd Hoffmann via groups.io wrote: > >>> qemu uses the etc/e820 fw_cf

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote: > > Hi, > > > >> In particular the firmware makes no further decisions based on > > >> whether QEMU advertized some of these features. > > > > > > I was thinking the other way around: When cpu hotplug is disabled in > > > qemu it should be

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg: Update ArmPlatformLib to work with changed ARM_CORE_INFO

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 13:55, Rebecca Cran wrote: > > I was under the impression that this is becoming a more standard format? > If this is not defined in an ARM spec somewhere, we shouldn't add it to ArmPkg at this point. > For example, the Neoverse N2 has AFF0 always 0 (it's not

Re: [edk2-devel] [PATCH v4 0/5] OvmfPkg: check 64bit mmio window for resource conflicts

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 13:16, Gerd Hoffmann wrote: > > v4: > - made mmio window move a bit more robust. > - dropped patches for moving MMCONFIG, they'll come as separate patch >series later. > > v3: > - Add / fix comments, add notes to commit messages. > - Make functions static. > -

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote: > > On 1/17/23 13:16, Gerd Hoffmann wrote: > > + PlatformAddMemoryRangeHob (Base, End); > > +} > > + } > > + > > (2) Still not sure if this empty line is intentional (it may be, you > didn't answer it under the v2 review

Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg/PlatformInitLib: Add PlatformAddHobCB

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 16:03, Laszlo Ersek wrote: > > On 1/17/23 13:16, Gerd Hoffmann wrote: > > Add PlatformAddHobCB() callback function for use with > > PlatformScanE820(). It adds HOBs for high memory and reservations (low > > memory is handled elsewhere because there are some special cases

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-17 Thread Ard Biesheuvel
d asimdrdm > Caches (sum of all): > L1d: 1.8 MiB (56 instances) > L1i: 1.8 MiB (56 instances) > L2: 14 MiB (56 instances) > L3: 64 MiB (2 instances) > [...] > > Thanks a lot! > - Oliver > > >

Re: [edk2-devel] [PATCH v4 1/5] OvmfPkg/PlatformInitLib: Add PlatformScanE820 and GetFirstNonAddressCB

2023-01-17 Thread Ard Biesheuvel
On Tue, 17 Jan 2023 at 15:47, Laszlo Ersek wrote: > > On 1/17/23 13:16, Gerd Hoffmann wrote: > > > +/** > > + Store first address not used by e820 RAM entries in > > + PlatformInfoHob->FirstNonAddress > > +**/ > > +VOID > > +PlatformGetFirstNonAddressCB ( > > + IN EFI_E820_ENTRY64

Re: [edk2-devel] [PATCH edk2-platforms 0/2] toolchain cleanups

2023-01-17 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 17:01, Ard Biesheuvel wrote: > > This cleans up some obsolete toolchain configuration variables: > - the RVCT ones, which are no longer supported by EDK2 > - ARCHCC and ARCHASM, which serve no useful purpose and are better > removed > > Ard Biesheu

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PlatformInitLib: pass through reservations from qemu

2023-01-16 Thread Ard Biesheuvel
On Thu, 12 Jan 2023 at 18:09, Tom Lendacky wrote: > > On 12/6/22 23:32, Gerd Hoffmann via groups.io wrote: > > qemu uses the etc/e820 fw_cfg file not only for memory, but > > also for reservations. Handle reservations by adding resource > > descriptor hobs for them. > > > > A typical qemu

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-16 Thread Ard Biesheuvel
On Fri, 13 Jan 2023 at 13:22, Gerd Hoffmann wrote: > > On Fri, Jan 13, 2023 at 11:10:54AM +0100, Laszlo Ersek wrote: > > On 1/13/23 10:32, Gerd Hoffmann wrote: > > > On Fri, Jan 13, 2023 at 07:03:54AM +0100, Gerd Hoffmann wrote: > > >> Hi, > > >> > > >>> - QEMU can be configured with other

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Measure ACPI table from QEMU in TDVF

2023-01-16 Thread Ard Biesheuvel
CPI table constructed by the BIOS dynamically does not need to be > measured. For example MADT. > OK so which EDK2 component is normally in charge of this? > > -Original Message- > > From: Ard Biesheuvel > > Sent: Monday, January 16, 2023 6:38 PM > > To: devel@edk

<    5   6   7   8   9   10   11   12   13   14   >