[Public]
+Laszlo, +Gerd, +Paolo
PR: https://github.com/tianocore/edk2/pull/4982
-Original Message-
From: Lin, Jacque
Sent: Tuesday, October 31, 2023 11:07 AM
To: devel@edk2.groups.io
Cc: Lin, Jacque ; Attar, AbdulLateef (Abdul Lateef)
; Chang, Abner
Subject: [PATCH v2]
[Public]
Hi Laszlo and @Lin, Jacque
Please find my response inline.
Thanks
AbduL
-Original Message-
From: Laszlo Ersek
Sent: Monday, October 30, 2023 7:34 PM
To: devel@edk2.groups.io; Lin, Jacque
Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner
; Gerd Hoffmann ; Paolo
[AMD Official Use Only - General]
Reviewed-by: Attar, AbdulLateef (Abdul Lateef) ;
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, October 23, 2023 6:35 PM
To: devel@edk2.groups.io
Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
; nick...@nvidia.com; Konstantin
[AMD Official Use Only - General]
Reviewed-by: Attar, AbdulLateef (Abdul Lateef)
-Original Message-
From: Konstantin Aladyshev
Sent: Monday, October 23, 2023 6:35 PM
To: devel@edk2.groups.io
Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
; nick...@nvidia.com; Konstantin
[AMD Official Use Only - General]
Acked-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Thursday, October 19, 2023 11:13 AM
To: devel@edk2.groups.io
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Attar, AbdulLateef (Abdul
Lateef) ; Nickle Wang ; Jian J
Wang
[AMD Official Use Only - General]
Looks good.
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Tuesday, October 10, 2023 8:47 PM
To: devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang
Subject: [edk2-platforms][PATCH]
[Public]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Xing, Eric
Sent: Thursday, September 28, 2023 10:37 PM
To: devel@edk2.groups.io
Cc: Michael D Kinney ; Chang, Abner
; Leif Lindholm ; Attar,
AbdulLateef (Abdul Lateef)
Subject: [[edk2-non-osi][Silicon/AMD][PATCH v2]
[AMD Official Use Only - General]
Hi Jeff, Sami,
I'm not reviewer, just providing the opinion.
How about making it generic(generic to integer argument) instead of single
integer argument.
INUINT64 IntegerArgument
IN UINT64
[AMD Official Use Only - General]
Gentle reminder, review please.
-Original Message-
From: Chang, Abner
Sent: Thursday, August 3, 2023 12:12 PM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai Chaganty
; Isaac Oram ; Nate
[AMD Official Use Only - General]
Thanks Dun for clarifying, I'll submit the patch.
Regards,
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan via
groups.io
Sent: Tuesday, July 11, 2023 3:21 PM
To: Attar, AbdulLateef (Abdul Lateef) ; Ni, Ray
;
[AMD Official Use Only - General]
Hi Ray,
I think Michael raised the similar concerned during the patch review.
Its intentionally kept it as gSmst because of the below reason.
2. AmdMmSaveStateLib and IntelMmSaveStateLib depend on SmmServicesTableLib. Can
they depend on
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Wednesday, June 21, 2023 7:08 AM
To: devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef)
Subject: [edk2-platforms][PATCH 2/2]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Wednesday, June 21, 2023 10:36 AM
To: devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef)
Subject: [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Tuesday, May 30, 2023 12:03 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Tuesday, May 30, 2023 12:03 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 2/2]
[AMD Official Use Only - General]
Emulator PR failed, that might be the reason its not allowing to push
https://github.com/tianocore/edk2/pull/4442/checks?check_run_id=13834435150
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
via groups.io
Sent: Monday, May
[AMD Official Use Only - General]
Hi Abner,
Yes, its same patch series with V2 version.
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: Friday, May 26, 2023 7:07 AM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef)
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 13 May 2023 18:03
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 12 May 2023 15:28
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2]
[AMD Official Use Only - General]
Hi Ray,
Looks like some issue with my mailbox, I saw your mail after submitting
patch V12.
I'll rework and send V13 patch series.
Thanks
AbduL
-Original Message-
From: Ni, Ray
Sent: 12 May 2023 09:11
To: devel@edk2.groups.io; Ni, Ray ; Attar,
[AMD Official Use Only - General]
Hi Michael,
Thanks for providing the inputs, I will make the necessary changes.
Please see inline for my reply.
-Original Message-
From: Michael Kubacki
Sent: 10 May 2023 00:42
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc:
[AMD Official Use Only - General]
reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 05 May 2023 10:54
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 09 May 2023 13:26
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 05 May 2023 10:54
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH]
[AMD Official Use Only - General]
Thanks Gerd, for the inputs. I'll drop the patch and submit the new version.
-AbduL
-Original Message-
From: Gerd Hoffmann
Sent: 04 May 2023 14:13
To: Attar, AbdulLateef (Abdul Lateef)
Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
;
[Public]
Thanks Isaac for correcting and pushing the patch.
-Original Message-
From: Oram, Isaac W
Sent: 02 May 2023 05:42
To: devel@edk2.groups.io; Oram, Isaac W ; Attar,
AbdulLateef (Abdul Lateef)
Cc: Chang, Abner ; Chaganty, Rangasai V
; Desimone, Nathaniel L
; Gao, Liming
[Public]
Hi Maintainers,
Please review the patch.
Thanks
AbduL
-Original Message-
From: Abdul Lateef Attar
Sent: 10 April 2023 15:56
To: devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner
; Sai Chaganty ; Isaac Oram
; Nate DeSimone ;
Liming Gao
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 21 April 2023 10:53
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V3 01/14]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 21 April 2023 10:53
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V3 03/14]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 21 April 2023 10:53
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V3 04/14]
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 18 April 2023 12:46
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V2 02/14]
[AMD Official Use Only - General]
Comments inline.
-Original Message-
From: Chang, Abner
Sent: 18 April 2023 12:46
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH V2 01/14] ManageabilityPkg:
[AMD Official Use Only - General]
Hi Ray,
From open-source code I can see OVMF still implements
SmmCpuFeaturesReadSaveStateRegister.
Hence, we can't directly use SmramSaveStateReadRegister in PiSmmCpuDxe driver,
until we implement the MmSaveStateLib for Ovmf.
I think it's better
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 17 April 2023 18:26
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH V2 2/3]
[AMD Official Use Only - General]
Hi @Ard Biesheuvel , @Leif Lindholm, @Michael D Kinney,
I had renamed the folder from MinBoardPkg to AmdMinBoardPkg, could you
please review it.
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via
[AMD Official Use Only - General]
Thanks for review comment, will update accordingly.
-Original Message-
From: Ni, Ray
Sent: 11 April 2023 13:21
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Grimes, Paul ; Kirkendall, Garrett
; Chang, Abner ; Dong, Eric
; Kumar,
[AMD Official Use Only - General]
Hi Abner,
I think EDK2 uses the below naming convention for variables which are
acronyms.
First letter is capitalized, and rest all are smaller.
Its better to rename below variables from I2C to
I2c.
-Original Message-
From: Chang, Abner
Sent:
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Saturday, April 15, 2023 5:27 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Saturday, April 15, 2023 5:27 PM
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH
[AMD Official Use Only - General]
Hi Mike, Abner,
Patch 5/9 is blank implementation of SmmCpuFeaturesLib library class.
Whereas patch 6/9 is actual implementation of the library for AMD processor
family.
I had separated in two different patches for easy to review.
Thanks
AbduL
[AMD Official Use Only - General]
Hi Ray,
I added the prefix "_" to be in align with Intel's SmramSaveStateMap.h,
so that it looks similar and suppose in future if there is any common
functionality requires then
we can easily add to the common files.
Thanks
AbduL
-Original
[AMD Official Use Only - General]
Hi Gerd,
I think CI was failing with the message " SmmSmramSaveStateLib library
not found", I didn't preserve the CI log.
Thanks
Abdul
-Original Message-
From: Gerd Hoffmann
Sent: 11 April 2023 15:13
To: Attar, AbdulLateef (Abdul Lateef)
Cc:
[AMD Official Use Only - General]
Hi Ray,
You mean directly call the SmramSaveStateReadRegister instead of below
code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ?
Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width,
Buffer);
if (Status ==
[AMD Official Use Only - General]
Got it, will merge these two patches(5/9 and 6/9) into single patch.
-Original Message-
From: Kinney, Michael D
Sent: 12 April 2023 00:19
To: Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner
; devel@edk2.groups.io
Cc: Grimes, Paul ; Kirkendall, Garrett
[AMD Official Use Only - General]
Hi Ray,
Please see inline.
Thanks
AbduL
-Original Message-
From: Ni, Ray
Sent: 31 March 2023 13:29
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes, Paul
; Kirkendall, Garrett ; Chang,
[AMD Official Use Only - General]
Hi Sean,
Renamed the AMD/MinBoardPkg to AMD/AmdMinBoardPkg and submitted the V4
version for review.
PR: https://github.com/tianocore/edk2-platforms/pull/75
Thanks
AbduL
-Original Message-
From: Sean Brogan
Sent: 01 April 2023 01:50
To:
[Public]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Oram, Isaac W
Sent: 23 March 2023 23:07
To: Leif Lindholm ; Chang, Abner
Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
; Kinney, Michael D ;
Gao, Liming ; Nickle Wang
Subject: RE: [PATCH v4 9/9]
[AMD Official Use Only - General]
Some comments inline.
-Original Message-
From: Chang, Abner
Sent: 22 March 2023 08:19
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Nickle Wang
; Igor Kulchytskyy ; Attar, AbdulLateef
(Abdul Lateef)
Subject: [PATCH v4 3/9]
[Public]
Hi Abner,
That's right, Platform/AMD/MinBoardPkg will contains all
modules/library/drivers required for AMD boards which are based on
MinPlatformPkg framework.
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: 22 March 2023 15:25
To: Attar, AbdulLateef (Abdul
[AMD Official Use Only - General]
Hi Leif,
AMD/BoardPkg will implements modules specific to boards(one or more
motherboards).
It will not contain any module specific to Platform or Silicon, which are part
of MinPlatformPkg.
How about just Min prefix?
AMD/MinBoardPkg (I am avoiding the
[AMD Official Use Only - General]
Thanks for reviewing, will submit V3 patch.
-Original Message-
From: Leif Lindholm
Sent: 17 March 2023 21:30
To: Attar, AbdulLateef (Abdul Lateef)
Cc: devel@edk2.groups.io; Ard Biesheuvel ; Chang,
Abner ; Michael D Kinney
Subject: Re: [PATCH v2
[AMD Official Use Only - General]
Hi Leif,
Please see inline my reply [Abdul]
I'll address the remaining review comments and submit V3 version.
Thanks
AbduL
-Original Message-
From: Leif Lindholm
Sent: 17 March 2023 21:25
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul
[Public]
Hi Leif,
AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg
framework.
BoardPkg will be generic across all AMD boards which are based on
MinPlatformPkg framework.
It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
We will gradually add modules
[AMD Official Use Only - General]
Hi Leif,
How about adding a separate entry?
Currently its generic to adapt the MinPlatformPkg, later will add more specific
platforms.
AMD board and platform
F: Platform/AMD/BoardPkg
F: Platform/AMD/PlatformPkg
M: maintainer1
M: maintainer2
AMD Seattle
F:
[AMD Official Use Only - General]
Hi Abner,
Thanks for reviewing the code, I had addressed the review comments in
V2 version.
- Abdul
-Original Message-
From: Abdul Lateef Attar
Sent: 17 March 2023 11:59
To: devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard
[Public]
Looks good.
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: Friday, March 3, 2023 1:10 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Attar, AbdulLateef (Abdul
Lateef) ; Nickle Wang ; Igor
Kulchytskyy
Subject:
[AMD Official Use Only - General]
Hi Isaac,
Please see inline for my reply. [Abdul]
Thanks
AbduL
-Original Message-
From: Oram, Isaac W
Sent: 18 January 2023 02:01
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Dong, Eric ; Gao, Liming
Subject: RE: [edk2-devel]
[AMD Official Use Only - General]
Hi Maintainers,
Could you please review and merge the below patch?
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: 15 November 2022 17:34
To: devel@edk2.groups.io
Cc: Eric Dong ;
Hi Abner,
Please see inline for my reply under [Abdul].
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: 15 January 2023 10:15
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc: Grimes, Paul ; Kirkendall, Garrett
; Eric Dong ; Ray Ni
; Rahul Kumar ; Gerd
[AMD Official Use Only - General]
Hi Ray,
I just rebase the PR and it passed all CI tests.
Hope, this is sufficient, or do I need to re-submit the patch ?
Thanks
AbduL
-Original Message-
From: Ni, Ray
Sent: 13 January 2023 14:28
To: Laszlo Ersek ; devel@edk2.groups.io; Attar,
[AMD Official Use Only - General]
Hi Abner,
Thanks for quick review. I'll create a new library and submit
the patch.
Thanks
AbduL
From: abner.chang via groups.io
Sent: 08 December 2022 10:38
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Subject: Re: [edk2-devel]
[AMD Official Use Only - General]
Hi Abner,
I’ll drop this patch from the patch list. We will investigate
and submit a separate patch for handling the S3 save stage.
Thanks
AbduL
From: abner.chang via groups.io
Sent: 08 December 2022 11:17
To: Attar, AbdulLateef (Abdul Lateef)
[AMD Official Use Only - General]
Looks good to me
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 15 October 2022 17:18
To: devel@edk2.groups.io
Cc: Ray Ni ; Michael D Kinney ;
Sunil V L ; Attar, AbdulLateef (Abdul Lateef)
; Leif Lindholm
Subject:
[Public]
Review please
-Original Message-
From: devel@edk2.groups.io On Behalf Of Attar,
AbdulLateef (Abdul Lateef) via groups.io
Sent: 16 September 2022 12:58
To: devel@edk2.groups.io; Eric Dong ; Liming Gao
Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg
Hi Abner,
Looks good to me.
Reviewed-by: Abdul Lateef Attar
Thanks
AbduL
-Original Message-
From: Chang, Abner
Sent: 28 September 2022 20:31
To: Sunil V L ; devel@edk2.groups.io; ray...@intel.com
Cc: Kinney, Michael D ; lichao
; Kirkendall, Garrett ; Grimes,
Paul ; He, Jiangang
[Public]
Hello Maintainers, Reviewers,
Could you please review the patch?
Thanks
AbduL
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: 13 July 2022 09:49
To: 'devel@edk2.groups.io' ; 'Eric Dong'
; 'Liming Gao'
Subject: RE: [edk2-devel] [edk2-platforms PATCH v1
[AMD Official Use Only - General]
Hi Liming, Zhiguang,
You can revert the patch, I will re-submit the patch for the next release.
Thanks
AbduL
From: gaoliming
Sent: 24 August 2022 12:50
To: devel@edk2.groups.io; zhiguang@intel.com; Attar, AbdulLateef (Abdul
Lateef)
Cc:
[Public]
Maintainers, Reviewers,
please review the patch.
Thanks
AbduL
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: 25 April 2022 12:45
To: devel@edk2.groups.io; Eric Dong ; Liming Gao
Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy
[Public]
Hi,
Please review the patch.
Thanks
AbduL
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: 05 April 2022 11:25
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
; Eric Dong ; Liming Gao
Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1]
[Public]
Hi,
Could you please review the patch?
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: 15 March 2022 10:16
To: devel@edk2.groups.io
Cc: Eric Dong ; Liming Gao
Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1]
Gentle reminder for PR.
-Original Message-
From: Gao, Zhichao
Sent: Monday, February 21, 2022 1:10 PM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ni, Ray ; Sami Mujawar
Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
[CAUTION:
Hi,
Gentle reminder, Please review the patch.
Thanks
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: Friday, January 7, 2022 7:26 PM
To: devel@edk2.groups.io
Cc: Michael D Kinney ; Liming Gao
; Zhiguang Liu
Subject:
[Public]
Hi Sami,
Why Bugzilla ticket required?
Also please see inline for my response [Abdul].
Thanks
AbduL
From: devel@edk2.groups.io On Behalf Of Sami Mujawar via
groups.io
Sent: 19 January 2022 22:17
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ray Ni ;
[AMD Official Use Only]
Hi Zhichao Gao, Ray Ni,
Could you please review the below patches and merge the changes?
Thanks
AbduL
-Original Message-
From: Attar, AbdulLateef (Abdul Lateef)
Sent: 07 January 2022 08:29
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
Cc:
[AMD Official Use Only]
Gentle reminder...please review and merge the changeset.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Abdul Lateef
Attar via groups.io
Sent: 19 December 2021 20:15
To: devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; Sami
Mujawar
Subject:
Hi Zhichao Gao, Ray Ni, Sami Mujawar,
Please review and create PR if looks good.
Thanks
AbduL
-Original Message-
From: Sami Mujawar
Sent: Monday, November 22, 2021 11:24 PM
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; nd
Subject: Re:
[Public]
Hi Heinrich,
Not able to attach the patch to the below Bugzilla link (yet to create
an account).
Hence attaching the patch with this mail.
Also find the reference branch link below.
https://github.com/abdattar/edk2-test/tree/X64_GCC_Compilation_fix
Thanks
AbduL
-Original
[Public]
Code changes looks good.
Is fwts passing now? I think FWTS has wrong test case.
It expects Global system interrupt number to be zero for APIC interrupt type,
which is wrong.
In my opinion it should check for Global system interrupt number for zero in
case of PC-AT interrupt type.
[Public]
Hi Nate,
I tested on windows 2019 and RHEL 8.3 and it works fine on both OSes.
Thanks
AbduL
-Original Message-
From: Desimone, Nathaniel L
Sent: 28 October 2021 08:19
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Chiu, Chasel ; Liming Gao
; Dong,
[AMD Official Use Only]
Hi Nate,
I'm following below Leszlo's document to submit the patch.
Please let me know how to remove the groups.io web interface.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers
Thanks
AbduL
[Public]
Hi Nate,
I tested on real hardware with latest linux(didn't tested with older
OSes).
Note that with X2APIC mode I don't see any issue having APIC NMI structure and
not having NMI structure.
In both cases OS boots without any issue. Just thought that why to include APIC
NMI
[AMD Official Use Only]
Gentle reminder to merge the code.
-Original Message-
From: Gao, Zhichao
Sent: 09 September 2021 07:54
To: Attar, AbdulLateef (Abdul Lateef) ;
devel@edk2.groups.io
Cc: Ni, Ray
Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure
82 matches
Mail list logo
