[AMD Official Use Only - General]

Hi Gerd,
        I think CI was failing with the message " SmmSmramSaveStateLib library 
not found", I didn't preserve the CI log.
Thanks
Abdul

-----Original Message-----
From: Gerd Hoffmann <kra...@redhat.com>
Sent: 11 April 2023 15:13
To: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>
Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) 
<abdullateef.at...@amd.com>; Grimes, Paul <paul.gri...@amd.com>; Kirkendall, 
Garrett <garrett.kirkend...@amd.com>; Chang, Abner <abner.ch...@amd.com>; Eric 
Dong <eric.d...@intel.com>; Ray Ni <ray...@intel.com>; Rahul Kumar 
<rahul1.ku...@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; Jiewen 
Yao <jiewen....@intel.com>; Jordan Justen <jordan.l.jus...@intel.com>
Subject: Re: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


> Uses new SmmSmramSaveStateLib library, which fix the CI failure.

What is the exact failure you are seeing?

> +
> + SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSm
> + mSmramSaveStateLib.inf

This should be the AMD version.  KVM uses the AMD smram state.

Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use actually use 
the new SmmSmramSaveStateLib library, and once this has been done it should be 
possible to remove OvmfPkg/Include/Register/QemuSmramSaveStateMap.h

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102904): https://edk2.groups.io/g/devel/message/102904
Mute This Topic: https://groups.io/mt/98172964/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to