is invalid.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolCommon.c
b/Features/ManageabilityPkg/Universal
From: Abner Chang
Currently all PLDM functions inside the PLDM_SMBIOS_TRANSFER_PROTOCOL
use PLDM terminus PCDs for the MCTP addressing.
Add additional function to the protocol API to provide user a way to
use custom TIDs.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
custom TIDs either via PldmSubmit
function arguments or by calling PldmSetTerminus API.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Include/Library/BasePldmProtocolLib.h | 16 ++
.../Include/Protocol/PldmProtocol.h | 18 +++---
.../PldmProtocolLibrary
the response buffer size handling.
Also update the message for error conditions.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../PldmProtocol/Common/PldmProtocolCommon.c | 100 +++---
.../PldmProtocol/Common/PldmProtocolCommon.h | 3 +
.../Universal/PldmProtocol/Dxe
Currently PldmSubmit command returns EFI_SUCCESS even if the response
header checks have failed.
Correct the code to return errors in such cases.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 9 ++---
1 file changed, 6 insertions(+), 3
From: Abner Chang
Add PLDM source and destination terminus IDs for transmiting PLDM
message.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Features/ManageabilityPkg
If MCTP KCS communication has failed we need to abort MCTP transfer
function before checking any MCTP header data.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Since the current driver doesn't yet support handling of
multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such
cases.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Currently PldmProtocol code uses magic numbers in the PLDM header
checks. Since PLDM headers have all the necessary definitions replace
magic numbers with the appropriate defines.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c| 8
1
Correct wrong structure member used for MCTP destination EID.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Features/ManageabilityPkg
values only if the
pointers are NULL.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Include/Protocol/MctpProtocol.h | 12 --
.../Dxe/ManageabilityTransportMctp.c | 4 +-
.../MctpProtocol/Common/MctpProtocolCommon.c | 4 +-
.../Universal
Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP
request and response.
According to the MTCP Base specification in case of the MCTP response
the TAG_OWNER bit should be equal to 0.
Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue.
Signed-off-by: Konstantin
Add checks for the MCTP header fields in the MCTP response.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 82 +++
1 file changed, 82 insertions(+)
diff --git
a/Features/ManageabilityPkg/Universal/MctpProtocol/Common
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
Tested:
- The IPMI KCS communication is tested by Abner Chang,
- The MCTP KCS communication is tested by Konstantin Aladyshev on the
AMD
MTCP base specification marks EIDs 1-7 as reserved. Therefore return
EFI_INVALID_PARAMETER if such EIDs were provided to the
MctpSubmitMessage function.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Universal/MctpProtocol/Dxe/MctpProtocol.c | 17 +
1
Currently there is only a definition for the MCTP KCS HEADER structure.
Add definition for the MCTP KCS TRAILER structure as well.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Library/ManageabilityTransportMctpLib.h| 5 +
.../MctpProtocol/Common
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
This patch is a result of a joint effort from the Konstantin Aladyshev
and Abner Chang .
Tested:
PLDM communication between the HOST
From: Abner Chang
Currently all PLDM functions inside the PLDM_SMBIOS_TRANSFER_PROTOCOL
use PLDM terminus PCDs for the MCTP addressing.
Add additional function to the protocol API to provide user a way to
use custom TIDs.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
Currently PldmSubmit command returns EFI_SUCCESS even if the response
header checks have failed.
Correct the code to return errors in such cases.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 9 ++---
1 file changed, 6 insertions(+), 3
the response buffer size handling.
Also update the message for error conditions.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../PldmProtocol/Common/PldmProtocolCommon.c | 100 +++---
.../PldmProtocol/Common/PldmProtocolCommon.h | 3 +
.../Universal/PldmProtocol/Dxe
custom TIDs either via PldmSubmit
function arguments or by calling PldmSetTerminus API.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Include/Library/BasePldmProtocolLib.h | 16 ++
.../Include/Protocol/PldmProtocol.h | 18 +++---
.../PldmProtocolLibrary
From: Abner Chang
Add PLDM source and destination terminus IDs for transmiting PLDM
message.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
Features/ManageabilityPkg/ManageabilityPkg.dec | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Features/ManageabilityPkg
Since the current driver doesn't yet support handling of
multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such
cases.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Currently PldmProtocol code uses magic numbers in the PLDM header
checks. Since PLDM headers have all the necessary definitions replace
magic numbers with the appropriate defines.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c| 8
1
If MCTP KCS communication has failed we need to abort MCTP transfer
function before checking any MCTP header data.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP
request and response.
According to the MTCP Base specification in case of the MCTP response
the TAG_OWNER bit should be equal to 0.
Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue.
Signed-off-by: Konstantin
values only if the
pointers are NULL.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Include/Protocol/MctpProtocol.h | 12 --
.../Dxe/ManageabilityTransportMctp.c | 4 +-
.../MctpProtocol/Common/MctpProtocolCommon.c | 4 +-
.../Universal
Add checks for the MCTP header fields in the MCTP response.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 82 +++
1 file changed, 82 insertions(+)
diff --git
a/Features/ManageabilityPkg/Universal/MctpProtocol/Common
Correct wrong structure member used for MCTP destination EID.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Features/ManageabilityPkg
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
Tested:
- The IPMI KCS communication is tested by Abner Chang,
- The MCTP KCS communication is tested by Konstantin Aladyshev on the
AMD
MTCP base specification marks EIDs 1-7 as reserved. Therefore return
EFI_INVALID_PARAMETER if such EIDs were provided to the
MctpSubmitMessage function.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Universal/MctpProtocol/Dxe/MctpProtocol.c | 17 +
1
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
This patch is a result of a joint effort from the Konstantin Aladyshev
and Abner Chang .
Tested:
PLDM communication between the HOST
Currently there is only a definition for the MCTP KCS HEADER structure.
Add definition for the MCTP KCS TRAILER structure as well.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Library/ManageabilityTransportMctpLib.h| 5 +
.../MctpProtocol/Common
,
Konstantin Aladyshev
On Wed, Oct 18, 2023 at 6:45 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Code update is on
> https://github.com/changab/edk2-platforms/tree/MCTP_OVER_KCS_UPDATE, the last
> commit.
>
> Abner
>
> > -Original Message
minor observation, there are actually 2 reserved values for
the TID according to the specification: 0x00 and 0xff.
Best regards,
Konstantin Aladyshev
On Tue, Oct 17, 2023 at 6:41 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Aladyshev,
> I had updated code accord
Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP
request and response.
According to the MTCP Base specification in case of the MCTP response
the TAG_OWNER bit should be equal to 0.
Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue.
Signed-off-by: Konstantin
Since the current driver doesn't yet support handling of
multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such
cases.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Currently PldmProtocol code uses magic numbers in the PLDM header
checks. Since PLDM headers have all the necessary definitions replace
magic numbers with the appropriate defines.
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c| 8
1
values only if the
pointers are NULL.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Include/Protocol/MctpProtocol.h | 12 --
.../Dxe/ManageabilityTransportMctp.c | 4 +-
.../MctpProtocol/Common/MctpProtocolCommon.c | 4 +-
.../Universal
If MCTP KCS communication has failed we need to abort MCTP transfer
function before checking any MCTP header data.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Correct wrong structure member used for MCTP destination EID.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
.../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Features/ManageabilityPkg
Add checks for the MCTP header fields in the MCTP response.
Signed-off-by: Konstantin Aladyshev
---
.../MctpProtocol/Common/MctpProtocolCommon.c | 82 +++
1 file changed, 82 insertions(+)
diff --git
a/Features/ManageabilityPkg/Universal/MctpProtocol/Common
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
Tested:
- The IPMI KCS communication is tested by Abner Chang,
- The MCTP KCS communication is tested by Konstantin Aladyshev on the
AMD
Currently there is only a definition for the MCTP KCS HEADER structure.
Add definition for the MCTP KCS TRAILER structure as well.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Library/ManageabilityTransportMctpLib.h| 5 +
.../MctpProtocol/Common
MTCP base specification marks EIDs 1-7 as reserved. Therefore return
EFI_INVALID_PARAMETER if such EIDs were provided to the
MctpSubmitMessage function.
Signed-off-by: Konstantin Aladyshev
Signed-off-by: Abner Chang
---
.../Universal/MctpProtocol/Dxe/MctpProtocol.c | 17 +
1
.
Modify Manageability KCS transport library code to check which message
is processed (IPMI or MCTP) and handle each case correctly based on its
own specification.
This patch is a result of a joint effort from the Konstantin Aladyshev
and Abner Chang .
Tested:
PLDM communication between the HOST
The PLDM protocol uses Request bit to help differentiate between PLDM
request and response messages.
Currently the Pldm.h header only have a flag for the request message.
Add a flag for the response message as well.
Signed-off-by: Konstantin Aladyshev
---
MdePkg/Include/IndustryStandard/Pldm.h
Correct MCTP_TRANSPORT_HEADER structure field 'SourceEndpointIdId' to
'SourceEndpointId'.
Signed-off-by: Abner Chang
Signed-off-by: Konstantin Aladyshev
---
MdePkg/Include/IndustryStandard/Mctp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include
t; firm?
As a part of my job I develop UEFI and BMC firmware. But all the
open-source work that I do I perform on my own free time. So you can
count me as an individual contributor)
Best regards,
Konstantin Aladyshev
On Sat, Oct 14, 2023 at 11:06 AM Chang, Abner wrote:
>
> [AMD Off
them and provide feedback.
Also I wanted to ask if you plan to work on the required changes
yourself, or am I on my own from here?)
Best regards,
Konstantin Aladyshev
On Wed, Oct 11, 2023 at 8:58 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Aladyshev,
> Here
error
information to the user?
I've also created PRs for your edk2/edk2-platforms forks with some
things that I've found today.
https://github.com/changab/edk2/pull/1
https://github.com/changab/edk2-platforms/pull/6
Best regards,
Konstantin Aladyshev
On Thu, Oct 5, 2023 at 3:31 PM Konstantin
)
Because only the PldmSmbios protocol code should know such information
as expected response sizes for its commands.
Best regards,
Konstantin Aladyshev
On Thu, Oct 5, 2023 at 3:19 PM Konstantin Aladyshev
wrote:
>
> Also I see that the 'PldmProtocolCommon' code contains array of
> expected
/PldmProtocolCommon.c#L261
This means that right now I can't execute my simple 'GetPLDMTypes'
command through the 'PldmSubmit' protocol function.
Best regards,
Konstantin Aladyshev
On Thu, Oct 5, 2023 at 12:55 PM Konstantin Aladyshev
wrote:
>
> Shouldn't we update the PLDM protocol's 'Pldm
://github.com/tianocore/edk2-platforms/blob/d6e36a151ff8365cdc55a6914cc5e6138d5788dc/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolCommon.c#L121
Best regards,
Konstantin Aladyshev
On Thu, Oct 5, 2023 at 7:03 AM Chang, Abner wrote:
>
> [AMD Official Use Only - G
the code is pushed to the torvalds/linux, it would be picked up
by the openbmc/linux automatically.
Best regards,
Konstantin Aladyshev
On Wed, Oct 4, 2023 at 7:12 PM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
>
> That is great, and I'm surprised there are some build
ERVED_ENDPOINT_END_ID)
+ (MctpDestinationEndpointId <= MCTP_RESERVED_ENDPOINT_END_ID)
) {
DEBUG ((DEBUG_ERROR, "%a: The value of MCTP destination EID (%x)
is reserved.\n", func, MctpDestinationEndpointId));
return EFI_INVALID_PARAMETER;
```
Best regards,
Konstantin Al
are reserved. It is critical that we do not use them since MCTP Linux
kernel subsystem checks that part. So we probably need to add some
check to the `MctpSubmitCommand` that would verify that we don't use
reserved EIDs.
Best regards,
Konstantin Aladyshev
On Thu, Sep 21, 2023 at 5:32 AM Chang
driver.
Best regards,
Konstantin Aladyshev
On Fri, Sep 1, 2023 at 8:58 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> See my answer below,
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of
> > Konstantin Aladyshev via grou
ta OPTIONAL,
IN OUT UINT32 *ResponseDataSize OPTIONAL
```
Should we include MCTP_TRANSPORT_HEADER/MCTP_MESSAGE_HEADER to this
output or not?
Best regards,
Konstantin Aladyshev
On Thu, Aug 31, 2023 at 6:52 PM Chang, Abner wrote:
>
> [AMD Official Use Only - Gen
MESSAGE_HEADER? Do we need to
check them here as well? Or do we need to check them somewhere upper
the call stack?
Best regards,
Konstantin Aladyshev
On Thu, Aug 31, 2023 at 7:59 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Aladyshev,
>
> > -Origina
be used both for IPMI and
MCTP, how should we deal with this?
Best regards,
Konstantin Aladyshev
On Wed, Aug 23, 2023 at 5:18 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Please see my answers inline.
>
> > -Original Message-
> > From: disc..
,
Konstantin Aladyshev
On Tue, Aug 22, 2023 at 7:26 PM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Aladyshev,
> We use library class to specify the desire transport interface for the
> management protocol, such as MCTP, PLDM and IPMI. This way we can flexibly
>
y to resolve this?
There are no platforms in the repo that actually implement PLDM/MCTP
functionality, so there is no example that I can use as a reference.
Best regards,
Konstantin Aladyshev
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Onl
sday, January 17, 2023 1:05 PM
> To: Jake Garver ; Konstantin Aladyshev
> ; devel@edk2.groups.io
> Cc: Gao, Liming ; Chen, Christine
>
> Subject: Re: [edk2-devel] [PATCH] Fix cyclic dependency error on OptionROM
> build
>
>
>
> Reviewed-by: Bob Feng
>
>
Hello!
Sorry to bother everyone.
It's been over a month. Can we merge this?
Best regards,
Konstantin Aladyshev
On Tue, Dec 13, 2022 at 9:47 PM Jake Garver wrote:
>
> Thanks, Konstantin,
>
> I approve this version.
>
> Thanks,
> Jake
> ___
Thanks Jake!
I've also verified that this change is enough to fix the cycle dependency issue.
I've sent an updated patch to the mailing list.
Best regards,
Konstantin Aladyshev
On Tue, Dec 13, 2022 at 6:42 PM Jake Garver wrote:
>
> Hi, Konstantin,
>
> Thanks for working wit
EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
...
PCI_VENDOR_ID = <...>
PCI_DEVICE_ID = <...>
PCI_CLASS_CODE = <...>
PCI_REVISION = <...>
to reproduce the issue.
Normally the build system should compile the driver code fine and then
call the EfiRom utility to produce the OptionROM image. But with the
d372ab585a2cdc5348af5f701c56c631235fe698 in place the driver build
fails.
Best regards,
Konstantin Aladyshev
On Mon, Dec 12, 2022 at 6:35 PM
Revert commit d372ab585a2cdc5348af5f701c56c631235fe698.
EdkII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
...
PCI_VENDOR_ID = <...>
PCI_DEVICE_ID = <...>
PCI_CLASS_CODE
regards,
Konstantin Aladyshev
On Thu, Sep 22, 2022 at 7:12 PM Kinney, Michael D
wrote:
>
> If the goal is to support a mix of graphical and serial consoles both with
> high text resolutions, then your patch is appropriate.
>
> It looks like you are observing some unexpec
RT options are checked again.
Also there is a menu "Boot Maintenance Manager -> Console Options ->
Console Output Mode Select" that has "Set Console Output Mode", and it
is always "80x25" without any options for me.
Best regards,
Konstantin Aladyshev
On Wed, Sep
; at runtime works just fine:
```
Shell> mode 240 56
```
After that the text output starts using the full screen.
Best regards,
Konstantin Aladyshev
On Wed, Sep 21, 2022 at 4:46 AM Kinney, Michael D
wrote:
>
> Tera Term works.
>
> Mike
>
> > -Original Message-
reen space.
Signed-off-by: Konstantin Aladyshev
---
MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c
index e2d779c783..6b7b970
Popen communication returns bytestrings. It is necessary to perform
decode on these strings before passing them to the EdkLogger that
works with ordinary strings.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/Python/Common/VpdInfoFile.py | 4 ++--
1 file changed, 2 insertions(+), 2
Fix typo in the set default value action define name:
DEFAUTL -> DEFAULT
Signed-off-by: Konstantin Aladyshev
---
MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
b/MdeModule
he change is good. Reviewed-by: Liming Gao
>
> Besides, how do you find this issue? Have you such test case or usage?
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Konstantin
> > Aladyshev
> > 发送时间: 2022年8月30日 18:20
> > 收件人: dev
Currently it is not possible to initialize all elements in the
array PCD.
For example, this PCD would result to a build failure:
gTokenSpaceGuid.PcdArray|{0x11, 0x22}|UINT8[2]|0x4C4CB9A3
Correct logical operator in the initialization data size checks to
fix the issue.
Signed-off-by: Konstantin
*|0x
Produces these strings in AutoGenC:
<...> _gPcd_<...>_PcdArray[4] = {0x44, 0x33, 0x22, 0x11};
<...> _gPcd_<...>_PcdArrayByExpression[4] = {0x44,0x33,0x22,0x11};
Add missing space character between the array elements to unify PCD value
formatting.
Signed-off-
Currently COMPAT16 section type is not recognized and GenSec is called
without the "-s [SectionType]" argument.
Add COMPAT16 type to the SectionType dictionary to fix the issue.
Now this syntax works correctly:
```
FILE FREEFORM = {
SECTION COMPAT16 =
}
```
Signed-off-by:
corresponds to EDKII
"[FV] section" documentation from the FDF Specification:
```
SECTION SUBTYPE_GUID =
```
Signed-off-by: Konstantin Aladyshev
---
.../Source/Python/CommonDataClass/FdfClass.py | 12 +++
BaseTools/Source/Python/GenFds/FdfParser.py | 22 ++
.../Pyt
Corrently the set of file types for the PIC section contains two
duplicate values.
Replace the duplicate value with the correct one to fix the issue.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Add Konstantin Aladyshev to the copyright header.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index 28c6806cf0..428011ca04 100644
Output file GUIDs from the DXE and PEI apriori files.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 74
1 file changed, 74 insertions(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index
Change SMM to MM in naming according to the recent PI specifications.
Remove trailing whitespaces in some strings.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/BaseTools/Source/C
The current string lenght (=60) is not enough for cases where basename
is a path to Build folder.
Drop custom define and use MAX_LINE_LEN from the BaseTools codebase
instead.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4 +---
1 file changed, 1 insertion(+), 3
itself.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index b5760d185e..4628e756d7 100644
--- a/BaseTools/Source/C/VolInfo
the issue.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index 135924e028..b5760d185e 100644
--- a/BaseTools/Source/C
Currently it is not possible to initialize all elements in the
array PCD.
For example, this PCD would result to a build failure:
gTokenSpaceGuid.PcdArray|{0x11, 0x22}|UINT8[2]|0x4C4CB9A3
Correct logical operator in the initialization data size checks to
fix the issue.
Signed-off-by: Konstantin
*|0x
Produces these strings in AutoGenC:
<...> _gPcd_<...>_PcdArray[4] = {0x44, 0x33, 0x22, 0x11};
<...> _gPcd_<...>_PcdArrayByExpression[4] = {0x44,0x33,0x22,0x11};
Add missing space character between the array elements to unify PCD value
formatting.
Signed-off-
EFI_GUIDED_SECTION_PROCESSING_REQUIRED=1 and DataOffset points to the
very start of data right after the EFI_GUID_DEFINED_SECTION header.
But in the case of GenCrc32 we can just set
EFI_GUIDED_SECTION_PROCESSING_REQUIRED=0 and point DataOffset to the
(EFI_GUID_DEFINED_SECTION + 4 bytes).
Best regards,
Konstantin Aladyshev
-by: Konstantin Aladyshev
---
.../Application/DumpDynPcd/DumpDynPcd.c | 28 +--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c
b/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c
index b8571c4556..013198963e 100644
Corrently the set of file types for the PIC section contains two
duplicate values.
Replace the duplicate value with the correct one to fix the issue.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Add Konstantin Aladyshev to the copyright header.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index 28c6806cf0..428011ca04 100644
Hi, Bob!
How should I update it?
Should I increase a year for the Intel Corporation like this
```
Copyright (c) 1999 - 2022, Intel Corporation. All rights reserved.
```
Or should I enter my name on another string?
```
Copyright (c) 2022, Konstantin Aladyshev
```
Best regards,
Konstantin
Output file GUIDs from the DXE and PEI apriori files.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 74
1 file changed, 74 insertions(+)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index
Change SMM to MM in naming according to the recent PI specifications.
Remove trailing whitespaces in some strings.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/BaseTools/Source/C
The current string lenght (=60) is not enough for cases where basename
is a path to Build folder.
Drop custom define and use MAX_LINE_LEN from the BaseTools codebase
instead.
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4 +---
1 file changed, 1 insertion(+), 3
Currently COMPAT16 section type is not recognized and GenSec is called
without the "-s [SectionType]" argument.
Add COMPAT16 type to the SectionType dictionary to fix the issue.
Now this syntax works correctly:
```
FILE FREEFORM = {
SECTION COMPAT16 =
}
```
Signed-off-by:
Signed-off-by: Konstantin Aladyshev
---
BaseTools/Source/C/GenSec/GenSec.c | 171 -
1 file changed, 169 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/GenSec/GenSec.c
b/BaseTools/Source/C/GenSec/GenSec.c
index 35a1ac64ea..d86cc197cc 100644
corresponds to EDKII
"[FV] section" documentation from the FDF Specification:
```
SECTION SUBTYPE_GUID =
```
Signed-off-by: Konstantin Aladyshev
---
.../Source/Python/CommonDataClass/FdfClass.py | 12 +++
BaseTools/Source/Python/GenFds/FdfParser.py | 22 ++
.../Pyt
1 - 100 of 117 matches
Mail list logo
