r expires.
> So, this patch adds the configuration screen for the watchdog timer
> which provides options to configure the timeout of these timers.
>
> By default, the values of these options are 5 minutes.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: L
On Fri, Oct 22, 2021 at 13:18:05 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide memory screen with below info:
> * Memory total capacity
> * Memory RAS and Performance Configuration
> * Per DIMM Information
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong
On Fri, Oct 22, 2021 at 13:18:03 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This change allows to configure the PCIe bifurcation mode and update
> the ACPI IORT tables based on the PCIe User setting.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Lei
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
Acked-by: Leif Lindholm
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec
Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
I haven't sanity-checked anything, but:
Acked-by: Leif Lindholm
> ---
> Platform/Ampere/JadePkg/Drivers/AcpiPl
ong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> |1 +
> Silicon/Ampere/Amp
c: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
Reviewed-by: Leif Lindholm
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
On Fri, Oct 22, 2021 at 13:17:52 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This driver takes responsibility for:
> - Parsing platform settings to build the Root Complex info HOB
> - Initializing each Root Complex
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Ph
On Fri, Oct 22, 2021 at 13:17:51 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide Mt. Jade specific segment number for each Root Complex and
> function to handle the PCIe PERST.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> C
On Fri, Oct 22, 2021 at 13:17:50 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides essential functions to initialize the PCIe Root Complex on
> Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael
On Fri, Oct 22, 2021 at 13:17:49 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide common data structures and macros which will be consumed by
> various PCIe modules.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael
vbDxe driver provides the implementation for the
> gEfiFirmwareVolumeBlock protocol
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
ndicates FailSafe
> monitor (ATF) that has booted up successfully. If the timer expires, it
> is considered a failed boot and the system is rebooted.
How?
(more below)
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc:
On Fri, Oct 22, 2021 at 13:17:40 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides functions to access the NVRAM, NVRAM2 and FailSafe region on the
> Flash over MM communication.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> C
to boot system
> to EDK2 UiApp.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
> Reviewed-by: Leif Lindholm
> -
On Mon, Oct 18, 2021 at 10:21:59 +0100, Sami Mujawar wrote:
> > In fact ... we could use more help on ArmPkg in general. Would you be
> > up for becoming an additional Maintainer or Reviewer?
> [SAMI] I can start helping with the review of the patches to start with, and
> we can revisit the maintai
On Fri, Oct 15, 2021 at 15:32:56 +0800, Abner Chang wrote:
> In V3: Fix the commit message in each patch.
>ArmVirtPkg->ArmPkg
> In V2: Fix the invalid email address.
Less haste, more speed ;)
Acked-by: Leif Lindholm
> This patch set fixes the build error caused
On Thu, Oct 14, 2021 at 06:05:59 -0600, Rebecca Cran wrote:
> Reviewed-by: Rebecca Cran
Acked-by: Leif Lindholm
Merged as 7e43d3e08611.
Thanks!
/
Leif
>
> On 10/14/21 1:23 AM, Ming Huang wrote:
> > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
> >
On Mon, Oct 11, 2021 at 21:52:13 +, Samer El-Haj-Mahmoud wrote:
> For the RFC itself, I personally do not have any objection, and
> welcome the addition of this protocol to AARCH64, as long as it
> utilizes the PSCI services to achieve the OS boot requirements.
>
> It may be worth getting feed
+Rebecca
On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote:
> As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
> for 64K granularity.
>
> Signed-off-by: Ming Huang
> ---
> ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
> 1 file changed, 1 insertion(+),
No issues with these, as long as they're merged (very shortly) after
the edk2 set.
Although please fix the typo in all of the commit messages
complaint ->
compliant
(But please don't send a v4 just for that.)
For the ones where you need it:
Acked-by: Leif Lindholm
On Mon, Oct 0
On Fri, Oct 08, 2021 at 16:18:44 +0200, Ard Biesheuvel wrote:
> On Fri, 8 Oct 2021 at 12:34, Leif Lindholm wrote:
> >
> > The MADT GICC structure contains the field PhysicalBaseAddress, which
> > is needed for a GICv1/v2 implementation, or to indicate legacy
> > c
; innovate and write their own code to run in these services as
> they wish.
>
>
> Thanks,
> --Samer
>
>
>
> From: Leif Lindholm
> Sent: Monday, October 11, 2021 8:28 AM
> To: Ard Biesheuvel ; Samer El-Haj-Mahmoud
>
> Cc: Ard Biesheuve
+Samer
On Fri, Oct 8, 2021 at 3:51 PM Ard Biesheuvel wrote:
> > > So either we severely constrain the kind of code that we permit to run
> > > on other cores, or we enable the MMU and caches on each core as it
> > > comes out of reset, as well as do any other CPU specific
> > > initialization th
the field to 0.
Signed-off-by: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Graeme Gregory
Cc: Radoslaw Biernacki
---
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe
On Thu, Oct 07, 2021 at 12:03:30 +0200, Ard Biesheuvel wrote:
> On Thu, 7 Oct 2021 at 11:41, Leif Lindholm wrote:
> >
> > Ard/Sami - any comments?
> >
>
> The code changes by itself look fine to me. The only problem I see is
> that we cannot run arbitrary code o
Hi Michael,
Apologies, I've owed you a response (promised off-list) for a while
now.
First, let me say I hugely appreciate this effort. Apart from aligning
the codebase(s), this will reduce manual reviewing effort
substantially, as well as cutting down on number of rework cycles for
developers.
Ard/Sami - any comments?
/
Leif
On Tue, Sep 28, 2021 at 12:14:35 +0100, Leif Lindholm wrote:
> On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote:
> > I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for
> > AARCH64 systems. I've attached two pat
On Wed, Oct 06, 2021 at 19:55:53 +0700, Nhi Pham wrote:
> > Would it be possible for PHYLib to link in ArmArchTimerLib directly
> > and wrap this there instead? Something about this integration just
> > feels kind of backwards to me.
>
> Thanks Leif. That's great idea.
>
> I will wrap it and re-s
On Mon, Oct 04, 2021 at 19:03:40 +0700, Nhi Pham wrote:
> Hi Leif,
>
> There are two comments that I would like to clarify with you.
>
> On 23/09/2021 20:49, Leif Lindholm wrote:
> > > +VOID
> > > +Ac01PcieMmioWr (
> >
v2:
>
> Added patch to increase Fv size to 768KB, which allows the NOOPT build
> to succeed.
>
> Added patch to add Readme.rst which explains the ROM loader limitations
> and provides links to the SRM, TRM etc.
For the two new patches:
Reviewed-by: Leif Lindholm
I dropped a tra
On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote:
> I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for
> AARCH64 systems. I've attached two patches to implement support for it
> in the DXE phase, based on code in EmulatorPkg and UefiCpuPkg. It's added
> under ArmPkg for now,
Could one of the BaseTools maintainers merge this set?
On Fri, Sep 24, 2021 at 08:44:42 +0800, gaoliming wrote:
> Leif:
> I gave my Acked-by for this patch set V2. I think it can be merged now.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io
Apart from the request to break out Ac01PcieConfigRW and
Ac01PcieCfgIn/Out# I noticed a further thing.
On Wed, Sep 15, 2021 at 22:55:11 +0700, Nhi Pham wrote:
> +/**
> + Get RootBridge disable status.
> +
> + @param[in] HBIndex Index to identify of PCIE Host bridge.
> + @param[in
pports upto 16 PCIe Root Complexs, the
> > target Root Complex will depend on the segment number parsed from the
> > input address.
> >
> > Cc: Thang Nguyen
> > Cc: Chuong Tran
> > Cc: Phong Vo
> > Cc: Leif Lindholm
> > Cc: Michael D Kinney
On Wed, Sep 15, 2021 at 22:55:17 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Registers the Platform NotifyPhase() to prevent unexpected issues
> caused by the enabled PCIe controllers which have unstable link.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
&
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Vu Nguyen
Reviewed-by: Leif Lindholm
> ---
> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dec
r expires.
> So, this patch adds the configuration screen for the watchdog timer
> which provides options to configure the timeout of these timers.
>
> By default, the values of these options are 5 minutes.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: L
On Wed, Sep 15, 2021 at 22:55:25 +0700, Nhi Pham wrote:
> From: Quan Nguyen
>
> This supports user to enable/disable RAS APEI components running in the
> system firmware such as HEST, BERT, and EINJ.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Lei
On Wed, Sep 15, 2021 at 22:55:24 +0700, Nhi Pham wrote:
> This supports:
> * Enable/Disable APEI Support
> * Enable/Disable CPPC Support
> * Enable/Disable LPI support
> * Enable/Disable Max Performance Mode
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
On Wed, Sep 15, 2021 at 22:55:23 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> This screen is to add configuration regarding CPU. Currently, this
> screen just adds a option for SubNUMA mode selection.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Lei
On Wed, Sep 15, 2021 at 22:55:22 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provide memory screen with below info:
> * Memory total capacity
> * Memory RAS and Performance Configuration
> * Per DIMM Information
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong
On Wed, Sep 15, 2021 at 22:55:20 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Helps to show various system information like CPU info and Board Setting
> values to UART console during boot process.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Lei
a default value in the BoardSetting.
> * Parsing the BoardSetting and coordinate with saved setting to enable
> corresponding PCIe controller of each Root Complex.
> * Config speed and lane of enabled controller.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: L
ication that has the guid in our inf so missed this.
>
> From my looking at it AndroidFastBootApp doesn't seem to use this lib.
(That ought to have been obvious even to me, oh well, thanks :)
/
Leif
> > -Original Message-
> > From: Leif Lindholm
> > S
Hi Rebecca,
I think I already gave v2 an Acked-by, but just in case:
Acked-by: Leif Lindholm
Bob, Liming, Yuwei - any comments?
/
Leif
Thu, Sep 23, 2021 at 10:09:55 -0600, Rebecca Cran wrote:
> BaseTools/Bin/gcc_[arm,aarch64]_linux_ext_dep.yaml downloads GCC releases
> from
On Thu, Sep 23, 2021 at 06:54:24 -0600, Rebecca Cran wrote:
> On 9/23/21 4:30 AM, Leif Lindholm wrote:
> > Not just an improvement, but an actual bugfix.
> >
> > I would propose a subject line change though:
> > Qemu: SbsaQemu: Set the DSDT revision va
Hi Nhi,
Following up with the comment I also made for 12/28:
On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote:
> diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h
> b/Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h
> new file mode 100644
> index ..66286bf
at 22:55:11 +0700, Nhi Pham wrote:
> From: Vu Nguyen
>
> Provides essential functions to initialize the PCIe Root Complex of
> Ampere Altra processor.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> C
Is to access flash through MM service.
> * FlashPei driver helps to restore the saved variables from
> flash on each boot.
> * FlashFvbDxe driver provides the implementation for the
> gEfiFirmwareVolumeBlock protocol
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
&
if
On Tue, Sep 21, 2021 at 16:32:58 +, Jeff Brasen wrote:
> Jun/Others,
>
> Any additional comments on this patch series?
>
>
> Thanks,
>
> Jeff
>
>
> From: Jeff Brasen
> Sent: Tuesday, September 14, 2021 10:57
Not just an improvement, but an actual bugfix.
I would propose a subject line change though:
Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
->
Platform/Qemu: fix SbsaQemu DSDT format version
If you're OK with the change, I can fold that in.
Reviewed-by: Leif Lindho
Hi Marcin,
On Wed, Sep 22, 2021 at 14:46:10 +0200, Marcin Wojtas wrote:
> > Marcin, when you find the time, could you please do a pass over these
> > files with Leif's critique in mind?
>
>
> For all 3 platforms, how about the following update:
> - extend the "Summary" section with supported fea
abled at entry or whether the firmware should put all UNKNOWN bits in
> all system registers in a consistent state (which it should), using EL0
> permissions serves no purpose whatsoever so let's fix that regardless.
>
> Signed-off-by: Ard Biesheuvel
Acked-by: Leif Lindhol
On Wed, Sep 22, 2021 at 14:20:31 +0200, Ard Biesheuvel wrote:
> On Wed, 22 Sept 2021 at 14:14, Leif Lindholm wrote:
> >
> > On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> > > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> > > >
&g
On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote:
> On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas wrote:
> >
> > Hi,
> >
> > This short patchset adds README files for the platforms
> > based on Marvell SoC's, which have already been
> > SystemReady ES certified. It also bumps the firmwa
pported, the first DWORD is the JEP-106 code and
> > the second DWORD is the SoC revision value. But in the current
> > implementation, they are set in reverse. This patch is to correct it.
> >
> > Cc: Leif Lindholm
> > Cc: Ard Biesheuvel
> > Cc: Rebecca Cran
&g
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
Reviewed-by: Leif Lindholm
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote:
> On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote:
> > From: Vu Nguyen
> >
> > This commit adds the support for Ampere’s Altra processor-based Mt. Jade
> > platform that provides up to 160 proce
to boot system
> to EDK2 UiApp.
>
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Vu Nguyen
Reviewed-by: Leif Lindholm
-=-=-=-=-=-=-=-=-=-=-=-
Groups
guyen
> Cc: Nhi Pham
> Cc: Thang Nguyen
> Cc: Chuong Tran
> Cc: Phong Vo
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Ard Biesheuvel
> Cc: Nate DeSimone
>
> Signed-off-by: Nhi Pham
>
> Changes since v2:
> + Addressed all Leif's feedback.
ally interacted with Android.
^
| shameless plug for more EmbeddedPkg reviewer volunteers.)
I've added Jun Nie, who wrote the original version of this code, to
see if he has any comments.
1-2/4 are obviously unproblematic, and I could merge those ahead of
time if preferred. You can add
Review
Ard, I think you were the one who converted the old crazy header stuff
to what we have now. Do you remember how this all fits together?
For the *other* 3 patches, but not this one:
Reviewed-by: Leif Lindholm
On Fri, Sep 10, 2021 at 20:57:11 -0600, Rebecca Cran wrote:
> Remove the configurat
On Tue, Sep 14, 2021 at 13:45:34 +0100, Leif Lindholm wrote:
> On Tue, Sep 14, 2021 at 14:18:06 +0200, Marcin Juszkiewicz wrote:
> > W dniu 14.09.2021 o 14:07, Leif Lindholm pisze:
> > > Hi Marcin,
> > >
> > > Thanks!
> > >
> > > Reviewe
On Tue, Sep 14, 2021 at 14:18:06 +0200, Marcin Juszkiewicz wrote:
> W dniu 14.09.2021 o 14:07, Leif Lindholm pisze:
> > Hi Marcin,
> >
> > Thanks!
> >
> > Reviewed-by: Leif Lindholm
> >
> > But could you give me access to this patch on a public b
Hi Marcin,
Thanks!
Reviewed-by: Leif Lindholm
But could you give me access to this patch on a public branch
somewhere, where I can pick it down from?
/
Leif
On Mon, Sep 13, 2021 at 14:01:27 +0200, Marcin Juszkiewicz wrote:
> Update the TF-A binaries with support for QEMU "
On Tue, Sep 14, 2021 at 15:56:01 +0800, 贾玲 wrote:
> Hi Leif,
>
> Thank you for your reply！
>
> I think your suggestion is very good. There is no dependency between
> patches 8 / 10 and 7 / 10.
Building with 8/10 but without 7/10 fails with
edk2-platforms/Silicon/Phytium/PhytiumCommonPkg/Drivers/
Library for Phytium platform.
> with multiple RCs.
>
> Signed-off-by: Ling Jia
> Reviewed-by: Leif Lindholm
> ---
> Platform/Phytium/DurianPkg/DurianPkg.dsc|9 +-
> Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 +
&g
On Fri, Sep 10, 2021 at 00:08:12 +, Chang, Abner (HPS SW/FW Technologist)
wrote:
> > Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> The naming sounds good to me.
>
> Another question,
> Can CI build the package with dependency of edk2-platform? Currently
> RiscVPkg in u
Hi Ling,
This set *still* does not contain the changes I included in my replies
to v3 and v4 that let it build against current edk2 master.
Please include those changes, verify the platform builds against
current edk2 master, and resubmit a v6.
Best Regards,
Leif
On Thu, Sep 09, 2021 at 17:47:
On Wed, Sep 08, 2021 at 15:33:34 +, Abner Chang wrote:
> > > I prefer to have RISC-V instance because I
> > > am not sure if any fw_cfg interface changes would be made on RISC-V
> > > QEMU.
> >
> > The fw_cfg interface should not diverge. ia32/x64 works a bit different
> > because there is a
On Wed, Sep 08, 2021 at 13:46:43 +0200, Gerd Hoffmann wrote:
> On Wed, Sep 08, 2021 at 12:13:12PM +0100, Leif Lindholm wrote:
> > On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote:
> > > Linaro no longer do gcc releases - Arm creates them now.
> > >
> &
On Wed, Sep 08, 2021 at 13:33:51 +0200, Gerd Hoffmann wrote:
> On Wed, Sep 08, 2021 at 12:06:46PM +0100, Leif Lindholm wrote:
> > On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote:
> > > Skip host bridge setup on microvm.
> > >
> > > Ref: https://bu
gt; from Arm and fix LinuxGcc5ToolChain.py with the new gcc prefix.
>
I don't know if anyone uses these files/tools to download toolchains
for downstream platforms. If they do, the upgrade from gcc7 to gcc10
may break their builds. But we're just after stable tag, so I have no
problem wi
On Wed, Sep 08, 2021 at 11:01:19 +0200, Gerd Hoffmann wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Jiewen Yao
Reviewed-by: Leif Lindholm
> ---
> Maintainers.txt | 6 ++
> 1 file changed, 6 insertions(+)
On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote:
> Skip host bridge setup on microvm.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599
> Signed-off-by: Gerd Hoffmann
> Acked-by: Jiewen Yao
> ---
> OvmfPkg/PlatformPei/MemDetect.c | 4
> 1 file changed, 4 insertions(+
Hi Nhi,
On Fri, Sep 03, 2021 at 22:44:23 +0700, Nhi Pham wrote:
> This adds more helper functions that assist in calculating the checksum,
> locating an ACPI table by signature, and updating an AML integer object.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Abner C
Minor style comments below.
On Wed, Sep 01, 2021 at 20:28:27 +, Jeff Brasen wrote:
> Add support under a pcd feature for using the new interface to pass
> initrd to the linux kernel.
>
> Signed-off-by: Jeff Brasen
> ---
> EmbeddedPkg/EmbeddedPkg.dec | 1 +
> .../AndroidB
@edk2.groups.io>> 代表 Abner Chang
> 发送时间: 2021年9月5日 11:15
> 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> 抄送: Ard Biesheuvel mailto:ard.biesheu...@arm.com>>;
> Michael D Kinney
> mailto:michael.d.kin...@intel.com>>; Leif
> Lindholm mailto:l...@nuv
Hi Ling,
Apologies for the delay.
To simplify things, I will respond to v4 in this thread, since there are
still a few things remaining from what I asked for v3.
Most of what I asked for has been addressed, but:
On Thu, May 27, 2021 at 1:43 PM Leif Lindholm wrote:
> First of all, some proc
On Thu, Aug 26, 2021 at 00:08:50 +0100, Pedro Falcato wrote:
> Add myself as a maintainter for Features/Ext4Pkg.
>
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off-by: Pedro Falcato
> ---
> Maintainers.txt | 4
> 1 file changed, 4 insertions(+)
>
>
so let's just drop this
> code. This fixes an issue reported by Marc where an SError is triggered
> by this code, bringing down the system.
>
> Reported-by: Marc Zyngier
> Signed-off-by: Ard Biesheuvel
Yikes.
Pretty sure that wasn't the right thing to do on gicv2 either
Hi Ling,
Many thanks for this.
I have accrued a huge review backlog, but I hope to be able to have a
look at this set before the end of this week.
Best Regards,
Leif
On Wed, Aug 18, 2021 at 17:40:14 +0800, Ling Jia wrote:
> This series added packages to support FT2000/4 chip.
> Platform/Phytium
+Ard
On Wed, Aug 04, 2021 at 22:47:24 +0800, Abner Chang wrote:
> Add Abner Chang as the maintainer of EmbeddedPkg/
> Add Daniel Schaefer as the reviewer of EmbeddedPkg/
>
> Signed-off-by: Abner Chang
> Cc: Daniel Schaefer
> Cc: Andrew Fish
> Cc: Leif Lindholm
&
Gah, sorry.
The original patch landed while I was distracted, and this reminder
while I was on holiday.
Apart from the typo in the subject line, I guess I'm OK with this.
Acked-by: Leif Lindholm
However, I have a feeling RISC-V will be updating EmbeddedPkg as
frequently as ARM in the
,
ArmPkg/Universal/Smbios/, and ended up keeping that header name.
Sorry about that.
However, moving around packages to make one identically named file be
picked over another is not the right solution. Could you possibly
rename your existing header? OemMiscHisi.h?
Best Regards,
Leif
> Cc: Lei
s://github.com/PierreARM/edk2-platforms/tree/1779_Fix_duplicated_guid_v1
>
> Pierre Gondois (2):
> Platform/ARM/Juno: Modify duplicated GUID in SmbiosPlatformDxe
> Platform/NXP: Modify duplicated GUID in ConfigurationManagerDxe
For the series:
Reviewed-by: Leif Lindholm
Apologies
Hi Rebecca,
I think the truth is we're a bit resigned about edk2-libc in general.
My view is it should be either maintained or deprecated (or replaced).
And maintainership *should* mean at least keeping it up to date with
security fixes.
I personally have no enthusiasm for the topic, but if ther
On Tue, Jul 20, 2021 at 11:53:58 +0800, Abner Chang wrote:
> Add maintainer and reviewer to RedfishClinetPkg.
>
> Signed-off-by: Abner Chang
> Cc: Nickle Wang
> Cc: Liming Gao
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> ---
> Maintainers.t
On Thu, Jul 08, 2021 at 12:50:47 -0700, Michael D Kinney wrote:
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Signed-off-by: Michael D Kinney
Reviewed-by: Leif Lindholm
Apologies for tardiness.
> ---
> Mai
s to
> the edk2 project (at their discretion).
Many thanks for your many contributions over the years. In code, in
review, in process, but for me most of all in education.
Reviewed-by: Leif Lindholm
> Cc: Andrew Fish
> Cc: Ard Biesheuvel
> Cc: Eric Dong
> Cc: Jordan Justen
&
Agh. *Actually* cc Wenyi.
On Fri, Jun 18, 2021 at 16:53:38 +0100, Leif Lindholm wrote:
> +Wenyi
>
> On Mon, Jun 14, 2021 at 12:57:49 -0600, Rebecca Cran wrote:
> > Many of the cache definitions in ArmLibPrivate.h are being used outside
> > of ArmLib, in Universal/S
t; Universal/Smbios.
>
> Signed-off-by: Rebecca Cran
Reviewed-by: Leif Lindholm
Pushed as a63914d3f603. Thanks!
I will note that this change breaks Silicon/Hisilicon/Hi1616 and
Silicon/Hisilicon/Hi1620, which use some of the macros moved by this
patch.
However, I am unable to build these anywa
Hi Marcin,
On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote:
> Hi,
>
> The MDIO ACPI binding has been established and merged to the
> Linux tree,
Congratulations! :)
Is FreeBSD expected to follow suit?
> hence it is now possible to update the ACPI
> description of the platforms that
> +
> +
> +#ifndef LS1046AFRWY_PLATFORM_ACPI_LIB_H
> +#define LS1046AFRWY_PLATFORM_ACPI_LIB_H
> +
> +#include
> +
> +/** C array containing the compiled AML template.
> +These symbols are defined in the auto generated C file
> +containing the AML bytecode ar
On Fri, Jun 11, 2021 at 21:21:59 +0530, Vikas Singh wrote:
> This patch set extends Configuration Manager (CM) and
> its services to leverage the Dynamic ACPI support for
> NXP's LS1046aFrwy platform.
This patch does not touch ConfigurationManager.
Please describe what this patch does.
My guess i
On Fri, Jun 11, 2021 at 21:21:58 +0530, Vikas Singh wrote:
> This change set intend to add a generic method to get
Does it intend to add, or does it add?
/
Leif
> access to SoC's Silicon Version Register (SVR) and its
> handling for LS1046aFrwy platform.
>
> Signed-off-by: Vikas Singh
> --
On Fri, Jun 11, 2021 at 21:21:57 +0530, Vikas Singh wrote:
> Summary -
> 1.Configuration Manager(CM) is a common implementation
> and should not evaluate the SoC version using macro's
> However CM must directly consume SoC ver string from
> platfrom who is extending CM services for ACPI table
edk2-platforms/Features/Ext4Pkg sounds good to me too.
/
Leif
On Thu, Jun 10, 2021 at 17:38:17 +, Michael D Kinney wrote:
> Hi Pedro,
>
> After thinking about this, I think I would prefer Option (4).
>
> The proposed landing zone would be a new Ext4Pkg in the edk2-platforms
> repositor
On Wed, Jun 09, 2021 at 13:25:16 +0100, Michael Brown wrote:
> On 09/06/2021 11:57, Laszlo Ersek wrote:
> > I'm uneducated about the "deliverables" in GSoC, but in general I'd
> > suggest narrowing down the scope as much as possible. I don't know how
> > hard it is to program USB audio, but if QEMU
501 - 600 of 1977 matches
Mail list logo
