m.cn>?
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Ni, Ray
Sent: Saturday, May 25, 2024 9:32
To: Feng, Ning ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0.
Reviewed-by: Ray Ni
Thanks,
Ray
Reviewed-by: Ray Ni
Thanks,
Ray
From: Feng, Ning
Sent: Saturday, May 25, 2024 15:42
To: devel@edk2.groups.io
Cc: Feng, Ning ; Ni, Ray
Subject: [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4778
MPInitlib
oInHob = (CPU_INFO_IN_HOB *)(UINTN)CpuMpData->CpuInfoInHob;
BTW, please remove "Pkg-Module:" from the subject.
Thanks,
Ray
From: Feng, Ning
Sent: Friday, May 24, 2024 7:16
To: devel@edk2.groups.io
Cc: Feng, Ning ; Ni, Ray
Subject: [PATCH] Pk
, 2024 2:02
To: devel@edk2.groups.io
Cc: Feng, Ning ; Ni, Ray
Subject: [PATCH] Pkg-Module:UefiCpuPkg/MpLib
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4778
MPInitlib have wrong expectation that BSP index should always be 0 in
MpInitLibInitialize(), SwitchBsp(),ApWakeupFunction
To: devel@edk2.groups.io
Cc: Feng, Ning ; Ni, Ray ; Wu, Jiaxin
Subject: [PATCH] Pkg-Module:UefiCpuPkg/MpLib
[Ray.1] The subject should be more specific. E.g.: UefiCpuPkg/MpInitLib: Do not
assume BSP is #0
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4778
MPlib have wrong expectation
From: Kun Qin
Sent: Saturday, May 18, 2024 1:09
To: Ni, Ray ; Tan, Dun ;
devel@edk2.groups.io
Cc: Liming Gao ; Sean Brogan
Subject: RE: [PATCH 7/9] MdeModulePkg:Consume
gEdkiiVariableRuntimeCacheInfoHobGuid
Hi Ray & Dun,
Thanks for adding me to the patch. I think the proposed solu
; Wu, Jiaxin ;
Ni, Ray ; Ard Biesheuvel ; Yao,
Jiewen ; Gerd Hoffmann ; Kumar, Rahul
R
Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu
driver
Comparing to V1 patchs set, the V2 patch set only adjusts the commits ordering
and modifies copy right year in some files
in bios-build phase. There is no runtime
information needed.
Thanks,
Ray
From: Nhi Pham
Sent: Monday, May 20, 2024 9:01
To: devel@edk2.groups.io ; Tan, Dun
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin ; Ard Biesheuvel ; Leif
Lindholm ; Sami Mujawar ; Gerd
Hoffmann
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin
Subject: [PATCH 9/9] MdeModulePkg:Add global variable mVariableRtCacheInfo
Add global variable mVariableRtCacheInfo to save the
content in gEdkiiVariableRuntimeCacheInfoHobGuid. With
this new global variable, 7 global variables can
Dun,
All the 6 new pointers that are accessed at runtime should be converted through
ConvertPointer().
Please ignore my previous Reviewed-by.
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:49
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao
Subject
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:49
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao
Subject: [PATCH 7/9] MdeModulePkg:Consume gEdkiiVariableRuntimeCacheInfoHobGuid
Consume gEdkiiVariableRuntimeCacheInfoHobGuid
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:49
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin
Subject: [PATCH 6/9] MdeModulePkg:Remove unnecessary global variable
Remove the two unnecessary global variables
+ VariableRuntimeCacheHob = BuildGuidHob
(, sizeof (VARIABLE_RUNTIME_CACHE_INFO));
+ ASSERT (VariableRuntimeCacheHob != NULL);
+ ZeroMem (VariableRuntimeCacheHob, sizeof (VARIABLE_RUNTIME_CACHE_INFO));
+
+ //
+ // AllocateRuntimePages for CACHE_INFO_FLAG and unblock it.
+ //
+ Pages =
it's not needed.
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:49
To: devel@edk2.groups.io
Cc: Ni, Ray ; Ard Biesheuvel ;
Yao, Jiewen ; Gerd Hoffmann
Subject: [PATCH 4/9] OvmfPkg: Add MmUnblockMemoryLib in DSC
Add MmUnblockMemoryLib
It's not needed.
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:49
To: devel@edk2.groups.io
Cc: Andrew Fish ; Ni, Ray
Subject: [PATCH 3/9] EmulatorPkg: Add MmUnblockMemoryLib in DSC
Add MmUnblockMemoryLib in EmulatorPkg.dsc.
This lib will be required
+
MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
[Ray] Do you really need this line as the next "!include" already includes the
NULL instance lib?
+
!include MdePkg/MdeLibs.dsc.inc
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
.groups.io
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin
Subject: [PATCH 1/9] MdeModulePkg:Add new gEdkiiVariableRuntimeCacheInfoHobGuid
This commit defines VARIABLE_RUNTIME_CACHE_INFO HOB.
The HOB is used to store the address and size of the
buffer that will be used for variable runtime service
when
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 17, 2024 17:44
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin ; Zhou, Jianfeng
Subject: [PATCH] UefiCpuPkg:fix issue when splitting paging entry
This patch
Thanks for confirming.
Thanks,
Ray
From: Ding, Feng (Sunnyvale)
Sent: Friday, May 17, 2024 8:39
To: Ni, Ray ; Hsueh, Hong-Chih (Neo)
; Laszlo Ersek ;
devel@edk2.groups.io
Cc: He, Jiangang ; Chang, Abner ;
gaolim...@byosoft.com.cn
Subject: RE: [PATCH v2
1. The patch is too big. Can you split it to multiple smaller patches?
> +STATIC
> +UINT64
> +PciSegmentLibGetConfigBase (
> + IN UINT64 Address
> + )
> +{
> + UINT8 Bus;
> + UINT8 Device;
> + UINT8 Function;
> +
> + EXTRACT_PCIE_ADDRESS (Address, Bus, Device, Function);
> + if
be added to CpuLib.
Thanks,
Ray
From: Gerd Hoffmann
Sent: Monday, May 13, 2024 19:07
To: Tan, Dun
Cc: devel@edk2.groups.io ; Ni, Ray ;
Laszlo Ersek ; Kumar, Rahul R ; Wu,
Jiaxin
Subject: Re: [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
Good suggestions, Jiaxin!
Thanks,
Ray
From: Tan, Dun
Sent: Monday, May 13, 2024 11:37
To: Wu, Jiaxin ; devel@edk2.groups.io
; Ni, Ray
Subject: RE: [edk2-devel] [PATCH 00/19] Remove some S3 related code in CpuS3.c
of smm cpu driver
Thanks for the comments
: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Wang, Jian J ; Liming
Gao
Subject: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in
SMM_S3_RESUME_STATE
This MpService2Ppi field in SMM_S3_RESUME_STATE is used to
wakeup AP to do the CPU initialization du
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 17/18] UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c
Remove
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 16/18] UefiCpuPkg:Remove code to wakeup AP and relocate ap
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 14/18] UefiCpuPkg: Remove code to set register table
Remove
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 13/18] UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
Set
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting
Remove code
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 11/18] UefiCpuPkg: Disable PG in IA32 ApLoopCode
Disable paging
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 10/18] UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 179f8e585b..11e0d2661f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -357,7 +357,8 @@ typedef
IN UINTNStackStart
);
-extern EFI_GUID
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Rahul
R ; Gerd Hoffmann ; Wu, Jiaxin
Subject: [PATCH 08/18] UefiCpuPkg:Abstract some DxeMpLib code to function
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 05/18] UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
In this commit
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 04/18] UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
Save MTRR by lockbox
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Wu, Jiaxin
Subject: [PATCH 03/18] UefiCpuPkg: Add locbox lib instance in DSC
Add locbox lib instance
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
; Wu, Jiaxin
Subject: [PATCH 02/18] OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
Save MTRR
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io
Cc: Ni, Ray ; Liming Gao ; Wu,
Jiaxin
Subject: [PATCH 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
Add gEdkiiS3MtrrSettingGuid a new GUID for s3
MTRR
diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
index 3e85eab28f..a8e9c92a93 100644
--- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
+++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
@@ -1139,7 +1139,6 @@
be cloned
to multiple similar pieces of code. So we need to be very careful.
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Borzeszkowski,
Alan
Sent: Wednesday, May 8, 2024 21:24
To: Ni, Ray ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/1
Reviewed-by: Ray Ni
Thanks,
Ray
From: Doug Flick
Sent: Wednesday, May 8, 2024 23:29
To: devel@edk2.groups.io
Cc: Andrew Fish ; Ni, Ray
Subject: [PATCH v1 02/14] EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg
From: Doug Flick
This patch adds
Reviewed-by: Ray Ni
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Doug Flick via
groups.io
Sent: Thursday, May 9, 2024 13:56
To: devel@edk2.groups.io
Cc: Andrew Fish ; Ni, Ray
Subject: [edk2-devel] [PATCH v2 01/13] EmulatorPkg: : Add RngDxe
Reviewed-by: Ray Ni
Thanks,
Ray
From: Lin, Du
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io
Cc: Lin, Du ; Liming Gao ; Ni, Ray
Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP
attribute
Add a new entry into GCD
Why not implement a customized SerialPortLib and use
MdeModulePkg/Universal/SerialDxe/SerialDxe.inf?
Thanks,
Ray
From: Borzeszkowski, Alan
Sent: Tuesday, May 7, 2024 21:09
To: devel@edk2.groups.io
Cc: Borzeszkowski, Alan ; Gao, Zhichao
; Ni, Ray ; Kinney
//
RemoveAllPciDeviceOnBridge (RootBridgeHandle, Bridge);
return EFI_SUCCESS;
}
Thanks,
Ray
From: Hsueh, Hong-Chih (Neo)
Sent: Wednesday, May 1, 2024 2:24
To: Laszlo Ersek ; devel@edk2.groups.io
; Ni, Ray
Cc: Ding, Feng (Sunnyvale) ; He
Reviewed-by: Ray Ni
Thanks,
Ray
From: Xie, Yuanhao
Sent: Tuesday, May 7, 2024 14:09
To: devel@edk2.groups.io
Cc: Liming Gao ; Wu, Jiaxin ;
Ni, Ray ; Xie, Yuanhao
Subject: [PATCH 3/3] MdeModulePkg: Add Standalone MM Lockbox Driver.
The Lockbox Driver allows
Reviewed-by: Ray Ni
Thanks,
Ray
From: Xie, Yuanhao
Sent: Tuesday, May 7, 2024 14:09
To: devel@edk2.groups.io
Cc: Liming Gao ; Wu, Jiaxin ;
Ni, Ray ; Xie, Yuanhao
Subject: [PATCH 2/3] MdeModulePkg: Refactors SmmLockBox.c.
The Lockbox Driver allows sensitive
+#include
[Ray] Can you check if BaseLib is really needed?
+#include
+
+/**
+ It attempts to install the gEfiLockBoxProtocolGuid protocol into the
system's DXE database
+ with NULL as the protocol interface to mark the protocol as handled in the
system or to
+ act as a trigger.
[Ray]
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation
logic
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary
CpuIndex
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary
global variable
Reviewed-by: Ray Ni
Thanks,
Ray
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Tuesday, April 30, 2024 15:45
To: Ni, Ray ; devel@edk2.groups.io
Cc: Laszlo Ersek ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Handle the NULL
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R ; Dong, Guo
; Rhodes, Sean ; Lu, James
; Guo, Gua ; Ard Biesheuvel
; Yao, Jiewen ; Abdul Lateef
Attar ; Abner Chang ; Tom
Lendacky
Subject: [PATCH v4 00/14] Add SmmRelocationLib
PR: https://github.com/tianocore/edk2
I've given Reviewed-by for the v3 version.
What extra changes did you make so that you need me to review it again?
Thanks,
Ray
From: Wu, Jiaxin
Sent: Friday, April 26, 2024 20:17
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Reviewed-by: Ray Ni
Thanks,
Ray
From: Xie, Yuanhao
Sent: Monday, April 29, 2024 8:03
To: devel@edk2.groups.io
Cc: Xie, Yuanhao ; Dong, Eric ; Ni,
Ray ; Kumar, Rahul R ; Gerd Hoffmann
; Wu, Jiaxin
Subject: [Patch V2 1/1] UefiCpuPkg/SmmCpuSyncLib: Add
Abdul,
Does Amd PEI include the CpuMpPeim?
If it includes the PEIM, the MpInformation2Hob should be in the HOB database.
Thanks,
Ray
From: Abdul Lateef Attar
Sent: Monday, April 29, 2024 19:17
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Ni, Ray ;
Laszlo
Reviewed-by: Ray Ni
Thanks,
Ray
From: Zhang, Hongbin1
Sent: Monday, April 29, 2024 14:24
To: devel@edk2.groups.io
Cc: Zhang, Hongbin1 ; Kinney, Michael D
; Ni, Ray ; Liming Gao
; Liu, Zhiguang ; Wu, Jiaxin
; Xie, Yuanhao
Subject: [PATCH v2] MdePkg: Add
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Monday, April 29, 2024 13:32
To: devel@edk2.groups.io
Cc: Ni, Ray ; Ard Biesheuvel ;
Sami Mujawar ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: [PATCH v1] Maintainers.txt: Update StandaloneMmPkg
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Monday, April 29, 2024 13:31
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Tuesday, April 30, 2024 11:33
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v1] UefiCpuPkg/Library: Support to get processor extended info
Intel has
Thanks,
Ray
From: Gerd Hoffmann
Sent: Thursday, April 25, 2024 14:58
To: Ni, Ray
Cc: Wu, Jiaxin ; devel@edk2.groups.io
; Zeng, Star ; Kumar, Rahul R
; Dong, Guo ; Rhodes, Sean
; Lu, James ; Guo, Gua
; Ard Biesheuvel ; Yao, Jiewen
; Abdul Lateef Attar
-# Copyright (c) 2023, Intel Corporation. All rights reserved.
+# Copyright (c) 2024, Intel Corporation. All rights reserved.
Yuanhao, why did you change the copyright year from 2023 to 2024?
You can either leave it unchanged, or change it to "2023 - 2024".
# SPDX-License-Identifier:
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Thursday, April 25, 2024 12:40
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Liming Gao
; Wu, Jiaxin ; Ni, Ray
; Laszlo Ersek ; Ard Biesheuvel
; Sami Mujawar
Subject: [PATCH 2/2] StandaloneMmPkg
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Thursday, April 25, 2024 12:40
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Liming Gao
; Wu, Jiaxin ; Ni, Ray
; Laszlo Ersek
Subject: [PATCH 1/2] MdeModulePkg/SMM: Initialize 'WillReturn' variable
e CPU.
Jiaxin, I agree that the confusion should be cleaned up by AMD experts. Let's
not change any existing behavior.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Thursday, April 25, 2024 8:54
To: Gerd Hoffmann
Cc: devel@edk2.groups.io ; Ni, Ray ;
Zeng, Star ; Kumar, Rah
So this is just junk unallocated memory that we are reporting as
a type it *could* be if an allocation occurs to minimize failures
of ExitBootServices. Which is questionable. But in terms of
attributes, I would expect we either have this unallocated
memory marked the same as the bin type or
Jiaxin,
I see Abdul from AMD has given R-B. I assume that's sufficient for merging this
patch.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Thursday, April 18, 2024 16:03
To: devel@edk2.groups.io ; Wu, Jiaxin
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
+ //
+ // Check whether the Required TileSize is enough.
+ //
+ if (TileSize > SIZE_8KB) {
+DEBUG ((DEBUG_ERROR, "The Range of Smbase in SMRAM is not enough --
Required TileSize = 0x%08x, Actual TileSize = 0x%08x\n", TileSize, SIZE_8KB));
+FreePool (mCpuHotPlugData.SmBase);
+
UINT64
EFIAPI
HookReturnFromSmm (
- IN UINTN CpuIndex,
IN OUT SMRAM_SAVE_STATE_MAP *CpuState,
IN UINT64NewInstructionPointer32,
IN UINT64NewInstructionPointer
)
{
diff --git
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Thursday, April 18, 2024 14:55
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v3 04/13] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Thursday, April 18, 2024 14:55
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v3 03/13] UefiCpuPkg/SmmRelocationLib: Rename global variables
This patch
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Thursday, April 18, 2024 14:55
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v3 02/13] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib
library
Comments below starting with [Ray]
Thanks,
Ray
From: Wu, Jiaxin
Sent: Tuesday, April 16, 2024 20:58
To: Ni, Ray ; devel@edk2.groups.io
Cc: Zeng, Star ; Gerd Hoffmann ; Kumar,
Rahul R
Subject: RE: [PATCH v2 02/10] UefiCpuPkg/SmmRelocationLib: Add
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Tuesday, April 16, 2024 10:41
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Liming Gao
; Wu, Jiaxin ; Ni, Ray
; Laszlo Ersek ; Ard Biesheuvel
; Sami Mujawar
Subject: [PATCH v4 6/6] StandaloneMmPkg
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Tuesday, April 16, 2024 10:41
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Liming Gao
; Wu, Jiaxin ; Ni, Ray
; Laszlo Ersek
Subject: [PATCH v4 5/6] MdeModulePkg/SMM: Support to unregister SMI
PR created for merge: Loongcpu by niruiyu · Pull Request #5560 · tianocore/edk2
(github.com)<https://github.com/tianocore/edk2/pull/5560>
Thanks,
Ray
From: Chao Li
Sent: Tuesday, April 16, 2024 10:42
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R
Acked-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Monday, April 15, 2024 21:30
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Abner Chang
; Tom Lendacky ; Ni, Ray
; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v2 03/10] UefiCpuPkg
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Tuesday, April 16, 2024 10:44
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v4 10/13] UefiCpuPkg: Add a new GUID to store the processors
resource
On a multi
Comments below starting with [Ray.xx]
Thanks,
Ray
/**
@@ -30,11 +30,12 @@ SemaphoreHook (
{
SMRAM_SAVE_STATE_MAP *CpuState;
mRebasedFlag = RebasedFlag;
- CpuState = (SMRAM_SAVE_STATE_MAP
*)(UINTN)(SMM_DEFAULT_SMBASE + SMRAM_SAVE_STATE_MAP_OFFSET);
+ CpuState =
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Monday, April 15, 2024 21:30
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v2 01/10] UefiCpuPkg: Add SmmRelocationLib class
Intel plans to separate
Liming,
Can you give a R-B?
Thanks,
Ray
From: Cai, Xianglei
Sent: Friday, April 12, 2024 9:53
To: Lewandowski, Krzysztof ;
devel@edk2.groups.io ; Ni, Ray ; Liming
Gao
Cc: Huang, Jenny ; Shih, More
Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Sami Mujawar ; Sunil V L
; Bibo Mao ; Dongyan Qian
Subject: [PATCH v3 00/13] Part 2 patch set to add LoongArch support into
UefiCpuPkg
This patch set adjusted some order in UefiCpuPig alphabetically, added
LoongArch
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v3 13/13] UefiCpuPkg/UefiCpuPkg.dsc: Add CpuMmio2Dxe.inf to
LoongArch64 field
LoongArch64
Acked-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Baoqi Zhang ; Dongyan
Qian ; Xianglai Li ; Bibo Mao
Subject: [PATCH v3 09/13] UefiCpuPkg: Add CpuMmuLib
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v3 08/13] UefiCpuPkg: Added a new PCD named
PcdLoongArchExceptionVectorBaseAddress
Added
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Friday, April 12, 2024 15:34
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Leif Lindholm ; Ard
Biesheuvel ; Sami Mujawar ;
Sunil V L ; Warkentin, Andrei
Subject: [PATCH v3 07/13
+
+typedef struct {
+ UINT32NumberOfProcessor;
+ UINTN *ApicId;
[Ray] How about "UINTN ApicId[]"? The difference between the two is your
version contains an 8-byte pointer pointing to somewhere else. My version
implies the APIC ID array is just after "NumberOfProcessor".
ated there.
But it's not needed when it's called from SmmEntry.nasm as IDTR is updated
there.
Other changes look good to me.
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
S
+STATIC CONST EFI_PEI_NOTIFY_DESCRIPTOR mMpServices2Notify = {
+ EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK | // Flags
+ EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,
+ , // Guid
+ OnMpServices2Available // Notify
+};
+
+VOID
+InstallSmmRelocationCallback (
[Ray.1]
Reviewed-by: Ray Ni
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
Subject: [PATCH v1 11/13] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is
done
Do you think it makes sense to combine this with #10? Otherwise, with this
patch the OVMF is broken.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
Which patch removes this HOB creation from SmmAccess driver?
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
Subject: [PATCH v1 10/13] OvmfPkg
owever, OVMF platform does not produce the GUID HOB. This patch produces the
HOB..
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Yao, Jiewen
; Gerd Hoffmann ; Ni, Ray
Subject: [PATCH v1
Please change the DSC in the earlier patch that adds the lib instance and avoid
this patch.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH
No. Please do not create a OVMF specific lib instance in UefiCpuPkg.
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Ard
Biesheuvel ; Yao, Jiewen ;
Gerd Hoffmann ; Kumar, Rahul R
Subject
devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R
Subject: [PATCH v1 02/13] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib
library instance
This patch separates the smbase relocation logic from
PiSmmCpuDxeSmm driver, and moves to the
SmmRelocationInit interface.
Jiaxin, can you kindly share a PR in GitHub so that it will be easier to review?
Thanks,
Ray
From: Wu, Jiaxin
Sent: Wednesday, April 10, 2024 21:57
To: devel@edk2.groups.io
Cc: Ni, Ray ; Zeng, Star ; Gerd Hoffmann
; Kumar, Rahul R ; Dong, Guo
; Rhodes, Sean
Reviewed-by: Ray Ni
Thanks,
Ray
From: devel@edk2.groups.io on behalf of Zhiguang Liu
Sent: Wednesday, April 10, 2024 15:49
To: devel@edk2.groups.io
Cc: Liu, Zhiguang
Subject: [edk2-devel] [PATCH v3 0/6] Support to unregister SMI handler in SMI
handlers
Reviewed-by: Ray Ni
Thanks,
Ray
From: Liu, Zhiguang
Sent: Wednesday, April 10, 2024 15:08
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Chiu, Chasel
; Desimone, Nathaniel L
; Duggapu, Chinni B
; Zeng, Star ; Kuo, Ted
; S, Ashraf Ali ; Susovan Mohapatra
; Ni
10:12
To: Shang, Qingyu
Cc: devel@edk2.groups.io ; Ni, Ray ;
Gahan Saraiya
Subject: Re: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
On Mon, Apr 8, 2024 at 10:48 AM Qingyu wrote:
>
> Refer to Uefi spec 2.10 section 11.11.2, add a new retval
> EFI_
1 - 100 of 2346 matches
Mail list logo
