10:12
To: Shang, Qingyu
Cc: devel@edk2.groups.io ; Ni, Ray ;
Gahan Saraiya
Subject: Re: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
On Mon, Apr 8, 2024 at 10:48 AM Qingyu wrote:
>
> Refer to Uefi spec 2.10 section 11.11.2, add a new retval
> EFI_
merged.
Thanks,
Ray
From: Shang, Qingyu
Sent: Monday, April 8, 2024 17:47
To: devel@edk2.groups.io
Cc: Pedro Falcato ; Ni, Ray ; Gahan
Saraiya
Subject: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
Refer to Uefi spec 2.10 section
resource. How is the GUID used to store the memory map resource?
Can the PEIM be placed in edk2-platforms repo?
Thanks,
Ray
From: Chao Li
Sent: Tuesday, April 9, 2024 12:29
To: devel@edk2.groups.io ; Ni, Ray ;
Gerd Hoffmann
Cc: Kumar, Rahul R ; Sami Mujawar
This optional plugin is designed to execute before the FSP SecCore to
rebase SecCore and PeiCore during runtime. If the FSP binary requires
rebasing at runtime, this module should be included within the FSP
binary. Additionally, specific patches must be applied to ensure proper
functionality.
In
en you address comments for
patch 8.
OK.
Thanks,
Ray
From: Gerd Hoffmann <mailto:kra...@redhat.com>
Sent: Friday, March 22, 2024 20:39
To: Chao Li <mailto:lic...@loongson.cn>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
<mailto:dev
Reviewed-by: Ray Ni
Thanks,
Ray
From: Shang, Qingyu
Sent: Monday, April 8, 2024 17:47
To: devel@edk2.groups.io
Cc: Pedro Falcato ; Ni, Ray ; Gahan
Saraiya
Subject: [PATCH 1/3] OptionRomPkg: Update the comments of GetInformation
function
Refer to Uefi spec
; Liming Gao ; Ni, Ray
; Liu, Zhiguang ; Kinney, Michael D
; Guo, Gua ; Dong, Guo
; Lu, James ; Rhodes, Sean
; Kumar, Rahul R
Cc: Ard Biesheuvel ; Aktas, Erdem
; Gerd Hoffmann ; Xu, Min M
; Michael Roth ; Anatol Belski
; Anthony Perard ;
Corvin Köhne ; Jianyong Wu ; Rebecca
Cran
Subject
; Kinney, Michael D ; Xu,
Min M ; Liu, Zhiguang ; Kumar,
Rahul R ; Ni, Ray ; Michael Roth
Subject: [edk2-devel] [PATCH v3 03/24] UefiCpuPkg/MpInitLib: Always use AP
Create if GhcbApicIds HOB is present
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
Currently, the first time an AP
; Kinney, Michael D ; Xu,
Min M ; Liu, Zhiguang ; Kumar,
Rahul R ; Ni, Ray ; Michael Roth
Subject: [edk2-devel] [PATCH v3 12/24] UefiCpuPkg/AmdSvsmLib: Create the
AmdSvsmLib library to support an SVSM
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
In order to support an SEV-SNP guest
,
Rahul R ; Ni, Ray ; Michael Roth
Subject: [PATCH v3 16/24] UefiCpuPkg/MpInitLib: Use AmdSvsmSnpVmsaRmpAdjust()
to set/clear VMSA
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The RMPADJUST instruction is used to change the VMSA attribute of a page,
but the VMSA attribute can only
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 3/3] MinPlatformPkg: Sort
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 13:59
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2] MinPlatformPkg: Corret
to avoid it?
Thanks,
Ray
From: Liu, Zhiguang
Sent: Monday, March 18, 2024 10:19
To: devel@edk2.groups.io
Cc: Liu, Zhiguang ; Liming Gao
; Wu, Jiaxin ; Ni, Ray
; Laszlo Ersek ; Ard Biesheuvel
; Sami Mujawar
Subject: [PATCH 6/6] StandaloneMmPkg: Support to unregister
: Please make accordingly changes when you address comments for
patch 8.
Thanks,
Ray
From: Gerd Hoffmann
Sent: Friday, March 22, 2024 20:39
To: Chao Li
Cc: devel@edk2.groups.io ; Ni, Ray ;
Kumar, Rahul R ; Sami Mujawar ;
Sunil V L ; Bibo Mao ; Dongyan
Qian
:43
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Leif Lindholm ; Ard
Biesheuvel ; Sami Mujawar ;
Sunil V L ; Warkentin, Andrei
Subject: [PATCH v2 07/13] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg
Add a new header file CpuMmuLib.h, whitch is referenced from
ArmPkg
one so that the lib API
can be dropped in future (not in this round of patch).
Thanks,
Ray
From: Chao Li
Sent: Wednesday, March 20, 2024 16:43
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann ; Leif Lindholm ; Ard
Biesheuvel ; Sami Mujawar ;
Sun
.
Nevertheless, the current changes look good to me.
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Wednesday, March 20, 2024 16:42
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v2 02/13] UefiCpuPkg/CpuExceptionHandlerLib
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Wednesday, March 20, 2024 16:42
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v2 01/13] UefiCpuPkg/CpuTimerLib: Reorder the INF file
alphabetically
Some of the order
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Du Lin
> Sent: Thursday, March 14, 2024 10:02 AM
> To: devel@edk2.groups.io
> Cc: Lin, Du ; S, Ashraf Ali ; Chiu,
> Chasel ; Chen, Gang C ;
> Duggapu, Chinni B ; Desimone, Nathaniel L
> ;
> - ASSERT (MeasurementExcludedFvPpi != NULL);
> + if (MeasurementExcludedFvPpi == NULL) {
> +ASSERT (FALSE);
I prefer the original meaningful assertion instead of ASSERT (FALSE).
Adding if-check is a good change to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
, Michael D ; Andrew Fish
; Ard Biesheuvel ; Gerd Hoffmann
; Yao, Jiewen ; Leif Lindholm
; Kumar, Rahul R ; Ni, Ray
; Sami Mujawar
Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries
On Fri, Mar 8, 2024 at 9:14 AM Laszlo Ersek wrote:
>
> On 3/6/24 23:22, Michael D Kinney
; Leif
Lindholm ; Kinney, Michael D
; Kumar, Rahul R ; Ni, Ray
; Sami Mujawar
Subject: [PATCH] Maintainers.txt: remove Laszlo's entries
Red Hat and I have mutually and amicably agreed to separate. Remove my
entries from "Maintainers.txt".
Cc: Andrew Fish
Cc: Ard Biesheuvel
Cc: Gerd Ho
Michael,
do you have any updated patch?
Thanks,
Ray
From: Michael Brown
Sent: Friday, March 1, 2024 19:10
To: Paolo Bonzini
Cc: Ni, Ray ; devel@edk2.groups.io ;
Kinney, Michael D ; Liming Gao
; Laszlo Ersek
Subject: Re: [PATCH 2/2] MdeModulePkg/DxeCore: Fix
Paolo,
Happy weekends!
Thanks! I will read it on my next Monday.
Thanks,
Ray
> -Original Message-
> From: Paolo Bonzini
> Sent: Friday, March 1, 2024 4:44 PM
> To: Ni, Ray
> Cc: devel@edk2.groups.io; Kinney, Michael D ;
> Liming Gao ; Laszlo Ersek ;
> Michael
Aaron,
Can you share more background of this change?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Aaron Li
> Sent: Friday, March 1, 2024 2:04 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Bi, Dandan
> ; Liming Gao ; Liu, Yun Y
>
> Subject:
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, March 1, 2024 11:02 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Liming Gao
> ; Wu, Jiaxin ; Ni, Ray
> ; Laszlo Ersek ; Ard Biesheuvel
> ; Sami Mujawar
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Friday, March 1, 2024 11:02 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Liming Gao
> ; Wu, Jiaxin ; Ni, Ray
> ; Laszlo Ersek
> Subject: [PATCH v3 2/4] MdeModulePkg/SMM:
t;? I think we should exit from this function.
+}
+ }
+
+ //
+ // If we get here with InInterruptHandler == TRUE, an interrupt
+ // handler forgot to restore the TPL.
+ //
+ ASSERT (!InInterruptHandler);
CoreRestoreTplInternal (NewTpl, NewTpl < TPL_HIGH_LEVEL);
}
Thanks,
Ray
> --
Assuming the current TPL is TPL_APPLICATION,
RaiseTPL (TPL_APPLICATION -> HIGH) and
RestoreTPL (TPL_HIGH -> TPL_APPLICATION) are called in the timer interrupt
context.
RestoreTPL() will lower the TPL from TPL_HIGH to TPL_NOTIFY first, enable
the interrupts and dispatch pending events associated
Ray Ni (2):
UefiCpuPkg/CpuDxe: Return correct interrupt state
MdeModulePkg/DxeCore: Fix stack overflow issue due to nested
interrupts
MdeModulePkg/Core/Dxe/Event/Tpl.c | 151 +-
UefiCpuPkg/CpuDxe/CpuDxe.c| 10 +-
2 files changed, 150 insertions(+), 11
CpuDxe driver uses a global C variable to record the interrupt state.
The state variable is updated every time CpuArch.EnableInterrupt() or
CpuArch.DisableInterrupt() is called.
CpuArch.GetInterruptState() simply returns the state variable.
But when CpuArch.GetInterruptState() is called in the
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, February 28, 2024 10:28 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Liming Gao
> ; Wu, Jiaxin ; Ni, Ray
> ; Laszlo Ersek
> Subject: [PATCH v2 1/4] M
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, February 28, 2024 4:47 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Liming Gao ; Wu, Jiaxin
> ; Ni, Ray ; Ard Biesheuvel
> ; Sami Mujawar
> Subject: Re: [e
Of Laszlo
> Ersek
> Sent: Monday, February 26, 2024 11:20 PM
> To: devel@edk2.groups.io; kra...@redhat.com
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Oliver Steffen
> Subject: Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support
> for multiple MP_HAND_OFF HOBs
>
> O
> + @param[in] MpHandOff Previous HOB body. Pass NULL to get the
> first HOB.
Can you replace "...HOB Body. Pass NULL..." with "...HOB Body. Pass NULL..."?
Your current comments contain two spaces.
With that, Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
> + ASSERT (FALSE);
How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE.
No matter you change or not, Reviewed-by: Ray Ni
> + return 0;
> }
>
> /**
> --
> 2.43.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, February 23, 2024 12:01 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Ni, Ray ; Kumar,
> Rahul R ; Oliver Steffen ;
> Gerd Hoffmann
> Subject: [PATCH v3 5/6] UefiCpuPkg/MpInitLib:
Cc: devel@edk2.groups.io; Oliver Steffen ; Kumar,
> Rahul R ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support
> for multiple HOBs to MpInitLibInitialize
>
> Hi,
>
> > The code looks otherwise OK, but I'm not happy that
> >
> +//
> +// Get APIC IDs
> +//
> +#define EFI_APIC_IDS_GUID \
> + { 0xbc964338, 0xee39, 0x4fc8, { 0xa2, 0x24, 0x10, 0x10, 0x8b, 0x17, 0x80,
> 0x1b }}
> +extern EFI_GUID gEfiApicIdsGuid;
Since the above GUID is associated with the structure below, how about
rename the GUID from
> > + @param[in] FirstMpHandOff Pointer to first MpHandOff HOB.
>
> ... also, it would be more precise to say "first MpHandOff HOB body".
>
"body" is a very good term that emphasizes it doesn't point to a separate
storage.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
> > I agree with the idea (I think it's a necessary change, or put
> > differently, an improvement, even though I may not be convinced that it
> > is a *sufficient* improvement; but let's not rehash all that here
> > again); however, I think the implementation is not the greatest.
> >
> >
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 3/5] U
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Zhou, Jianfeng
> Sent: Wednesday, February 21, 2024 9:25 AM
> To: devel@edk2.groups.io
> Cc: Zhou, Jianfeng ; Ni, Ray ;
> Laszlo Ersek ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH] UefiCpuPkg
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Zhou, Jianfeng
> Sent: Wednesday, February 21, 2024 9:25 AM
> To: devel@edk2.groups.io
> Cc: Zhou, Jianfeng ; Ni, Ray ;
> Laszlo Ersek ; Kumar, Rahul R
> ; Gerd Hoffmann
> Subject: [PATCH] UefiCpuPk
>
> + MaxCpusPerHob = (MAX_UINT16 - sizeof (EFI_HOB_GUID_TYPE) - sizeof
> (MP_HAND_OFF)) / sizeof (PROCESSOR_HAND_OFF);
Above formula assumes the maximum HOB length could be 0x.
But actually the maximum HOB length could be only 0xFFF8 because
PeiCore::PeiCreateHob() contains following
>
> Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB
> covering all CPUs in the system.
>
> Add a new HaveMpHandOff variable to track whenever MP_HAND_OFF HOBs
> are
The commit message may need to be updated as "HaveMpHandOff" variable is gone
in this version.
With that,
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 2/5] U
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 2/5] U
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, February 21, 2024 1:50 AM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Laszlo Ersek
> ; Kumar, Rahul R ; Ni, Ray
> ; Gerd Hoffmann
> Subject: [PATCH v2 1/5] UefiCpuPkg/MpInitLib: Add sup
>
> > +
> > + if (CpuMpData->ApLoopMode != ApInHltLoop) {
> > +MpHandOff->StartupSignalValue= MP_HAND_OFF_SIGNAL;
> > +MpHandOff->WaitLoopExecutionMode = sizeof (VOID *);
> > + }
> > +}
>
> As noted elsewhere, these fields don't belong in the loop (they don't
>
>
> That will only work if the HOBs are returned in ProcessorIndex order.
>
> That happens to be the case in my testing; the HOBs are returned in the
> same order they are created by patch #5 of this series.
>
> Is that behavior guaranteed? MdePkg/Include/Library/HobLib.h doesn't
> say
> This patch makes me uncomfortable. I understand what it intends to do,
> and the intent is not wrong, but we're again treating "volatile UINT32"
> as atomic, and non-reorderable against the
> InterlockedCompareExchange32(). This kind of "optimization" is what
> people write cautionary tales
> -PleB->Uint64 = LocalPleB.Uint64;
>
> +*(volatile UINT64 *)&(PleB->Uint64) = LocalPleB.Uint64;
Jianfeng,
If "volatile" is to tell compiler to generate single "mov" instruction for
the assignment.
I am curious how it works in 32bit env where the general purpose registers are
32bit
> + STATIC CONST UINT32 CpusPerHob = 128;
1. Can you refer to
https://github.com/tianocore/edk2/blob/9979c887ef54023c9e262242db02c92d11b7f1e5/UefiCpuPkg/CpuMpPei/CpuMpPei.c#L572
to avoid
hardcode 128?
The MP_HAND_OFF structure change may cause 128 an invalid value.
-=-=-=-=-=-=-=-=-=-=-=-
> - MpHandOff = GetMpHandOffHob (0);
> - if (MpHandOff == NULL) {
> + MaxLogicalProcessorNumber = 0;
> + HaveMpHandOff = FALSE;
1. Can we cache the first MpHandOff instance? It can be used as an indicator to
replace "HaveMpHandOff",
and also can speed up the HOB enumeration in
SwitchApContext() can cache the first instance of MpHandOffHob so that the
second enumeration can avoid searching
for the MpHandOffHob from the top of HOB list.
> VOID
> SwitchApContext (
> - IN MP_HAND_OFF *MpHandOff
> + VOID
>)
> {
> - UINTN Index;
> - UINT32 BspNumber;
> +
> -Original Message-
> From: Gerd Hoffmann
> Sent: Thursday, February 15, 2024 5:32 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Rahul R ;
> Gerd Hoffmann
> Subject: [PATCH 2/5] UefiCpuPkg/MpInitLib: Add support for multipl
>EFI_HOB_GUID_TYPE *GuidHob;
>MP_HAND_OFF*MpHandOff;
>
> - MpHandOff = NULL;
> - GuidHob = GetFirstGuidHob ();
> - if (GuidHob != NULL) {
> + for (GuidHob = GetFirstGuidHob ();
> + GuidHob != NULL;
> + GuidHob = GetNextGuidHob (, GET_NEXT_HOB
> (GuidHob)))
> +
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, January 27, 2024 3:56 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [Patch 1/1] PcAtChipsetPkg/HpetTimerDxe: Fix nested interrupt time
> acc
> Sounds safe enough. I don't know if it conforms to the spec however
> (although we might just choose not to care about that).
Should be compliant to spec. Or I should say spec does not under which case the
Unregister() should succeed. As long as spec allows Unregister() returns a
failure
> That would then be a bug in HpetTimer, which ought to be fixed. If
> HpetTimer were to be used on a platform where the NotifyFunction
> correctly assumes that it is called at TPL_HIGH_LEVEL and does something
> that would break at a lower level, then this could lead to undefined
> behaviour.
> On 25/01/2024 07:57, Ni, Ray wrote:
> > This mail is to bring another approach to solve the stack-overflow due
> > to nested interrupts. Michael solved this problem in OVMF through
> > NestedInterruptTplLib.
> >
> > I made a draft patch as attached “DxeCore.dif
ent: Tuesday, January 23, 2024 11:31 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gerd Hoffmann ; Laszlo
> Ersek ; Michael Brown
> Subject: [edk2-devel] [PATCH v3 0/5] MdeModulePkg: Move
> NestedInterruptTplLib to MdeModulePkg
>
> NestedInterruptTplLib provides a way for timer
t to
NULL when it returns.
Unregister() compares the handle against gCurrentSmiHandle if it's not NULL.
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, January 25, 2024 6:48 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Liming Gao ; Wu,
Rename an existing PCD might break lots of platform builds.
When 5-level paging capability was added to ResetVector, I also considered to
remove the PcdUse5LevelPageTable reference from C code.
Let me think about it...
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On
Acked-by: Ray Ni
+ Tom
Thanks,
Ray
> -Original Message-
> From: Attar, AbdulLateef (Abdul Lateef)
> Sent: Thursday, January 25, 2024 1:02 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Liming Gao
> ; Liu, Zhiguang ; Ni,
> Ray ; Kumar, Rahul R ; Gerd
>
All,
This mail is to bring another approach to solve the stack-overflow due to
nested interrupts. Michael solved this problem in OVMF through
NestedInterruptTplLib.
I made a draft patch as attached "DxeCore.diff". The patch simply to avoid the
interrupt in enable state when TPL is dropped to
Agree.
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, January 24, 2024 8:41 PM
> To: Ni, Ray
> Cc: Guo, Gua ; devel@edk2.groups.io; Marc Beatove
> ; Ard Biesheuvel ;
> Sami Mujawar ; Mathews, John
>
> Sub
spec does not say the unregistration is allowed inside handler. it's just to
improve the qualiquali the code.
thanks,
ray
From: Laszlo Ersek
Sent: Wednesday, January 24, 2024 9:06:13 PM
To: devel@edk2.groups.io ; Ni, Ray ;
Liu, Zhiguang
Cc: Liming Gao ; Wu
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Huang, Jenny
> Sent: Tuesday, January 23, 2024 11:26 AM
> To: Sheng, W ; devel@edk2.groups.io
> Cc: Ni, Ray ; Chiang, Chris
> Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Add feedback status for
> P
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, January 23, 2024 3:16 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Ni, Ray ; Laszlo
> Ersek ; Kumar, Rahul R ; Gerd
> Hoffmann ; Lee, Crystal ;
> Pedro Falca
Thank you for adding the self-test code!
Thanks,
Ray
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, January 24, 2024 6:25 PM
> To: Michael Brown ; devel@edk2.groups.io
> Cc: Gerd Hoffmann ; Laszlo Ersek
> Subject: RE: [PATCH v3 4/5] MdeModuleP
> +//
> +// Number of self-tests to perform.
> +//
> +#define NUMBER_OF_SELF_TESTS \
> + (FixedPcdGet32 (PcdNestedInterruptNumberOfSelfTests))
1. can we avoid defining a PCD? I do not see a need that each platform needs
to use a different count. How about just define it as 1?
> +
> +STATIC
>
> ; Wu, Jiaxin ; Ni, Ray
>
> Subject: [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler
> inside SMI handler
>
> To support unregister SMI handler inside SMI handler itself,
> get next node before SMI handler is executed, since LIST_ENTRY that
> Link points to
ead of in the callers?
Thanks,
Ray
> -Original Message-
> From: Nhi Pham
> Sent: Friday, January 19, 2024 12:57 PM
> To: devel@edk2.groups.io
> Cc: ardb+tianoc...@kernel.org; Ni, Ray ;
> sami.muja...@arm.com; ler...@redhat.com; Nhi Pham
>
> Subject: [PATCH 1/1] S
> The worry I have here is that it becomes a maintenance concern having to
> update the list of leaves with sub-leaves whenever a new CPUID leaf with
> sub-leaves is introduced.
Intel SDM or AMD equivalent "SDM" should not change a CPUID leaf in a way
that it does not consume ECX today but
ichael Brown
> Sent: Saturday, January 20, 2024 7:25 AM
> To: devel@edk2.groups.io
> Cc: Michael Brown ; Ni, Ray ; Laszlo
> Ersek ; Gerd Hoffmann ; Kinney,
> Michael D
> Subject: [PATCH 1/1] MdeModulePkg: Move NestedInterruptTplLib to
> MdeModulePkg
>
> NestedInterru
D
Sent: Saturday, January 20, 2024 9:49 AM
To: Ni, Ray ; Tom Lendacky ;
devel@edk2.groups.io; Gao, Liming ; Liu, Zhiguang
; Dong, Eric ; Kumar, Rahul R
; Gerd Hoffmann ; Ard Biesheuvel
Cc: Michael Roth ; Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use
From: Kinney, Michael D
Sent: Saturday, January 20, 2024 7:16:14 AM
To: Ni, Ray ; Tom Lendacky ;
devel@edk2.groups.io ; Gao, Liming
; Liu, Zhiguang ; Dong, Eric
; Kumar, Rahul R ; Gerd Hoffmann
; Ard Biesheuvel
Cc: Michael Roth ; Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH 1/2
From: Michael Brown
Sent: Saturday, January 20, 2024 1:42 AM
To: devel@edk2.groups.io ; Ni, Ray ;
Laszlo Ersek ; kra...@redhat.com
Cc: Pedro Falcato ; Kinney, Michael D
; Desimone, Nathaniel L
; Kumar, Rahul R ;
Liu, Zhiguang
Subject: Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg
2. If DxeCore can be changed, do you have an easier-to-understand solution?
It really took me 2 days to understand why NestedInterruptTplLib is written in
today's way.
thanks,
ray
From: Michael Brown
Sent: Wednesday, January 17, 2024 6:46:59 PM
To: devel@edk2.
.
Thanks,
Chao
On 2024/1/16 08:59, Chao Li wrote:
OK, let me finish this work tomorrow, I'm a little busy today.
On 2024/1/15 16:11, Ni, Ray wrote:
Yes. Fine to me. Thanks!
Thanks,
Ray
-Original Message-
From: Sunil V L <mailto:suni...@ventanamicro.com>
Sent: Monday, January 15,
gt; Sent: Friday, January 19, 2024 7:11 AM
> To: Tom Lendacky ; devel@edk2.groups.io;
> Gao, Liming ; Liu, Zhiguang ;
> Dong, Eric ; Ni, Ray ; Kumar, Rahul R
> ; Gerd Hoffmann ; Ard
> Biesheuvel
> Cc: Michael Roth ; Kinney, Michael D
>
> Subject: RE:
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, January 17, 2024 6:24 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Gerd Hoffmann
> Subject: Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, January 17, 2024 6:23 PM
> To: devel@edk2.groups.io; Liu, Zhiguang
> Cc: Ni, Ray ; Kumar, Rahul R ;
> Gerd Hoffmann
> Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiC
estoreTPL(), CPU interrupt is enabled.
But, in my opinion, it's impossible.
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, January 16, 2024 11:37 PM
> To: devel@edk2.groups.io; mc...@ipxe.org; kra...@redhat.com
> Cc: Pedro Falcato ; Ni, Ray ;
> K
t; Cc: Abdul Lateef Attar ; Ni, Ray
> ; Kumar, Rahul R ; Gerd
> Hoffmann
> Subject: [PATCH v1 2/2] UefiCpuPkg/BaseXApicX2ApicLib: Implements AMD
> extended cpu topology
>
> From: Abdul Lateef Attar
>
> This patch adds support for AMD's new extended topology.
> I
Yes. Fine to me. Thanks!
Thanks,
Ray
> -Original Message-
> From: Sunil V L
> Sent: Monday, January 15, 2024 2:46 PM
> To: Chao Li
> Cc: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D
> ; Laszlo Ersek ; Gerd
> Hoffmann
> Subject: Re: [edk2-devel] R
The patch adds detailed comments to explain that passing fixed timer period
to mTimerNotifyFunction() is not a bug.
Signed-off-by: Ray Ni
Cc: Michael D Kinney
Cc: Nate DeSimone
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/LocalApicTimerDxe/LocalApicTimerDxe.c | 15 +++
1 file
LocalApicTimerDxe uses APIC Timer as the timer interrupt source.
Other code should not program the APIC Timer as it may cause the timer
interrupt be signaled at the incorrect timer period or the timer interrupt
might be disabled.
The patch prints warning debug messages in driver entrypoint when
Old logic is simply to get the APIC Timer Frequency from PcdFSBClock.
New logic follows the SDM to firstly get the crystal clock frequency from
CPUID.0x15 leaf. If CPUID.0x15 is not supported, the crystal clock frequency
is retrieved from PcdCpuCoreCrystalClockFrequency.
Then the new logic finds
Signed-off-by: Ray Ni
Cc: Michael D Kinney
Cc: Nate DeSimone
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
UefiCpuPkg/UefiCpuPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
index
a086f4a adds NestedInterruptTplLib call in OvmfPkg/LocalApicTimerDxe to
avoid stack overflow due to interrupt storm in VM guest.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2815
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4162
The interrupt storm only happens in VM guest
This commit only duplicates the OvmfPkg/LocalApicTimerDxe.
Following commits will enhance the driver.
FILE_GUID in INF file is updated with a new GUID.
Signed-off-by: Ray Ni
Cc: Michael D Kinney
Cc: Nate DeSimone
Cc: Laszlo Ersek
Cc: Rahul Kumar
Cc: Gerd Hoffmann
---
Ray Ni (6):
UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe
driver
UefiCpuPkg/LocalApicTimerDxe: Remove NestedInterruptTplLib call
UefiCpuPkg: Add LocalApicTimerDxe driver in DSC file
UefiCpuPkg/LocalApicTimerDxe: Enhance Timer Frequency calculation
logic
That will be great!
Thanks,
Ray
> -Original Message-
> From: Sunil V L
> Sent: Monday, January 15, 2024 12:44 PM
> To: Ni, Ray
> Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael D
> ; Laszlo Ersek ; Gerd
> Hoffmann
> Subject: Re: RFC: Folder lay
Sunil,
I am glad that you don't have concern about the direction.
"RiscV" is good to me.
Thanks,
Ray
> -Original Message-
> From: Sunil V L
> Sent: Friday, January 12, 2024 6:19 PM
> To: Ni, Ray
> Cc: devel@edk2.groups.io; lic...@loongson.cn; Kinney, Michael
, January 12, 2024 5:16 PM
To: devel@edk2.groups.io; Ni, Ray
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: Re: [edk2-devel] [PATCH v7 11/37] UefiCpuPkg: Add LoongArch64 CPU
Timer library
Hi Ray,
Thanks,
Chao
On 2024/1/12 16:51, Ni, Ray wrote:
Chao,
Do you mind putting the lib content
101 - 200 of 2347 matches
Mail list logo
