[edk2-devel] [PATCH 1/6] MdePkg: Add TME-MK related CPUID and MSR definitions

TME (Total Memory Encryption) is the capability to encrypt the entirety of physical memory of a system. TME-MK (Total Memory Encryption-Multi-Key) builds on TME and adds support for multiple encryption keys. The patch adds some necessary CPUID/MSR definitions for TME-MK. Signed-off-by: Ray Ni

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

> + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > + { > +X2Apic = TRUE; Gerd, I agree with your needs that want X2 APIC even the actual processor number in BIOS phase <= 255. Question: Is it possible

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

. Thanks, Ray From: Sean Rhodes Sent: Monday, March 20, 2023 8:47 PM To: Ni, Ray Cc: Tan, Lean Sheng ; devel@edk2.groups.io; Kinney, Michael D ; Gao, Zhichao ; Wang, Jian J ; Gao, Liming Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Hi

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

Reviewed-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; Gerd > Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; > Dong, Eric > Subject: [PATCH 2/2] Uef

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors

Reviewed-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; Gerd > Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; > Dong, Eric > Subject: [PATCH 1/2] Uefi

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

0, 2023 4:12 PM To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D Cc: Rhodes, Sean ; Gao, Zhichao ; Wang, Jian J ; Gao, Liming Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo Hi Ray, Any feedback per Mic feedback? On 15. Mar 2023, at 1

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

> ASM_PFX(FspInfoHeaderRelativeOff): > > DD0x12345678 ; This value must be patched by the build > script > > - and rax, 0x > > + mov eax, eax ; equal to and rax, 0x Based on the discussion, we know "mov eax, eax" clears upper

Re: [edk2-devel] [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed

OK. Then Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, March 15, 2023 5:26 PM > To: Ni, Ray ; Tan, Dun ; > devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > > Subject: RE: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

What’s the meaning of “have both options”? If you want to support two cases, put the logic in your platform specific Logo driver. This Logo driver is just for reference. From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Friday, March 10, 2023 9:43 PM To: Ni, Ray Cc: devel@edk2

Re: [edk2-devel] [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed

> @@ -413,8 +422,9 @@ CompareEntrysforOnePoint ( >// >for (Index = 0; Index < MapCount; Index++) { > if ((Address >= Map[Index].LinearAddress) && (Address < > (Map[Index].LinearAddress + Map[Index].Length))) { > - AttributeInMap.Uint64= >

Re: [edk2-devel] [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

> +UINT32PageTableBaseAddressLow : 19; // Page Table Base Address > High 1. Comments say "High". Should be "Low". > + > > - MapMask.Bits.PageTableBaseAddress = 1; > - MapMask.Bits.Present = 1; > - MapMask.Bits.ReadWrite= 1; > +

Re: [edk2-devel] [Patch V2 12/14] UefiCpuPkg/CpuPageTableLib: Add RandomTest for PAE paging

Can you please check that the reserved fields in 4 PDPTE entries are set to 0 in the test? > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Sub

Re: [edk2-devel] [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

> +if (PagingMode == PagingPae) { > + // > + // These fields of PAE paging PDPTE should be 0 according to SDM. > + // 1. can you update comments to explain such as: "These fields are treated as ReadWrite, by the common map logic. So they might be set to 1." > +

Re: [edk2-devel] [Patch V2 10/14] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified

> >GenerateSingleRandomMapEntry (MaxAddress, MapEntrys); >Status = PageTableParse (*PageTable, PagingMode, NULL, ); > > + if (MapCount != 0) { > +// > +// Allocate memory for Map > +// Note the memory is only used in this one Single MapEntry Test > +// > +

Re: [edk2-devel] [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

> + IA32_PAGING_ENTRY ParentPagingEntryContent; 1. how about "OriginalParentPagingEntry"? > + IA32_PAGING_ENTRY PrevLeafPagingEntryContent; 2. how about "OriginalCurrentPagingEntry"? > > + // > + // Check if ParentPagingEntry entry is modified. > + // 3. Can you add more comments to

Re: [edk2-devel] [Patch V2 07/14] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

> > -/** > - Return a random boolean. > - > - @return boolean > -**/ > -BOOLEAN > -RandomBoolean ( > - VOID > - ) > -{ > - BOOLEAN Value; > - > - LocalRandomBytes ((UINT8 *), sizeof (BOOLEAN)); > - return Value%2; > -} > - > /** >Return a 32bit random number. > > @@ -139,6 +123,21

Re: [edk2-devel] [Patch V2 08/14] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 mapping in random test

Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2 08/14] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 >

Re: [edk2-devel] [Patch V2 06/14] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

Please update test case to not expect failure when setting a non-present range as non-present . > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann &g

Re: [edk2-devel] [Patch V2 05/14] UefiCpuPkg/CpuPageTebleLib: Check Mask and Attr in PageTableMap

> +**/ > +RETURN_STATUS > +CheckMaskAndAttrForNotPresentEntry ( > + IN IA32_MAP_ATTRIBUTE *Attribute, > + IN IA32_MAP_ATTRIBUTE *Mask > + ) > +{ > + if ((Attribute->Bits.Present == 0) || (Mask->Bits.Present == 0) || (Mask- > >Bits.ReadWrite == 0) || 1. I think we can allow caller to

Re: [edk2-devel] [Patch V2 04/14] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

> + > + ParentPagingEntry->Uintn = (UINTN)(VOID *)PagingEntry; Only address field is set but attributes are cleared to zeros. Then following code sets the attributes. Still a hole at this point, right? > >// >// Set NOP attributes > @@ -363,12 +370,6 @@

Re: [edk2-devel] [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

3 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 > mapping issue > > In previous code logic, when splitting a leaf parent entry to > smaller granularity chil

Re: [edk2-devel] [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

You can carry my Reviewed-by in next version if you add the copy right year change. > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Sub

Re: [edk2-devel] [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length

The function header comments in lib header and C file should be updated as well to document a new condition when success is returned. > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; K

Re: [edk2-devel] [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

Dun, The copyright year needs to change to 2023. Code logic change is good to me. Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann >

Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

ael D ; Feng, Bob C > ; Gao, Liming ; > devel@edk2.groups.io > Cc: Chen, Christine ; Ni, Ray ; > Oram, Isaac W ; Sean Brogan > ; a...@kernel.org > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > information in build report > > Hi guys, can we submit t

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

That depends on review from other package maintainers. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, March 13, 2023 4:46 PM > To: Ni, Ray > Cc: Tom Lendacky ; devel@edk2.groups.io; > Dong, Eric ; Kumar, Rahul R >

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu

Jiaxin, Thanks for fixing the bug. Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Monday, March 13, 2023 3:04 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > > Subject: [PATCH v1] U

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

Agree with both comments > -Original Message- > From: Gerd Hoffmann > Sent: Monday, March 13, 2023 4:00 PM > To: Tom Lendacky > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Michael > Roth ; Ashish Kalra > Subject: Re: [PATCH 1/2] UefiCpuP

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

> > +#define IS_ALIGNED(x, y) UINTN)(x) & (y - 1)) == 0)) 1. Can you use the existing macro ALIGN_POINTER() defined in Base.h? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101059): https://edk2.groups.io/g/devel/message/101059

Re: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

PM > To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > Cc: Grimes, Paul ; Kirkendall, Garrett > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: RE: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Adds > SmmSmramSaveStateLib library class > >

Re: [edk2-devel] [Patch 1/1] ShellPkg/Library: Fix 32-bit truncation of pointer values

Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 12, 2023 4:12 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [Patch 1/1] ShellPkg/Library: Fix 32-bit truncation of pointer values > > REF: https:

Re: [edk2-devel] [Patch V3 0/2] Modify defination for MpWakeupStructure

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Thursday, March 9, 2023 11:40 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/2] Modify defination for > MpWakeupStructure > > In V3 patch: > Modify wrong naming in

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

> -Original Message- > From: Tan, Dun > Sent: Thursday, March 9, 2023 11:12 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ni, > Ray > Subject: [Patch V2 2/2] MdePkg: Add define for > MultiprocessorWakeupMailboxStruct

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Maybe I didn’t explain my idea clearly. That is: You can get the screen resolution in the code that produces Logo protocol. You can return a carefully-calculated X/Y value to make the logo at MS preferred position. From: devel@edk2.groups.io On Behalf Of Ni, Ray

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

M: Jian J Wang jian.j.w...@intel.com [jwang36] M: Liming Gao gaolim...@byosoft.com.cn [lgao4] Jian and Liming are maintainers of MdeModulePkg. The patch passed my review. Either of them can help to merge the patch. I guess Liming

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Sure. I will. > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, March 8, 2023 7:53 AM > To: devel@edk2.groups.io; Ni, Ray ; Reyes, Darbin > > Cc: Narey, Jacob ; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasure

Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception

Great fix. I am wondering why this bug was not found earlier. If Status is 0 (Success), #PF exception would occur when NULL pointer protection is turned on. If Status is 0x8000_x (Error), #GP exception would occur because an address with only the BIT63 set is an invalid address. Thanks, Ray

Re: [edk2-devel] [Patch V4 0/8] Put APs in 64 bit mode before handoff to OS.

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Yuanhao Xie > Sent: Wednesday, March 1, 2023 2:10 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V4 0/8] Put APs in 64 bit mode before handoff > to OS. > > The purpose of this patch

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly

Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, March 7, 2023 2:32 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann ; Zeng, > Star ; Mike Maslenkin > Subject: [PATC

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

@Liu, Zhiguang, can you check if Mike's suggestion "+" instead of "|" is more matching to SDM? If yes, we can create another code patch. > -Original Message- > From: Mike Maslenkin > Sent: Monday, March 6, 2023 9:37 PM > To: devel@edk2.groups.io; Ni,

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

ExtendedModelId field should use shift. So I believe nothing wrong there. > -Original Message- > From: Mike Maslenkin > Sent: Monday, March 6, 2023 7:14 PM > To: devel@edk2.groups.io; Zeng, Star > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Ger

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

Gerd, Thanks for reporting. Can you kindly share the reproduce steps? Jiaxin, Can you look into this? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, March 6, 2023 7:13 PM > To: devel@edk2.groups.io > Cc: Ni

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

Curious about the background of this change. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dhaval > Sharma > Sent: Friday, March 3, 2023 2:12 AM > To: devel@edk2.groups.io > Cc: Guo, Gua > Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from > UPL

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Thursday, March 2, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg: Calculate DisplayF

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Remove Duplicate gEmuIoThunkProtocolGuid

Acked-by: Ray Ni > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, March 1, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Andrew Fish > ; Ni, Ray ; Kinney, Michael D > ; Chiu, Chasel > Subject: [PATCH v1] Emula

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix misspelling

Acked-by: Ray Ni > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, March 1, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Andrew Fish > ; Ni, Ray ; Kinney, Michael D > ; Chiu, Chasel > Subject: [PATCH v1] Emul

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling

Acked-by: Ray Ni > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, March 1, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Andrew Fish > ; Ni, Ray ; Kinney, Michael D > ; Chiu, Chasel > Subject: [PATCH v1] EmulatorPkg:

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Rename Variable

Nice change Acked-by: Ray Ni > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, March 1, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Andrew Fish > ; Ni, Ray ; Kinney, Michael D > ; Chiu, Chasel > Subject: [PATCH

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Correct Comment

Acked-by: Ray Ni > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, March 1, 2023 12:55 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Andrew Fish > ; Ni, Ray ; Kinney, Michael D > ; Chiu, Chasel > Subject: [PATCH v1] Emul

Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

uesday, February 28, 2023 7:42 AM > To: Kinney, Michael D ; devel@edk2.groups.io; > a...@kernel.org > Cc: Ni, Ray ; Chen, Christine ; > Feng, Bob C ; Gao, Liming > ; Oram, Isaac W ; > Sean Brogan > Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile > info

Re: [edk2-devel] [Patch V3 0/6] Put APs in 64 bit mode before handoff to OS.

Yuanhao, What changes have been made in V3 comparing against V2? > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Yuanhao Xie > Sent: Friday, February 24, 2023 2:05 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/6] Put APs in 64 bit mode before handoff

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

: Tuesday, February 21, 2023 4:49 PM > To: Ni, Ray > Cc: Wu, Jiaxin ; devel@edk2.groups.io; Dong, Eric > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process > > On Mon, Feb 20, 2023 at 01:14:33AM +, Ni

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

Mike, it can wait. > -Original Message- > From: Kinney, Michael D > Sent: Monday, February 20, 2023 10:37 AM > To: devel@edk2.groups.io; Wu, Jiaxin > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R ; Kinney, > Michael

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

SMBASE configuration Thanks, Ray > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 20, 2023 9:07 AM > To: devel@edk2.groups.io; Wu, Jiaxin > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: RE: [e

Re: [edk2-devel] [PATCH v6] Update CPUID Leaf 06H to follow latest SDM.

Reviewed-by: Ray Ni > -Original Message- > From: Wang, William2 > Sent: Friday, February 17, 2023 4:24 PM > To: devel@edk2.groups.io > Cc: Wang, William2 ; Kinney, Michael D > ; Gao, Liming ; > Ni, Ray ; Kuo, Donald ; Kumar, > Chandana C > Subject: [PATC

Re: [edk2-devel] [PATCH v5] Update CPUID Leaf 06H to follow latest SDM.

> > +UINT32HW_FEEDBACK: 1; Though the field name looks strange and inconsistent with other field naming styles, it does follow the SDM content. Looks good to me. > > -UINT32Reserved2: 28; > > +UINT32Reserved2

Re: [edk2-devel] [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, February 16, 2023 2:17 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v9 3/6] UefiCpuPkg/Sm

Re: [edk2-devel] [PATCH v8 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, February 16, 2023 10:47 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v8 4/6] UefiCpuPkg

Re: [edk2-devel] [PATCH v8 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

> -Original Message- > From: Wu, Jiaxin > Sent: Thursday, February 16, 2023 10:47 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v8 3/6] UefiCpuPkg/SmmBaseHob.h:

Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

Mike, Thanks for the explanation of status and plan. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 16, 2023 7:13 AM > To: Ni, Ray ; devel@edk2.groups.io; Chen, Christine > ; Palomino Sosa, Guillermo A > > Cc: Feng, Bob C ; Gao, Liming

Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

Christine, If BaseTools related changes is implemented in edk2-basetools repo, does that mean if I only checkout edk2 repo, I am using an older version of BaseTools? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Wednesday, February 15,

Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Thursday, January 12, 2023 1:14 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Garrett > Kirkendall ; Abner Chang > > Subj

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

@Wang, Jian J thanks, ray From: devel@edk2.groups.io on behalf of Sheng Lean Tan Sent: Monday, February 13, 2023 6:01:21 PM To: Rhodes, Sean ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip

Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

Will review v6 of PiSmmCpu driver change after you two are aligned. > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 13, 2023 12:15 PM > To: kra...@redhat.com; Ni, Ray > Cc: devel@edk2.groups.io; Dong, Eric ; Zeng, Star > ; Laszlo Ersek ; Kumar, Rahul

Re: [edk2-devel] [PATCH v6 5/6] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

I remember I already provided the R-B. Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 13, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R >

Re: [edk2-devel] [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not

gt; Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [edk2-devel] [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check > SmBase relocation supported or not > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4337 > >

Re: [edk2-devel] [PATCH v6 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

> + UINT64SmBase[1]; Can you please use "SmBase[]" as what Marvin pointed out? Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100070): https://edk2.groups.io/g/devel/message/100070 Mute This Topic:

Re: [edk2-devel] [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 13, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v6 2/6] UefiCpuPkg

Re: [edk2-devel] [PATCH v6 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Monday, February 13, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v6 1/6] UefiCpuPkg/PiS

Re: [edk2-devel] [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

the chunk idea. Thanks, Ray > -Original Message- > From: Gerd Hoffmann > Sent: Friday, February 10, 2023 8:32 PM > To: Ni, Ray > Cc: Wu, Jiaxin ; devel@edk2.groups.io; Dong, Eric > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v4 2/5] Uefi

Re: [edk2-devel] [PATCH v4 0/5] Simplify SMM Relocation Process

Jiaxin, I provide separate review comments for each patch. Can you please make sure the copy right year is updated for every file change? I may not emphasize this for each patch. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Friday, February 10, 2023

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 07/19] UefiCpuPkg: Add CpuTimerDxeRiscV64 module

> UefiCpuPkg/CpuTimerDxeRiscV64/CpuTimer.uni | 14 + > UefiCpuPkg/CpuTimerDxeRiscV64/CpuTimerExtra.uni | 12 + For the above two file name, better to use the same base name as that of INF file. > -Original Message- > From: devel@edk2.groups.io On Behal

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 05/19] UefiCpuPkg: Add BaseRiscV64CpuExceptionHandlerLib

Acked-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Friday, February 10, 2023 8:30 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer ; > Abner Chang ; Gerd Hoffmann ; > Wark

Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

> > Hi, > > > 3) The special case you have to handle is not running on a AMD > > Processor, but AmdSev being active (i.e. UseSevEsAPMethod == True). > > Otherwise it should be just standard Ia32 and X64, there should be no > > need to check whenever you are running on a AMD processor. > > > >

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 06/19] UefiCpuPkg: Add BaseRiscV64CpuTimerLib library

Acked-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Friday, February 10, 2023 8:30 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer ; > Abner Chang ; Gerd Hoffmann ; > Wark

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 07/19] UefiCpuPkg: Add CpuTimerDxeRiscV64 module

Acked-by: Ray Ni > -Original Message- > From: Sunil V L > Sent: Friday, February 10, 2023 8:30 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer ; > Gerd Hoffmann ; Abner Chang ; > Warkentin, Andrei > Subject: [e

Re: [edk2-devel] [PATCH v4 4/5] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

Reviewed-by: Ray Ni -- but please update the copyright year. > -Original Message- > From: Wu, Jiaxin > Sent: Friday, February 10, 2023 2:05 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R &

Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

Behalf Of Gerd > Hoffmann > Sent: Friday, February 10, 2023 7:27 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: > Consume SMM Base Hob

Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

> + ZeroMem (mSmmInitialized, sizeof (BOOLEAN) * mMaxNumberOfCpus); > ... > + for (Index = 0; Index < mNumberOfCpus; Index++) { > +while (mSmmInitialized[Index] == FALSE) { > +} Above code sets the BOOLEAN array to all FALSE. Then polling on the array to be all TRUE. We need to add

Re: [edk2-devel] [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

Gerd, That requires changing PI spec and all HOB consuming logic. But if you have a simple idea, please advise. Thanks, Ray > -Original Message- > From: Gerd Hoffmann > Sent: Friday, February 10, 2023 7:24 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; N

Re: [edk2-devel] [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

Jiaxin, > + /// > + /// Pointer to SmBase address for each Processors. > + /// > + UINT64SmBase[1]; Why SmBase[1] instead of SmBase[0]? I think using SmBase[0] can better help C code to calculate the HOB size. Simply sizeof (SMM_BASE_HOB_DATA) * sizeof (UINT64) * CpuCount, instead of

Re: [edk2-devel] [PATCH v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Friday, February 10, 2023 2:05 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R

Re: [edk2-devel] [PATCH] MdeModulePkg: allow PlatformBootManagerLib to use BootNext

use EfiBootManagerBoot() API to boot directly. > -Original Message- > From: Kinney, Michael D > Sent: Friday, February 10, 2023 11:50 AM > To: devel@edk2.groups.io; jesh...@nvidia.com; Demeter, Miki > ; Ni, Ray ; Wang, Jian J > ; Gao, Liming ; Gao, > Zhichao &g

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 07/20] UefiCpuPkg/CpuDxe: Add RISC-V instance

Since there is nothing shared between RiscV and X86, can you put the driver in a different folder such as RiscVCpuDxe? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99864): https://edk2.groups.io/g/devel/message/99864 Mute This Topic:

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 09/20] UefiCpuPkg/UefiCpuPkg.ci.yaml: Ignore RISC-V file

Acked-by: Ray Ni > -Original Message- > From: Sunil V L > Sent: Sunday, January 29, 2023 3:18 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Abner Chang > Subject: [edk2-staging/RiscV64QemuVirt PATC

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 08/20] UefiCpuPkg/CpuTimerLib: Add RISC-V instance

Can you rename CpuTimerLib to RiscVTimerLib or something else that's more specific? RiscV64 sub-directory might not be necessary. > -Original Message- > From: Sunil V L > Sent: Sunday, January 29, 2023 3:18 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; K

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 06/20] UefiCpuPkg/CpuExceptionHandlerLib: Add RISC-V instance

alf Of Sunil V L > Sent: Sunday, January 29, 2023 3:18 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer > ; Abner Chang ; Gerd > Hoffmann > Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 06/20] > UefiCpuPkg/CpuException

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 05/20] UefiCpuPkg: Add CpuTimerDxe module

o > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer > ; Gerd Hoffmann ; Abner > Chang > Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 05/20] > UefiCpuPkg: Add CpuTimerDxe module > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 >

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V7 04/20] UefiCpuPkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions

Acked-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > Sent: Sunday, January 29, 2023 3:18 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Daniel Schaefer > ; Gerd Hoffmann ; Abner > Cha

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/PeiTimerLib: Bug fix in NanoSecondDelay

Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 9, 2023 7:17 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Gao, Liming > Cc: Cole, Deric ; Andrew Fish ; Ni, > Ray ; Kinney, Michael D > Subject: RE:

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

2023 9:23 PM > To: kra...@redhat.com; Ni, Ray > Cc: Johnson, Brian ; devel@edk2.groups.io; Laszlo > Ersek ; Dong, Eric ; Zeng, Star > ; Kumar, Rahul R ; Kinney, > Michael D ; Zimmer, Vincent > > Subject: RE: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SM

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

> > > > It's doable to program the hardware interface using DXE MP service > protocol in > > CpuSmm driver's entry point. > > But, considering the standalone MM environment where the CpuMm > driver runs > > in a isolated environment and it cannot invoke any DXE or PEI MP service, > you could > >

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

> -Original Message- > From: Laszlo Ersek > Sent: Thursday, February 2, 2023 7:47 PM > To: Gerd Hoffmann ; Wu, Jiaxin > Cc: Ni, Ray ; devel@edk2.groups.io; Dong, Eric > ; Zeng, Star ; Kumar, Rahul R > > Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Ski

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

-Original Message- > From: Brian J. Johnson > Sent: Friday, February 3, 2023 6:29 AM > To: devel@edk2.groups.io; kra...@redhat.com; Ni, Ray > Cc: Laszlo Ersek ; Wu, Jiaxin ; Dong, > Eric ; Zeng, Star ; Kumar, Rahul R > ; Kinney, Michael D ; > Zimmer, Vincent > Su

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Wednesday, February 1, 2023 9:15 PM > To: Wu, Jiaxin > Cc: Laszlo Ersek ; Ni, Ray ; > devel@edk2.groups.io; Dong, Eric ; Zeng, Star > ; Kumar, Rahul R ; Kinney, >

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

> -Original Message- > From: Laszlo Ersek > Sent: Friday, January 20, 2023 4:21 PM > To: Ni, Ray ; Gerd Hoffmann ; Wu, > Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Zeng, Star > ; Kumar, Rahul R ; Kinney, > Michael D ; Zimmer, Vincent > > Subject:

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging

> Cc: devel@edk2.groups.io; Kumar, Rahul R ; Zeng, > Star ; w...@sirius.home.kraxel.org; Wu, Jiaxin > ; Ni, Ray ; Dong, Eric > > Subject: Re: [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging > > On Wed, Jan 18, 2023 at 09:23:48AM +0800, Zhiguang Liu wrote: > &

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging

> > > And for the CpuPageTableLib, I think the API don't provide the > > interface to split 2MB-page page table into 4KB-page, which is the > > function wants to do. > > I think that is handled by the library automatically. You can request > address ranges being mapped with specific attributes

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

hanks, Ray > -Original Message- > From: Gerd Hoffmann > Sent: Wednesday, January 18, 2023 7:19 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h:

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

, January 18, 2023 8:20 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE > configuration > > On Wed, Jan 18, 2023 at 05:56:20PM +0800

<    3   4   5   6   7   8   9   10   11   12   >