dk2 --recursive
Best regards,
Mike
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, May 29, 2024 11:33 AM
To: Pete Batard ; devel@edk2.groups.io; Yao, Jiewen
; mikub...@linux.microsoft.com
Cc: Kinney, Michael D
Subject: RE: [edk2-devel] libspdm Breaking Builds
Hi Pete,
There is
Hello all,
On 2024.05.24 03:13, Yao, Jiewen via groups.io wrote:
Please let us know if the preference for libspdm submodule. (Below options)
1) Keep current libspdm official 3.3.0 release, and update to next release at
the beginning of July.
2) Update libspdm immediately with the new cmocka
question, see inline:
On 2024.05.08 10:08, Ard Biesheuvel wrote:
On Wed, 8 May 2024 at 11:07, Ard Biesheuvel wrote:
On Wed, 8 May 2024 at 10:52, Pete Batard wrote:
Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression
resulting in 'error A2023: undefined symbol
Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression
resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer'
when compling MdePkg for AARCH64 with Visual Studio.
Fix this by adding the relevant EXTERN reference.
Signed-off-by: Pete Batard
Cc: Leif Lindholm
Cc
much like to push for a VS2019/AARCH64 CI
pipeline to be added to the edk2 patch validation process.
Thanks,
/Pete
Pete Batard (1):
MdePkg/BaseLib: Fix undefined symbol when compiling with Visual Studio
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
1 file changed, 1 insertion
We also use this opportunity to update the TF-A binaries for RPi4.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 8
Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin | Bin 18853 -> 18853 bytes
Platform/RaspberryPi/RPi3/TrustedFirmware/fip.
available from:
https://developer.arm.com/documentation/den0115/latest
Tested for regression on Pi 3 Model B and Pi 4 Model B.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 6 +++---
Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin | Bin 18853 -> 18
Thanks Jeremy!
On 2021.12.17 17:52, Jeremy Linton wrote:
First a huge thank you to Pete Batard for all the hard work
landing the RPi code here, and keeping everyone in line.
But, he has lots of commitments, and its time to give him
a breather. As such, I will take over as a platform reviewer
files, as we were able to validate using the latest Windows 11
Build 22000 Insider image.
Signed-off-by: Pete Batard
Tested-by: Pete Batard
---
Platform/RaspberryPi/AcpiTables/Xhci.asl | 21
1 file changed, 21 insertions(+)
diff --git a/Platform/RaspberryPi/AcpiTables/Xhci.asl
ents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
Reviewed-by: Pete Batard
Tested-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78592): https://edk2.groups.io
rst EfiSetVariable() call to make two calls consistent.
By the way, this patch also fix a minor issue with a debug message.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Leif Lindholm
Signed-off-by: Sunny Wang
---
.../VirtualRealTimeClock
cations64 (
case R_RISCV_SET16:
case R_RISCV_SET32:
case R_RISCV_PCREL_HI20:
+case R_RISCV_GOT_HI20:
case R_RISCV_PCREL_LO12_I:
break;
Tested-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Link
-off-by: Sunil V L
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Cc: Pete Batard
Cc: Abner Chang
Cc: Daniel Schaefer
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 55 +
1 file changed, 55 insertions(+)
diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c
b/BaseTools
I agree that this is unlikely to be a consequence of the current patch.
I logged new BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3459
Regards,
/Pete
On 2021.06.17 05:44, Sunil V L wrote:
Hi Pete,
Thank you very much!.
On Wed, Jun 16, 2021 at 01:35:27PM +0100, Pete Batard wrote
Sunil, Daniel, thanks for the patch.
I confirm that this addresses the 0x13 and 0x14 relocation issues that I
was seeing.
However, this patch appears to introduces new R_RISCV_PCREL_LO12_S
relocation errors that I was not seeing previously, so I still can't
manage to get a successful
to update these binaries for
each TF-A release.
Tested for regression on Pi 3 Model B and Pi 4 Model B.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 10 +-
Platform/RaspberryPi/RPi3/TrustedFirmware/bl1.bin | Bin 18837 -> 18853 bytes
Platf
(PL011 UART).
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Bălănică
Signed-off-by: Sunny Wang
---
Platform/RaspberryPi/AcpiTables/Uart.asl | 16 --
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 22
On 2021.06.07 08:53, Sunny Wang wrote:
Make the changes below for making it clearer.
- Rename GpioPinSet() to GpioPinConfigure()
- Rename parameter Val to Config and change its type to BOOLEAN
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard
: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Mario Bălănică
Signed-off-by: Sunny Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 8 +-
.../RaspberryPi/AcpiTables/Dbg2MiniUart.aslc | 81 +
.../AcpiTables/{Dbg2.aslc => Dbg2Pl011.aslc} | 30 +---
.../Raspberr
f
!endif
INF
MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
INF EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
Reviewed-by: Pete Batard
Tested-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Re
lized from defaults.\n Are you sure?"
+
#string STR_SECURE_BOOT_ENROLL_SIGNATURE #language en-US "Enroll Signature"
#string STR_SECURE_BOOT_DELETE_SIGNATURE #language en-US "Delete Signature"
#string STR_SECURE_BOOT_DELETE_LIST_FORM #language en-US "Delete Si
, Components.AARCH64]
#
Reviewed-by: Pete Batard
Tested-by: Pete Batard on Raspberry Pi 4
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75991): https://edk2.groups.io/g/devel/message/75991
Mute This Topic: https://groups.io/mt
+ DeleteDb ();
+
+error:
+ Status = SetSecureBootMode (STANDARD_SECURE_BOOT_MODE);
+ if (EFI_ERROR (Status)) {
+FAIL ("Cannot set CustomMode to STANDARD_SECURE_BOOT_MODE\n"
+ "Please do it manually, otherwise system can be easily compromised\n");
+ }
+
+ return 1;
+}
default variables"
+
+#string STR_MODULE_DESCRIPTION #language en-US "This module reads embedded
keys and initializes Secure Boot default variables."
+
This adds an extra trailing blank line.
Reviewed-by: Pete Batard
Tested-by: Pete Batard on Raspberry Pi 4
-=-=-=
ION RAW = $(DBX_DEFAULT_FILE1)
+ !endif
+ !ifdef $(DBX_DEFAULT_FILE2)
+SECTION RAW = $(DBX_DEFAULT_FILE2)
+ !endif
+ !ifdef $(DBX_DEFAULT_FILE3)
+SECTION RAW = $(DBX_DEFAULT_FILE3)
+ !endif
+SECTION UI = "DBX Default"
+ }
+
+!endif
Reviewed-by: Pete
0000..2c51e4db53
--- /dev/null
+++ b/SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.uni
@@ -0,0 +1,16 @@
+// /** @file
+//
+// Provides initialization of Secure Boot keys and databases.
+//
+// Copyright (c) 2021, ARM Ltd. All rights reserved.
+// Copyright (c) 2021, Semihalf All r
e THERM_SENSOR 0xfd5d2200
+#define ID_CHIPREV 0xfc404000
+
#endif /* BCM2711_H__ */
With the comment changes, if agreed, applicable during integration:
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Repl
ti|L"MmcDisableMulti"|gConfigDxeFormSetGuid|0x0|0
-
gRaspberryPiTokenSpaceGuid.PcdMmcEnableDma|L"MmcEnableDma"|gConfigDxeFormSetGuid|0x0|0
+
gRaspberryPiTokenSpaceGuid.PcdMmcEnableDma|L"MmcEnableDma"|gConfigDxeFormSetGuid|0x0|1
#
# Debug-related.
Reviewed-by: Pete Bata
: Jeremy Linton
Cc: Sami Mujawar
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
Platform/RaspberryPi/AcpiTables/Dsdt.asl| 3 ++-
Platform/RaspberryPi/AcpiTables/Emmc.asl| 4 ++--
Platform/RaspberryPi/AcpiTables/SsdtThermal.asl | 4 ++--
3 files changed, 6
On 2021.04.13 16:22, Ard Biesheuvel wrote:
On Tue, 13 Apr 2021 at 14:13, Pete Batard wrote:
Thanks for the v2. Everything looks good now.
On 2021.04.13 08:14, Sunny Wang wrote:
This is a fix for https://github.com/pftf/RPi4/issues/114.
Changes:
1. Add a setup option called Boot Policy
specific type devices so
that we can still have the shortest boot time for all use cases.
Cc: Samer El-Haj-Mahmoud
Cc: Jeremy Linton
Cc: Sami Mujawar
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 11
that we can still have the shortest boot time for all use cases.
Cc: Samer El-Haj-Mahmoud
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c| 11 ++-
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 3
On 2021.04.08 13:26, Ard Biesheuvel wrote:
On Thu, 8 Apr 2021 at 13:43, Pete Batard wrote:
On 2021.04.08 12:06, Ard Biesheuvel wrote:
On Thu, 8 Apr 2021 at 11:47, Pete Batard wrote:
On 2021.04.06 15:04, Mario Bălănică wrote:
The VPU clock divisor has changed in this commit:
https
On 2021.04.08 12:06, Ard Biesheuvel wrote:
On Thu, 8 Apr 2021 at 11:47, Pete Batard wrote:
On 2021.04.06 15:04, Mario Bălănică wrote:
The VPU clock divisor has changed in this commit:
https://github.com/raspberrypi/firmware/commit/1e5456a,
thus breaking the mini UART clock divisor
From: Mario BÄlÄnicÄ
The VPU clock divisor has changed in this commit:
https://github.com/raspberrypi/firmware/commit/1e5456a,
thus breaking the mini UART clock divisor calculation on the Pi 4.
Fix this by reading the core clock from the mailbox instead.
Signed-off-by: Mario BÄlÄnicÄ
QWordMemory (ResourceConsumer,
+QWordMemory (ResourceProducer,
,
MinFixed,
MaxFixed,
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73836): https://edk2.groups.io/g/devel
// MemoryAccessFlags
+ 30, // AddressSizeLimit
+}, {
+ "\\_SB_.GDV1.SDC3"// ObjectName
+}
}
};
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Onl
() { "sdhci-caps", 0x0120fa81 },
}
})
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73834): https://edk2.groups.io/g/devel/message/73834
Mute This Topic: https://groups.io/mt/81935643/21656
Group Owner: devel
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.inf
Reviewed-by: Pete Batard
Tested-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73833): https://edk2.group
Hi Mario,
Please re-send a v2 with a commit message that explains the issue that
is being fixed. Thanks.
For the record, I ran some tests that show that the divisor was changed
from 1 to 2 with the latest Pi Foundation firmware (which is confirmed
by the fact that if you switch your
On 2021.04.03 17:55, Mario Bălănică wrote:
Can you tell me which commit in the firmware repo breaks the mini UART
divisor calculation, so that I can test the final changes against it too?
That would be one of the start4.elf/fixup4.dat combination around the
time when the commit that added the
On 2021.04.03 17:15, Mario Bălănică wrote:
> -#if (RPI_MODEL == 4)
> - Divisor = MmioRead32(BCM2836_CM_BASE +
BCM2836_CM_VPU_CLOCK_DIVISOR) & 0xFF;
> - if (Divisor != 0)
> - BaseClockRate = (BaseClockRate << 12) / Divisor;
> -#endif
Keeping this doesn't
On 2021.04.03 16:17, Mario Bălănică wrote:
I've submitted this patch because the mini UART serial console produces
garbage since UEFI v1.25 (due to the wrong baud rate).
OK.
When you fix something like this, please mention that there was a
regression that requires fixing, in the commit
Hi Mario,
On 2021.04.03 13:47, Mario Bălănică wrote:
It works with the old firmware as well.
Are you sure of this? You may have to go quite far back to find
start4.elf versions where this might not work...
The whole reason behind reading the base clock and divisor from MMIO,
rather than
or PL011) and SPCR, DBG2 tables and device BTH0 are dynamically
changed as expected.
Cc: Samer El-Haj-Mahmoud
Cc: Sami Mujawar
Cc: Jeremy Linton
Cc: Pete Batard
Cc: Ard Biesheuvel
Signed-off-by: Sunny Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 9
platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pete Batard
Signed-off-by: Dandan Bi
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 4 +++-
Platform/RaspberryPi/RPi4/RPi4.dsc | 4 +++-
2 files
/RPi-Windows-Drivers/releases
and checked that both Bluetooth and serial port (Mini UART) can
work fine.
Cc: Samer El-Haj-Mahmoud
Cc: Pete Batard
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Sunny Hsuan-Wen Wang
---
.../RaspberryPi/AcpiTables/AcpiTables.inf | 7
atforms that need to load a boot image discovered by
using short-form File Path Media Device Path.
Regards,
Sunny Wang
-Original Message-
From: Laszlo Ersek
Sent: Wednesday, February 17, 2021 10:26 PM
To: Pete Batard ; Leif Lindholm ;
devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud ;
should give specification-compliant
behaviour.
/
Leif
On Tue, Jun 30, 2020 at 18:17:10 +0100, Pete Batard wrote:
Please note that I have created a bug report
(https://bugzilla.tianocore.org/show_bug.cgi?id=2831) to address the
non-compliance issue was raised during the course
1Bit` | 4-bit Mode = `0x`
(default) 1-bit Mode = `0x0001`
uSD Force Default Speed | `MmcForceDefaultSpeed` | Allow High Speed =
`0x0000` (default) Force Default Speed = `0x0001`
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
,4 @@
gRaspberryPiTokenSpaceGuid.PcdFanOnGpio|0|UINT32|0x001C
gRaspberryPiTokenSpaceGuid.PcdFanTemp|0|UINT32|0x001D
gRaspberryPiTokenSpaceGuid.PcdPlatformResetDelay|0|UINT32|0x001E
+ gRaspberryPiTokenSpaceGuid.PcdMmcEnableDma|0|UINT32|0x001F
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Gro
CE_TABLES SdtTables[] = {
SsdtNameOpReplace
},
{
+SIGNATURE_64 ('R', 'P', 'I', '4', 'E', 'M', 'M', 'C'),
+0,
+PcdToken(PcdSdIsArasan),
+NULL
+ },
+ {
SIGNATURE_64 ('R', 'P', 'I', 0, 0, 0, 0, 0),
0,
0,
With all of the above being formattin
_64 ('R', 'P', 'I', 'T', 'H', 'F', 'A', 'N'),
PcdToken(PcdFanOnGpio),
+0,
SsdtNameOpReplace
},
{
SIGNATURE_64 ('R', 'P', 'I', 0, 0, 0, 0, 0),
0,
+0,
NULL
},
{ }
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You rec
, September 21, 2020 4:01 PM
*To:* Pete Batard ; Jeff Booher-Kaeding
; devel@edk2.groups.io
*Cc:* Ard Biesheuvel ; Leif Lindholm
*Subject:* Re: [edk2-devel] [PATCH v1 1/1]
Platform/RaspberryPi/ConfigDxe: Fix JTAG Pinout for Pi3/4
Hi folks,
No objection at all. IIRC the original pin selection
to this change.
Regards,
/Pete
On 2020.09.14 22:32, Jeff Booher-Kaeding wrote:
Updated the pinout to match the Pi4 datasheet, tested with the RPi4, Pi3
Datasheet has same pinout.
Signed-off-by: Jeff Booher-Kaeding
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Pete Batard
---
Platform
+ 2732);
}
Method (_SCP, 3) { } // receive cooling policy from OS
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65195): https://edk2.groups.io/g/devel/message/65195
Mute
Hi Ard,
On 2020.09.01 12:39, Ard Biesheuvel wrote:
On 8/31/20 7:25 PM, Jeremy Linton wrote:
Pete's review pointed out some whitespace issues in the
context of a previous patch. Since there are a number of
similar errors in the file lets fix them separately.
Cc: Leif Lindholm
Cc: Pete Batard
to select the temperature at which the
fan cycles on.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/AcpiTables/SsdtThermal.asl | 9 +
Platform/RaspberryPi/Drivers/ConfigDxe
cooling
by specifying active cooling points (_ACx) which can
be tied to fan objects that turn fans on/off using GPIO
pins.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
Reviewed-by: Pete Batard <@pbat
Thanks for this.
On 2020.08.28 23:02, Jeremy Linton wrote:
Pete's review pointed out some whitespace issues in the
context of a previous patch. Since there are a number of
similar errors in the file lets fix them separately.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard
ASL above.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 153 -
1 file changed, 152 insertions(+), 1 deletion(-)
diff --git
ch operate via simple GPIO control.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
Reviewed-by: Pete Batard <@pbatard>
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 ++
PPC should be able to monitor the thermal throttling.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
Reviewed-by: Pete Batard <@pbatard>
---
Platform/RaspberryPi/AcpiTables/Dsdt.as
: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Pete Batard
Cc: Andrei Warkentin
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c
b/Platform
Same typo as previous patch:
On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote:
Fix input param error checking for the DwUsbHostDxe ComponentName2
protocol.
This fixes https://github.com/pftf/RPi4/issues/86
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off
Same typo as previous patch:
On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote:
Fix input param error checking for the BcmGenetDxe ComponentName2
protocol.
This fixes https://github.com/pftf/RPi4/issues/85
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off
One typo:
On 2020.08.15 21:26, Samer El-Haj-Mahmoud wrote:
Fix input param error checking for the DisplayDxe ComponentName2
protocol.
This fixes https://github.com/pftf/RPi4/issues/84
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off-by: Samer El-Haj
his simply.
It appears there are a couple boards (fan SHIM) which operate this
way, and probably should have custom menu items/SSDT edits as
people acquire the boards and test them.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-
+5 and +10 of that. In the future
CPPC should be able to monitor the thermal throttling.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Samer El-Haj-Mahmoud
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/AcpiTables/Dsdt.asl | 31 +
Whitespace/style and typos:
On 2020.08.14 00:00, Jeremy Linton wrote:
Now that we have a thermal zone we can add active cooling
by specifying active cooling points (_ACx) which can
be tied to fan objects that turn fans on/off using GPIO
pins.
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei
On 2020.08.13 15:27, Samer El-Haj-Mahmoud wrote:
The UART namespace reference in DBG2 is incorrect. Fix to point to the
correct name.
This fixes the certification failure reported by FWTS tests at:
https://github.com/pftf/RPi4/issues/69
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
template for
consistency. This is already done in LogSmbiosData().
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 43
1 file
Adding a tested-by, since these are values that could potentially trip
the custom handling that Windows seems to have of MADT, and I hadn't
tested that yet.
Testing shows that Windows is happy with these new values, so with this:
On 2020.07.31 08:55, Pete Batard via groups.io wrote
as bbb8a8185838.
Thanks!
/Pete
Regards,
Leif
On Fri, Jul 24, 2020 at 17:37:42 +0100, Pete Batard wrote:
These can be used, for instance, to automate the population of an SMBIOS
Type 0 BIOS Release Date when building a UEFI firmware (which is how we
plan to use these macros for the Raspberry
the
date otherwise.
Also, the system manufacturer should not be set to the same value as the
board manufacturer for the Type 1 strings, as, on the Raspberry Pi, this is
not representative of the actual manufacturer of the system, which is the
Raspberry Pi Foundation always.
Signed-off-by: Pete Batard
Changes from v1:
* Use the newly introduced EmbeddedPkg/Include/Library/TimeBaseLib.h macros.
Pete Batard (1):
Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer
Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 12
++--
1 file changed, 10
/message/63577
Best regards,
Marcin
From: Pete Batard
Sent: Friday, July 31, 2020 09:53
To: devel@edk2.groups.io ; liming@intel.com
; m...@semihalf.com ; Leif Lindholm
Cc: Zhang, Shenglei ; Ard Biesheuvel ;
Kinney, Michael D ; Ming Huang
Subject: Re: [edk2
-by: Pete Batard
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 51 +---
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 8 +--
2 files changed, 39 insertions(+), 20 deletions(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
b/Platform/RaspberryPi
029/latest
This partially fixes SBSA test #11 ("Incorrect PPI value") reported in
https://github.com/pftf/RPi4/issues/74
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off-by: Samer El-Haj-Mahmoud
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 8
1 file c
.
Thanks
Liming
-Original Message-
From: devel@edk2.groups.io On Behalf Of Marcin Wojtas
Sent: 2020年7月31日 0:09
To: Leif Lindholm
Cc: Gao, Liming ; devel@edk2.groups.io; Zhang, Shenglei
; Ard Biesheuvel ; Kinney, Michael D
; Ming Huang ; Pete Batard
Subject: Re: [edk2-devel] [PATCH] MdePkg
-by: Pete Batard
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 34 ++--
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 4 +--
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
b/Platform/RaspberryPi
those to send a patch that adds their compiler
to the list, once they have tested the macros there.
Signed-off-by: Pete Batard
---
EmbeddedPkg/Include/Library/TimeBaseLib.h | 32
1 file changed, 32 insertions(+)
diff --git a/EmbeddedPkg/Include/Library/TimeBaseLib.h
b
Hi Andrew,
On 2020.07.23 18:15, Andrew Fish wrote:
On Jul 23, 2020, at 8:47 AM, Leif Lindholm <mailto:l...@nuviainc.com>> wrote:
Hi Pete,
On Thu, Jul 23, 2020 at 15:38:55 +0100, Pete Batard wrote:
@@ -626,6 +627,28 @@ BIOSInfoUpdateSmbiosType0 (
INTN i;
INTN State = 0
Hi Leif,
On 2020.07.23 12:08, Leif Lindholm wrote:
On Mon, Jul 20, 2020 at 17:15:07 +0100, Pete Batard wrote:
Per SMBIOS specs, The Type 0 BIOS Release Date is not a free form field but
must be specified in a US middle-endian format (mm/dd/), so make sure
we populate it accordingly
other compilers than ones using
a __DATE__ format similar to gcc's to be used for the foreseeable future.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 31
++--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git
On 2020.07.19 00:04, Samer El-Haj-Mahmoud wrote:
Set the supported RPi3 platform language to English (US),
and remove French.
This fixes https://github.com/pftf/RPi4/issues/35
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off-by: Samer El-Haj-Mahmoud
On 2020.07.19 00:04, Samer El-Haj-Mahmoud wrote:
Set the supported RPi4 platform language to English (US),
and remove French.
This fixes https://github.com/pftf/RPi4/issues/35
Cc: Leif Lindholm
Cc: Pete Batard
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Signed-off-by: Samer El-Haj-Mahmoud
On 2020.07.14 14:36, Leif Lindholm wrote:
On Mon, Jul 13, 2020 at 12:25:18 +0100, Pete Batard wrote:
One very minor formatting issue inline (that can be sorted during
integration):
I would also like to prepend "Silicon/" to the subject line.
Please do. It should have been there in
On 2020.07.14 14:25, Leif Lindholm wrote:
On Mon, Jul 13, 2020 at 12:16:20 +0100, Pete Batard wrote:
The Raspberry Pi 3 and Pi 4 platforms (with latest EEPROM) can boot
straight from USB, without the need for an SD card being present.
However, the IsCardPresent () calls from the ArasanMmcHost
e, and its initialization.
Cc: Andrei Warkentin
Cc: Pete Batard
Signed-off-by: Leif Lindholm
---
Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c
b/Platform/Raspberry
DmaMapRxDescriptor (Genet, DescIndex);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: Failed to remap RX descriptor!\n",
__FUNCTION__));
}
+ GenetRxComplete (Genet);
+
EfiReleaseLock (>Lock);
return Status;
}
Reviewed-by: Pete Batard
-=-=-=-=-=-=-=-=-=-=-=-
pftf/RPi3#13, pftf/RPi3#14, pftf/RPi4#37.
Co-authored-by: Andrei Warkentin
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 86
++--
Platform/RaspberryPi/Drivers/SdHostDxe/SdHostDxe.c | 75
+++--
Platform
This supersedes https://edk2.groups.io/g/devel/message/62339 - 62340
Changes from v2:
- Fix regression for CM3 module due to MMC/eMMC not accepting CMD8
Pete Batard (1):
Platform/RaspberryPi/Drivers: Add SD/(e)MMC card detection
Platform/RaspberryPi/Drivers/ArasanMmcHostDxe
v2 to correct a couple "STATIC" -> "static" that were applied by
an overzealous text editor.
No other changes from v1.
Pete Batard (1):
Platform/RaspberryPi/Drivers: Add SD card detection
Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 66
+++
good enough for the intended purpose, which
is to allow straight to USB boot.
Tested on Raspberry Pi 3 and 4, and for both SD controllers.
Addresses pftf/RPi3#13, pftf/RPi3#14, pftf/RPi4#37.
Signed-off-by: Pete Batard
Reviewed-by: Andrei Warkentin
Tested-by: Andrei Warkentin
---
Platform
On 2020.07.02 13:03, Ard Biesheuvel wrote:
On 6/29/20 8:39 PM, Pete Batard wrote:
* Add GpioPinSet () function to set a GPIO pin value
* Add GpioPinGet () function to read a GPIO pin value
* Add GpioSetPull () function to set pullup/down state of a GPIO pin
GpioSetPull () supports both
veterans can chime in, is
whether we are doing the right thing, or if we should be overriding the boot
mode? I.e. is it normal that we boot up in recovery until options are saved?
A
From: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>
of these calls was tested on Raspberry Pi 3 B+ as well as on a
Raspberry Pi 4 B.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Gpio.h | 44 -
Silicon/Broadcom/Bcm283x/Include/Library/GpioLib.h | 17
Silicon/Broadcom/Bcm283x/Library
good enough for the intended purpose, which
is to allow straight to USB boot.
Tested on Raspberry Pi 3 and 4, and for both SD controllers.
Addresses pftf/RPi3#13, pftf/RPi3#14, pftf/RPi4#37.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 66
A
*From:* devel@edk2.groups.io on behalf of Pete
Batard via groups.io
*Sent:* Wednesday, June 17, 2020 11:34 AM
*To:* Wang, Sunny (HPS SW) ; devel@edk2.groups.io
*Cc:* zhichao@intel.com ; ray...@intel.com
; ard.biesheu
1 - 100 of 464 matches
Mail list logo
