Hi Rebecca,
We have tried the patch. It works on my device.
I think it could be add it into UsbNetwork source. Do you think?
Thanks,
Richard
-Original Message-
From: Mike Maslenkin
Sent: 2023年8月26日 9:58 AM
To: devel@edk2.groups.io
Cc: Richard Ho (何明忠) ; rebe...@bsdio.com; Mike Maslenkin
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Acked-by: Hao A Wu
Reviewed-by: Rebecca Cran
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Acked-by: Hao A Wu
Reviewed-by: Rebecca Cran
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Acked-by: Hao A Wu
Reviewed-by: Rebecca Cran
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Acked-by: Hao A Wu
Reviewed-by: Rebecca Cran
Hi Hao Wu,
I will provide V4 for below next.
#1 Modify DSC file in patch 3/3
#2 add Acked-by: Hao A Wu
#3 modify DXE_DRIVER to UEFI_DRIVER
Thanks,
Richard
-Original Message-
From: Wu, Hao A
Sent: 2023年6月8日 2:23 PM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Reviewed-by: Rebecca Cran
Reviewed-by: Tony Lo
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Reviewed-by: Rebecca Cran
Reviewed-by: Tony Lo
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Reviewed-by: Rebecca Cran
Reviewed-by: Tony Lo
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Tested-by: Tinh Nguyen
Reviewed-by: Rebecca Cran
Reviewed-by: Tony Lo
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
R: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
R: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
Hi Rebecca,
ECM and NCM will be enable when move the UsbNetworkPkg to
MdeModulePkg\Bus\Usb\UsbNetwork.
About rate limiting. We have test it X86 system. It will be slow to PXE boot.
Do you think this PCD should be enabled by default?
Thanks,
Richard
-Original Message-
From: Rebecca
Hi Pedro,
Would you consent if I upstream the code to
edk2/MdeModulePkg/Bus/Usb/UsbNetwork?
Thanks,
Richard
-Original Message-
From: Chang, Abner
Sent: 2023年4月12日 12:26 PM
To: Richard Ho (何明忠) ; Pedro Falcato
; devel@edk2.groups.io; rebe...@bsdio.com
Cc: Andrew Fish ; Leif Lindholm ;
Hi Pedro/Abner,
UsbNetworkPkg provide the RNDIS/ECM/NCM device support that are implement form
USB specification(we have other USB network device's driver to upstream).
It is not specific USB device. The driver could work on any platform. So, we
create UsbNetworkPkg same as NetworkPkg in edk2
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Tested-by: Tinh Nguyen
Reviewed-by: Tony Lo
---
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
Hi Tinh/Rebecca/Michael,
Does other issue in UsbNetworkPkg PATCH V4?
May I add you to reviewer’s list in commit message?
Thanks,
Richard
From: Richard Ho (何明忠)
Sent: 2023年2月21日 11:02 AM
To: Tinh Nguyen OS ; devel@edk2.groups.io
Cc: Tony Lo (羅金松) ; Felix Polyudov ; Srini
Narayana ; Harikrishna
Hi Tinh,
Our last RNDIS driver’s code has add that.
To see
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf| 42 +
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Cc: Rebecca Cran
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf| 42 ++
Hi Rebecca,
Thanks for your response. We will fixed it next.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2023年2月16日 1:28 AM
To: devel@edk2.groups.io; Tony Lo (羅金松) ; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu
Hi Michael,
If select EnableRateLimiting to TRUE and use the X86 system. It will be hang
when PXE boot.
Could you help to check?
Thanks,
Richard
-Original Message-
From: Michael Brown
Sent: 2023年2月15日 6:24 PM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
Hi Rebecca,
We will modify it in next patch.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2023年2月8日 12:14 AM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu ; Liming
Gao ; Tony Lo (羅金松)
Hi Tinh,
Thanks for your response. We will do more test in this patch.
Thanks,
Richard
-Original Message-
From: Tinh Nguyen OS
Sent: 2023年2月8日 10:46 AM
To: Michael Brown ; devel@edk2.groups.io; Tinh Nguyen OS
; Richard Ho (何明忠)
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v2 1/3]
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
Hi Michael,
We add this patch in my X86 platform and use the NCM device to test IPV4 PXE
boot from 1330MB ISO file.
No this patch: 35 sec to download 1330M ISO file
Add this patch: 181 sec to download 1330M ISO file
The patch will increase boot time in my X86 platform.
Thanks,
Richard
Hi Michael,
Thanks for your response. We will do more test in Nic->CanReceive flag's code
next.
Thanks,
Richard
-Original Message-
From: Michael Brown
Sent: 2023年1月11日 9:18 AM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
Hi Rebecca,
Thanks for your response. I will fixed it next.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2022年12月5日 11:15 AM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu ; Liming
Gao ;
Hi Michael,
Thanks for your response. I will fixed it next.
Thanks,
Richard
-Original Message-
From: Michael Brown
Sent: 2022年12月2日 6:09 PM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu ; Liming
Gao ;
Hi Rebecca,
Thanks for your response. I will fixed it next.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2022年12月1日 11:47 PM
To: devel@edk2.groups.io; Richard Ho (何明忠)
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
; Zhiguang Liu ; Liming
Gao ;
Hi Rebecca,
Thanks for your response.
#1. The NCM, ECM, and RNDIS feature could enable at the same time.
#2. UsbEthernetProtocol.h, PxeFunction.c the TYPO will be fixed next.
#3 Receive buffer will be allocate during driver initialize.
Thanks,
Richard
-Original Message-
From: Rebecca
This driver provides UEFI driver for USB CDC NCM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170
This driver provides UEFI driver for USB CDC ECM device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Zhiguang Liu
Cc: Liming Gao
Reviewed-by: Tony Lo
---
UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 +
Hi Liming,
RNDIS specification is not defines this.
We're follow the ECM (5.4 Ethernet Networking Functional Descriptor) and NCM
(5.2.1 NCM Functional Descriptor)specification to implement RNDIS driver.
If RNDIS device has other way to know the networking functional information.
We could
Hi Abner,
For #4, To see below code. RNDIS driver provide the RndisUndiStart routine.
It could execute RndisUndiStart in UndiStart routine end.
The upper layer driver not need to know the USB CDC driver
interface class.
It only provide the
Hi Abner,
Ans #1. I think the USB network feature is better in the UsbNetworkPkg. It is
easy to control USB network stack in this package.
The package is same as NetworkPkg(The NetworkPkg gathers all
network stack features). The UsbNetworkPkg could gather the USB network stack.
Hi Rebecca,
We didn't check it in QEMU.
Is QEMU report standard USB RNDIS protocol?
We only test it in physical device. Below is device lists.
USB RNDIS:
AST2500: BMC report the RNDIS device
USB NCM:
DisplayLink HIS USB3.0 Portable Dock(DisplayLink (UK) Ltd.)
Vendor ID: 0x17E9
Product ID:
Hi Liming,
See the Binding.jpg that is NetworkCommon driver boot flow.
Below is NetworkCommon driver to do
#1 Install UNDI protocol
#2 Respond normal Cdb flag or attribute in UNDI API
#3 Provide device API hook if the device has specific command or setting.
Ex: UndiGetState routine in
Hi Abner,
OK, I will using "--transfer-encoding=8bit " to resend it next.
Thanks,
Richard
-Original Message-
From: Chang, Abner
Sent: 2022年9月1日 5:06 PM
To: devel@edk2.groups.io; RichardHo [何明忠] ; Rebecca Cran
Cc: Andrew Fish ; Leif Lindholm ;
Michael D Kinney ; Michael Kubacki
;
Hi Liming,
Please see more information in ReadMe.md for your question.
Thanks,
Richard
-Original Message-
From: gaoliming
Sent: 2022年8月31日 5:47 PM
To: devel@edk2.groups.io; RichardHo [何明忠]
Cc: 'Andrew Fish' ; 'Leif Lindholm'
; 'Michael D Kinney' ;
'Michael Kubacki' ; 'Leif
Hi Rebecca,
All files are new. I sent it with "git send-email".
I don't have account to push the code into branch.
Thanks,
Richard
-Original Message-
From: Rebecca Cran
Sent: 2022年8月31日 9:28 PM
To: devel@edk2.groups.io; RichardHo [何明忠]
Cc: Andrew Fish ; Leif Lindholm ;
Michael D
51 matches
Mail list logo
