No additional comment from my side.
Best Regards,
Hao Wu
> -Original Message-
> From: Dat Mach
> Sent: Saturday, March 9, 2024 7:33 AM
> To: gaoliming ; devel@edk2.groups.io
> Cc: Cheng, Gao ; Wu, Hao A ;
> Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/Xhci: Skip
Acked-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Henz,
> Patrick
> Sent: Wednesday, November 1, 2023 12:51 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Henz,
> Patrick
> Subject: [edk2-dev
the usage of these APIs for performance
consideration.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Henz,
> Patrick
> Sent: Tuesday, October 31, 2023 4:36 AM
> To: Wu, Hao A ; devel@edk2.groups.io; Michael Brown
>
> Subject: Re
i
> ; West, Catharine
> ; Bi, Dandan ; Daniel
> Schaefer ; David Woodhouse
> ; De, Debkumar ; Dong,
> Eric ; Jiang, Guomin ; Wu,
> Hao A ; James Bottomley ;
> Wang, Jian J ; Justen, Jordan L
> ; Julien Grall ; Peter Grehan
> ; Zhang, Qi1 ; Ng, Ray Han Lim
> ; Stefan Be
Please grant me some time to review this patch.
Really sorry that I am not able to provide an estimated time for the review.
Best Regards,
Hao Wu
From: Ashish Singhal
Sent: Friday, October 13, 2023 10:13 AM
To: Rick Tseng ; devel@edk2.groups.io; Wu, Hao A
; Ni, Ray ; Wang, Jian J
; Gao
Patch merged via:
PR - https://github.com/tianocore/edk2/pull/4875
Commit -
https://github.com/tianocore/edk2/commit/f36e1ec1f0a5fd3be84913e09181d7813444b620
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday,
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Cheng, Gao
> Sent: Tuesday, September 26, 2023 4:25 PM
> To: devel@edk2.groups.io
> Cc: Cheng, Gao ; Wu, Hao A ;
> Ni, Ray ; Wang, Jian J ; Gao,
> Liming
> Subject: [PATCH v2] MdeModulePkg/
results for the upcoming patch?
Best Regards,
Hao Wu
> -Original Message-
> From: Cheng, Gao
> Sent: Tuesday, September 26, 2023 10:12 AM
> To: devel@edk2.groups.io
> Cc: Cheng, Gao ; Wu, Hao A ;
> Ni, Ray ; Wang, Jian J ; Gao,
> Liming
> Subject: [PATCH] MdeModuleP
Pushed via:
PR - https://github.com/tianocore/edk2/pull/4863
Commit -
https://github.com/tianocore/edk2/commit/d11f0ea045f598e08b414eeba4f8a74ac1b4ca0b
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Thursday, Septembe
Merged via:
PR - https://github.com/tianocore/edk2/pull/4862
Commit -
https://github.com/tianocore/edk2/commit/43dcf453fc15ca152945ca41dcce7f2f43a14313
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday, Septem
Series pushed via:
PR - https://github.com/tianocore/edk2/pull/4856
Commits:
https://github.com/tianocore/edk2/commit/e9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916
https://github.com/tianocore/edk2/commit/28a267af4024c329e58121ccd9bf5f4f7aabc0f4
Best Regards,
Hao Wu
> -Original Message-
>
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, September 21, 2023 11:58 AM
> To: devel@edk2.groups.io
> Cc: Cai, Xianglei ; Wu, Hao A ;
> Ni, Ray ; Wang, Jian J ; Gao,
> Liming ; Shih, More ;
> Huang, Jen
ral inline comments below:
> -Original Message-
> From: Cai, Xianglei
> Sent: Monday, September 18, 2023 2:57 PM
> To: devel@edk2.groups.io
> Cc: Cai, Xianglei ; Wu, Hao A ;
> Ni, Ray ; Wang, Jian J ; Gao,
> Liming ; Shih, More
> Subject: [PATCH 1/1] MdeModulePkg\XhciD
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Henz,
> Patrick
> Sent: Wednesday, September 13, 2023 2:06 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Henz,
> Patrick
> Subject
Pushed via:
PR - https://github.com/tianocore/edk2/pull/4843
Commit -
https://github.com/tianocore/edk2/commit/4317b4824bc881fe6079d04b7ee5b0f6bddf62ca
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Thursday, August
Pushed via:
PR - https://github.com/tianocore/edk2/pull/4841
Commit -
https://github.com/tianocore/edk2/commit/4fb69c2bee3006b08ca2abba58843f7573e0c5c6
Best Regards,
Hao Wu
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, August 10, 2023 10:39 AM
> To: Ranbir Singh
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Wednesday, August 16, 2023 1:38 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray ; Veeresh
> Sangolli
> Subject: [PATCH v2 1/2] MdeModu
: Henz, Patrick
> Sent: Friday, September 8, 2023 2:39 AM
> To: devel@edk2.groups.io; Wu, Hao A ; Mike
> Maslenkin
> Subject: RE: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use
> Performance Timer for XHCI Timeouts
>
> I don’t have strong opinions either. If we would
nal Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Thursday, September 7, 2023 3:48 PM
> To: Mike Maslenkin ; devel@edk2.groups.io
> Cc: Henz, Patrick
> Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use
> Performance Timer for XHCI Tim
: Mike Maslenkin
> Sent: Thursday, September 7, 2023 3:36 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Henz, Patrick
> Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use
> Performance Timer for XHCI Timeouts
>
> Hello Hao Wu,
>
> Isn't GetPerforman
unresolved externals
I think we need to update "(UINT64)Timeout * XHC_1_MILLISECOND" by using
BaseLib API MultU64x32().
Could you help to update the patch and check if it can pass the CI builds,
thanks.
Best Regards,
Hao Wu
> -Original Message-----
> From: Wu, Hao A
> Sent:
Sorry for the late response.
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Henz,
> Patrick
> Sent: Thursday, September 7, 2023 4:37 AM
> To: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use
is being passed into this UhciConvertPollRate
function if anything does go wrong brought by future changes.
Best Regards,
Hao Wu
From: Ranbir Singh
Sent: Monday, August 14, 2023 3:49 PM
To: Wu, Hao A
Cc: devel@edk2.groups.io; Ni, Ray ; Veeresh Sangolli
Subject: Re: [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD
t; To: devel@edk2.groups.io; Wu, Hao A ; Michael Brown
>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance
> Timer for XHCI Timeouts
>
> I can certainly make that change.
>
> For what it's worth I have been working on adding the new function,
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 17, 2023 7:39 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray ; Veeresh
> Sangolli
> Subject: [PATCH v1 2/2] MdeModulePkg
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 17, 2023 7:39 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray ; Veeresh
> Sangolli
> Subject: [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT
> Coverity
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 17, 2023 7:59 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fi
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 17, 2023 7:40 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray ; Veeresh
> Sangolli
> Subject: [PATCH v1 1/1] MdeModulePkg/
Series pushed via:
PR - https://github.com/tianocore/edk2/pull/4707
Commits:
https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f47519a9
https://github.com/tianocore/edk2/commit/d11968fcc56cbbffef7d906048b00faea9415447
Best Regards,
Hao Wu
> -Original Message-
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> brit.chesley via groups.io
> Sent: Saturday, July 8, 2023 1:07 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; Abner Chang
> Subject: [edk2-devel]
For the 2 occurrences of in XhcWaitOpRegBit & XhcExecTransfer:
TimeoutTime = XHC_MICROSECOND_TO_NANOSECOND (Timeout * XHC_1_MILLISECOND);
How about changing them to:
TimeoutTime = XHC_MICROSECOND_TO_NANOSECOND ((UINT64) Timeout *
XHC_1_MILLISECOND);
to address possible overflow during
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 17, 2023 12:25 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v4 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
> UNUSED_VALUE Coverity issue
&g
3 9:44 AM
To: devel@edk2.groups.io; suli...@loongson.cn; Demeter, Miki
Cc: Wu, Hao A
Subject: 回复: [edk2-devel] empty USB DVD disk hang Xhci
Likun:
This change is good to me. Reviewed-by: Liming Gao
mailto:gaolim...@byosoft.com.cn>>
Hao:
Have you time to review this fix?
Thanks
Liming
Merged via:
PR - https://github.com/tianocore/edk2/pull/4648
Commit -
https://github.com/tianocore/edk2/commit/dd49d448b0815c65847241a3faa957e3b4605001
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao A
> Sent: Wednesday, July 12, 2
> -Original Message-
> From: Ranbir Singh
> Sent: Friday, July 14, 2023 12:47 AM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
> UNUSED_VALUE Coverity issue
&g
It works for me, better to override by:
Status = EFI_SUCCESS;
Best Regards,
Hao Wu
From: Ranbir Singh
Sent: Wednesday, July 12, 2023 3:01 PM
To: Wu, Hao A
Cc: devel@edk2.groups.io; Ni, Ray
Subject: Re: [PATCH v2 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
UNUSED_VALUE Coverity issue
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 3, 2023 7:44 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWA
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Friday, June 9, 2023 8:33 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v2 1/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fi
-Original Message-
> From: Ranbir Singh
> Sent: Friday, June 9, 2023 8:33 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v2 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
> UNUSED_VALUE Coverity issue
>
> From: Ranbi
Thank you.
Best Regards,
Hao Wu
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, June 13, 2023 11:40 AM
> To: Wu, Hao A ; devel@edk2.groups.io
> Cc: Gao, Zhichao ; Liu, Zhiguang
> ; Guo, Gua
> Subject: RE: [PATCH] Maintainers.txt: Stop to be reviewer of seve
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, June 13, 2023 10:07 AM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao ; Wu, Hao A
> ; Liu, Zhiguang ; Guo, Gua
>
> Subject: [PATCH] Maintainers.txt: Stop to be reviewer of several modules
>
> Rem
to ensure it will not
bring issue to previously working devices.
Best Regards,
Hao Wu
From: Ranbir Singh
Sent: Thursday, June 8, 2023 6:17 PM
To: Wu, Hao A
Cc: devel@edk2.groups.io; a...@kernel.org; pedro.falc...@gmail.com; Ni, Ray
Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Bus/Ata
> -Original Message-
> From: Ranbir Singh
> Sent: Saturday, June 3, 2023 12:09 AM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix
> SIGN_EXTENSION Coverity issue
>
> Fr
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Monday, June 5, 2023 4:32 PM
> To: Ranbir Singh
> Cc: devel@edk2.groups.io; pedro.falc...@gmail.com; Wu, Hao A
> ; Ni, Ray
> Subject: Re: [edk2-devel] [PATCH 2/2
iver Model (install EFI Driver Binding
Protocol), why they are listed as DXE_DRIVER instead of UEFI_DRIVER in the INF
files?
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> RichardHo [何明忠] via groups.io
> Sent: Thursday, June 8, 2023 1
Merged via:
PR - https://github.com/tianocore/edk2/pull/4478
Commit -
https://github.com/tianocore/edk2/commit/67fc78d026490ea4c375eeb19724abb40e7be8f2
Best Regards,
Hao Wu
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, June 2, 2023 11:14 AM
> To: He, Jiangang
ns
> a failure and the drop down for "Re-run failed checks" is available.
Best Regards,
Hao Wu
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, June 7, 2023 11:08 AM
> To: Wu, Hao A ; devel@edk2.groups.io; Ard
> Biesheuvel
> Cc: Michael Kubacki ;
Hello Mike,
I do not see the "re-run failed jobs" under "Checks" tab for cancelled CI tests:
https://github.com/tianocore/edk2/pull/4478
(Only "Re-run all checks" is found)
What should be done to handle such case?
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io
Sorry for the late response, inline comments below:
> -Original Message-
> From: brit.ches...@amd.com
> Sent: Wednesday, May 17, 2023 6:16 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
>
> Subject: [PATCH v1 1/1] MdeMod
Add Stewards.
I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to constant
cancelled CI tests.
Could someone help with the situation or help to merge the change? Thanks in
advance.
Best Regards,
Hao Wu
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Monday, June 5
Thanks all,
Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478,
but failed 3 times (all due to some canceled CI tests).
Will re-try tomorrow.
Best Regards,
Hao Wu
From: Hsueh, Hong-Chih (Neo)
Sent: Saturday, June 3, 2023 2:12 AM
To: Chang, Abner ; Wu, Hao A ; He
Thanks.
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: He, Jiangang
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A ; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo)
> Cc: Chang, Abner
> Subject: RE: [edk2-devel] [PATCH] M
Thanks, the code changes look good to me.
May I know what tests have been performed for the patch?
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Neo
> Hsueh via groups.io
> Sent: Wednesday, May 24, 2023 1:07 AM
> To: devel@edk2.groups.io
> Cc:
Merged via:
PR - https://github.com/tianocore/edk2/pull/4439
Commit -
https://github.com/tianocore/edk2/commit/e1f5c6249af08c1df2c6257e4bb6abbf6134318c
Best Regards,
Hao Wu
> -Original Message-
> From: Giri Mudusuru
> Sent: Thursday, May 18, 2023 2:01 AM
> To: Wu, Hao A
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, May 17, 2023 7:46 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Giri Mudusuru ; Ni, Ray ; Wang,
> Jian J ; Gao, Liming ;
> Andrew Fish
> Subject: Re: [edk2-
Thanks for the patch, inline comment below:
> -Original Message-
> From: Giri Mudusuru
> Sent: Friday, May 12, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Giri Mudusuru ; Wu, Hao A ; Ni,
> Ray ; Wang, Jian J ; Gao, Liming
> ; Andrew Fish
> Subject: [PATCH] Md
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray ; Mike Maslenk
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming ; Wu, Hao A ; Ni,
> Ray
&g
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro
> Falcato
> Sent: Wednesday, May 10, 2023 12:32 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Pedro Falcato
> ; Wang, Jian J ; Gao,
> Liming
; From: devel@edk2.groups.io On Behalf Of Wu, Hao A
> Sent: Thursday, May 4, 2023 10:20 AM
> To: devel@edk2.groups.io; o...@linux.microsoft.com
> Cc: Ni, Ray ; Wang, Jian J ; Gao,
> Liming ; Michael Kubacki
> ; Sean Brogan
> Subject: Re: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword
Thanks Oliver,
Agree with your points. Let's keep "Sq" as is and mark "Cq" as volatile.
Best Regards,
Hao Wu
> -Original Message-
> From: Oliver Smith-Denny
> Sent: Thursday, April 27, 2023 5:07 AM
> To: devel@edk2.groups.io; Wu, Hao A ; Ni, Ray
>
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Oliver
> Smith-Denny
> Sent: Thursday, April 20, 2023 11:48 PM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Wu, Hao A ; Wang, Jian J ;
> Gao, Liming ; Michael Kubacki
> ; Sean Brogan
Patch merged via:
PR - https://github.com/tianocore/edk2/pull/4207
Commit -
https://github.com/tianocore/edk2/commit/eb6a74827200eedc81b8f45f332d6e9f3b3d2906
Best Regards,
Hao Wu
From: Anbazhagan, Baraneedharan
Sent: Wednesday, March 29, 2023 10:30 AM
To: devel@edk2.groups.io; Wu, Hao
Reviewed-by: Hao A Wu
Will wait a couple of days before merging to see if comments from other
reviewers.
Best Regards,
Hao Wu
> -Original Message-
> From: Albecki, Mateusz
> Sent: Tuesday, March 28, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz ; Wu, Ha
From: devel@edk2.groups.io On Behalf Of Anbazhagan,
Baraneedharan via groups.io
Sent: Friday, March 24, 2023 12:55 AM
To: devel@edk2.groups.io; Wu, Hao A ; Albecki, Mateusz
Cc: Ni, Ray ; Chang, Hunter
Subject: Re: [edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for
non-transient errors
Albecki, Mateusz
> Sent: Wednesday, March 22, 2023 4:20 AM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz ; Wu, Hao A
> ; Ni, Ray ; Chang, Hunter
>
> Subject: [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors
>
> Fix for the recovery logic which ca
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 3, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Wang, Jian J ; Yao, Jiewen
> ; Marvin Häuser ; James
> Bottomley ;
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 3, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Wang, Jian J ; Yao, Jiewen
> ; Marvin Häuser ; James
> Bottomley ;
Merged via:
PR - https://github.com/tianocore/edk2/pull/4102
Commit -
https://github.com/tianocore/edk2/commit/46f51898ff716e53921b93e8d78af0fc7d06a2f9
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao A
> Sent: Monday, February 27,
the protocol to perform the platform specific
actions.
Best Regards,
Hao Wu
> -Original Message-
> From: Chevron Li
> Sent: Friday, February 24, 2023 8:40 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Wang,
> Jian J ; Gao, Liming ;
> shaper@ba
Reviewed-by: Hao A Wu .
Will merge it after the upcoming stable tag announcement.
Best Regards,
Hao Wu
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, February 24, 2023 8:18 AM
> To: devel@edk2.groups.io; Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
>
"UsbHubInit: failed to queue interrupt transfer for
hub %d - %r\n",
I found that most of them follows the pattern "... - %r ...".
Not sure if this format is good enough to you.
Best Regards,
Hao Wu
> -Original Message-
> From: Rebecca Cran
> Sent:
o; Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
>
> Cc: Rebecca Cran
> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of
> warning DEBUG in UsbSelectConfig
>
> Improve the formatting of a warning in UsbSelectConfig by adding parentheses
> aroun
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zhu, Weipu
> Sent: Thursday, February 2, 2023 2:42 PM
> To: devel@edk2.groups.io
> Cc: Zhu, Weipu ; Wu, Hao A ;
> Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 2/
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Zhu, Weipu
> Sent: Thursday, February 2, 2023 2:42 PM
> To: devel@edk2.groups.io
> Cc: Zhu, Weipu ; Wu, Hao A ;
> Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH
Merged via:
PR - https://github.com/tianocore/edk2/pull/3992
Commit -
https://github.com/tianocore/edk2/commit/7623b4bf6a4541b1bc5ad1978f27a55f2fb62c5f
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Wednesday, Februa
Add MdePkg maintainers & reviewers.
One inline comment below:
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Weipu
> Zhu
> Sent: Wednesday, February 1, 2023 2:27 PM
> To: devel@edk2.groups.io
> Cc: Zhu, Weipu
> Subject: [edk2-devel] [PATCH 2/2] MdePkg: Add NVMe boot
Add MdePkg maintainers & reviewers.
One general level comment, could you help to add 'NVME_' prefix to the name of
all newly added structure and macro definitions (like most existing ones in
Nvme.h)?
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
Merged via:
PR - https://github.com/tianocore/edk2/pull/3979
Commit -
https://github.com/tianocore/edk2/commit/d375273c899bfa279c2732c509caf455af285006
Best Regards,
Hao Wu
From: Yuan Yu
Sent: Thursday, February 2, 2023 2:17 AM
To: Wu, Hao A
Cc: devel@edk2.groups.io; Ard Biesheuvel ; Gao
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Yuan Yu
> Sent: Wednesday, February 1, 2023 2:31 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; C, sivaparvathi
> Subject: [PATCH v1 1/1] M
io
> Cc: Ard Biesheuvel ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; C, sivaparvathi
> Subject: [PATCH v2 1/1] MdeModulePkg: ScsiBusDxe: Refactor
> DiscoverScsiDevice()
>
> Currently DiscoverScsiDevice() returns a boolean which cannot
> distinguish a "not found" situatio
Thanks for the patch, inline comments below:
> -Original Message-
> From: Yuan Yu
> Sent: Wednesday, January 18, 2023 5:14 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
> ; C, sivaparvathi
> Subject: [PATCH v1 1/
://github.com/tianocore/edk2/commit/47ab397011b6d1ce4d5805117dc87d9e35f378db
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, January 11, 2023 11:10 AM
> To: devel@edk2.groups.io
> Cc: W
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, January 11, 2023 11:10 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Garrett
> Kirkendall ; Abne
Pushed via:
PR - https://github.com/tianocore/edk2/pull/3848
Commit -
https://github.com/tianocore/edk2/commit/992d5451d19b93635d52db293bab680e32142776
Best Regards,
Hao Wu
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Tuesday, January 3, 2023 9:25 AM
To: Rhodes, Sean ; devel@edk2
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
From: Sean Rhodes
Sent: Friday, December 23, 2022 6:22 PM
To: devel@edk2.groups.io; Wu, Hao A
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Reset the port
if status change returns an error
Hi Hao
This PR has passed CI - https
Sorry,
The CI tests failed for the proposed patch:
https://github.com/tianocore/edk2/pull/3824
Could you help to check and resolve? Thanks.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> Sent: Wednesday, December 21, 2022 4:15 PM
>
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, December 21, 2022 11:41 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Garrett
> Kirkendall ; Abne
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, December 21, 2022 11:42 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Garrett
> Kirkendall ; Abne
ehalf Of Chang,
> Abner via groups.io
> Sent: Wednesday, December 21, 2022 11:42 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Garrett
> Kirkendall ; Abner Chang
> ; Kuei-Hung Lin
> Subject: [edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei
> memory blo
Merged via:
PR - https://github.com/tianocore/edk2/pull/3806
Commit -
https://github.com/tianocore/edk2/commit/ec25e904c7da70302f2725e2005e3762f1ae891e
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Monday, December 1
Merged via:
PR - https://github.com/tianocore/edk2/pull/3806
Commit -
https://github.com/tianocore/edk2/commit/01c2fb0d2260d4de898e4e91e48770ffa5510153
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: Monday, December 1
st Regards,
Hao Wu
> -Original Message-
> From: Chang, Abner
> Sent: Tuesday, December 20, 2022 10:45 AM
> To: Wu, Hao A ; devel@edk2.groups.io
> Cc: Lin, Kuei-Hung (Timothy) ; Ni, Ray
> ; Kirkendall, Garrett
> Subject: RE: [PATCH V3] MdeModulePkg/Xhci: Initial
Thanks.
You are right. I agree with you that aligning with XhciDxe is a better
resolution.
Best Regards,
Hao Wu
> -Original Message-
> From: He, Jiangang
> Sent: Tuesday, December 20, 2022 6:54 AM
> To: Wu, Hao A ; Chang, Abner
> ; devel@edk2.groups.io
> Cc: Lin,
Reviewed-by: Hao A Wu
I will make minor modification to:
* Function description comment
* Input parameter name
of XhcCheckUsbPortSpeedUsedPsic() to make the declaration (in .H) and the
definition (in .C) match.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On
reply, which aligns with XhciDxe
should work fine.
I will leave it to you for the final decision.
Best Regards,
Hao Wu
> -Original Message-
> From: He, Jiangang
> Sent: Friday, December 16, 2022 12:48 AM
> To: Chang, Abner ; Wu, Hao A
> ; devel@edk2.groups.io
> Cc: Lin,
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Sean Rhodes
> Sent: Friday, December 16, 2022 4:58 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier ; Wu, Hao A
> ; Ni, Ray ; Rhodes, Sean
>
> Subject: [PATCH 2/3] MdeModulePkg/X
Sorry,
Could you help to:
1. Update the function description comment for XhcCheckUsbPortSpeedUsedPsic()
in .C/.H files for adding the new input parameter 'PortNumber'
2. Add additional checks in XhciPsivGetPsid() to not allow:
* PortId.Data.CompPortOffset having a value of 0
*
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Sean Rhodes
> Sent: Saturday, December 10, 2022 4:46 AM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier ; Wu, Hao A
> ; Ni, Ray ; Rhodes, Sean
>
> Subject: [PATCH 2/3] MdeModulePkg/X
1 - 100 of 962 matches
Mail list logo
