Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

[AMD Official Use Only - AMD Internal Distribution Only] Thanks Abner for the up-stream. Looks good to me. Reviewed-by: Eric Xing > -Original Message- > From: Chang, Abner > Sent: Thursday, May 23, 2024 12:12 PM > To: devel@edk2.groups.io > Cc: Grimes, Paul ; Attar, AbdulLateef

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] Hi Ard, Please let me merge VangoGh board code next time after we finished the review process and build/verification test since I am maintainer and responsible for Vangogh Board platform code. I will discuss it inside AMD to how to resolve current

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] Hi Ard, Agree with you, reverting code looks not a good way now. We will think about new method to resolve this issue. Just need a bit more time and I will hold on checking in code to VanGoghBoard before it. Thanks again for your suggestion and help us improve

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

Leif Lindholm > > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Fri, 19 Apr 2024

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] Thanks Duke. Hi Thomas, PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off EDK2_202208. Please hold on this PATCH check in. Added my comments below. Thanks, Eric > -Original Message- > From: Zhai, MingXin

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[AMD Official Use Only - General] Thanks Thomas and Abner. Reviewed-by: For up-stream, please let us verify it first: @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani Board and feedback. Thanks, Eric > -Original Message- > From: Chang, Abner > Sent: Thursday,

Re: [edk2-devel] [PATCH] AMD/AmdPlatformPkg: Update AMD Vangogh platform reference code

[AMD Official Use Only - General] Below changes are reviewed and verified. Reviewed-by: Eric Xing > -Original Message- > From: Zhai, MingXin (Duke) > Sent: Tuesday, March 12, 2024 11:06 AM > To: devel@edk2.groups.io > Cc: Yao, Ken ; Fu, Igniculus ; > Chang, Abner ; Xing, Eric >

Re: [edk2-devel] [PATCH] AMD/VanGogh: Update VanGogh firmware binaries to UCC4126.3B30 Update firmware binaries for VanGogh B0 processors to UCC4126.3B30

[AMD Official Use Only - General] Thanks Duke. Reviewed by: Eric Xing > -Original Message- > From: duke.z...@amd.com > Sent: Thursday, January 25, 2024 5:56 PM > To: devel@edk2.groups.io > Cc: Xing, Eric ; Yao, Ken ; Fu, > Igniculus ; Chang, Abner > Subject: [PATCH] AMD/VanGogh:

Re: [edk2-devel] [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg

[AMD Official Use Only - General] Hi Abner, Thanks for your review, we have V2 patch improved the coding style issue. [PATCH V2 33/33] AMD/VanGoghBoard: Improvement coding style Thanks, Eric > -Original Message- > From: Chang, Abner > Sent: Tuesday, January 23, 2024 12:44 PM > To:

Re: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in SmramSaveState module.

[AMD Official Use Only - General] Hi Abner and Abdul, Thanks for the review, it is good catch. Currently, our current override files are based on UDK202208 code base now. AmdMmSaveStateLib.inf is not existed in UDK2208 code base, we will leverage latest EDK2 changes after we update to new EDK2

Re: [edk2-devel] [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module.

[AMD Official Use Only - General] Hi Abner, Thanks for the review, it is good catch. Currently, our current override files are based on UDK202208 code base now. We will leverage latest EDK2 changes after we update to new EDK2 code base. Thanks, Eric > -Original Message- > From: Chang,

Re: [edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code

[AMD Official Use Only - General] Hi Duke, Looks fine to me all 33 patch sets, I'd like to invite Abner help reviewing initial Vangogh platform reference code up-stream this time. Reviewed-by: Eric Xing Thanks, Eric > -Original Message- > From: duke.z...@amd.com > Sent: Thursday,

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH v2. Sorry troubling you, would you help review it again so I can get your approved with v2 patch? Thanks again. Eric -Original Message- From: Leif Lindholm Sent: Friday,

[edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH v2] 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

From: Eric Xing Cc: Michael D Kinney Cc: Abner Chang Cc: Leif Lindholm Cc: Abdul Lateef Attar Signed-off-by: Eric Xing --- Maintainers.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb 100644 --- a/Maintainers.txt +++

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] Thanks Abner for the kindly reminder. Will correct it next time. Eric From: Chang, Abner via groups.io Sent: Thursday, September 28, 2023 11:19 PM To: Xing, Eric ; devel@edk2.groups.io Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries

[AMD Official Use Only - General] Thanks Abner for the prompt review. Will follow coding standard and correct the new files’ name in PATCH V2. Eric. From: Chang, Abner via groups.io Sent: Thursday, September 28, 2023 11:23 PM To: Xing, Eric ; devel@edk2.groups.io Subject: Re: [edk2-devel]