Thanks. Not urgent. Let’s wait.
> -Original Message-
> From: gaoliming
> Sent: Monday, May 27, 2024 3:12 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Lin, Du
>
> Cc: 'Ard Biesheuvel' ; 'Gerd Hoffmann'
>
> Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: U
I have approved it.
What is the process to merge? There is no COMMIT button or PUSH label.
> -Original Message-
> From: Lin, Du
> Sent: Monday, May 27, 2024 2:23 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Yao, Jiewen ; Lin, Du
>
>
Acked-by: Jiewe Yao
BTW: This patch is already got RB from below people. I suggest you can put them
in commit directly.
Reviewed-by: Pierre Gondois
Reviewed-by: Ard Biesheuvel
Thank you
Yao, Jiewen
> -Original Message-
> From: Flickdm
> Sent: Friday, May 24, 202
)
1) Keep current libspdm official 3.3.0 release, and update to next release at
the beginning of July.
2) Update libspdm immediately with the new cmocka submodule, which is NOT an
official release.
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf
. But that is NOT a reason to disable
it.
Anyway, I think tianocore project has freedom to choose whatever options,
independent with libspdm project. And I hope we have a consistent way to handle
all projects.
Thank you
Yao, Jiewen
> -Original Message-
> From: Kinney, Michael D
Reviewed-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Lin, Du
> Sent: Thursday, May 9, 2024 1:27 PM
> To: devel@edk2.groups.io
> Cc: Lin, Du ; Ard Biesheuvel ;
> Gerd Hoffmann ; Yao, Jiewen
> Subject: [edk2-devel] [PATCH] OvmfPkg
Thanks to confirm that.
I am OK on what you have said.
Since the ARM part is added by Pierre Gondois
pierre.gond...@arm.com<mailto:pierre.gond...@arm.com>, I will let him comment
if there is any concern on the change for ARM.
Thank you
Yao, Jiewen
From: Doug Flick via groups.io
[Index]
);
It seems to me that the EntropyBits is also less than 256, when the input
requirement is less than 256 bit.
Would you please double check that, to see if the requirement is still
satisfied?
Please correct me if my understanding is wrong.
Thank you
Yao, Jiewen
>
Acked-by: Jiewen Yao
> -Original Message-
> From: Li, Yi1
> Sent: Thursday, May 9, 2024 4:33 PM
> To: Hou, Wenxing ; gaoliming
> ; devel@edk2.groups.io
> Cc: Yao, Jiewen
> Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
>
> This patch se
Acked-by: Jiewen Yao
From: Wu, Jiaxin
Sent: Tuesday, May 7, 2024 11:39 AM
To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel
; Yao, Jiewen
Cc: Zeng, Star ; Gerd Hoffmann ; Kumar,
Rahul R ; Dong, Guo ; Rhodes, Sean
; Lu, James ; Guo, Gua
; Abdul Lateef Attar ; Abner
Chang ; Tom Lendacky
Merged https://github.com/tianocore/edk2/pull/5628
> -Original Message-
> From: Dionna Glaze
> Sent: Tuesday, May 7, 2024 2:08 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Kinney, Michael D
> ; Liming Gao ; Liu,
> Zhiguang ; Yao, Jiewen ;
> Kumar, Rahul R ;
"Reviewed-by".
Thank you
Yao, Jiewen
> -Original Message-
> From: Dionna Glaze
> Sent: Thursday, May 2, 2024 8:50 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Kinney, Michael D
> ; Liming Gao ; Liu,
> Zhiguang ; Yao, Jiewen ;
> Kumar, Rahul R ; Ard Biesheuv
Thanks Dionna.
Almost good, except you create a typo below:
>EFI_GUIDReferenceManifestGuid;
> - //
> + //
>// Below structure is newly added in TCG_Sp800_155_PlatformId_Event2.
With typo fix, reviewed-by: Jiewen Yao
Thank you
Yao, Jiewen
> -Original Mess
I think it is confusing to add "TCG_Sp800_155_PlatformId_Event3" field for
"TCG_Sp800_155_PlatformId_Event2" structure.
Maybe just create a new "TCG_Sp800_155_PlatformId_Event3" structure?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Dionna Glaze
> via groups.io
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Dionna Glaze
> Sent: Wednesday, May 1, 2024 8:53 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Kinney, Michael D
> ; Liming Gao ; Liu,
> Zhiguang ; Yao, Jiewen ;
> Kumar, Rahul R ; Ard Biesheuvel
>
Hi All
It has been 4 work weeks and this V4 patch resolved previous comments and
feedbacks.
If there is no further objection, I plan to merge it tomorrow.
Thank you
Yao, Jiewen
> -Original Message-
> From: Hou, Wenxing
> Sent: Friday, April 26, 2024 9:52 AM
> To: Yao, Ji
Thank you very much for the help.
https://github.com/tianocore/edk2/pull/5595 merged.
> -Original Message-
> From: Michael Kubacki
> Sent: Thursday, April 25, 2024 7:22 AM
> To: devel@edk2.groups.io; Yao, Jiewen ; Kinney, Michael
> D ; Sean Brogan
> Cc: Gerd Hoffman
Ah, thank you Mike.
Should I close/re-open my PR?
Or should I keep waiting?
Thank you
Yao, Jiewen
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, April 25, 2024 7:01 AM
> To: Yao, Jiewen ; devel@edk2.groups.io; Sean Brogan
> ; Michael Kubacki
>
&
Hi Mike/Sean
Can someone look at the EDKII CI?
My PR has been blocked for 9 hours -
https://github.com/tianocore/edk2/pull/5595.
Thank you
Yao, Jiewen
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, April 25, 2024 1:05 AM
> To: Yao, Jiewen
> Cc: Gerd H
Thanks Ard.
I have submitted https://github.com/tianocore/edk2/pull/5595 3 hours ago.
But it seems the CI stops working...
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, April 25, 2024 12:27 AM
> To: Yao, Jiewen
> Cc: Gerd Hoffmann ; devel@edk2.gr
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, April 24, 2024 2:00 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Gerd Hoffmann
> ; Ard Biesheuvel ; Yao, Jiewen
> ; Srikanth Aithal
> Subject: [PATCH v4 1/1] OvmfPkg/
Get32
(PcdOvmfFdBaseAddress))", reviewed-by: Jiewen Yao
Thank you
Yao, Jiewen
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, April 19, 2024 8:31 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Konstantin Kostiuk
> ; Ard Biesheuvel ; Yao,
> Jiewen ; Gerd H
All series: Reviewed-by: Jiewen Yao
Dear Steward member
Do you have any concern on adding libspdm (https://github.com/DMTF/libspdm) as
one more submodule?
Thank you
Yao, Jiewen
> -Original Message-
> From: Hou, Wenxing
> Sent: Thursday, April 18, 2024 6:16 PM
> To
7/7, 4/7, 3/7 - reviewed-by: Jiewen Yao
> -Original Message-
> From: Sachin Ganesh
> Sent: Saturday, April 20, 2024 5:46 AM
> To: devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; Liu, Zhiguang ; Kinney,
> Michael D ; ardb+tianoc...@kernel.org;
> kra...@re
1) Yes, I highly recommend remove Q35 keyword.
2) Got it. I think we had better add such info in the code as comment as well.
Thank you
Yao, Jiewen
> -Original Message-
> From: kra...@redhat.com
> Sent: Thursday, April 18, 2024 7:45 PM
> To: Yao, Jiewen
> Cc: devel@edk2
Ah. That is good. I did not realize they are in one set.
For this one, reviewed-by: Jiewen Yao
> -Original Message-
> From: Sachin Ganesh
> Sent: Thursday, April 18, 2024 9:32 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: gaolim...@byosoft.com.cn; ardb+tianoc...@
Thanks Adam and Ard.
Since this #VC specific hardening, I would rely on AMD people's expertise to
fix it.
I have no objection for the patch.
Thank you
Yao, Jiewen
> -Original Message-
> From: Adam Dunlap
> Sent: Thursday, April 18, 2024 1:45 AM
> To: Ard Biesheuvel
>
Hi Sachin
I like this clean up. Thanks for doing this.
I saw this patch is 6/6, but I did not see any other such as 1/6 ~ 5/6 in my
mailbox. Not sure what is happening on my side.
Just double confirm, have you sent those patches?
Thank you
Yao, Jiewen
> -Original Message-
>
_FLASH mean NO write to flash even in SMM mode?
Or does it just mean NO write in normal operation mode, but still writable in
SMM mode?
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Wednesday, April 17, 2024 4:18 PM
I have merged this one https://github.com/tianocore/edk2/pull/5566
Hi Gerd
If you prefer that we move all TDX / SEV specific component to IntelTdx and
AmdSev, I am OK with that.
Personally, I like your idea. Please submit Bugzilla and work on it, if you
would like to.
Thank you
Yao, Jiewen
https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDecryptPei
https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncryptSevLib
I think we can follow the existing code structure in this patch set.
Thank you
Yao, Jiewen
> -Original Message-
> From
Hi Wenxing
I just realized that this libspdm submodule does NOT use the latest tag.
Since DMTF release 3.3.0 for libspdm
https://github.com/DMTF/libspdm/releases/tag/3.3.0, I recommend we update to
the latest one.
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.gro
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Hou, Wenxing
> Sent: Monday, April 15, 2024 10:08 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Sean Brogan ; Joey Vagedes
> ; Liming Gao ; Andrew
> Fish ; Liu, Zhiguang ; Kumar, Rahul R
> ; Ya
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Monday, April 15, 2024 3:59 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Gerd Hoffmann
> Subject: RE: [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to
Merged https://github.com/tianocore/edk2/pull/5563
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Cindy Kuo
> Sent: Tuesday, April 16, 2024 1:03 PM
> To: devel@edk2.groups.io
> Cc: Kuo, CindyX
> Subject: [edk2-devel] [PATCH v5 0/2] SecurityPkg/OpalPasswordDxe: Update
>
Merged https://github.com/tianocore/edk2/pull/5556
> -Original Message-
> From: Xu, Wei6
> Sent: Friday, April 12, 2024 3:15 PM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 ; Kumar, Rahul R ;
> Yao, Jiewen
> Subject: [PATCH v2 1/1] SecurityPkg/Tcg2Config: Hide
I am not sure why patch 0/1 contains the code. It should be the cover letter.
Also, if Dandan has already reviewed that, you may add R-B tag.
> -Original Message-
> From: Kuo, CindyX
> Sent: Friday, April 12, 2024 4:31 PM
> To: devel@edk2.groups.io
> Cc: Kuo, Cindy
, or split them into different patch.
In each patch, please explain as clear as possible, on why it is needed.
That will help reviewer or maintainer to have better understanding.
Last but not least, please describe what test you have done for the patch.
Thank you
Yao, Jiewen
> -Original Mess
eForm() to force reparsing the IFR binary.
Thank you
Yao, Jiewen
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, April 11, 2024 7:15 PM
> To: Kuo, CindyX ; devel@edk2.groups.io
> Cc: Yao, Jiewen ; Kumar, Rahul R
> ; Tan, Ming ; Chen, Arthur G
> ; Chen, Xiao X
Ard Biesheuvel
> Cc: devel@edk2.groups.io; Yao, Jiewen ; Dionna Amalie
> Glaze ; Mikko Ylinen ;
> James Bottomley ; Tom Lendacky
> ; Michael Roth ; qinkun
> Bao ; linux-c...@lists.linux.dev; Aktas, Erdem
> ; Peter Gonda ; Johnson,
> Simon P ; Xiang, Qinglan
>
> Sub
ou think AMD is OK with this coexistence proposal?
Are you willing to give "reviewed-by"?
Thank you
Yao, Jiewen
> -Original Message-
> From: Dionna Amalie Glaze
> Sent: Monday, March 25, 2024 11:29 PM
> To: Mikko Ylinen
> Cc: Gerd Hoffmann ; Yao, Jiewen ;
> qin
; Hoffmann ; Kumar, Rahul R ;
> Dong, Guo ; Rhodes, Sean ; Lu,
> James ; Guo, Gua ; Ard Biesheuvel
> ; Yao, Jiewen
> Subject: [PATCH v1 00/13] Add SmmRelocationLib
>
> Intel plans to separate the smbase relocation logic from
> PiSmmCpuDxeSmm driver, and the related behavi
Thanks.https://github.com/tianocore/edk2/pull/5533
> -Original Message-
> From: Bi, Dandan
> Sent: Sunday, April 7, 2024 10:07 AM
> To: Tan, Ming ; devel@edk2.groups.io
> Cc: Xu, Min M ; Yao, Jiewen ;
> POLUDOV, FELIX
> Subject: RE: [PATCH v4] SecurityPkg/SecureBoo
to endorse the runtime
co-existence of vTPM and RTMR.
Also, I would like to hear the opinions from other companies.
BTW: A small comment: In EDKII, we don’t use MACRO. Please change to PCD
(default false), after you get endorsement from other compony.
Thank you
Yao, Jiewen
> -Original Mess
it is a right way to provide an *empty* one just to
pass the SVVP.
That totally looses the value to having HSTI in the SVVP program.
I recommend we provide a real HSTI based on the OVMF threat model (without and
with configuration computing) and current real implementation.
Thank you
Yao, Jiewen
From
Question: What is the value to provide an *empty* HSTI table?
IMHO, If the goal is to perform some security check, I think we need provide a
*real* HSTI table.
Thank you
Yao, Jiewen
> -Original Message-
> From: Konstantin Kostiuk
> Sent: Thursday, March 14, 2024 6:25 PM
&g
Thanks for the patch.
Is this the only missing configuration data?
Or do you have more on the way?
> -Original Message-
> From: Sun, CepingX
> Sent: Wednesday, March 13, 2024 7:52 AM
> To: devel@edk2.groups.io
> Cc: Sun, CepingX ; Aktas, Erdem
> ; Yao, Jiewen ;
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Tuesday, February 27, 2024 2:49 PM
> To: Sun, CepingX ; devel@edk2.groups.io
> Cc: Liming Gao ; Kinney, Michael D
> ; Aktas, Erdem ; James
> Bottomley ; Yao, Jiewen ; Tom
> Lendacky ; Michae
> ; Gerd Hoffmann ; Yao, Jiewen
> ; Leif Lindholm ; Kumar,
> Rahul R ; Ni, Ray ; Sami Mujawar
>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries
>
> On Fri, 8 Mar 2024 at 10:14, Laszlo Ersek wrote:
> >
> > On 3/6/24 23:22, Michael
; Chiu, Chasel ; Duggapu,
> Chinni B ; Aktas, Erdem
> ; Gerd Hoffmann ; Guo, Gua
> ; Dong, Guo ; Lu, James
> ; Yao, Jiewen ; Joey Vagedes
> ; Leif Lindholm ; Liming
> Gao ; Kinney, Michael D
> ; Michael Roth ; Xu, Min
> M ; Desimone, Nathaniel L
> ; Kumar, Rahul R ;
>
Right, if it is only required by ARM, then it should under ARM section.
Thank you
Yao, Jiewen
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, March 1, 2024 7:45 PM
> To: Yao, Jiewen ; Pierre Gondois
> ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Lim
add/remove DSC freely.
Having "dependency" in DSC does not matter.
Having dependency in INF is something we should care about.
Thank you
Yao, Jiewen
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, February 13, 2024 1:38 AM
> To: Pierre Gondois ; d
Below:
> -Original Message-
> From: Tom Lendacky
> Sent: Thursday, February 29, 2024 12:20 AM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Aktas, Erdem
> ; Gerd Hoffmann ; Laszlo Ersek
> ; Liming Gao ; Kinney, Michael
> D ; Xu, Min M ; Liu,
>
the position of SVSM.
If the SVSM interface is AMD specific, the it should be AmdSvsmLib.
If the SVSM interface is generic, then we should define everything in a generic
way.
It is very confusing to mix a generic CcSvsm lib with AMD specific
.
Thank you
Yao, Jiewen
> -Original Mess
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Shang, Qingyu
> Sent: Monday, February 26, 2024 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen
> Subject: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function
> description
>
> Refe
is still UEFI 2.9? would that still work?
Third, because I am not HII expert, I would like to have HII expert to comment
the HII/Browser related change.
Thank you
Yao, Jiewen
> -Original Message-
> From: Tan, Ming
> Sent: Tuesday, February 27, 2024 10:59 AM
> To: devel@ed
Thanks Laslo and Eddie.
I am just back from Chinese New Year vocation, still checking email.
If you can file a Bugzilla (https://bugzilla.tianocore.org/) with source code
of your app, that would be very helpful for us to investigate this issue.
> -Original Message-
> From:
Thanks Tom. Below is exactly what I am looking for:
"the decision to use the SVSM API will be based on the VMPL level at which OVMF
is running."
OVMF needs to detect SEV-SNP, then make next level decision on VMPL.
Makes sense to me.
Thank you
Yao, Jiewen
> -Original Messag
these mode requires runtime detection. Am I right?
If so, where is the flag to set those mode?
Please correct me if my understanding is wrong.
Thank you
Yao, Jiewen
> -Original Message-
> From: Tom Lendacky
> Sent: Saturday, January 27, 2024 6:13 AM
> To: devel@edk2.groups.
Always good to reduce duplication!
Thanks for doing that.
Acked-by: Jiewen Yao
> -Original Message-
> From: Gerd Hoffmann
> Sent: Thursday, January 25, 2024 12:38 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Ard Biesheuvel
> ; Michael Roth ; Gerd
> Hoffmann ;
Thank you Doug for the prompt response.
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Thursday, January 18, 2024 6:47 AM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Yao, Jiewen
> ; Kumar, Rahul R
> Subjec
Hi Marc
I notice you are reviewer for TPM module in OvmfPkg.
Would you please help to test the TPM2.0 feature with patch from Gerd?
Thank you
Yao, Jiewen
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, January 17, 2024 10:06 PM
> To: devel@edk2.groups.io;
.
But it does seems a big issue now. Would you please propose a patch to resolve
it? Just rename the symbol.
Thank you
Yao, Jiewen
> -Original Message-
> From: Li, Yi1
> Sent: Wednesday, January 17, 2024 4:15 PM
> To: Yao, Jiewen ; devel@edk2.groups.io; Gerd Hoffmann
>
Please check https://github.com/tianocore/edk2/pull/5264. It is merged after
pass CI.
May I know where you see PR CI builds are broken?
Thank you
Yao, Jiewen
> -Original Message-
> From: Li, Yi1
> Sent: Wednesday, January 17, 2024 3:21 PM
> To: devel@edk2.groups.io; Yao, J
Gerd
I am OK with the patch.
Quick question: Have you validated that the TPM2 is still working?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, January 16, 2024 11:42 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Gerd Hoffmann
Sure. Let's start from OVMF.
We have leaf enough time for feedback, but I see no comment from other people.
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, January 16, 2024 10:35 PM
> To: devel@edk2.groups.io; Yao, Jiewen
> Cc: dougfl...@microsoft.com; Doug
Gerd
I have merged this patch set today.
I am fine to remove TPM1.2 in OVMF because of the known security limitation.
Thank you
Yao, Jiewen
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, January 16, 2024 8:01 PM
> To: devel@edk2.groups.io; dougfl...@micros
Merged https://github.com/tianocore/edk2/pull/5264
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Friday, January 12, 2024 2:16 AM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Yao, Jiewen
>
> Subject: [PATCH 0/6] SECURITY PATCHES TCBZ4117 &
need help from Ubuntu people.
Thank you
Yao, Jiewen
From: devel@edk2.groups.io On Behalf Of Hamit Can Karaca
Sent: Friday, January 12, 2024 1:39 PM
To: Hamit Can Karaca ; devel@edk2.groups.io
Subject: Re: [edk2-devel] When TPM is enabled, Ubuntu doesn't boot
I still need help on this topic. I have
Hi Doug
Thanks for the fix.
Please remember to CC all SecurityPkg maintainer and reviewer.
I will merge after several days to see if there is any additional feedback from
the community.
Thank you
Yao, Jiewen
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Friday, J
Cool, thanks for considering that!
> -Original Message-
> From: Ard Biesheuvel
> Sent: Wednesday, November 22, 2023 12:03 AM
> To: devel@edk2.groups.io; quic_llind...@quicinc.com
> Cc: Yao, Jiewen ; Pierre Gondois
> ; Li, Yi1 ; Lu, Xiaoyu1
> ; Jiang, Guomin ; Ar
interface in MdePkg, then your INF can declare that
interface.
You can still put real implementation in ArmPkg - no requirement to move.
That benefit is that you don’t need to add ArmPkg dependency in yaml.
Thank you
Yao, Jiewen
> -Original Message-
> From: Leif Lindholm
> Sent
to suggest this approach.
But I would like to have ARM expert to check if those are really ARM standard,
and also have MdePkg owner check if it is acceptable.
Thank you
Yao, Jiewen
> -Original Message-
> From: Pierre Gondois
> Sent: Tuesday, November 21, 2023 8:59 PM
Why CryptoPkg needs to depend on ArmPkg?
Can we move content to MdePkg?
> -Original Message-
> From: Pierre Gondois
> Sent: Tuesday, November 21, 2023 4:47 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Li, Yi1 ; Lu,
> Xiaoyu1
> ; Jiang, Guomin ; Leif Lindho
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, November 17, 2023 6:52 AM
> To: Laszlo Ersek ; devel@edk2.groups.io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Gerd Hoffmann ; Yao,
> Jiewen ; Leif Lindholm ;
> Kumar, Rahul R ;
Reviewed-by: Jiewen Yao
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 15, 2023 4:22 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Corvin Köhne
> ; Gerd Hoffmann ; Yao, Jiewen
> ; Rebecca Cran
> Subject: [PATCH
heuvel ; Corvin Köhne
> ; Aktas, Erdem ; Gerd
> Hoffmann ; Jianyong Wu ; Yao,
> Jiewen ; Michael Roth ; Xu,
> Min M ; Rebecca Cran ; Sunil V L
> ; Tom Lendacky
> Subject: [PATCH 00/37] OvmfPkg: remove the CSM (after edk2-stable202311)
>
> BZ: https://bugzilla.tianocore.org/
Thank you.
Merged. https://github.com/tianocore/edk2/pull/5026
> -Original Message-
> From: gaoliming
> Sent: Thursday, November 9, 2023 9:54 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; Sun, CepingX
> ; Kinney, Michael D ;
> 'Leif Lindholm' ; 'Andrew Fish'
> Cc:
you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Wednesday, November 8, 2023 9:21 PM
> To: Sun, CepingX ; devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Aktas, Erdem ; James
> Bottomley ; Xu, M
All: Reviewed-by: Jiewen Yao
> -Original Message-
> From: Sun, CepingX
> Sent: Wednesday, November 8, 2023 7:38 PM
> To: devel@edk2.groups.io
> Cc: Sun, CepingX ; Gao, Liming
> ; Kinney, Michael D ;
> Aktas, Erdem ; James Bottomley
> ; Xu, Min M ; Tom Lendack
Hey Ceping
Please don't change two packages in one patch, because it is hard to let the
corresponding maintainer to review and give R-B, if he/she only reviews part of
them.
The patch should be split to MdePkg update and OvmfPkg update.
Thank you
Yao, Jiewen
> -Original Mess
I think the macro definition (#define TDVMCALL_STATUS_RETRY 0x1) should be in
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/IndustryStandard/Tdx.h,
together with other TDX definition.
Thank you
Yao, Jiewen
> -Original Message-
> From: Sun, CepingX
> Sent:
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Sun, CepingX
> Sent: Thursday, November 2, 2023 5:10 PM
> To: devel@edk2.groups.io
> Cc: Sun, CepingX ; Gao, Liming
> ; Kinney, Michael D ;
> Aktas, Erdem ; James Bottomley
> ; Yao, Jiewen ; Xu, Min M
> ; To
Acked-by: Jiewen Yao
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, November 8, 2023 11:50 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm ;
> Aktas, Erdem ; Yao, Jiewen ;
> Xu, Min M ; Tom Lendacky
> ; Michael Rot
Hi Leif/Ard/Sami
I would expect ARM/AARCH64 maintainers to review the ARM specific files, even
they are in CryptoPkg. Please help on that.
Thank you
Yao, Jiewen
> -Original Message-
> From: Li, Yi1
> Sent: Tuesday, November 7, 2023 10:39 AM
> To: Pierre Gondois ; devel@ed
from anyone who can be trusted by the
maintainer.
That is based upon the current situation - anyone can be a reviewer just
because they want to be CCed and has no expectation to review the code.
Restricting R-B from a reviewer does not make sense to me.
Thank you
Yao, Jiewen
> -Original Mess
iner may ask the reviewer to provide feedback, right?
Those are more than just CCed.
Thank you
Yao, Jiewen
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, October 30, 2023 1:23 AM
> To: Yao, Jiewen ; j...@linux.ibm.com; Laszlo Ersek
> ; devel@edk2.groups.io; p
is no expectation that he/she would
review the patch?
I would like to understand more on how that works and what that means.
Would you please give a URL for the reviewer definition in Linux Kernel?
Thank you
Yao, Jiewen
> -Original Message-
> From: James Bottomley
> Sent: Mond
about.gitlab.com/topics/version-control/what-is-code-review/
Our definition seems more like *a notification receiver*, instead of a real
code reviewer.
I would say, it is a very misleading definition.
Thank you
Yao, Jiewen
> -Original Message-
> From: Laszlo Ersek
> Sent: Sunday,
ot;, although he has no such title.
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Sunday, October 29, 2023 10:17 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Andrew Fish ; Leif Lindholm ;
> Warkentin, A
merge, even if it pass
review.
Otherwise, once the review passed, the maintainer may merge it.
I don't think that is the intention.
Thank you
Yao, Jiewen
> -Original Message-
> From: Tan, Dun
> Sent: Friday, October 27, 2023 2:32 PM
> To: Yao, Jiewen ; devel@edk2.groups.
HI
Since this impact TDX and SEV, would you please let me know what kind of test
you have done?
Have you validated TDX and SEV before you submit the patch? Please describe
that clearly in your patch description.
Also please include AMD SEV reviewer in this patch series.
Thank you
Yao, Jiewen
Acked-by: Jiewen Yao
> -Original Message-
> From: Taylor Beebe
> Sent: Saturday, August 5, 2023 3:47 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Gerd
> Hoffmann
> Subject: [PATCH v4 04/14] OvmfPkg: Add ImageProp
Acked-by: Jiewen Yao
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, September 19, 2023 10:33 PM
> To: devel@edk2.groups.io
> Cc: Anatol Belski ; Anthony Perard
> ; Gerd Hoffmann ; Jianyong
> Wu ; Yao, Jiewen ; Justen,
> Jordan L ;
, a malicious QEMU MAY purposely
downgrade the protection in CC use case. In order to detect such scenario, the
QEMU configuration MUST be measured. Is that done in this patch set?
Thank you
Yao, Jiewen
> -Original Message-
> From: Taylor Beebe
> Sent: Monday, October 9, 2023 8:07 AM
&g
cannot nail down shortly, that would be next next week.
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Wednesday, September 27, 2023 4:39 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] setting TLS
I am OK for the RISC-V change.
Would you please let me know why we need openssl submodule ?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Andrei
> Warkentin
> Sent: Tuesday, September 19, 2023 12:43 PM
> To: devel@edk2.groups.io
> Cc: Warkentin, Andrei ; Li, Yong
> ;
Thanks Laszlo for the detail explanation, appreciate that.
I hope people will take action when it is close to 16MiB, then.
Anyway, I am OK with this so far.
Acked-by: Jiewen Yao
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, September 12, 2023 11:36 PM
> To:
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Liu, Linus
> Sent: Tuesday, September 12, 2023 9:42 AM
> To: devel@edk2.groups.io
> Cc: Liu, Linus ; Zhang, Qi1 ; Kumar,
> Rahul R ; Yao, Jiewen ; Chen,
> Tina ; Chen, Xiao X
> Subject: [PATCH v3] Pyrit
16MiB ? More than 128MiB?
Thank you
Yao, Jiewen
> -Original Message-
> From: Ard Biesheuvel
> Sent: Tuesday, September 12, 2023 10:59 PM
> To: Laszlo Ersek
> Cc: devel@edk2.groups.io; Ard Biesheuvel ; Gerd
> Hoffmann ; Yao, Jiewen ; Justen,
> Jordan L
> Subject: Re
1 - 100 of 1351 matches
Mail list logo
