Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-19 Thread Nate DeSimone
Hi Chasel, Please update the comments for the TempRamExit() function declaration to include all of the FSP specification allowed return values: EFI_SUCCESS - FSP execution environment was initialized successfully. EFI_INVALID_PARAMETER - Input parameters are invalid. EFI_UNSUPPORTED - The FSP

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Chiu, Chasel
t; Cc: Desimone, Nathaniel L ; Zeng, Star > > Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. > > And the 'Ppi' postfix seems not needed in the file name. > > Thanks, > Star > > > -Original Message- > > From: devel@edk2.groups.io [mailt

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
imone, Nathaniel L ; Zeng, Star > > Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h. > > Hi Chasel, > > Two minor feedbacks. > > 1. The spec defines the return status below, should we follow it? > > EFI_SUCCESS FSP execution environment was initial

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
Hi Chasel, Two minor feedbacks. 1. The spec defines the return status below, should we follow it? EFI_SUCCESS FSP execution environment was initialized successfully. EFI_INVALID_PARAMETER Input parameters are invalid. EFI_UNSUPPORTED The FSP calling conditions were not met. EFI_DEVICE_ERROR

[edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-14 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883 Add header file for FSP_TEMP_RAM_EXIT_PPI which is defined by FSP 2.1 spec. Test: Build successfully. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 50