Re: [edk2-devel] [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-18 Thread Chiu, Chasel
Thanks Nate! I have sent V2 accordingly, please help to review again. > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, July 18, 2022 4:53 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Oram, Isaac W ; Gao, Liming > ; Dong, Eric > Subject: RE: [PATCH 0/2]

Re: [edk2-devel] [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-18 Thread Nate DeSimone
Hi Chasel, Please change the function signature for CallFspWrapperResetSystem() to take a EFI_STATUS as input. UINTN is certainly better than UINT32, but the actual data type defined in the FSP specification is EFI_STATUS. Also, that is the data type that FspmWrapperPeim.c and

Re: [edk2-devel] [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-18 Thread Oram, Isaac W
Series Reviewed-by: Isaac Oram -Original Message- From: Chiu, Chasel Sent: Monday, July 18, 2022 3:13 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric Subject: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64

[edk2-devel] [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-18 Thread Chiu, Chasel
FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on the build and this patch series extended the support for 64bit build. Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Chasel Chiu Chasel Chiu (2): MinPlatformPkg/FspWrapper: FspResetType