Re: [edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-18 Thread Liming Gao
Bob: I think these two C tools are only verified for IA32 and X64 arch OS. They may not work on ARM or AARCH64 OS. Once they are added into BaseTools C Makefile, they may cause compile failure on ARM or AARCH64 OS. So, I suggest to move them into edk2-platforms/Platform/Intel/Tools directory

Re: [edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-17 Thread Bob Feng
Adding FMMT, FCE to BaseTools is fine for me. The patch is good to me. Reviewed-by: Bob Feng -Original Message- From: Zhang, Shenglei Sent: Tuesday, June 11, 2019 1:23 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to

[edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-10 Thread Zhang, Shenglei
REF:FMMT(https://bugzilla.tianocore.org/show_bug.cgi?id=1847) FCE(https://bugzilla.tianocore.org/show_bug.cgi?id=1848) Changes are committed in forked repository: https://github.com/shenglei10/edk2/commits/movetool FCE & FMMT tools are in https://firmware.intel.com/develop Intel UEFI tools