Hi Leif,
Yes, that's a Reviewed-by.
Thanks.
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, April 29, 2020 7:16 PM
> To: Loh, Tien Hock
> Cc: Pankaj Bansal ; Ard Biesheuvel
> ; Gaurav Jain ; Meenakshi
> Aggarwal ; devel@edk2.groups.io; Haojian
> Zhuang ; Varun Sethi
>
Hi Tien Hock,
Can I take that as a Reviewed-by:?
Regards,
Leif
On Wed, Apr 29, 2020 at 05:17:18 +, Loh, Tien Hock wrote:
> Hi Ard,
>
> I have checked the patch and it looks good.
>
> However, I can no longer test the patch as the new DwMmc driver no longer
> uses the protocol.
> Sorry
Hi Ard,
I have checked the patch and it looks good.
However, I can no longer test the patch as the new DwMmc driver no longer uses
the protocol.
Sorry for the delay, I initially thought I can test it until I investigated
further today.
Thanks
> -Original Message-
> From: Pankaj
+ Meenakshi
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, April 6, 2020 7:42 PM
> To: Leif Lindholm ; Gaurav Jain
> Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian
> Zhuang ; Loh, Tien Hock
> Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer
> Limit
Hi Gaurav,
Haojian, Tien Hock - can you help review/test this change?
Best Regards,
Leif
On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote:
> Moved BlockCount calculation below BufferSize Validation checks.
> First Ensure Buffersize is Not Zero and multiple of Media BlockSize.
> then
Moved BlockCount calculation below BufferSize Validation checks.
First Ensure Buffersize is Not Zero and multiple of Media BlockSize.
then calculate BlockCount and perform Block checks.
Corrected BlockCount calculation, as BufferSize is multiple of BlockSize,
So adding (BlockSize-1) bytes to
