y ; Dong, Eric ; Ni, Ray
> ; Kumar, Rahul1 ; nd
>
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
> Hi Jiewen,
>
> I agree using CC as in (EFI_CC_MEASUREMENT_PROTOCOL) would be much
> clearer.
>
&
Dong, Eric ; Ni, Ray
> ; Kumar, Rahul1
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
> On 10/28/21 10:52 AM, Yao, Jiewen wrote:
> > Thanks Brijesh.
> >
> &
On Fri, Oct 29, 2021 at 07:51:13AM +, Xu, Min M wrote:
> On October 29, 2021 12:53 PM, Gerd Hoffmann wrote:
> > On Fri, Oct 29, 2021 at 12:17:05AM +, Yao, Jiewen wrote:
> > > I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace
> > > EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO)
>
On October 29, 2021 12:53 PM, Gerd Hoffmann wrote:
> On Fri, Oct 29, 2021 at 12:17:05AM +, Yao, Jiewen wrote:
> > I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace
> > EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO)
>
> Looks good to me. The PCD uses the term ConfidentialComputing t
On Fri, Oct 29, 2021 at 12:17:05AM +, Yao, Jiewen wrote:
> I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace
> EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO)
Looks good to me. The PCD uses the term ConfidentialComputing too,
so using that or 'CC' as shortcut consistently everywher
s weird to me, btw. :(
>>> Like Brijesh, I worry about confusion with the ARM TEE feature. Maybe just
>>> CC then?
>>>
>>> Thanks,
>>> Tom
>>>
>>>> Thank you
>>>> Yao Jiewen
>>>>
>>>>> -Origi
ky ; Brijesh Singh
> ; kra...@redhat.com; Xu, Min M
> ; sami.muja...@arm.com
> Cc: devel@edk2.groups.io; Erdem Aktas ; James
> Bottomley ; Dong, Eric ; Ni, Ray
> ; Kumar, Rahul1
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for
.com; Xu, Min M
>
> Cc: devel@edk2.groups.io; Erdem Aktas ; James
> Bottomley ; Dong, Eric ; Ni, Ray
> ; Kumar, Rahul1
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
> On 10/28/21 10:52 AM, Yao, Jiewe
l1
Subject: Re: [edk2-devel] [PATCH V2 12/28]
UefiCpuPkg/CpuExceptionHandler:
Add base support for the #VE exception
Hi,
How about adding the tdx exception handler to the existing library, so we
don't
have the churn of adding a new library everywhere *again*?
Do you mean add the
gt; Cc: brijesh.si...@amd.com; devel@edk2.groups.io; Erdem Aktas
> ; James Bottomley ; Tom
> Lendacky ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul1
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
>
>
riginal Message-
From: kra...@redhat.com
Sent: Wednesday, October 27, 2021 3:20 PM
To: Xu, Min M
Cc: Brijesh Singh ; Yao, Jiewen
; devel@edk2.groups.io; Erdem Aktas
; James Bottomley ; Tom
Lendacky ; Dong, Eric ; Ni,
Ray ; Kumar, Rahul1
Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExcept
On Thu, Oct 28, 2021 at 02:07:58AM +, Yao, Jiewen wrote:
> Besides VmgExitLib -
> https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Include/Library/VmgExitLib.h
>
> We have another potential issue - MemEncryptSevLib -
> https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Libr
ong, Eric
> ; Ni, Ray ; Kumar, Rahul1
>
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
> Hi Gerd
> I tend to agree with you on the direction to use one TEE specific Exception
> lib.
>
> Ho
t; ; James Bottomley ; Tom
> Lendacky ; Dong, Eric ; Ni,
> Ray ; Kumar, Rahul1
> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler:
> Add base support for the #VE exception
>
> Hi,
>
> > > How about adding the tdx exception handler to the existing lib
Hi,
> > How about adding the tdx exception handler to the existing library, so we
> > don't
> > have the churn of adding a new library everywhere *again*?
> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in
> CpuExceptionHandlerLib, then include the corresponding source file in eac
On October 26, 2021 6:25 PM, Gerd Hoffmann wrote:
> Hi,
>
> > > > So it has to be implemented inside the exception lib.
> > >
> > > Well, no, you can also change the code to avoid triggering an exception.
> > >
> > > Adding a new lib for the exception means the lib must be added into
> > > each
Hi,
> > > So it has to be implemented inside the exception lib.
> >
> > Well, no, you can also change the code to avoid triggering an exception.
> >
> > Adding a new lib for the exception means the lib must be added into each
> > and every *.dsc file (either the tdx impl or the null variant),
On October 26, 2021 2:12 PM, Gerd Hoffmann wrote:
> On Tue, Oct 26, 2021 at 05:06:21AM +, Xu, Min M wrote:
> > On October 12, 2021 6:27 PM, Gerd Hoffmann wrote:
> > > > + if (ExceptionType == VE_EXCEPTION) {
> > > > +EFI_STATUS Status;
> > > > +//
> > > > +// #VE needs to be handl
On Tue, Oct 26, 2021 at 05:06:21AM +, Xu, Min M wrote:
> On October 12, 2021 6:27 PM, Gerd Hoffmann wrote:
> > > + if (ExceptionType == VE_EXCEPTION) {
> > > +EFI_STATUS Status;
> > > +//
> > > +// #VE needs to be handled immediately upon enabling exception
> > > handling
> > > +
On October 12, 2021 6:27 PM, Gerd Hoffmann wrote:
> > + if (ExceptionType == VE_EXCEPTION) {
> > +EFI_STATUS Status;
> > +//
> > +// #VE needs to be handled immediately upon enabling exception handling
> > +// and therefore can't use the RegisterCpuInterruptHandler() interface.
>
Hi,
> + if (ExceptionType == VE_EXCEPTION) {
> +EFI_STATUS Status;
> +//
> +// #VE needs to be handled immediately upon enabling exception handling
> +// and therefore can't use the RegisterCpuInterruptHandler() interface.
Can please you explain in more detail why this is the
RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Add base support to handle #VE exceptions. Update the common exception
handlers to invoke the VmTdExitHandleVe () function of the VmTdExitLib
library when a #VE is encountered. A non-zero return code will propagate
to the targeted exception
22 matches
Mail list logo
