Re: [edk2-devel] [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h

2022-04-19 Thread Gerd Hoffmann
Hi, > As the first step CC_GUEST_TYPE is defined in this patch. In the > next patch GUEST_TYPE will be deleted. This is to make sure the > bisect work correctly. Hmm, what exactly went wrong? Splitting into two patches looks pointless. If the change is too big for an all-in-one patch typical

Re: [edk2-devel] [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h

2022-04-18 Thread Min Xu
On April 18, 2022 9:48 PM, Tom Lendacky wrote: > > +// > > +// Confidential computing guest type > > +// > > +typedef enum { > > + CCGuestTypeNonEncrypted = 0, > > + CCGuestTypeAmdSev, > > + CCGuestTypeIntelTdx, > > +} CC_GUEST_TYPE; > > Should these be CcGuest... ? The precedent seems to be

Re: [edk2-devel] [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h

2022-04-18 Thread Lendacky, Thomas via groups.io
On 4/16/22 22:01, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902 The confidential computing guest type (GUEST_TYPE) was defined in OvmfPkg/Include/WorkArea.h. Now it is to be moved to MdePkg/Include/ConfidentialComputingGuestAttr.h and renamed as CC_GUEST_TYPE. There are

[edk2-devel] [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h

2022-04-16 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3902 The confidential computing guest type (GUEST_TYPE) was defined in OvmfPkg/Include/WorkArea.h. Now it is to be moved to MdePkg/Include/ConfidentialComputingGuestAttr.h and renamed as CC_GUEST_TYPE. There are 2 reasons for this change. 1.