Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-02-04 Thread Rebecca Cran
On 1/31/22 04:42, Ard Biesheuvel wrote: On Mon, 31 Jan 2022 at 00:22, Ard Biesheuvel wrote: I've had a stab at refactoring this code. Branch can be found here: https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor OK, I've did some more work on this, and ended up with a

Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-01-31 Thread Ard Biesheuvel
On Mon, 31 Jan 2022 at 00:22, Ard Biesheuvel wrote: > > On Sun, 30 Jan 2022 at 11:44, Ard Biesheuvel wrote: > > > > Hello Rebecca, > > > > On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > > > > > Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in > > > favor of a new

Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-01-30 Thread Ard Biesheuvel
On Sun, 30 Jan 2022 at 11:44, Ard Biesheuvel wrote: > > Hello Rebecca, > > On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > > > Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in > > favor of a new Mpidr field. Update code in > > ArmPlatformPkg/PrePeiCore/MainMPCore

Re: [edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2022-01-30 Thread Ard Biesheuvel
Hello Rebecca, On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in > favor of a new Mpidr field. Update code in > ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c > to use the new field and call

[edk2-devel] [PATCH v3 1/4] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2021-12-15 Thread Rebecca Cran
Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in favor of a new Mpidr field. Update code in ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c to use the new field and call new macros GET_MPIDR_AFF0 and GET_MPIDR_AFF1 instead. Signed-off-by: Rebecca