Re: [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-19 Thread Michael D Kinney
Hi Jordan, Thank you for the reviews. I have addressed the two issues you raised in my local branch and I verified that the lldbefi.py script behaves the same after breaking up the long line. Best regards, Mike > -Original Message- > From: Justen, Jordan L > Sent: Sunday, August 18,

Re: [edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-18 Thread Jordan Justen
On 2019-08-16 17:57:04, Michael D Kinney wrote: > > Andrew Fish (7): > EmulatorPkg/Unix/Host: Disable inline/optimizations Maybe add XCODE5 in commit message subject? Acked-by: Jordan Justen > EmulatorPkg: Fix XCODE5 lldb issues There was another long line in the

[edk2-devel] [Patch V5 00/11] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config

2019-08-16 Thread Michael D Kinney
New in V5 = * Update author to be Andrew Fish for XCODE5 fixes * Split patch #7 into two patches * Break up long line in build.sh into multiple lines New in V4 (Resolve XCODE5 issues) == * Disable inline if SecGdbScriptBreak() for XCODE5 issues * Disable