Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-21 Thread Leif Lindholm
On Sun, Feb 21, 2021 at 21:50:20 +0100, Ard Biesheuvel wrote: > On Sun, 21 Feb 2021 at 21:43, Leif Lindholm wrote: > > > > On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote: > > > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > > > > > > > *How* annoying was this? > > > > > > >

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-21 Thread Ard Biesheuvel
On Sun, 21 Feb 2021 at 21:43, Leif Lindholm wrote: > > On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote: > > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > > > > > *How* annoying was this? > > > > > > This is kind of useful information, well at the "would be good to see > > >

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-21 Thread Leif Lindholm
On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote: > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > > > *How* annoying was this? > > > > This is kind of useful information, well at the "would be good to see > > in a regular DEBUG build" level. > > > > This change will have

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-21 Thread Ard Biesheuvel
On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > *How* annoying was this? > > This is kind of useful information, well at the "would be good to see > in a regular DEBUG build" level. > > This change will have suddenly effectively hidden a message that was > already present in many

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Samer El-Haj-Mahmoud
Leif, I admit, this is not *super* annoying on a normal DEBUG build boot. On the RPi4 for instance, this shows up between 25-50 times until the OS boots (depending on the boot source). On a test run (such as running SCT), this message is *EXTREMLY* annoying. I see ~6600 instances on one run,

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Leif Lindholm
*How* annoying was this? This is kind of useful information, well at the "would be good to see in a regular DEBUG build" level. This change will have suddenly effectively hidden a message that was already present in many platforms, where they were not (very) annoyingly repetitive during a normal

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Samer El-Haj-Mahmoud
: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity > > On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud mahm...@arm.com> wrote: > > > > the DEBUG message for using compilation time epoch is appear

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Ard Biesheuvel
On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud wrote: > > the DEBUG message for using compilation time epoch is appearing very > frequently on DEBUG firmware builds, for example during UEFI SCT runs. > Reduce verbosity to avoid the annoying repetitive message. > > Cc: Ard Biesheuvel > Cc:

[edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Samer El-Haj-Mahmoud
the DEBUG message for using compilation time epoch is appearing very frequently on DEBUG firmware builds, for example during UEFI SCT runs. Reduce verbosity to avoid the annoying repetitive message. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud ---

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Ard Biesheuvel
; To: Samer El-Haj-Mahmoud ; Pete > > Batard > > > ; devel@edk2.groups.io; Leif Lindholm > > > > > > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] > > > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message > > v

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity

2021-02-20 Thread Samer El-Haj-Mahmoud
ndholm ; Samer El-Haj- > Mahmoud > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity > > resent > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Wednesday, January 6,