Hello,
Thanks for all your valuable feedbacks, I have sent V4 to incorporate all of
them, please help to review.
Thanks,
Chasel
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 8, 2021 2:43 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Oram, Isaac W
> ;
The "VariableReadLib.*BaseVariableReadLibNull.inf" belongs in
edk2-platforms\Platform\Intel\MinPlatformPkg\Include\Dsc\CorePeiLib.dsc. The
purpose of the common include is so we can make the same change in one place,
not every board port DSC file. Board ports should be exceptions to the basic
Hi Chasel,
There is one minor thing I found,
MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryConfig.c needs to be
updated to use LargeVariableLib as well since the PEI code is now using it.
Other than that the change look's good!
Thanks,
Nate
> -Original Message-
> From: Chiu,
Reviewed-by: Kathappan Esakkithevar
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, October 8, 2021 12:13 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Oram, Isaac W
> ; Desimone, Nathaniel L
> ; Luo, Heng ;
> Jeremy Soller ; Benjamin Doron
> ; Chaganty, Rangasai V
> ;
V3:
Fix another GCC build failure.
V2:
Fix GCC build failures.
V1:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly
and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
Also added
