Re: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-11-02 Thread Chaganty, Rangasai V
Thanks for incorporating the feedback. Few more minor comments based on the new patch: 1. The description of "DieIndex" perhaps should be modified to " Index of the die in the package" to make it more apt. 2. The description of "DieId" perhaps should be modified to " Unique ID specific to the

Re: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-26 Thread Maciej Czajkowski
Hi Ray, Sai, Could you take a look on this patch? Pasting below questions and answers from previous patch for a reference. What's the difference between SOC and CPU? SOC die differs from typical CPU die in Intel's chiplet design. What the purpose of "DieIndex"? We want to have an indication

[edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-18 Thread Maciej Czajkowski
Added IntelDieInfoProtocol header into IntelSiliconPkg tree. The purpose is to have generic and unified interface for getting information about dies installed in the system. It will be implemented by silicon code. Change-Id: Iedc414d435c27f37e6f12e7affd046a0a9e7e19d Cc: Ray Ni Cc: Rangasai V