*** Add BaseCryptLibMbedTls for CryptoPkg, which can be an alternative to
OpenSSL in some scenarios. There are four features in the patch:
HMAC/HKDF/RSA/HASH.***
Wenxing Hou (9):
CryptoPkg: Add mbedtls submodule for EDKII
CryptoPkg: Add mbedtls_config and MbedTlsLib.inf
CryptoPkg: Add
Add mbedtls 3.3.0 as submodule in CryptoPkg.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.gitmodules | 3 +++
CryptoPkg/Library/MbedTlsLib/mbedtls | 1 +
2 files
Reviewed-by: Jayaprakash N
Regards,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Monday, August 28, 2023 4:01 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D ; Kloper, Dimitry
Subject: [edk2-devel] [edk2-libc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=983
>From the bug description:
Analysis and root cause
After some investigation and debugging I have figured out the following:
The following function is implemented in file edk2/StdLib/EfiSocketLib/Tcp4.c
VOID
This patch fixes the issue reported in BZ given below:
https://bugzilla.tianocore.org/show_bug.cgi?id=983
Patch extracted from PR https://github.com/tianocore/edk2-libc/pull/7
Jayaprakash N (1):
edk2-libc: Socket completion functions are not called on Linux
Compilation
Cran ;
Kinney, Michael D ; Kloper, Dimitry
Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib: Fix console jump
to 0, 0 issue in lseek()
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4531
Python code opens console file descriptor and uses lseek() with position == 0
and SEEK_CUR
On Thu, Aug 24, 2023 at 5:34 PM Jayaprakash, N wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4531
>
> Python code opens console file descriptor and uses lseek()
> with position == 0 and SEEK_CUR as
> 'do nothing, check console is alive' operation.
>
> Current implementation of
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4531
Python code opens console file descriptor and uses lseek()
with position == 0 and SEEK_CUR as
'do nothing, check console is alive' operation.
Current implementation of daConsole ignores whence argument,
this is wrong in case lseek(0,
This patch fixes a corner case issue with the lseek function.
The issue is captured in
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4531
Jayaprakash N (1):
edk2-libc/StdLib: Fix console jump to 0, 0 issue in lseek()
StdLib/LibC/Uefi/Devices/Console/daConsole.c | 10 +-
1 file
NT_FW_CONFIG DTB contains platform information passed by
Tf-A boot stage.
This information is used for Virtual memory map generation
during PEI phase and passed on to DXE phase as a HOB, where
it is used in ConfigurationManagerDxe.
This patch adds a PEI to parse NT_FW_CONFIG and pass it to
other
[AMD Official Use Only - General]
Please see my answers inline.
> -Original Message-
> From: disc...@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Wednesday, August 23, 2023 1:54 AM
> To: Chang, Abner
> Cc: disc...@edk2.groups.io; devel@edk2.groups.io
>
Thanks for the answer!
I was a little bit confused about the part, that in the same package I
actually need to provide different library implementations for the
same 'ManageabilityTransportLib', thanks for the clarification!
I think your DSC example should go into the package documentation.
As
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jayaprakash, N
> Sent: Monday, August 21, 2023 8:22 PM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D ;
> Kloper, Dimitry
> Subject: [edk2-libc Patch 1/1] edk2-libc/StdLib: file
[AMD Official Use Only - General]
Hi Aladyshev,
We use library class to specify the desire transport interface for the
management protocol, such as MCTP, PLDM and IPMI. This way we can flexibly
support any transport interface for the management protocol.
Here is the example of using
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4529
rename() call leads to a function that makes open() for source file
to be renamed. The resulting file descriptor is never closed.
If you have to rename a couple of files this will quickly exhaust
the descriptor table.
The fix is trivial -
This patch provides fix for the file descriptor leak issue in
rename function from the LibC library of the StdLib of edk2-libc
Jayaprakash N (1):
edk2-libc/StdLib: file descriptor leak in rename()
StdLib/LibC/Uefi/Devices/UefiShell/daShell.c | 2 ++
1 file changed, 2 insertions(+)
--
Reviewed-by: Heng Luo
> -Original Message-
> From: Li, Yi1
> Sent: Thursday, August 17, 2023 3:10 PM
> To: devel@edk2.groups.io
> Cc: Sheng, W ; Gao, Zhichao ;
> Luo, Heng ; Li, Yi1
> Subject: [edk2-staging/crypto-new-api][PATCH] CryptoPkg/OpensslLib:
> Upgrade OpenSSL to 1.1.1u
>
>
From: Sheng Wei
(cherry-pick from: master b2de9ec5a759aa4a7ac029cda9079dce077bf856)
Cc: Zhichao Gao
Cc: Heng Luo
Signed-off-by: Yi Li
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 -
CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 1 -
CryptoPkg/Library/OpensslLib/openssl
Hi Arun,
When I apply these changes in intel platform, I will hit some "warning treated
as error" issues, so I file a bug in tianocore:
https://bugzilla.tianocore.org/show_bug.cgi?id=4522
Could you please help to check it?
Thanks!
Best Regards,
Yanbo Huang
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Reviewed-by: Chao Li
Thanks,
Chao
在 2023/8/10 15:05, xianglai 写道:
Adding a reference to AcpiPlatformLib to the dsc file
as loongarch is used to fix compilation errors.
Cc: Ard Biesheuvel
Cc: Bibo Mao
Cc: Chao Li
Cc: Leif Lindholm
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: xianglai li
https://bugzilla.tianocore.org/show_bug.cgi?id=4461
1. The function GetRandomNumber128() returns a boolean TRUE/FALSE.
The existing code was getting data in EFI_STATUS.0==FALSE==EFI_SUCCESS
Updated code to check for the return value before proceeding further.
2. The 'seed' from the
Adding a reference to AcpiPlatformLib to the dsc file
as loongarch is used to fix compilation errors.
Cc: Ard Biesheuvel
Cc: Bibo Mao
Cc: Chao Li
Cc: Leif Lindholm
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: xianglai li
---
Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 1 +
1
Gao, Liming ; Dong,
> Eric
> Subject: RE: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP
> 2.4 MultiPhase library.
>
> Is the FSP 2.4 specification available publicly? It is hard to understand the
> impact of this without referencing the specification. From the FSP page on
Reviewed-by: Jayaprakash Nevara
-Original Message-
From: R, Vishal
Sent: Thursday, August 3, 2023 10:12 PM
To: devel@edk2.groups.io
Cc: R, Vishal ; Rebecca Cran ; Kinney,
Michael D ; Jayaprakash, N
Subject: [edk2-libc Patch 1/1] edk2-libc/AppPkg: Fix documentation issue with
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4517
This commit fixes the API documentation issue reported via the BZ4517
Updated documentation strings for rdmsr() and wrmsr()
Cc: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Vishal R
---
This patch contains fix for edk2 module documentation issue
Vishal R (1):
edk2-libc/AppPkg: Fix documentation issue with edk2module.c
.../PyMod-3.6.8/Modules/edk2module.c | 28 +++
1 file changed, 23 insertions(+), 5 deletions(-)
--
2.39.1.windows.1
Pushed as 3037c13015016f7c398da37eabe33fb0961dc490
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107473):
Pushed as 421e64019d4622b049f510ba8eef7c82fba7b32d
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107472):
Pushed as e563c1c528f15d4224103f5c49559df620b5a655
Note I fixed PatchCheck.py issues and committed in an order that doesn't break
git bisect.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107471):
Reviewed-by: Isaac Oram
-Original Message-
From: Arun K
Sent: Tuesday, July 25, 2023 8:36 AM
To: devel@edk2.groups.io; Arun K
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Ramkumar Krishnamoorthi ;
Gao, Liming
Subject: [edk2-devel][edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Arun K via
groups.io
Sent: Tuesday, July 25, 2023 8:37 AM
To: devel@edk2.groups.io; Arun K
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Ramkumar Krishnamoorthi ;
Gao, Liming
Subject: [edk2-devel][edk2
Hi Pedro Falcato,
At 2023-07-31 17:15:20, "Pedro Falcato" wrote:
>On Mon, Jul 31, 2023 at 4:25 AM wangy wrote:
>>
>> From: Yang Wang
>>
>> The EFI spec (see UEFI 2.10, 24.1.12) requires
>> EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus pointers
>> by not reading nor clearing the
On Mon, Jul 31, 2023 at 4:25 AM wangy wrote:
>
> From: Yang Wang
>
> The EFI spec (see UEFI 2.10, 24.1.12) requires
> EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus pointers
> by not reading nor clearing the interrupt status from the device.
>
> However, EmacGetDmaStatus (part of
Reviewed-by: Jayaprakash N
Regards,
JP
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Wednesday, July 26, 2023 9:09 PM
To: devel@edk2.groups.io
Cc: Jayaprakash, N ; Rebecca Cran ;
Kinney, Michael D ; Kloper, Dimitry
Subject: [edk2-devel] [edk2-libc
Hi Pedro Falcato,
At 2023-07-29 03:40:15, "Pedro Falcato" wrote:
>On Fri, Jul 28, 2023 at 5:00 AM wangy wrote:
>>
>> From: Yang Wang
>>
>> If IrqStat is NULL, the interrupt status will not be
>> read from the device.When the interrupt status is read,
>> it will also be cleared.
>
>Let's
From: Yang Wang
The EFI spec (see UEFI 2.10, 24.1.12) requires
EFI_SIMPLE_NETWORK.GetStatus() to handle NULL InterruptStatus pointers
by not reading nor clearing the interrupt status from the device.
However, EmacGetDmaStatus (part of the DwEmacSnpDxe GetStatus()
implementation) did not
On Fri, 28 Jul 2023 at 21:40, Pedro Falcato wrote:
>
> On Fri, Jul 28, 2023 at 5:00 AM wangy wrote:
> >
> > From: Yang Wang
> >
> > If IrqStat is NULL, the interrupt status will not be
> > read from the device.When the interrupt status is read,
> > it will also be cleared.
>
> Let's improve the
On Fri, Jul 28, 2023 at 5:00 AM wangy wrote:
>
> From: Yang Wang
>
> If IrqStat is NULL, the interrupt status will not be
> read from the device.When the interrupt status is read,
> it will also be cleared.
Let's improve the commit message a bit, something like:
The EFI spec (see UEFI 2.10,
From: Yang Wang
If IrqStat is NULL, the interrupt status will not be
read from the device.When the interrupt status is read,
it will also be cleared.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Ran Wang
Signed-off-by: Yang Wang
---
.../Drivers/DwEmacSnpDxe/EmacDxeUtil.c| 22
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library. It depends
on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not
initialized.
Depending on compiler and build
This patch contains a fix for the uninitialized global variable
in edk2-libc/StdLib/BsdSocketLib/res_init.c
Jayaprakash N (1):
edk2-libc/StdLib: Fix uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.40.0.windows.1
On 25/07/2023 17:07, Jayaprakash, N wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library. It depends
on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library. It depends
on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not
initialized. Depending on compiler and build
This patch contains the fix for uninitialized global variable
in edk2-libc/StdLib/BsdSocketLib/res_init.c file.
Jayaprakash N (1):
edk2-libc/StdLib: Fix uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--
Created IpmiTransport2 PPI/Protocol to support multiple
IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's
IpmiSubmitCommand2 & IpmiSubmitCommand2Ex.
IpmiSubmitCommand2 - This API use the default interface
(PcdDefaultSystemInterface) to send IPMI command.
IpmiSubmitCommand2Ex - This
Created IpmiTransport2 PPI/Protocol to support multiple
IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's
IpmiSubmitCommand2 & IpmiSubmitCommand2Ex.
IpmiSubmitCommand2 - This API use the default interface
(PcdDefaultSystemInterface) to send IPMI command.
IpmiSubmitCommand2Ex - This
Reviewed by : Jayaprakash N
-Original Message-
From: devel@edk2.groups.io On Behalf Of Jayaprakash, N
Sent: Friday, July 21, 2023 9:22 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Rebecca Cran ; Kloper, Dimitry
; Kloper, Dimitry
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1
Hi Mike,
I was trying to explore with Co-authored-by tag as I simplified the patch with
minor edits.
If it doesn't work I shall remove it.
I noticed after sending the patch. So I have sent V2 patch by removing the , in
the names.
I will go ahead and merge this change.
Regards,
JP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library.
It depends on global _res variable containing a state.
The problem is that if __BIND_RES_TEXT macro is not defined, _res is not
initialized.
Depending on compiler and build
This patch has fix for un-initialized global variable in the
edk2-libc repos StdLib/BsdSocketLib.
Jayaprakash N (1):
edk2-libc/StdLib: Uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.40.0.windows.1
Hi JP,
I have not seen co-authored-by tag used before.
If Dimitry is the author, then please update git commit so
Dimitry is the author and remove that tag.
Also, please make sure that names do not contain ','.
Should be: Dimity Kloper
Thanks,
Mike
> -Original Message-
> From:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4506
res_init() is called from different places in sockets library. It depends
on global _res variable containing a state. The problem is that
if __BIND_RES_TEXT macro is not defined, _res is not initialized.
Depending on compiler and build
This patch has fix for un-initialized global variable in the edk2-libc repos
StdLib/BsdSocketLib.
Jayaprakash N (1):
edk2-libc/StdLib: Uninitialized global variable
StdLib/BsdSocketLib/res_init.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--
2.40.0.windows.1
On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote:
>
> The patch is upstreamed by:
> https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4
Checking the memory map for memory below 4G only makes sense if the
system has no IOMMU and does not use translation
The patch is upstreamed by:
https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107101): https://edk2.groups.io/g/devel/message/107101
Mute This Topic:
John,
The UEFI Forum (https://uefi.org/) is the industry trade group that owns the
UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools
Thanks,
Andrew Fish
> On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io
> wrote:
>
> Hello,
>
> I am John Sellock, an
Hello,
I am John Sellock, an Associate Software Engineering Technician at Leonardo
DRS.
I believe I need Self-Certification Test source code for UEFI 2.5, but I
cannot find any saved archive for it available in the tianocore or edk2-test
repositories.
I would appreciate if someone could point
Hi Chris,
Prior to FF-A, an impdef structure populated by TF-A was passed to a
SPM_MM based StMM SP. The data structures used for this are
EFI_SECURE_PARTITION_BOOT_INFO and EFI_SECURE_PARTITION_CPU_INFO.
With FF-A, we have reduced the amount of information that is passed
e.g. the per-cpu
Should |EFI_FFA_PART_INFO_DESC be packed since its used across an ABI?
Also there are a few immediately actionable TODO's in this commit.
|
|-Chris
|
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
Might as well use MAKE_FFA_VERSION from ArmFfaSvc.h for consistency.
-Chris
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for querying whether FF-A v1.1 is supported by the
FF-A impplementation.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant
Achin/Nishant, could you explain the motivation behind falling back to
device tree for some of the secure partition information? It seems like
we have this large abstraction framework using FF-A and it seems a bit
odd to have the secure partition have to directly read device tree for
some of
I had one comment , in-line.
Thanks
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch discovers the SP manifest in DT format passed by the SPMC. It
then parses it to obtain the boot
Couple of comments/questions inline (prefixed by [GM])
Thanks
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch packages requests for accessing a Standalone MM driver
through the MM
A few comments in line. (Prefixed with [GM])
Best Regards
Girish
On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote:
External email: Use caution opening links or attachments
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
Thanks for sending out the patchset!
I may be missing it, where is the StMM FF-A partition manifest as part
of this? I see where it gets parsed, but not the actual information. My
understanding, which may be flawed, is that there should be a separate
file defining the StMM manifest. Is that
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
EFI_MM_COMMUNICATION_PROTOCOL GUID that implements Standalone MM
drivers. This is done by querying the framework through
FFA_PARTITION_INFO_GET whether any
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
An FF-A partition can map only a single RX/TX buffer pair with the
framework. The DXE MM communication driver maps its pair before
ExitBootServices is called. The OS cannot re-use this pair once it boots
subsequently and loads its
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch adds support for creating a hoblist from the reduced boot
information retrieved from the SP manifest.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
For better or worse, an StMM SP can communicate with the SPM through one
of these interfaces.
1. SPM_MM interface
2. FF-A v1.0 interface
3. FF-A v1.1 interface
2) implements only minimal FF-A support. It reuses the initialisation
Would it be possible to make the stack size configurable in a way that
doesn't require an silicon/platform vendor to customize the assembly
code? Perhaps through a fixed PCD if its not problematic to do so with
the .space directive.
Thanks,
Chris
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch uses the FFA_MEM_PERM_GET/SET ABIs to tweak the permissions of a
set of pages if FF-A v1.1 and above is supported by the SPMC. For FF-A v1.0
the previous method through FFA_MSG_SEND_DIRECT_REQ/RESP is used.
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
The SPMC will pass the manifest to the StMM SP which contains the boot
information required for SP initialisation. This patch defines the data
structures defined in Section 5.4 of the FF-A v1.1 BETA0 spec to enable
this support. The
On top of Oliver's question, in the changes
to|||StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf,
we should probably leave the .ARM and .AARCH64 specifiers since that is
not an ARM specific INF.
|
-Chris
On 7/12/2023 10:21 AM, Oliver Smith-Denny wrote:
On
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
FeatureFlag type PCD flags are declared by typecasting an integer value
to BOOLEAN. These flags cannot be use in assembly code as assembler does
not recognise C primitive types. Change the flag data type from BOOLEAN
to UINT32.
Signed-off-by: Nishant
*From:* Kun Qin
*Sent:* 11 July 2023 20:22
*To:* devel@edk2.groups.io ; Nishant Sharma
*Cc:* Ard Biesheuvel ; Sami Mujawar
; Thomas Abraham ;
Sayanta Pattanayak ; Achin Gupta
; Aditya Angadi
*Subject:* Re: [edk2-devel] [edk2-platforms][PATCH V1 19/20]
ArmPkg
about the scenarios you have in
mind?
cheers,
Achin
From: Kun Qin
Sent: 11 July 2023 20:22
To: devel@edk2.groups.io ; Nishant Sharma
Cc: Ard Biesheuvel ; Sami Mujawar
; Thomas Abraham ; Sayanta
Pattanayak ; Achin Gupta ;
Aditya Angadi
Subject: Re: [edk2-devel
[AMD Official Use Only - General]
Hi Isaac, thanks for the last minutes review.
Abner
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, July 12, 2023 10:06 AM
> To: Chang, Abner ; Chesley, Brit
> ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle
> Wang
Reviewed-by: Isaac Oram
-Original Message-
From: Chang, Abner
Sent: Monday, July 10, 2023 6:36 PM
To: Chesley, Brit ; devel@edk2.groups.io
Cc: Oram, Isaac W ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang
Subject: RE: [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set
gt; To: Chesley, Brit ; devel@edk2.groups.io
> Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
> ; Nickle Wang
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg:
> Ipmi Get/Set Boot Options
>
> [AMD Official Use Only - General]
>
> Caution: This mes
, Liming
Subject: Re: [edk2-devel][edk2-platforms][PATCH V4-1] IpmiFeaturePkg:Provided
multiple IPMI interface support in PEI
Arun,
My apologies that my feedback wasn't clear enough. I would like to avoid the
preprocessor optimization step of using #if in favor of using C code and using
link time
k.py -3 on the changes and
correct the issues.
Otherwise, the code looks good.
Regards,
Isaac
-Original Message-
From: Arun K
Sent: Monday, July 3, 2023 7:43 AM
To: devel@edk2.groups.io; Arun K
Cc: Oram, Isaac W ; Desimone, Nathaniel L
; Ramkumar Krishnamoorthi ;
Gao, Liming
Subject: [edk2
Hi Nishant,
Thank you for sending out the patch. Can you please evaluate how much
effort it would be
to support the same for MmCommunicatePei? I think it would provide
better coverage for
the FFA support if we can have that change.
Thanks,
Kun
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
From: Achin Gupta
This patch packages requests for accessing a Standalone MM driver
through the MM communication protocol as FF-A direct messages.
Corresponding changes in Standalone MM Core ensure that responses are
packaged in the same way.
Signed-off-by: Achin Gupta
Co-developed-by: Aditya
From: Achin Gupta
This patch adds support for correctly receiving a request for a
Standalome MM driver service using the MM communication protocol
packaged as an FF-A direct request message.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
This patch adds support for creating a hoblist from the reduced boot
information retrieved from the SP manifest.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h
| 16 ++
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
EFI_MM_COMMUNICATION_PROTOCOL GUID that implements Standalone MM
drivers. This is done by querying the framework through
FFA_PARTITION_INFO_GET whether any partition that implements the
From: Achin Gupta
An FF-A partition can map only a single RX/TX buffer pair with the
framework. The DXE MM communication driver maps its pair before
ExitBootServices is called. The OS cannot re-use this pair once it boots
subsequently and loads its own FF-A driver. This patch ensures that the
From: Achin Gupta
This patch statically allocates an FF-A RX/TX buffer pair and registers
them with the framework. This enables discovery of the StMM SP in a
subsequent patch.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h |
From: Achin Gupta
This patch adds support for querying whether FF-A v1.1 is supported by the
FF-A impplementation.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 +++
ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
From: Achin Gupta
This patch invokes the FFA_ID_GET to obtain and stash the ID of the the
FF-A partition that implements the DXE MM communication driver. This ID
is used in subsequent patches for sending and receiving MM communication
protocol requests and responses that are packaged as FF-A
From: Achin Gupta
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
index
From: Achin Gupta
This patch skips zero sized sections in the StMM SP image e.g. .reloc since
there is no point in attempting to change their permissions.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c | 18
From: Achin Gupta
This patch copies the value of the corresponding stack variable to a global
variable so that it can be used to determine whether FF-A v1.1 or earlier
ABIs should be used for communication with the SPMC.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
This patch discovers the SP manifest in DT format passed by the SPMC. It
then parses it to obtain the boot information required to initialise the
SP.
Signed-off-by: Achin Gupta
Signed-off-by: Sayanta Pattanayak
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
For better or worse, an StMM SP can communicate with the SPM through one
of these interfaces.
1. SPM_MM interface
2. FF-A v1.0 interface
3. FF-A v1.1 interface
2) implements only minimal FF-A support. It reuses the initialisation ABI
defined by 1) and wraps the remaining
From: Achin Gupta
Add new fid for Success, error and wait. Also add macro to generate FFA
verions.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 21 +++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git
From: Achin Gupta
With FF-A v1.1, the SPMC sends a reduced amount of boot information as
compared to the original SPM implementation. For example, the stack layout,
MP information etc. This information could be accommodated in the old data
structure but this is too complicated. This patch
From: Achin Gupta
This patch uses the FFA_MEM_PERM_GET/SET ABIs to tweak the permissions of a
set of pages if FF-A v1.1 and above is supported by the SPMC. For FF-A v1.0
the previous method through FFA_MSG_SEND_DIRECT_REQ/RESP is used.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
From: Achin Gupta
The StMM SP will extract boot information from its manifest instead of a C
data structure populated by the SPM. The manifest will be passed by the
SPM. This patch includes support for libfdt to prepare for parsing the
manifest in future patches.
Signed-off-by: Sayanta
From: Achin Gupta
The SPMC will pass the manifest to the StMM SP which contains the boot
information required for SP initialisation. This patch defines the data
structures defined in Section 5.4 of the FF-A v1.1 BETA0 spec to enable
this support. The manifest is identified by the TF-A
1101 - 1200 of 12072 matches
Mail list logo
