[edk2-devel] [edk2-platforms][PATCH V1 00/20] Add the support for ARM Firmware First Framework

V1 : Following patchset add the support of ARM Firmware Framework protocol to MM communication. Following chagnes are made to enable the support 1> Changed the FFA enable flag(PcdFfaEnable) to integer to enable it use in assembly. 2> Add the support to Reserved SP stack space and program in

[edk2-devel] [edk2-platforms][PATCH V1 02/20] StandaloneMmPkg: Allocate and initialise SP stack from internal memory

From: Achin Gupta This patch removes the dependency on the SPM to allocate and initialise stack memory for the StMM SP. This is done by reserving 8K worth of memory in the StMM image at a page aligned address in the data section. Then, instead of jumping directly to the C entrypoint, an

[edk2-devel] [edk2-platforms][PATCH V1 01/20] ArmPkg: Change PcdFfaEnable flag datatype

FeatureFlag type PCD flags are declared by typecasting an integer value to BOOLEAN. These flags cannot be use in assembly code as assembler does not recognise C primitive types. Change the flag data type from BOOLEAN to UINT32. Signed-off-by: Nishant Sharma --- ArmPkg/ArmPkg.dec

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options

[AMD Official Use Only - General] Thank you Brit for the contribution! Let's wait for 1-2 days to see if there is any other comments for this change. Reviewed-by: Abner Chang > -Original Message- > From: Chesley, Brit > Sent: Tuesday, July 11, 2023 3:23 AM > To: devel@edk2.groups.io

[edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options

From: Brit Chesley BZ #: 4455. Support parameter selectors for IPMI Get/Set boot options. The size of the response data is now dependent on the parameter selector, rather than being fixed. Cc: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Signed-off-by: Brit Chesley ---

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks

; Lautner, Kenneth Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:57 PM To: devel@edk2

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib

Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:40 PM To: devel@edk2.groups.io Cc: Chiu

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks

-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks From: Michael Kubacki Adds some sanity checks around the Memory Type Information data restored from the `EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME` UEFI variable. This is particularly useful when

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib

Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, July 5, 2023 6:40 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric Subject: [edk2-devel] [edk2-platforms

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add Mem Type Info variable validity checks

From: Michael Kubacki Adds some sanity checks around the Memory Type Information data restored from the `EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME` UEFI variable. This is particularly useful when the structures that the data was saved against have changed in the latest firmware image. For

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Fix build errors in SmmVariableWriteLib

From: Michael Kubacki Commit `b71f2bd` introduced a couple build errors in VariableWritelib. This change adds the SMM Services Table (`gSmst`) and MM Services Table (`gMmst`) calls needed to register the protocol notify in the Traditional and Standalone MM services constructors. Cc: Chasel Chiu

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

@edk2.groups.io; Kinney, Michael D Cc: Xue, Gavin ; suni...@ventanamicro.com; Warkentin, Andrei ; Wang, Yimin ; Sheng, Alan Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney wrote: > > Using th

[edk2-devel] [edk2-staging][PATCH 1/1] BaseTools/Fmmt: Fix GCC warnings

GCC is throwing a warning during BaseTools compilation which leads to build errors when Wall is set. This commit removes all conditions which are always true/false(Waddress warning) and wraps one snprintf in compiler pragma to disable format-truncation warning. Cc: Bob Feng Cc: Liming Gao Cc:

[edk2-devel] [edk2 PATCH v2] MdePkg: Use same ProcessorBind guard define name

Using the same include guard define name is preferred for all CPU architecture. Cc: Kinney, Michael D Cc: Andrei Warkentin Cc: Sunil V L Cc: Yimin Wang Cc: Alan Sheng Cc: Pedro Falcato Signed-off-by: Gavin Xue --- MdePkg/Include/LoongArch64/ProcessorBind.h | 5 +++--

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

; Pedro Falcato Cc: suni...@ventanamicro.com; Warkentin, Andrei ; Wang, Yimin ; Sheng, Alan ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 Using the same include guard define name is preferred. Why was anything other than

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney wrote: > > Using the same include guard define name is preferred. > > Why was anything other than that considered? I don't see the point of making the include guard an actual part of the "API". Consumers should not depend on it being named

[edk2-devel][edk2-platforms][PATCH V4-3] IpmiFeaturePkg:Provided multiple IPMI interface support in Library

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel][edk2-platforms][PATCH V4-2] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel][edk2-platforms][PATCH V4-1] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel] edk2 NULL instance library

[AMD Official Use Only - General] Hi all, NULL instance library is commonly used as a dummy library that statically linked with a module, usually that is a no implementation to the module framework. However, do we have an document or edk2 spec that describes what is a NULL library instance and

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

Pushed as 1befeabcc8..dd09609ec9 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Friday, June 30, 2023 1:22 PM To: S, Ashraf Ali ; devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: Ni, Ray ; Chaganty, Rangasai V Subject: Re: [edk2-devel] [edk2

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

it. Regards, Isaac -Original Message- From: S, Ashraf Ali Sent: Friday, June 30, 2023 11:57 AM To: devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: RE: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbSer

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

Reviewed-by: Ashraf Ali S -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Friday, June 30, 2023 8:03 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

.@ventanamicro.com; Warkentin, Andrei > ; Wang, Yimin ; > Sheng, Alan > Subject: RE: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind > symbol define for RISCV64 > > Hi Mike, > > Thanks for your comments. > I haven't seen specific error message when using the same

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 It is better if we can use the same include guard names, but is not strictly required for builds to work. What is the specific error message seen when using the same include guard names as other CPU types? Include

[edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Non-functional cleanup

From: Michael Kubacki During a review of this driver a number of improvements were noted such as strengthening function input validation, checking return values, making debug print error levels consistent in certain code blocks, etc. These type of changes are made with no explicit change to

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

/Pragma_once Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Xue, Gavin > Sent: Thursday, June 22, 2023 2:59 AM > To: Pedro Falcato > Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Warkentin, Andrei > ; Wang, Yimin ; Sheng, > Alan >

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/SimulatorSerialPortLibPort80: Simulator serial port lib

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Wednesday, June 21, 2023 7:08 AM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) Subject: [edk2-platforms][PATCH 2/2]

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Wednesday, June 21, 2023 10:36 AM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) Subject: [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

- From: Pedro Falcato Sent: Wednesday, June 21, 2023 10:16 PM To: Xue, Gavin Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Warkentin, Andrei ; Wang, Yimin ; Sheng, Alan Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 On Fri, Jun 16, 2023

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Thu, Jun 22, 2023 at 10:59 AM Xue, Gavin wrote: > > Hi Pedro, > > Thanks for your feedback. > > The sample code what I listed in last mail is from/owned by another team, and > I didn't find other special #ifndef case for RSIC-V building so far. > RISC-V is an new processor architecture in

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Fri, Jun 16, 2023 at 4:52 PM Xue, Gavin wrote: > > Hi Sunil/Pedro, > > 1. As you know, ProcessorBind.h file of CPU Architecture file declares sets > of base types for edk2 code compiling. > So data type in edk2 code doesn't rely on specific compiler (msvc, gcc etc.), > which is a good

Re: [edk2-devel] [edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

Hi Isaac, Seems Uncrustify has not done this for IpmiFeaturePkg. Do I need to provide the changes for the complete IpmiFeaturePkg or for my changes alone fine? Sure, I will use the PCD directly instead of macros. the main concern of #if is to avoid compiler warnings when the library is not

[edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/LogoDxe: AMD Logo Driver

From: Abdul Lateef Attar Current logo INF and IDF files are used for server platform logo. Additional INF, IDF and logo image files are required for other platform usages but leverage logo source files. Set PcdAmdDisplayLogoEventGuid to change the event GUID for displaying logo. Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

From: Abner Chang Platform/AMD/AmdPlatformPkg provides the AMD edk2 common platform drivers and libraries for AMD server, client and Strategic Silicon Solutions (S3) platforms. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18

[edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/DxeAcpiSdtParserLib: ACPI SDT parser

From: Abner Chang Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 3 + .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 69 .../DxeAcpiSdtParserLib.inf | 33 ++ .../Include/Library/AmdAcpiSdtParserLib.h | 118

[edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

From: Abner Chang Platform/AMD/AmdPlatformPkg provides the AMD edk2 common platform drivers and libraries for AMD server, client and Strategic Silicon Solutions (S3) platforms. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18

[edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/SimulatorSerialPortLibPort80: Simulator serial port lib

From: Abner Chang AMD simulator port 80 serial port library. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 71 ++ .../SimulatorSerialPortLibPort80.inf | 31 +++ .../SimulatorSerialPortLibPort80.c| 207

[edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

From: Abner Chang Platform/AMD/AmdPlatformPkg provides the AMD edk2 common platform drivers and libraries for AMD server, client and Strategic Silicon Solutions (S3) platforms. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18

[edk2-devel] [edk2-platforms][PATCH 2/2] AmdPlatformPkg/HiiConfigRouting: AMD HiiConfigRouting module

From: Mark Wilson This module overrides BlockToConfig and ConfigToBlock interfaces for the better performance. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Mark Wilson --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 33 + .../HiiConfigRouting/AmdConfigRouting.inf | 45 +

[edk2-devel] [edk2-platforms][PATCH 1/2] Platform/AMD: Initial commit of AmdPlatformPkg

From: Abner Chang Platform/AMD/AmdPlatformPkg provides the AMD edk2 common platform drivers and libraries for AMD server, client and Strategic Silicon Solutions (S3) platforms. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 18

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

-Original Message- From: Pedro Falcato Sent: Friday, June 16, 2023 10:12 PM To: devel@edk2.groups.io; suni...@ventanamicro.com Cc: Xue, Gavin ; Warkentin, Andrei ; Wang, Yimin ; Sheng, Alan Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define

[edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h from other CPU Arch. An unexception compilation error generated if include __PROCESSOR_BIND_H__ symbol in header file for cross-platform compiling. Cc: Andrei Warkentin Cc: Sunil V L Cc: Yimin Wang Cc: Alan Sheng

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Fri, Jun 16, 2023 at 11:36 AM Sunil V L wrote: > > On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote: > > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h > > from other CPU Arch. An unexception compilation error generated > > if include __PROCESSOR_BIND_H__

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote: > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h > from other CPU Arch. An unexception compilation error generated > if include __PROCESSOR_BIND_H__ symbol in header file for > cross-platform compiling. > > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

iesheuvel > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add > Readme under Platform\AMD > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 2023-06-14 18:57

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

(Abdul Lateef) ; Xing, Eric ; He, Jiangang Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On 2023-06-14 05:22, Chang

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] Introduce HII to Redfish sample drivers

[AMD Official Use Only - General] Thanks for addressing the naming issue. For entire patch set, Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 13, 2023 9:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject:

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

Lateef) ; Xing, Eric > ; He, Jiangang > Subject: Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add > Readme under Platform\AMD > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. >

Re: [edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

On 2023-06-14 05:22, Chang, Abner via groups.io wrote: From: Abner Chang For AMD edk2 opensource project and the needs of opensource AMD platform common modules those can be leverage across AMD business units, AMD server, client and S3 (silicon strategic solution) BUs have the consensus to

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix uncrustify check error

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 13, 2023 9:32 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix

[edk2-devel] [edk2-platforms][PATCH] edk2-platform: Add Readme under Platform\AMD

From: Abner Chang For AMD edk2 opensource project and the needs of opensource AMD platform common modules those can be leverage across AMD business units, AMD server, client and S3 (silicon strategic solution) BUs have the consensus to propose AMD as the maintainer of Platform/AMD folder. The

Re: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

: Chang, Abner Sent: Monday, June 12, 2023 9:36 PM To: devel@edk2.groups.io; Oram, Isaac W ; Arun K Cc: Desimone, Nathaniel L ; Ramkumar Krishnamoorthi ; Gao, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: Introduce HiiToRedfishBiosDxe driver

Add HiiToRedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: Introduce HiiToRedfishBootDxe driver

Add HiiToRedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

This is an HII sample driver of memory configuration. This demonstrates the communication between platform configuration (EDK2/HII) and Redfish service (Memory resource) base on RedfishClientPkg. The language ("x-uef-redfish-*") defined in the Redfish-specific uni file is the connection between

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] Introduce HII to Redfish sample drivers

V2: Rename "Hii2Redfish" to "HiiToRedfish" for file path, file name and file content. v1: Introduce three sample drivers to demonstrate the way of providing Redfish attributes in HII provider driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (3):

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix uncrustify check error

Only run uncrustify check to c file and h file in script. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/uncrustify-check.sh | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/uncrustify-check.sh

Re: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

> Oram via groups.io > Sent: Tuesday, June 13, 2023 8:27 AM > To: Arun K ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Ramkumar > Krishnamoorthi ; Gao, Liming > > Subject: Re: [edk2-devel][edk2-platforms][PATCH V3-1] > IpmiFeaturePkg:Provided multiple IPMI in

Re: [edk2-devel][edk2-platforms][PATCH V3-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

Subject: [edk2-devel][edk2-platforms][PATCH V3-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitComm

Re: [edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

regular C logic is also preferred. Thanks, Isaac -Original Message- From: Arun K Sent: Monday, June 12, 2023 5:52 AM To: devel@edk2.groups.io; Arun K Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Ramkumar Krishnamoorthi ; Gao, Liming Subject: [edk2-devel][edk2-platforms][

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, June 12, 2023 11:15 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check **CAUTION: The e-mail below

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, June 12, 2023 11:15 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch >

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add patch check

- Run /BaseTools/Scripts/PatchCheck.py to check changes on pull request. - Create main.yml to handle push check on main branch. And show the status of RedfishClientPkg on README.md Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/workflows/build.yml | 3 --

[edk2-devel][edk2-platforms][PATCH V3-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This API

[edk2-devel][edk2-platforms][PATCH V3-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This API

[edk2-devel][edk2-platforms][PATCH V2-2] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel][edk2-platforms][PATCH V2-1] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix workflows folder location

[AMD Official Use Only - General] Reviewed-by: Abner Chang Get Outlook for Android From: Nickle Wang Sent: Thursday, June 8, 2023 10:03:45 AM To: devel@edk2.groups.io Cc: Chang, Abner ; Igor Kulchytskyy Subject:

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: fix workflows folder location

There is additional ".github" folder in early commit. Move the workflows folder to correct location. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/{.github => }/workflows/build.sh| 0 .github/{.github => }/workflows/build.yml | 0

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Thank you, Nickle Get Outlook for Android From: Chang, Abner Sent: Wednesday, June 7, 2023 8:28:11 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH]

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

[AMD Official Use Only - General] Nice work Nickle!! Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, June 8, 2023 12:12 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH]

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/.github: add build check and uncrustify check

Enable Github Actions to check below items: - RedfishClientPkg build check on push and pull request - Uncrustify check on pull request Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .github/.github/workflows/build.sh| 70 +++

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Introduce Hii2RedfishBootDxe driver

[AMD Official Use Only - General] Same as the comment given to 1/3, let's rename Hii2 to HiiTo. The same comment applied to 3/3. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 6, 2023 9:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

[AMD Official Use Only - General] Hi Nickle, I have no problem with this patch except for the file naming and function that use "2" instead of "To". Could you replace "2" with "To" in those naming? Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 6, 2023

Re: [edk2-devel] [edk2-rfc] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

Hi Vincent, Thanks for your suggestion. I will follow the code-first-process to submit a change request to PI specification. Regards, Nickle > -Original Message- > From: Zimmer, Vincent > Sent: Tuesday, June 6, 2023 11:27 PM > To: r...@edk2.groups.io; Oram, Isaac W ; >

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors

[AMD Official Use Only - General] To the entire series: Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 6, 2023 8:32 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH v2 0/9] Fix

Re: [edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: Re: [edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances On Tue, Jun 6, 2023 at 8:41 PM Saloni Kasbekar wrote: > > Adds the following library instances: > AlderlakePRv

Re: [edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

On Tue, Jun 6, 2023 at 8:41 PM Saloni Kasbekar wrote: > > Adds the following library instances: > AlderlakePRvp/Library/BoardAcpiLib > AlderlakePRvp/Library/BoardInitLib Hi Saloni, Thanks for the patch. Is this part of a larger series? There's no AlderlakeOpenBoardPkg in-tree, and this patch

[edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

Adds the following library instances: AlderlakePRvp/Library/BoardAcpiLib AlderlakePRvp/Library/BoardInitLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Library/BoardAcpiLib/BaseAcpiTableLib.c | 30 ++

Re: [edk2-devel] [edk2-rfc] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

I agree. These additions make sense. Perhaps you can format the submission per https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process in order to have this included in a future UEFI PI specification https://uefi.org/specs/PI/1.8/V3_Status_Codes.html. I can help you w/

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg: Introduce Hii2RedfishBiosDxe driver

Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Introduce Hii2RedfishBootDxe driver

Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

This is an HII sample driver of memory configuration. This demonstrates the communication between platform configuration (EDK2/HII) and Redfish service (Memory resource) base on RedfishClientPkg. The language ("x-uef-redfish-*") defined in the Redfish-specific uni file is the connection between

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Introduce HII to Redfish sample drivers

Introduce three sample drivers to demonstrate the way of providing Redfish attributes in HII provider driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (3): RedfishClientPkg: Add a sample memory configuration HII driver RedfishClientPkg: Introduce

[edk2-devel] [edk2-redfish-client][PATCH v2 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 8/9] RedfishClientPkg/MemoryDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 7/9] RedfishClientPkg/BiosDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 20 ++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 6/9] RedfishClientPkg/RedfishConfigLangMapDxe: Fix build error

Add missing "EFIAPI" and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 5/9] RedfishClientPkg/RedfishETagDxe: Fix build error

- Fix missing "EFIAPI" build error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 13 - 2 files changed, 9 insertions(+), 6

[edk2-devel] [edk2-redfish-client][PATCH v2 4/9] RedfishClientPkg/RedfishFeatureUtilityLib: Fix build error

Follow latest definition of EDKII_REDFISH_VALUE_TYPES and rename all corresponding variable in RedfishFeatureUtilityLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.c| 50 +-- 1 file changed, 25

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 2/9] RedfishClientPkg/RedfishAddendumLib: Fix build error

Rename ProvisioningCallback() to GetData() and OemCallback() to GetOemData() and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Library/RedfishAddendumLib/RedfishAddendumLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2-devel] [edk2-redfish-client][PATCH v2 1/9] RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error

Add GCC flag "-Wno-unused-but-set-variable" to remove build error because ConverterLib is 3rd party library. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../edk2library/Bios/v1_0_9/Lib.inf | 102 +-

[edk2-devel] [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors

V2: Instead of modifying ConverterLib, use build option in INF file to fix build error V1: Fix RedfishClientPkg build errors and typos. The compiler toolchain is GCC5. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (9): RedfishClientPkg/ConverterLib: Fix

Re: [edk2-devel] [edk2-platforms][PATCH 0/4] Add support new SMBIOS Tables and refactor to adapt with ArmPkg/SMBIOS

Hi Ard, The error is created by this commit https://github.com/tianocore/edk2/commit/e6447d2a08f5ca585816d093e79a01dad3781f98. We are investigating and will get back to you soon. Thanks for merging our patches. -Nhi On 6/2/2023 7:48 PM, Ard Biesheuvel wrote: On Wed, 24 May 2023 at 02:41,

Re: [edk2-devel] [edk2-platforms] Platform/Loongson: Revise the Readme

Reviewed-by: Chao Li Thanks, Chao 在 2023/6/1 19:20, xianglai 写道: Fix some errors in the Readme file. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Readme.md | 2 +- 1 file

Re: [edk2-devel] [edk2-platforms] Platform/Loongson: Pre-allocate 0-4K memory during the Pei phase

Reviewed-by: Chao Li Thanks, Chao 在 2023/6/1 19:19, xianglai 写道: When 0 address protection is enabled, 0-4k memory needs to be preallocated to prevent UEFI applications from allocating use, such as grub. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael

[edk2-devel] [edk2-redfish-client][PATCH 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

<    8   9   10   11   12   13   14   15   16   17   >